All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org,
	Michael Roth <mdroth@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH] qapi: Clean up includes in generated files
Date: Mon, 08 Feb 2016 18:39:40 +0100	[thread overview]
Message-ID: <87bn7rrtib.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <1454945806-14090-1-git-send-email-eblake@redhat.com> (Eric Blake's message of "Mon, 8 Feb 2016 08:36:46 -0700")

Eric Blake <eblake@redhat.com> writes:

> As a followup to commit cbf2115, clean up the includes in files
> generated by QAPI so that osdep.h is included first in .c files,
> and headers which it implies are not included manually.  This
> patch is done manually, since Coccinelle (and therefore
> scripts/clean-includes) doesn't see into the generator scripts.
>
> Signed-off-by: Eric Blake <eblake@redhat.com>

  CC    tests/check-qfloat.o
In file included from /home/armbru/work/qemu/include/qapi/qmp/qobject.h:37:0,
                 from /home/armbru/work/qemu/include/qapi/qmp/qfloat.h:18,
                 from /home/armbru/work/qemu/tests/check-qfloat.c:15:
./qapi-types.h:55:9: error: unknown type name ‘bool’
         bool value;
         ^

Chicken and egg problem?  check-qfloat.c doesn't include osdep.h, yet...

  reply	other threads:[~2016-02-08 17:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-08 15:36 [Qemu-devel] [PATCH] qapi: Clean up includes in generated files Eric Blake
2016-02-08 17:39 ` Markus Armbruster [this message]
2016-02-08 17:45   ` Peter Maydell
2016-02-08 18:25     ` Markus Armbruster
2016-02-08 18:29       ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bn7rrtib.fsf@blackfin.pond.sub.org \
    --to=armbru@redhat.com \
    --cc=eblake@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.