From: "Alex Bennée" <alex.bennee@linaro.org>
To: Tim Sander <tim@krieglstein.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH RFC] i2c-tiny-usb
Date: Fri, 27 Nov 2015 11:57:59 +0000 [thread overview]
Message-ID: <8737vr7iyg.fsf@linaro.org> (raw)
In-Reply-To: <1727507.5NJ00yyck5@dabox>
Tim Sander <tim@krieglstein.org> writes:
> Hi Alex
>
> Thanks for your feedback, answers as usual inline.
>
> Am Donnerstag, 26. November 2015, 18:07:35 schrieb Alex Bennée:
>> Tim Sander <tim@krieglstein.org> writes:
>> > Hi
>> >
<snip>
>> You are missing a s-o-b line and scripts/checkpatch.pl complains about a
>> few things you should fix before your next submission.
> I was unsure about the access length so i was just asking for feedback this
> time, thats why omitted the signed of by line.
> It seems as if i grabbed an older version of checkpatch as these errors didn't
> come up with the slightly older script. These new occurences will be fixed.
Cool. FWIW I always run against the current
$(QEMU_SRC)/scripts/checkpatch.pl as it is updated reasonably
frequently.
--
Alex Bennée
next prev parent reply other threads:[~2015-11-27 11:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-26 16:35 [Qemu-devel] [PATCH RFC] i2c-tiny-usb Tim Sander
2015-11-26 18:07 ` Alex Bennée
2015-11-27 8:41 ` Tim Sander
2015-11-27 9:35 ` Markus Armbruster
2015-11-27 11:57 ` Alex Bennée [this message]
2015-11-27 6:48 ` Gerd Hoffmann
2015-11-27 10:59 ` Tim Sander
[not found] ` <56582329.5040304@redhat.com>
2015-11-27 12:39 ` Tim Sander
2015-11-27 12:53 ` Paolo Bonzini
2015-12-09 16:40 ` [Qemu-devel] i2c data address question was " Tim Sander
2015-12-09 17:04 ` Paolo Bonzini
2015-12-16 15:56 ` [Qemu-devel] [PATCH] i2c-tiny-usb: add new usb to i2c bridge Tim Sander
2015-12-17 16:15 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8737vr7iyg.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=tim@krieglstein.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.