From: Bill Pringlemeir <bpringlemeir@nbsps.com>
To: dwmw2@infradead.org, computersforpeace@gmail.com,
Stefan Agner <stefan@agner.ch>
Cc: mark.rutland@arm.com, boris.brezillon@free-electrons.com,
aaron@tastycactus.com, marb@ixxat.de, pawel.moll@arm.com,
ijc+devicetree@hellion.org.uk, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, robh+dt@kernel.org,
linux-mtd@lists.infradead.org, kernel@pengutronix.de,
galak@codeaurora.org, shawn.guo@linaro.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 3/6] mtd: nand: vf610_nfc: add device tree bindings
Date: Mon, 09 Mar 2015 16:11:59 -0400 [thread overview]
Message-ID: <87385eue0g.fsf@nbsps.com> (raw)
In-Reply-To: 1425919132-13827-4-git-send-email-stefan@agner.ch
On 9 Mar 2015, stefan@agner.ch wrote:
> Signed-off-by: Bill Pringlemeir <bpringlemeir@nbsps.com>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
> .../devicetree/bindings/mtd/vf610-nfc.txt | 39 ++++++++++++++++++++++
> 1 file changed, 39 insertions(+) create mode 100644
> Documentation/devicetree/bindings/mtd/vf610-nfc.txt
>
> diff --git a/Documentation/devicetree/bindings/mtd/vf610-nfc.txt
> b/Documentation/devicetree/bindings/mtd/vf610-nfc.txt
> new file mode 100644
> index 0000000..312c872
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mtd/vf610-nfc.txt
[snip]
> +- reg: Address range of the mtd chip
> +- interrupts: Should contain the STMMAC interrupts
What is 'STMMAC'? Is that something I cribbed from another file? Ah, I
see 'spear_smi.txt' which is an NAND driver with a 'clock-frequency'
parameter (probably before 'assigned-clocks' support).
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/mtd/spear_smi.txt
I don't think 'STMMAC' makes sense.
+- interrupts: irq to be used
Maybe? Same as mxc-nand.txt. It is not so helpful though.
> +- nand-bus-width: see nand.txt
> +- nand-ecc-mode: see nand.txt
> +- nand-on-flash-bbt: see nand.txt
> +- clock-frequency : Optional clock rate to NFC in Hz
I guess this changed? We might want to put a note about what kind of
impact this might have on the bus. Ie,
assigned-clocks: Input SOC clock to the NAND controller.
assigned-clock-rates: The NAND bus timing is derived from this clock
rate and should not exceed maximum timing for any NAND memory chip
in a board stuffing. Typical NAND memory timings derived from this
clock are found in the SOC hardware reference manual.
Originally, the reason I made this file was because the
'clock-frequency' was non-standard. I guess it is nice to have it
anyways.
Fwiw,
Bill Pringlemeir.
WARNING: multiple messages have this Message-ID (diff)
From: bpringlemeir@nbsps.com (Bill Pringlemeir)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/6] mtd: nand: vf610_nfc: add device tree bindings
Date: Mon, 09 Mar 2015 16:11:59 -0400 [thread overview]
Message-ID: <87385eue0g.fsf@nbsps.com> (raw)
In-Reply-To: 1425919132-13827-4-git-send-email-stefan@agner.ch
On 9 Mar 2015, stefan at agner.ch wrote:
> Signed-off-by: Bill Pringlemeir <bpringlemeir@nbsps.com>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
> .../devicetree/bindings/mtd/vf610-nfc.txt | 39 ++++++++++++++++++++++
> 1 file changed, 39 insertions(+) create mode 100644
> Documentation/devicetree/bindings/mtd/vf610-nfc.txt
>
> diff --git a/Documentation/devicetree/bindings/mtd/vf610-nfc.txt
> b/Documentation/devicetree/bindings/mtd/vf610-nfc.txt
> new file mode 100644
> index 0000000..312c872
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mtd/vf610-nfc.txt
[snip]
> +- reg: Address range of the mtd chip
> +- interrupts: Should contain the STMMAC interrupts
What is 'STMMAC'? Is that something I cribbed from another file? Ah, I
see 'spear_smi.txt' which is an NAND driver with a 'clock-frequency'
parameter (probably before 'assigned-clocks' support).
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/mtd/spear_smi.txt
I don't think 'STMMAC' makes sense.
+- interrupts: irq to be used
Maybe? Same as mxc-nand.txt. It is not so helpful though.
> +- nand-bus-width: see nand.txt
> +- nand-ecc-mode: see nand.txt
> +- nand-on-flash-bbt: see nand.txt
> +- clock-frequency : Optional clock rate to NFC in Hz
I guess this changed? We might want to put a note about what kind of
impact this might have on the bus. Ie,
assigned-clocks: Input SOC clock to the NAND controller.
assigned-clock-rates: The NAND bus timing is derived from this clock
rate and should not exceed maximum timing for any NAND memory chip
in a board stuffing. Typical NAND memory timings derived from this
clock are found in the SOC hardware reference manual.
Originally, the reason I made this file was because the
'clock-frequency' was non-standard. I guess it is nice to have it
anyways.
Fwiw,
Bill Pringlemeir.
WARNING: multiple messages have this Message-ID (diff)
From: Bill Pringlemeir <bpringlemeir-ygJ1pmMJ17cAvxtiuMwx3w@public.gmane.org>
To: dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
Stefan Agner <stefan-XLVq0VzYD2Y@public.gmane.org>
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
pawel.moll-5wv7dgnIgG8@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org,
marb-Z4QKGCRq86k@public.gmane.org,
aaron-yuhzfaV+M/Wz3Dx2OeFgIA@public.gmane.org,
linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2 3/6] mtd: nand: vf610_nfc: add device tree bindings
Date: Mon, 09 Mar 2015 16:11:59 -0400 [thread overview]
Message-ID: <87385eue0g.fsf@nbsps.com> (raw)
In-Reply-To: 1425919132-13827-4-git-send-email-stefan@agner.ch
On 9 Mar 2015, stefan-XLVq0VzYD2Y@public.gmane.org wrote:
> Signed-off-by: Bill Pringlemeir <bpringlemeir-ygJ1pmMJ17cAvxtiuMwx3w@public.gmane.org>
> Signed-off-by: Stefan Agner <stefan-XLVq0VzYD2Y@public.gmane.org>
> ---
> .../devicetree/bindings/mtd/vf610-nfc.txt | 39 ++++++++++++++++++++++
> 1 file changed, 39 insertions(+) create mode 100644
> Documentation/devicetree/bindings/mtd/vf610-nfc.txt
>
> diff --git a/Documentation/devicetree/bindings/mtd/vf610-nfc.txt
> b/Documentation/devicetree/bindings/mtd/vf610-nfc.txt
> new file mode 100644
> index 0000000..312c872
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mtd/vf610-nfc.txt
[snip]
> +- reg: Address range of the mtd chip
> +- interrupts: Should contain the STMMAC interrupts
What is 'STMMAC'? Is that something I cribbed from another file? Ah, I
see 'spear_smi.txt' which is an NAND driver with a 'clock-frequency'
parameter (probably before 'assigned-clocks' support).
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/mtd/spear_smi.txt
I don't think 'STMMAC' makes sense.
+- interrupts: irq to be used
Maybe? Same as mxc-nand.txt. It is not so helpful though.
> +- nand-bus-width: see nand.txt
> +- nand-ecc-mode: see nand.txt
> +- nand-on-flash-bbt: see nand.txt
> +- clock-frequency : Optional clock rate to NFC in Hz
I guess this changed? We might want to put a note about what kind of
impact this might have on the bus. Ie,
assigned-clocks: Input SOC clock to the NAND controller.
assigned-clock-rates: The NAND bus timing is derived from this clock
rate and should not exceed maximum timing for any NAND memory chip
in a board stuffing. Typical NAND memory timings derived from this
clock are found in the SOC hardware reference manual.
Originally, the reason I made this file was because the
'clock-frequency' was non-standard. I guess it is nice to have it
anyways.
Fwiw,
Bill Pringlemeir.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Bill Pringlemeir <bpringlemeir@nbsps.com>
To: dwmw2@infradead.org, computersforpeace@gmail.com,
Stefan Agner <stefan@agner.ch>
Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
shawn.guo@linaro.org, kernel@pengutronix.de,
boris.brezillon@free-electrons.com, marb@ixxat.de,
aaron@tastycactus.com, linux-mtd@lists.infradead.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/6] mtd: nand: vf610_nfc: add device tree bindings
Date: Mon, 09 Mar 2015 16:11:59 -0400 [thread overview]
Message-ID: <87385eue0g.fsf@nbsps.com> (raw)
In-Reply-To: 1425919132-13827-4-git-send-email-stefan@agner.ch
On 9 Mar 2015, stefan@agner.ch wrote:
> Signed-off-by: Bill Pringlemeir <bpringlemeir@nbsps.com>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
> .../devicetree/bindings/mtd/vf610-nfc.txt | 39 ++++++++++++++++++++++
> 1 file changed, 39 insertions(+) create mode 100644
> Documentation/devicetree/bindings/mtd/vf610-nfc.txt
>
> diff --git a/Documentation/devicetree/bindings/mtd/vf610-nfc.txt
> b/Documentation/devicetree/bindings/mtd/vf610-nfc.txt
> new file mode 100644
> index 0000000..312c872
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mtd/vf610-nfc.txt
[snip]
> +- reg: Address range of the mtd chip
> +- interrupts: Should contain the STMMAC interrupts
What is 'STMMAC'? Is that something I cribbed from another file? Ah, I
see 'spear_smi.txt' which is an NAND driver with a 'clock-frequency'
parameter (probably before 'assigned-clocks' support).
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/mtd/spear_smi.txt
I don't think 'STMMAC' makes sense.
+- interrupts: irq to be used
Maybe? Same as mxc-nand.txt. It is not so helpful though.
> +- nand-bus-width: see nand.txt
> +- nand-ecc-mode: see nand.txt
> +- nand-on-flash-bbt: see nand.txt
> +- clock-frequency : Optional clock rate to NFC in Hz
I guess this changed? We might want to put a note about what kind of
impact this might have on the bus. Ie,
assigned-clocks: Input SOC clock to the NAND controller.
assigned-clock-rates: The NAND bus timing is derived from this clock
rate and should not exceed maximum timing for any NAND memory chip
in a board stuffing. Typical NAND memory timings derived from this
clock are found in the SOC hardware reference manual.
Originally, the reason I made this file was because the
'clock-frequency' was non-standard. I guess it is nice to have it
anyways.
Fwiw,
Bill Pringlemeir.
next prev parent reply other threads:[~2015-03-09 20:11 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-09 16:38 [PATCH v2 0/6] mtd: nand: vf610_nfc: Freescale NFC for VF610 Stefan Agner
2015-03-09 16:38 ` Stefan Agner
2015-03-09 16:38 ` Stefan Agner
2015-03-09 16:38 ` [PATCH v2 1/6] mtd: nand: vf610_nfc: Freescale NFC for VF610, MPC5125 and others Stefan Agner
2015-03-09 16:38 ` Stefan Agner
2015-03-09 16:38 ` Stefan Agner
2015-03-09 16:38 ` [PATCH v2 2/6] mtd: nand: vf610_nfc: add hardware BCH-ECC support Stefan Agner
2015-03-09 16:38 ` Stefan Agner
2015-03-09 16:38 ` Stefan Agner
2015-03-09 16:38 ` Stefan Agner
2015-03-09 16:38 ` [PATCH v2 3/6] mtd: nand: vf610_nfc: add device tree bindings Stefan Agner
2015-03-09 16:38 ` Stefan Agner
2015-03-09 16:38 ` Stefan Agner
2015-03-09 16:38 ` Stefan Agner
2015-03-09 20:11 ` Bill Pringlemeir [this message]
2015-03-09 20:11 ` Bill Pringlemeir
2015-03-09 20:11 ` Bill Pringlemeir
2015-03-09 20:11 ` Bill Pringlemeir
2015-03-09 16:38 ` [PATCH v2 4/6] ARM: vf610: enable NAND Flash Controller Stefan Agner
2015-03-09 16:38 ` Stefan Agner
2015-03-09 16:38 ` Stefan Agner
2015-03-09 16:38 ` [PATCH v2 5/6] ARM: dts: vf610: add NAND flash controller peripherial Stefan Agner
2015-03-09 16:38 ` Stefan Agner
2015-03-09 16:38 ` Stefan Agner
2015-03-09 16:38 ` [PATCH v2 6/6] ARM: dts: vf-colibri: enable NAND flash controller Stefan Agner
2015-03-09 16:38 ` Stefan Agner
2015-03-09 16:38 ` Stefan Agner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87385eue0g.fsf@nbsps.com \
--to=bpringlemeir@nbsps.com \
--cc=aaron@tastycactus.com \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marb@ixxat.de \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=shawn.guo@linaro.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.