From: arno@natisbad.org (Arnaud Ebalard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv0 5/5] dt-bindings: fix isl vs isil prefix issue for Intersil
Date: Mon, 15 Dec 2014 19:05:18 +0100 [thread overview]
Message-ID: <87388gkcv5.fsf@natisbad.org> (raw)
In-Reply-To: <20141215135545.GC967@titan.lakedaemon.net> (Jason Cooper's message of "Mon, 15 Dec 2014 08:55:45 -0500")
Hi,
Jason Cooper <jason@lakedaemon.net> writes:
>> AFAICT, it seems it makes sense to *definitively* settle for isil as the
>> vendor prefix for Intersil, as Philip did in 7a6540ca856a: it's the NASDAQ
>> symbol and this choice requires less changes than opting for isl.
>>
>> So, this patch changes compatible strings in .dts files to use isil where
>> isl was found before, and modify drivers w/ compatible strings using isl
>> to add one using isil. In those cases, a comment is made that the old
>> compatible string is kept for backward compatibility (w/ out-fo-tree users
>> of those drivers). Additionally, it leaves only isil as prefix in
>> vendor-prefixes.txt. Those changes should prevent any new inclusion of
>> isl compatible strings for Intersil devices due to copy-and-paste.
>>
>> Signed-off-by: Arnaud Ebalard <arno@natisbad.org>
>> ---
>> Documentation/devicetree/bindings/i2c/trivial-devices.txt | 5 ++---
>> Documentation/devicetree/bindings/regulator/isl9305.txt | 4 ++--
>> Documentation/devicetree/bindings/vendor-prefixes.txt | 3 +--
>
>> arch/arm/boot/dts/tegra30-cardhu.dtsi | 2 +-
>> arch/arm/boot/dts/zynq-parallella.dts | 2 +-
>
>> drivers/regulator/isl9305.c | 6 ++++--
>> drivers/rtc/rtc-isl12022.c | 3 ++-
>> drivers/rtc/rtc-isl12057.c | 3 ++-
>> drivers/staging/iio/light/isl29028.c | 4 ++--
>> 9 files changed, 17 insertions(+), 15 deletions(-)
>
> Please split the dts{i} changes out into a separate patch. The
> different maintainers under drivers/ may want separate patches as well.
I will prepare that, and then let get_maintainer.pl decide who should
be added to the CC: list. But before doing that work, I would like to
at least get some feedback that there will not be a big NAK on the
whole approach in the end.
Cheers,
a+
WARNING: multiple messages have this Message-ID (diff)
From: arno@natisbad.org (Arnaud Ebalard)
To: Jason Cooper <jason@lakedaemon.net>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
"Uwe Kleine-König" <uwe@kleine-koenig.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Alessandro Zummo" <a.zummo@towertech.it>,
"Peter Huewe" <peter.huewe@infineon.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Thierry Reding" <treding@nvidia.com>,
"Mark Brown" <broonie@kernel.org>,
"Arnd Bergmann" <arnd@arndb.de>,
"Darshana Padmadas" <darshanapadmadas@gmail.com>,
"Rob Herring" <rob.herring@calxeda.com>,
"Pawel Moll" <pawel.moll@arm.com>,
"Stephen Warren" <swarren@wwwdotorg.org>,
"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
"Grant Likely" <grant.likely@linaro.org>,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
"Rob Landley" <rob@landley.net>,
rtc-linux@googlegroups.com, "Guenter Roeck" <linux@roeck-us.net>,
"Jason Gunthorpe" <jgunthorpe@obsidianresearch.com>,
"Kumar Gala" <galak@codeaurora.org>,
linux-arm-kernel@l
Subject: Re: [PATCHv0 5/5] dt-bindings: fix isl vs isil prefix issue for Intersil
Date: Mon, 15 Dec 2014 19:05:18 +0100 [thread overview]
Message-ID: <87388gkcv5.fsf@natisbad.org> (raw)
In-Reply-To: <20141215135545.GC967@titan.lakedaemon.net> (Jason Cooper's message of "Mon, 15 Dec 2014 08:55:45 -0500")
Hi,
Jason Cooper <jason@lakedaemon.net> writes:
>> AFAICT, it seems it makes sense to *definitively* settle for isil as the
>> vendor prefix for Intersil, as Philip did in 7a6540ca856a: it's the NASDAQ
>> symbol and this choice requires less changes than opting for isl.
>>
>> So, this patch changes compatible strings in .dts files to use isil where
>> isl was found before, and modify drivers w/ compatible strings using isl
>> to add one using isil. In those cases, a comment is made that the old
>> compatible string is kept for backward compatibility (w/ out-fo-tree users
>> of those drivers). Additionally, it leaves only isil as prefix in
>> vendor-prefixes.txt. Those changes should prevent any new inclusion of
>> isl compatible strings for Intersil devices due to copy-and-paste.
>>
>> Signed-off-by: Arnaud Ebalard <arno@natisbad.org>
>> ---
>> Documentation/devicetree/bindings/i2c/trivial-devices.txt | 5 ++---
>> Documentation/devicetree/bindings/regulator/isl9305.txt | 4 ++--
>> Documentation/devicetree/bindings/vendor-prefixes.txt | 3 +--
>
>> arch/arm/boot/dts/tegra30-cardhu.dtsi | 2 +-
>> arch/arm/boot/dts/zynq-parallella.dts | 2 +-
>
>> drivers/regulator/isl9305.c | 6 ++++--
>> drivers/rtc/rtc-isl12022.c | 3 ++-
>> drivers/rtc/rtc-isl12057.c | 3 ++-
>> drivers/staging/iio/light/isl29028.c | 4 ++--
>> 9 files changed, 17 insertions(+), 15 deletions(-)
>
> Please split the dts{i} changes out into a separate patch. The
> different maintainers under drivers/ may want separate patches as well.
I will prepare that, and then let get_maintainer.pl decide who should
be added to the CC: list. But before doing that work, I would like to
at least get some feedback that there will not be a big NAK on the
whole approach in the end.
Cheers,
a+
next prev parent reply other threads:[~2014-12-15 18:05 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-14 1:42 [PATCHv0 0/5] ISL12057 alarm support and isil vs isl fix Arnaud Ebalard
2014-12-14 1:42 ` Arnaud Ebalard
2014-12-14 1:42 ` [PATCHv0 1/5] rtc: rtc-isl12057: add alarm support to Intersil ISL12057 RTC driver Arnaud Ebalard
2014-12-14 1:42 ` Arnaud Ebalard
2014-12-15 19:36 ` RFC: new dt property "can-wakeup-machine" [Was: [PATCHv0 1/5] rtc: rtc-isl12057: add alarm support to Intersil ISL12057 RTC driver] Uwe Kleine-König
2014-12-15 19:36 ` Uwe Kleine-König
2014-12-15 20:18 ` Arnaud Ebalard
2014-12-15 20:18 ` Arnaud Ebalard
2014-12-14 1:42 ` [PATCHv0 2/5] ARM: mvebu: ISL12057 rtc chip can be used to wake up RN102 Arnaud Ebalard
2014-12-14 1:42 ` Arnaud Ebalard
2014-12-15 13:53 ` Jason Cooper
2014-12-15 13:53 ` Jason Cooper
2014-12-15 18:00 ` Arnaud Ebalard
2014-12-15 18:00 ` Arnaud Ebalard
2014-12-14 1:42 ` [PATCHv0 3/5] ARM: mvebu: ISL12057 rtc chip can be used to wake up RN104 Arnaud Ebalard
2014-12-14 1:42 ` Arnaud Ebalard
2014-12-14 1:43 ` [PATCHv0 4/5] ARM: mvebu: ISL12057 rtc chip can be used to wake up RN2120 Arnaud Ebalard
2014-12-14 1:43 ` Arnaud Ebalard
2014-12-14 1:43 ` [PATCHv0 5/5] dt-bindings: fix isl vs isil prefix issue for Intersil Arnaud Ebalard
2014-12-14 1:43 ` Arnaud Ebalard
2014-12-15 13:55 ` Jason Cooper
2014-12-15 13:55 ` Jason Cooper
2014-12-15 18:05 ` Arnaud Ebalard [this message]
2014-12-15 18:05 ` Arnaud Ebalard
2014-12-15 18:06 ` Jason Cooper
2014-12-15 18:06 ` Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87388gkcv5.fsf@natisbad.org \
--to=arno@natisbad.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.