From: Rusty Russell <rusty@rustcorp.com.au>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>,
Julia Lawall <julia.lawall@lip6.fr>,
"Michael S. Tsirkin" <mst@redhat.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Dan Magenheimer <dan.magenheimer@oracle.com>
Subject: Please add PTR_RET tree.
Date: Mon, 15 Jul 2013 14:07:03 +0930 [thread overview]
Message-ID: <8738rg30cw.fsf@rustcorp.com.au> (raw)
Temporary branch for PTR_RET -> PTR_ERR_OR_ZERO and associated cleanups.
git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux.git PTR_RET
Log appended. Contributors and people who didn't already ack CC'd.
Cheers,
Rusty.
commit 6e8b8726ad503214ba66e34aed69aff41de33489
Author: Rusty Russell <rusty@rustcorp.com.au>
Date: Mon Jul 15 11:19:32 2013 +0930
PTR_RET is now PTR_ERR_OR_ZERO
True, it's often used in return statements, but after much bikeshedding
it's probably better to have an explicit name.
(I tried just putting the IS_ERR check inside PTR_ERR itself and gcc
usually generated no more code. But that clashes current expectations
of how PTR_ERR behaves, so having a separate function is better).
Suggested-by: Julia Lawall <julia.lawall@lip6.fr>
Suggested-by: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Julia Lawall <julia.lawall@lip6.fr>
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
commit 8c6ffba0eddc8c110dbf444f51354ce42069abfc
Author: Rusty Russell <rusty@rustcorp.com.au>
Date: Mon Jul 15 11:20:32 2013 +0930
PTR_RET is now PTR_ERR_OR_ZERO(): Replace most.
Sweep of the simple cases.
Cc: netdev@vger.kernel.org
Cc: linuxppc-dev@lists.ozlabs.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Acked-by: David S. Miller <davem@davemloft.net>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
commit 228b82211b47b597fa75dff2ac146b40eaaddf18
Author: Rusty Russell <rusty@rustcorp.com.au>
Date: Mon Jul 15 11:21:32 2013 +0930
s390: Replace weird use of PTR_RET.
Saves repeating "(void __force *)__uptr" but it's less clear. Using
the output of PTR_RET() to determine the error rather than just
testing IS_ERR() is odd.
For example, I *assume* __gptr_to_uptr() never returns NULL? Because
the __ret would be 0 for the old code. The new version is clearer, IMHO:
it would try to get_user() on that address.
If you hate this variant, I can just s/PTR_RET/PTR_ERR_OR_ZERO/ instead.
Cc: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Acked-by: Heiko Carstens <heiko.carstens@de.ibm.com>
commit 5d7e438629413586ab78779751caa6e713c2234c
Author: Rusty Russell <rusty@rustcorp.com.au>
Date: Mon Jul 15 11:22:32 2013 +0930
acpi: Replace weird use of PTR_RET.
This functions is really weird. It sets rc to -ENOMEM, then overrides
it. It was converted to PTR_RET in a1458187 when it should have
simply been rewritten.
This version makes it more explicit, with a single IS_ERR() test.
Cc: Alexandru Gheorghiu <gheorghiuandru@gmail.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
commit 5795c6ac7c77dc2363c41948cf828916c17cf78f
Author: Rusty Russell <rusty@rustcorp.com.au>
Date: Mon Jul 15 11:23:32 2013 +0930
pinctrl: don't use PTR_RET().
We've already tested that it's an error.
Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
commit 60d676c007964576e83d791fc0908af8d133519f
Author: Rusty Russell <rusty@rustcorp.com.au>
Date: Mon Jul 15 11:24:08 2013 +0930
remoteproc: don't use PTR_RET().
We've already tested that it's an error.
Cc: Robert Tivy <rtivy@ti.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Acked-by: Ohad Ben-Cohen <ohad@wizery.com>
commit 8a1d41cfeaf59a07acc7b1b3620ad6aa5cf47dc2
Author: Rusty Russell <rusty@rustcorp.com.au>
Date: Mon Jul 15 11:24:08 2013 +0930
staging/zcache: don't use PTR_RET().
We've already tested that it's an error.
Cc: Dan Magenheimer <dan.magenheimer@oracle.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
commit 6b4f2b56a48c8ea9775bd2b29681725d4474367a
Author: Rusty Russell <rusty@rustcorp.com.au>
Date: Mon Jul 15 11:24:08 2013 +0930
mm/oom_kill: remove weird use of ERR_PTR()/PTR_ERR().
The normal expectation for ERR_PTR() is to put a negative errno into a
pointer. oom_kill puts the magic -1 in the result (and has since
pre-git), which is probably clearer with an explicit cast.
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
WARNING: multiple messages have this Message-ID (diff)
From: Rusty Russell <rusty@rustcorp.com.au>
To: "Stephen Rothwell" <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org, "lkml" <linux-kernel@vger.kernel.org>
Cc: Julia Lawall <julia.lawall@lip6.fr>
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Cc: Dan Magenheimer <dan.magenheimer@oracle.com>
Subject: Please add PTR_RET tree.
Date: Mon, 15 Jul 2013 14:07:03 +0930 [thread overview]
Message-ID: <8738rg30cw.fsf@rustcorp.com.au> (raw)
Temporary branch for PTR_RET -> PTR_ERR_OR_ZERO and associated cleanups.
git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux.git PTR_RET
Log appended. Contributors and people who didn't already ack CC'd.
Cheers,
Rusty.
commit 6e8b8726ad503214ba66e34aed69aff41de33489
Author: Rusty Russell <rusty@rustcorp.com.au>
Date: Mon Jul 15 11:19:32 2013 +0930
PTR_RET is now PTR_ERR_OR_ZERO
True, it's often used in return statements, but after much bikeshedding
it's probably better to have an explicit name.
(I tried just putting the IS_ERR check inside PTR_ERR itself and gcc
usually generated no more code. But that clashes current expectations
of how PTR_ERR behaves, so having a separate function is better).
Suggested-by: Julia Lawall <julia.lawall@lip6.fr>
Suggested-by: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Julia Lawall <julia.lawall@lip6.fr>
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
commit 8c6ffba0eddc8c110dbf444f51354ce42069abfc
Author: Rusty Russell <rusty@rustcorp.com.au>
Date: Mon Jul 15 11:20:32 2013 +0930
PTR_RET is now PTR_ERR_OR_ZERO(): Replace most.
Sweep of the simple cases.
Cc: netdev@vger.kernel.org
Cc: linuxppc-dev@lists.ozlabs.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Acked-by: David S. Miller <davem@davemloft.net>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
commit 228b82211b47b597fa75dff2ac146b40eaaddf18
Author: Rusty Russell <rusty@rustcorp.com.au>
Date: Mon Jul 15 11:21:32 2013 +0930
s390: Replace weird use of PTR_RET.
Saves repeating "(void __force *)__uptr" but it's less clear. Using
the output of PTR_RET() to determine the error rather than just
testing IS_ERR() is odd.
For example, I *assume* __gptr_to_uptr() never returns NULL? Because
the __ret would be 0 for the old code. The new version is clearer, IMHO:
it would try to get_user() on that address.
If you hate this variant, I can just s/PTR_RET/PTR_ERR_OR_ZERO/ instead.
Cc: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Acked-by: Heiko Carstens <heiko.carstens@de.ibm.com>
commit 5d7e438629413586ab78779751caa6e713c2234c
Author: Rusty Russell <rusty@rustcorp.com.au>
Date: Mon Jul 15 11:22:32 2013 +0930
acpi: Replace weird use of PTR_RET.
This functions is really weird. It sets rc to -ENOMEM, then overrides
it. It was converted to PTR_RET in a1458187 when it should have
simply been rewritten.
This version makes it more explicit, with a single IS_ERR() test.
Cc: Alexandru Gheorghiu <gheorghiuandru@gmail.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
commit 5795c6ac7c77dc2363c41948cf828916c17cf78f
Author: Rusty Russell <rusty@rustcorp.com.au>
Date: Mon Jul 15 11:23:32 2013 +0930
pinctrl: don't use PTR_RET().
We've already tested that it's an error.
Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
commit 60d676c007964576e83d791fc0908af8d133519f
Author: Rusty Russell <rusty@rustcorp.com.au>
Date: Mon Jul 15 11:24:08 2013 +0930
remoteproc: don't use PTR_RET().
We've already tested that it's an error.
Cc: Robert Tivy <rtivy@ti.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Acked-by: Ohad Ben-Cohen <ohad@wizery.com>
commit 8a1d41cfeaf59a07acc7b1b3620ad6aa5cf47dc2
Author: Rusty Russell <rusty@rustcorp.com.au>
Date: Mon Jul 15 11:24:08 2013 +0930
staging/zcache: don't use PTR_RET().
We've already tested that it's an error.
Cc: Dan Magenheimer <dan.magenheimer@oracle.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
commit 6b4f2b56a48c8ea9775bd2b29681725d4474367a
Author: Rusty Russell <rusty@rustcorp.com.au>
Date: Mon Jul 15 11:24:08 2013 +0930
mm/oom_kill: remove weird use of ERR_PTR()/PTR_ERR().
The normal expectation for ERR_PTR() is to put a negative errno into a
pointer. oom_kill puts the magic -1 in the result (and has since
pre-git), which is probably clearer with an explicit cast.
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
next reply other threads:[~2013-07-15 4:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-15 4:37 Rusty Russell [this message]
2013-07-15 4:37 ` Please add PTR_RET tree Rusty Russell
2013-07-15 7:38 ` Stephen Rothwell
2013-09-17 0:50 ` Rusty Russell
2013-09-17 5:08 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8738rg30cw.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=dan.magenheimer@oracle.com \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mst@redhat.com \
--cc=sebastian.hesselbarth@gmail.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.