From: khilman@linaro.org (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC/PATCH 2/5] kernel_cpustat: convert to atomic 64-bit accessors
Date: Thu, 21 Feb 2013 21:57:46 -0800 [thread overview]
Message-ID: <8738woriud.fsf@linaro.org> (raw)
In-Reply-To: <CAFTL4hzHbp-JYgAbMRc4tefJZh9ZVdqGMp3ZTQAe-kmaX1fC3w@mail.gmail.com> (Frederic Weisbecker's message of "Thu, 21 Feb 2013 22:54:43 +0100")
Frederic Weisbecker <fweisbec@gmail.com> writes:
> 2013/2/21 Frederic Weisbecker <fweisbec@gmail.com>:
>> 2013/2/21 Kevin Hilman <khilman@linaro.org>:
>>> Subject: [PATCH 2/5] kernel_cpustat: convert to atomic 64-bit accessors
>>>
>>> Use the atomic64_* accessors for all the kernel_cpustat fields to
>>> ensure atomic access on non-64 bit platforms.
>>>
>>> Thanks to Mats Liljegren for CGROUP_CPUACCT related fixes.
>>>
>>> Cc: Mats Liljegren <mats.liljegren@enea.com>
>>> Signed-off-by: Kevin Hilman <khilman@linaro.org>
>>
>> Funny stuff, I thought struct kernel_cpustat was made of cputime_t
>> field. Actually it's u64. So the issue is independant from the new
>> full dynticks cputime accounting. It was already broken before.
>>
>> But yeah that's not the point, we still want to fix this anyway. But
>> let's just treat this patch as independant.
OK, I just sent an updated series based on your proposal.
Thanks for the review,
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@linaro.org>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Mats Liljegren <mats.liljegren@enea.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linaro-dev@lists.linaro.org,
Peter Zijlstra <peterz@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [RFC/PATCH 2/5] kernel_cpustat: convert to atomic 64-bit accessors
Date: Thu, 21 Feb 2013 21:57:46 -0800 [thread overview]
Message-ID: <8738woriud.fsf@linaro.org> (raw)
In-Reply-To: <CAFTL4hzHbp-JYgAbMRc4tefJZh9ZVdqGMp3ZTQAe-kmaX1fC3w@mail.gmail.com> (Frederic Weisbecker's message of "Thu, 21 Feb 2013 22:54:43 +0100")
Frederic Weisbecker <fweisbec@gmail.com> writes:
> 2013/2/21 Frederic Weisbecker <fweisbec@gmail.com>:
>> 2013/2/21 Kevin Hilman <khilman@linaro.org>:
>>> Subject: [PATCH 2/5] kernel_cpustat: convert to atomic 64-bit accessors
>>>
>>> Use the atomic64_* accessors for all the kernel_cpustat fields to
>>> ensure atomic access on non-64 bit platforms.
>>>
>>> Thanks to Mats Liljegren for CGROUP_CPUACCT related fixes.
>>>
>>> Cc: Mats Liljegren <mats.liljegren@enea.com>
>>> Signed-off-by: Kevin Hilman <khilman@linaro.org>
>>
>> Funny stuff, I thought struct kernel_cpustat was made of cputime_t
>> field. Actually it's u64. So the issue is independant from the new
>> full dynticks cputime accounting. It was already broken before.
>>
>> But yeah that's not the point, we still want to fix this anyway. But
>> let's just treat this patch as independant.
OK, I just sent an updated series based on your proposal.
Thanks for the review,
Kevin
next prev parent reply other threads:[~2013-02-22 5:57 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-20 19:41 [RFC/PATCH 0/5] context_tracking: prerequisites for ARM support Kevin Hilman
2013-02-20 19:41 ` Kevin Hilman
2013-02-20 19:41 ` [RFC/PATCH 1/5] context tracking: conditionalize guest support based on CONFIG_KVM Kevin Hilman
2013-02-20 19:41 ` Kevin Hilman
2013-02-22 13:27 ` Frederic Weisbecker
2013-02-22 13:27 ` Frederic Weisbecker
2013-02-26 19:29 ` Kevin Hilman
2013-02-26 19:29 ` Kevin Hilman
2013-02-26 22:13 ` Namhyung Kim
2013-02-26 22:13 ` Namhyung Kim
2013-02-27 14:24 ` Kevin Hilman
2013-02-27 14:24 ` Kevin Hilman
2013-02-27 15:21 ` Frederic Weisbecker
2013-02-27 15:21 ` Frederic Weisbecker
2013-02-20 19:41 ` [RFC/PATCH 2/5] kernel_cpustat: convert to atomic 64-bit accessors Kevin Hilman
2013-02-20 19:41 ` Kevin Hilman
2013-02-21 19:38 ` Kevin Hilman
2013-02-21 19:38 ` Kevin Hilman
2013-02-21 21:53 ` Frederic Weisbecker
2013-02-21 21:53 ` Frederic Weisbecker
2013-02-21 21:54 ` Frederic Weisbecker
2013-02-21 21:54 ` Frederic Weisbecker
2013-02-22 5:57 ` Kevin Hilman [this message]
2013-02-22 5:57 ` Kevin Hilman
2013-02-21 21:58 ` Russell King - ARM Linux
2013-02-21 21:58 ` Russell King - ARM Linux
2013-02-21 22:15 ` Frederic Weisbecker
2013-02-21 22:15 ` Frederic Weisbecker
2013-02-20 19:41 ` [RFC/PATCH 3/5] virt CPU accounting: Kconfig: drop 64-bit requirment Kevin Hilman
2013-02-20 19:41 ` Kevin Hilman
2013-02-20 19:41 ` [RFC/PATCH 4/5] cputime: use do_div() for nsec resolution conversion helpers Kevin Hilman
2013-02-20 19:41 ` Kevin Hilman
2013-02-21 16:24 ` Frederic Weisbecker
2013-02-21 16:24 ` Frederic Weisbecker
2013-02-21 17:58 ` Namhyung Kim
2013-02-21 17:58 ` Namhyung Kim
2013-02-21 19:21 ` Kevin Hilman
2013-02-21 19:21 ` Kevin Hilman
2013-02-26 15:21 ` Frederic Weisbecker
2013-02-26 15:21 ` Frederic Weisbecker
2013-02-20 19:41 ` [RFC/PATCH 5/5] ARM: Kconfig: allow virt CPU accounting Kevin Hilman
2013-02-20 19:41 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8738woriud.fsf@linaro.org \
--to=khilman@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.