From: Kevin Hilman <khilman@ti.com>
To: "Govindraj.R" <govindraj.raja@ti.com>
Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>,
Tony Lindgren <tony@atomide.com>,
linux-omap@vger.kernel.org,
Robert Nelson <robertcnelson@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] omap3_beagle: Init only uart3 used for console
Date: Mon, 05 Mar 2012 12:00:16 -0800 [thread overview]
Message-ID: <87399mkecv.fsf@ti.com> (raw)
In-Reply-To: <1330945952-14714-1-git-send-email-govindraj.raja@ti.com> (Govindraj R.'s message of "Mon, 5 Mar 2012 16:42:32 +0530")
"Govindraj.R" <govindraj.raja@ti.com> writes:
> From: "Govindraj.R" <govindraj.raja@ti.com>
>
> On beagle some of uart mux lines are used for other
> purpose so init only uart3.
OK, but you should also be clear that this patch is effectively
disabling all UARTS (except UART3) by defatul, which I'm not sure all
Beagle users will be happy about.
> Uart2 rx line clashes with gpio_147 used for usb ehci
> phy reset. Initializing uart2 pad_mux lines can break
> ehci module on beagle xm.
> (gpio_147 is available on uart2_rx in mode4 reference
> mux34xx.c -> uart2_rx.gpio_147)
As Koen mentioned, this conflict only exists on certain boards, so
you should be clear that this is just an example.
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Kevin Hilman <khilman@ti.com>
> Tested-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> Tested-by: Robert Nelson <robertcnelson@gmail.com>
> Signed-off-by: Govindraj.R <govindraj.raja@ti.com>
[...]
> +
> +static inline void board_serial_init(void)
Should be __init
[...]
> +static inline void board_serial_init(void)
here too.
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: khilman@ti.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] omap3_beagle: Init only uart3 used for console
Date: Mon, 05 Mar 2012 12:00:16 -0800 [thread overview]
Message-ID: <87399mkecv.fsf@ti.com> (raw)
In-Reply-To: <1330945952-14714-1-git-send-email-govindraj.raja@ti.com> (Govindraj R.'s message of "Mon, 5 Mar 2012 16:42:32 +0530")
"Govindraj.R" <govindraj.raja@ti.com> writes:
> From: "Govindraj.R" <govindraj.raja@ti.com>
>
> On beagle some of uart mux lines are used for other
> purpose so init only uart3.
OK, but you should also be clear that this patch is effectively
disabling all UARTS (except UART3) by defatul, which I'm not sure all
Beagle users will be happy about.
> Uart2 rx line clashes with gpio_147 used for usb ehci
> phy reset. Initializing uart2 pad_mux lines can break
> ehci module on beagle xm.
> (gpio_147 is available on uart2_rx in mode4 reference
> mux34xx.c -> uart2_rx.gpio_147)
As Koen mentioned, this conflict only exists on certain boards, so
you should be clear that this is just an example.
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Kevin Hilman <khilman@ti.com>
> Tested-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> Tested-by: Robert Nelson <robertcnelson@gmail.com>
> Signed-off-by: Govindraj.R <govindraj.raja@ti.com>
[...]
> +
> +static inline void board_serial_init(void)
Should be __init
[...]
> +static inline void board_serial_init(void)
here too.
Kevin
next prev parent reply other threads:[~2012-03-05 20:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-05 11:12 [PATCH] omap3_beagle: Init only uart3 used for console Govindraj.R
2012-03-05 11:12 ` Govindraj.R
2012-03-05 14:06 ` Koen Kooi
2012-03-05 14:06 ` Koen Kooi
2012-03-06 9:03 ` Raja, Govindraj
2012-03-06 9:03 ` Raja, Govindraj
2012-03-06 9:10 ` Koen Kooi
2012-03-06 9:10 ` Koen Kooi
2012-03-05 20:00 ` Kevin Hilman [this message]
2012-03-05 20:00 ` Kevin Hilman
2012-03-05 20:51 ` Tony Lindgren
2012-03-05 20:51 ` Tony Lindgren
2012-03-06 9:16 ` Raja, Govindraj
2012-03-06 9:16 ` Raja, Govindraj
2012-03-06 9:10 ` Raja, Govindraj
2012-03-06 9:10 ` Raja, Govindraj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87399mkecv.fsf@ti.com \
--to=khilman@ti.com \
--cc=govindraj.raja@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=robertcnelson@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.