From: Kevin Hilman <khilman@ti.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
Santosh Shilimkar <santosh.shilimkar@ti.com>
Subject: Re: [PATCH] ARM: PM: build sleep/suspend code for idle path also (not only suspend)
Date: Fri, 07 Oct 2011 15:49:37 -0700 [thread overview]
Message-ID: <8739f4ju2m.fsf@ti.com> (raw)
In-Reply-To: <20111007223922.GC26805@n2100.arm.linux.org.uk> (Russell King's message of "Fri, 7 Oct 2011 23:39:22 +0100")
Russell King - ARM Linux <linux@arm.linux.org.uk> writes:
> On Fri, Oct 07, 2011 at 03:31:26PM -0700, Kevin Hilman wrote:
>> Some platforms (e.g. OMAP) use the same common cpu_suspend/cpu_resume
>> helpers during idle as well as suspend.
>>
>> Currently, if suspend is disabled (CONFIG_PM_SLEEP=n) and the platform
>> idle code is using the common cpu_suspend/cpu_resume functions, the
>> kernel will not link.
>>
>> Since platform code commonly uses CONFIG_PM=y to build it's idle code,
>> build the common sleep/suspend code based on CONFIG_PM instead of
>> CONFIG_PM_SLEEP.
>>
>> Signed-off-by: Kevin Hilman <khilman@ti.com>
>> ---
>> Applies on Russell's devel-stable branch, where the new common
>> suspend/resume code is queued.
>
> See:
>
> commit 15e0d9e37c7fe9711b60f47221c394d45553ad8c
> Author: Arnd Bergmann <arnd@arndb.de>
> Date: Sat Oct 1 21:09:39 2011 +0200
>
> ARM: pm: let platforms select cpu_suspend support
>
> Support for the cpu_suspend functions is only built-in
> when CONFIG_PM_SLEEP is enabled, but omap3/4, exynos4
> and pxa always call cpu_suspend when CONFIG_PM is enabled.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Nice. That will work too.
I see this in Arnd's randconfig/arm branch but not yet in
arm-soc/for-next. Is this being queued for v3.2?
This will also conflict with your devel-stable where the suspend.c is
added.
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: khilman@ti.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: PM: build sleep/suspend code for idle path also (not only suspend)
Date: Fri, 07 Oct 2011 15:49:37 -0700 [thread overview]
Message-ID: <8739f4ju2m.fsf@ti.com> (raw)
In-Reply-To: <20111007223922.GC26805@n2100.arm.linux.org.uk> (Russell King's message of "Fri, 7 Oct 2011 23:39:22 +0100")
Russell King - ARM Linux <linux@arm.linux.org.uk> writes:
> On Fri, Oct 07, 2011 at 03:31:26PM -0700, Kevin Hilman wrote:
>> Some platforms (e.g. OMAP) use the same common cpu_suspend/cpu_resume
>> helpers during idle as well as suspend.
>>
>> Currently, if suspend is disabled (CONFIG_PM_SLEEP=n) and the platform
>> idle code is using the common cpu_suspend/cpu_resume functions, the
>> kernel will not link.
>>
>> Since platform code commonly uses CONFIG_PM=y to build it's idle code,
>> build the common sleep/suspend code based on CONFIG_PM instead of
>> CONFIG_PM_SLEEP.
>>
>> Signed-off-by: Kevin Hilman <khilman@ti.com>
>> ---
>> Applies on Russell's devel-stable branch, where the new common
>> suspend/resume code is queued.
>
> See:
>
> commit 15e0d9e37c7fe9711b60f47221c394d45553ad8c
> Author: Arnd Bergmann <arnd@arndb.de>
> Date: Sat Oct 1 21:09:39 2011 +0200
>
> ARM: pm: let platforms select cpu_suspend support
>
> Support for the cpu_suspend functions is only built-in
> when CONFIG_PM_SLEEP is enabled, but omap3/4, exynos4
> and pxa always call cpu_suspend when CONFIG_PM is enabled.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Nice. That will work too.
I see this in Arnd's randconfig/arm branch but not yet in
arm-soc/for-next. Is this being queued for v3.2?
This will also conflict with your devel-stable where the suspend.c is
added.
Kevin
next prev parent reply other threads:[~2011-10-07 22:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-07 22:31 [PATCH] ARM: PM: build sleep/suspend code for idle path also (not only suspend) Kevin Hilman
2011-10-07 22:31 ` Kevin Hilman
2011-10-07 22:39 ` Russell King - ARM Linux
2011-10-07 22:39 ` Russell King - ARM Linux
2011-10-07 22:49 ` Kevin Hilman [this message]
2011-10-07 22:49 ` Kevin Hilman
2011-10-07 23:00 ` Russell King - ARM Linux
2011-10-07 23:00 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8739f4ju2m.fsf@ti.com \
--to=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=santosh.shilimkar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.