From: Rusty Russell <rusty@rustcorp.com.au>
To: "Michael S. Tsirkin" <mst@redhat.com>,
habanero@linux.vnet.ibm.com, Shirley Ma <mashirle@us.ibm.com>,
Krishna Kumar2 <krkumar2@in.ibm.com>,
kvm@vger.kernel.org, steved@us.ibm.com,
Tom Lendacky <tahm@linux.vnet.ibm.com>,
borntraeger@de.ibm.com, avi@redhat.com
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC] virtio_net: fix patch: virtio_net: limit xmit polling
Date: Thu, 19 May 2011 17:00:17 +0930 [thread overview]
Message-ID: <8739kb5era.fsf@rustcorp.com.au> (raw)
In-Reply-To: <20110518220125.GA26835@redhat.com>
On Thu, 19 May 2011 01:01:25 +0300, "Michael S. Tsirkin" <mst@redhat.com> wrote:
> The patch virtio_net: limit xmit polling
> got the logic reversed: it polled while we had
> capacity not while ring was empty.
>
> Fix it up and clean up a bit by using a for loop.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>
> OK, turns out that patch was borken. Here's
> a fix that survived stress test on my box.
> Pushed on my branch, I'll send a rebased series
> with Rusty's comments addressed ASAP.
Normally you would have missed the merge window by now, but I'd really
like this stuff in, so I'm holding it open for this. I want these patches
in linux-next for at least a few days before I push them.
If you think we're not close enough, please tell me and I'll push
the rest of the virtio patches to Linus now.
Thanks,
Rusty.
WARNING: multiple messages have this Message-ID (diff)
From: Rusty Russell <rusty@rustcorp.com.au>
To: "Michael S. Tsirkin" <mst@redhat.com>,
habanero@linux.vnet.ibm.com, Shirley Ma <mashirle@us.ibm.com>,
Krishna Kumar2 <krkumar2@in.ibm.com>,
kvm@vger.kernel.org, steved@us.ibm.com, Tom
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC] virtio_net: fix patch: virtio_net: limit xmit polling
Date: Thu, 19 May 2011 17:00:17 +0930 [thread overview]
Message-ID: <8739kb5era.fsf@rustcorp.com.au> (raw)
In-Reply-To: <20110518220125.GA26835@redhat.com>
On Thu, 19 May 2011 01:01:25 +0300, "Michael S. Tsirkin" <mst@redhat.com> wrote:
> The patch virtio_net: limit xmit polling
> got the logic reversed: it polled while we had
> capacity not while ring was empty.
>
> Fix it up and clean up a bit by using a for loop.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>
> OK, turns out that patch was borken. Here's
> a fix that survived stress test on my box.
> Pushed on my branch, I'll send a rebased series
> with Rusty's comments addressed ASAP.
Normally you would have missed the merge window by now, but I'd really
like this stuff in, so I'm holding it open for this. I want these patches
in linux-next for at least a few days before I push them.
If you think we're not close enough, please tell me and I'll push
the rest of the virtio patches to Linus now.
Thanks,
Rusty.
next prev parent reply other threads:[~2011-05-20 4:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-18 22:01 [PATCH RFC] virtio_net: fix patch: virtio_net: limit xmit polling Michael S. Tsirkin
2011-05-18 22:01 ` Michael S. Tsirkin
2011-05-19 7:30 ` Rusty Russell
2011-05-19 7:30 ` Rusty Russell [this message]
2011-05-19 7:30 ` Rusty Russell
2011-05-22 17:32 ` Michael S. Tsirkin
2011-05-22 17:32 ` Michael S. Tsirkin
-- strict thread matches above, loose matches on Subject: below --
2011-05-18 22:01 Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8739kb5era.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=avi@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=habanero@linux.vnet.ibm.com \
--cc=krkumar2@in.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mashirle@us.ibm.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=steved@us.ibm.com \
--cc=tahm@linux.vnet.ibm.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.