From: Kevin Hilman <khilman@deeprootsystems.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org
Subject: Re: [RFC/PATCH] arm: oprofile: remove locking from suspend/resume
Date: Wed, 19 May 2010 15:44:29 -0700 [thread overview]
Message-ID: <8739xnjyuq.fsf@deeprootsystems.com> (raw)
In-Reply-To: <20100519070459.GA22212@n2100.arm.linux.org.uk> (Russell King's message of "Wed\, 19 May 2010 08\:04\:59 +0100")
Russell King - ARM Linux <linux@arm.linux.org.uk> writes:
> On Tue, May 18, 2010 at 05:13:01PM -0700, Kevin Hilman wrote:
>> Since oprofile is a sysdev, its suspend/resume methods are called with
>> interrupts disabled. Using a mutex (which might sleep) in this atomic
>> context is not safe.
>
> It isn't a sysdev anymore. Suggest you take a look at the ARM tree once
> in a while.
Indeed, I see it is fixed already there.
Sorry for the noise,
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: khilman@deeprootsystems.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC/PATCH] arm: oprofile: remove locking from suspend/resume
Date: Wed, 19 May 2010 15:44:29 -0700 [thread overview]
Message-ID: <8739xnjyuq.fsf@deeprootsystems.com> (raw)
In-Reply-To: <20100519070459.GA22212@n2100.arm.linux.org.uk> (Russell King's message of "Wed\, 19 May 2010 08\:04\:59 +0100")
Russell King - ARM Linux <linux@arm.linux.org.uk> writes:
> On Tue, May 18, 2010 at 05:13:01PM -0700, Kevin Hilman wrote:
>> Since oprofile is a sysdev, its suspend/resume methods are called with
>> interrupts disabled. Using a mutex (which might sleep) in this atomic
>> context is not safe.
>
> It isn't a sysdev anymore. Suggest you take a look at the ARM tree once
> in a while.
Indeed, I see it is fixed already there.
Sorry for the noise,
Kevin
next prev parent reply other threads:[~2010-05-19 22:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-19 0:13 [RFC/PATCH] arm: oprofile: remove locking from suspend/resume Kevin Hilman
2010-05-19 0:13 ` Kevin Hilman
2010-05-19 7:04 ` Russell King - ARM Linux
2010-05-19 7:04 ` Russell King - ARM Linux
2010-05-19 22:44 ` Kevin Hilman [this message]
2010-05-19 22:44 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8739xnjyuq.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.