From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: mike@compulab.co.il,
Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [PATCH 2/4] pxa_camera: Redesign DMA handling
Date: Wed, 11 Mar 2009 22:21:16 +0100 [thread overview]
Message-ID: <873adjhi2b.fsf@free.fr> (raw)
In-Reply-To: <87r615hwzb.fsf@free.fr> (Robert Jarzmik's message of "Tue\, 10 Mar 2009 22\:46\:48 +0100")
Robert Jarzmik <robert.jarzmik@free.fr> writes:
> Guennadi Liakhovetski <g.liakhovetski@gmx.de> writes:
> It is the result of our conversation about "hot DMA linking". I tested both
> paths (the optimal one and the one where DMA stops while queuing =>
> cf. pxa_camera_check_link_miss) for RGB565 format. I'll test further for
> YUV422P ...
Well, surprise surprise with the YUV422P format. We're not done yet ...
There is a little issue with overrun : buf->active_dma is cleared in dma irq
handler (for example suppose is cleared of DMA_U which finished first). Then an
overrun occurs, and we restart that frame ...
We should have reset buf->active_dma to DMA_Y | DMA_U | DMA_V.
I think same thing applies to the "hot chain" link miss restart.
The non-regression tests are not yet finished ... exciting, isn't it ? :)
Cheers.
--
Robert
next prev parent reply other threads:[~2009-03-11 21:21 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-05 19:45 [PATCH 0/4] pxa_camera: Redesign DMA handling Robert Jarzmik
2009-03-05 19:45 ` [PATCH 1/4] pxa_camera: Remove YUV planar formats hole Robert Jarzmik
2009-03-05 19:45 ` [PATCH 2/4] pxa_camera: Redesign DMA handling Robert Jarzmik
2009-03-05 19:45 ` [PATCH 3/4] pxa_camera: Coding style sweeping Robert Jarzmik
2009-03-05 19:45 ` [PATCH 4/4] pxa_camera: Fix overrun condition on last buffer Robert Jarzmik
2009-03-09 11:39 ` Guennadi Liakhovetski
2009-03-09 19:16 ` Robert Jarzmik
2009-03-11 18:31 ` Guennadi Liakhovetski
2009-03-12 21:36 ` Robert Jarzmik
2009-03-12 22:12 ` Guennadi Liakhovetski
2009-03-09 11:35 ` [PATCH 2/4] pxa_camera: Redesign DMA handling Guennadi Liakhovetski
2009-03-09 20:50 ` Robert Jarzmik
2009-03-09 23:14 ` Guennadi Liakhovetski
2009-03-10 21:46 ` Robert Jarzmik
2009-03-11 18:25 ` Guennadi Liakhovetski
2009-03-11 19:45 ` Robert Jarzmik
2009-03-11 20:24 ` Robert Jarzmik
2009-03-11 21:21 ` Robert Jarzmik [this message]
2009-03-05 20:29 ` [PATCH 1/4] pxa_camera: Remove YUV planar formats hole Guennadi Liakhovetski
2009-03-05 21:10 ` Robert Jarzmik
2009-03-05 21:22 ` Trent Piepho
2009-03-05 22:15 ` Guennadi Liakhovetski
2009-03-06 9:30 ` Trent Piepho
2009-03-09 10:45 ` Guennadi Liakhovetski
2009-03-09 19:13 ` Robert Jarzmik
2009-03-10 18:33 ` Trent Piepho
[not found] <1817982448.2932771236676188034.JavaMail.root@zimbra20-e3.priv.proxad.net>
2009-03-10 9:11 ` [PATCH 2/4] pxa_camera: Redesign DMA handling robert.jarzmik
2009-03-10 9:35 ` Guennadi Liakhovetski
[not found] <1214153377.2956891236680608913.JavaMail.root@zimbra20-e3.priv.proxad.net>
2009-03-10 10:25 ` robert.jarzmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=873adjhi2b.fsf@free.fr \
--to=robert.jarzmik@free.fr \
--cc=g.liakhovetski@gmx.de \
--cc=linux-media@vger.kernel.org \
--cc=mike@compulab.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.