warnings when compiling minix and hfs

warnings when compiling minix and hfs

[Yoshinori K. Okuji]

I get these warnings when compiming minix.c and hfs.c:

gcc -Ifs -I../fs -I. -Iinclude -I../include -Wall -W -Wall -W -Wshadow 
-Wpointer-arith -Wmissing-prototypes            -Wundef 
-Wstrict-prototypes -g -Os -falign-jumps=1 -falign-loops=1 
-falign-functions=1 -fno-builtin -mrtd -mregparm=3 -c -o 
minix_mod-fs_minix.o ../fs/minix.c
../fs/minix.c: In function `grub_minix_get_file_block':
../fs/minix.c:131: warning: no previous prototype for `grub_get_indir'
../fs/minix.c: In function `grub_get_indir':
../fs/minix.c:134: warning: declaration of `indir' shadows a previous 
local
../fs/minix.c:127: warning: shadowed declaration is here
../fs/minix.c:143: warning: declaration of `indir' shadows a previous 
local
../fs/minix.c:127: warning: shadowed declaration is here
rm -f pre-minix.o
ld -r -o pre-minix.o minix_mod-fs_minix.o
nm -g --defined-only -P -p pre-minix.o | sed 's/^\([^ ]*\).*/\1 minix/' 
> def-minix.lst
gcc -Ifs -I../fs -I. -Iinclude -I../include -Wall -W -Wall -W -Wshadow 
-Wpointer-arith -Wmissing-prototypes            -Wundef 
-Wstrict-prototypes -g -Os -falign-jumps=1 -falign-loops=1 
-falign-functions=1 -fno-builtin -mrtd -mregparm=3 -c -o 
hfs_mod-fs_hfs.o ../fs/hfs.c
../fs/hfs.c: In function `grub_hfs_find_node':
../fs/hfs.c:527: warning: no previous prototype for `node_found'
../fs/hfs.c: At top level:
../fs/hfs.c:582: warning: no previous prototype for 
`grub_hfs_iterate_dir'
../fs/hfs.c: In function `grub_hfs_iterate_dir':
../fs/hfs.c:592: warning: no previous prototype for `node_found'
../fs/hfs.c:613: warning: no previous prototype for `it_dir'
../fs/hfs.c: In function `grub_hfs_dir':
../fs/hfs.c:727: warning: no previous prototype for `dir_hook'


Marco, can you fix them?

Okuji

Re: warnings when compiling minix and hfs

[Marco Gerards]

"Yoshinori K. Okuji" <okuji@enbug.org> writes:

> I get these warnings when compiming minix.c and hfs.c:

[...]

> Marco, can you fix them?

Sure.  I think this happened because for grub-emu other compile
options are used then for the modules.  I will have a look at this as
well.

--
Marco

Re: warnings when compiling minix and hfs

[metgerards]

"Yoshinori K. Okuji" <okuji@enbug.org> writes:

> I get these warnings when compiming minix.c and hfs.c:

[...]

> Marco, can you fix them?

Done.  If there are any more problems, please tell me.

--
Marco