Re: [dovetail 7.3][PATCH] net: dovetail: Pick up lost return code of packet_do_bind_unlocked

[Philippe Gerum <rpm@xenomai.org>]

Jan Kiszka <jan.kiszka@siemens.com> writes:

> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> Results in missed errors and uninitialized usage of ret, thus random
> behavior.
>
> Reported-by: opencode:Opus-5.5
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>
> Apparently a regression of the 6.19 forward port.
>
>  net/packet/af_packet.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c
> index 6ebeb3f1f5811..53b1c35423699 100644
> --- a/net/packet/af_packet.c
> +++ b/net/packet/af_packet.c
> @@ -3371,7 +3371,7 @@ static int packet_bind_spkt(struct socket *sock, struct sockaddr_unsized *uaddr,
>  	name[sizeof(sa->sa_data)] = 0;
>  
>  	lock_sock(sk);
> -	packet_do_bind_unlocked(sk, name, 0, 0);
> +	ret = packet_do_bind_unlocked(sk, name, 0, 0);
>  	if (!ret && sock_oob_capable(sk->sk_socket))
>  		ret = sock_oob_bind(sk, uaddr, addr_len);
>  	release_sock(sk);

Merged, thanks.

-- 
Philippe.