* [dovetail 7.3][PATCH] net: dovetail: Pick up lost return code of packet_do_bind_unlocked
@ 2026-11-11 9:15 Jan Kiszka
2026-11-11 9:44 ` Philippe Gerum
0 siblings, 1 reply; 2+ messages in thread
From: Jan Kiszka @ 2026-11-11 9:15 UTC (permalink / raw)
To: Philippe Gerum, Xenomai
From: Jan Kiszka <jan.kiszka@siemens.com>
Results in missed errors and uninitialized usage of ret, thus random
behavior.
Reported-by: opencode:Opus-5.5
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
Apparently a regression of the 6.19 forward port.
net/packet/af_packet.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c
index 6ebeb3f1f5811..53b1c35423699 100644
--- a/net/packet/af_packet.c
+++ b/net/packet/af_packet.c
@@ -3371,7 +3371,7 @@ static int packet_bind_spkt(struct socket *sock, struct sockaddr_unsized *uaddr,
name[sizeof(sa->sa_data)] = 0;
lock_sock(sk);
- packet_do_bind_unlocked(sk, name, 0, 0);
+ ret = packet_do_bind_unlocked(sk, name, 0, 0);
if (!ret && sock_oob_capable(sk->sk_socket))
ret = sock_oob_bind(sk, uaddr, addr_len);
release_sock(sk);
--
2.47.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [dovetail 7.3][PATCH] net: dovetail: Pick up lost return code of packet_do_bind_unlocked
2026-11-11 9:15 [dovetail 7.3][PATCH] net: dovetail: Pick up lost return code of packet_do_bind_unlocked Jan Kiszka
@ 2026-11-11 9:44 ` Philippe Gerum
0 siblings, 0 replies; 2+ messages in thread
From: Philippe Gerum @ 2026-11-11 9:44 UTC (permalink / raw)
To: Jan Kiszka; +Cc: Xenomai
Jan Kiszka <jan.kiszka@siemens.com> writes:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> Results in missed errors and uninitialized usage of ret, thus random
> behavior.
>
> Reported-by: opencode:Opus-5.5
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>
> Apparently a regression of the 6.19 forward port.
>
> net/packet/af_packet.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c
> index 6ebeb3f1f5811..53b1c35423699 100644
> --- a/net/packet/af_packet.c
> +++ b/net/packet/af_packet.c
> @@ -3371,7 +3371,7 @@ static int packet_bind_spkt(struct socket *sock, struct sockaddr_unsized *uaddr,
> name[sizeof(sa->sa_data)] = 0;
>
> lock_sock(sk);
> - packet_do_bind_unlocked(sk, name, 0, 0);
> + ret = packet_do_bind_unlocked(sk, name, 0, 0);
> if (!ret && sock_oob_capable(sk->sk_socket))
> ret = sock_oob_bind(sk, uaddr, addr_len);
> release_sock(sk);
Merged, thanks.
--
Philippe.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-11 9:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-11 9:15 [dovetail 7.3][PATCH] net: dovetail: Pick up lost return code of packet_do_bind_unlocked Jan Kiszka
2026-11-11 9:44 ` Philippe Gerum
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.