All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ALSA: hda/realtek: Fix mute LED for HP Victus 15-fa1xxx (MB 8C3F)
@ 2026-08-15 16:33 Yashraj221B
  2026-08-16 10:42 ` Takashi Iwai
  2026-08-16 11:06 ` [PATCH v2] " Yashraj Ghule
  0 siblings, 2 replies; 4+ messages in thread
From: Yashraj221B @ 2026-08-15 16:33 UTC (permalink / raw)
  To: perex; +Cc: tiwai, linux-sound, Yashraj221B

The HP Victus 15-fa1xxx with motherboard 8C3F is missing the
existing mute LED quirk for ALC245 codecs.

Add the 103c:8c3f subsystem ID to the existing
ALC245_FIXUP_HP_MUTE_LED_COEFBIT quirk.

Tested on HP Victus 15-fa1xxx (MB 8C3F). The mute LED works
as intended.

Signed-off-by: Yashraj221B <yashrajghule.221@gmail.com>
---
 sound/hda/codecs/realtek/alc269.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
index 3f0e276fc606..df0732c5e14d 100644
--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -7470,6 +7470,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x103c, 0x8c17, "HP Spectre x360 2-in-1 Laptop 16-aa0xxx", ALC245_FIXUP_HP_SPECTRE_X360_16_AA0XXX),
 	SND_PCI_QUIRK(0x103c, 0x8c21, "HP Pavilion Plus Laptop 14-ey0XXX", ALC245_FIXUP_HP_X360_MUTE_LEDS),
 	SND_PCI_QUIRK(0x103c, 0x8c2d, "HP Victus 15-fa1xxx (MB 8C2D)", ALC245_FIXUP_HP_MUTE_LED_COEFBIT),
+	SND_PCI_QUIRK(0x103c, 0x8c3f, "HP Victus 15-fa1xxx (MB 8C3F)", ALC245_FIXUP_HP_MUTE_LED_COEFBIT),
 	SND_PCI_QUIRK(0x103c, 0x8c30, "HP Victus 15-fb1xxx", ALC245_FIXUP_HP_MUTE_LED_COEFBIT),
 	SND_PCI_QUIRK(0x103c, 0x8c46, "HP EliteBook 830 G11", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8c47, "HP EliteBook 840 G11", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
-- 
2.55.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] ALSA: hda/realtek: Fix mute LED for HP Victus 15-fa1xxx (MB 8C3F)
  2026-08-15 16:33 [PATCH] ALSA: hda/realtek: Fix mute LED for HP Victus 15-fa1xxx (MB 8C3F) Yashraj221B
@ 2026-08-16 10:42 ` Takashi Iwai
  2026-08-16 11:06 ` [PATCH v2] " Yashraj Ghule
  1 sibling, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2026-08-16 10:42 UTC (permalink / raw)
  To: Yashraj221B; +Cc: perex, tiwai, linux-sound

On Sat, 15 Aug 2026 18:33:12 +0200,
Yashraj221B wrote:
> 
> The HP Victus 15-fa1xxx with motherboard 8C3F is missing the
> existing mute LED quirk for ALC245 codecs.
> 
> Add the 103c:8c3f subsystem ID to the existing
> ALC245_FIXUP_HP_MUTE_LED_COEFBIT quirk.
> 
> Tested on HP Victus 15-fa1xxx (MB 8C3F). The mute LED works
> as intended.
> 
> Signed-off-by: Yashraj221B <yashrajghule.221@gmail.com>

The Signed-off-by tag is a legal requirement, and it must be with a
real name (or a known identity).  At best, change From: address to
align with it altogether.

Also, about the code change:

> ---
>  sound/hda/codecs/realtek/alc269.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
> index 3f0e276fc606..df0732c5e14d 100644
> --- a/sound/hda/codecs/realtek/alc269.c
> +++ b/sound/hda/codecs/realtek/alc269.c
> @@ -7470,6 +7470,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
>  	SND_PCI_QUIRK(0x103c, 0x8c17, "HP Spectre x360 2-in-1 Laptop 16-aa0xxx", ALC245_FIXUP_HP_SPECTRE_X360_16_AA0XXX),
>  	SND_PCI_QUIRK(0x103c, 0x8c21, "HP Pavilion Plus Laptop 14-ey0XXX", ALC245_FIXUP_HP_X360_MUTE_LEDS),
>  	SND_PCI_QUIRK(0x103c, 0x8c2d, "HP Victus 15-fa1xxx (MB 8C2D)", ALC245_FIXUP_HP_MUTE_LED_COEFBIT),
> +	SND_PCI_QUIRK(0x103c, 0x8c3f, "HP Victus 15-fa1xxx (MB 8C3F)", ALC245_FIXUP_HP_MUTE_LED_COEFBIT),
>  	SND_PCI_QUIRK(0x103c, 0x8c30, "HP Victus 15-fb1xxx", ALC245_FIXUP_HP_MUTE_LED_COEFBIT),
>  	SND_PCI_QUIRK(0x103c, 0x8c46, "HP EliteBook 830 G11", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
>  	SND_PCI_QUIRK(0x103c, 0x8c47, "HP EliteBook 840 G11", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),

The table is sorted in PCI SSID order.  Please put the new entry at
the right position.

Could you resubmit with the corrections above?  Thanks.


Takashi

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v2] ALSA: hda/realtek: Fix mute LED for HP Victus 15-fa1xxx (MB 8C3F)
  2026-08-15 16:33 [PATCH] ALSA: hda/realtek: Fix mute LED for HP Victus 15-fa1xxx (MB 8C3F) Yashraj221B
  2026-08-16 10:42 ` Takashi Iwai
@ 2026-08-16 11:06 ` Yashraj Ghule
  2026-08-17  7:54   ` Takashi Iwai
  1 sibling, 1 reply; 4+ messages in thread
From: Yashraj Ghule @ 2026-08-16 11:06 UTC (permalink / raw)
  To: perex; +Cc: tiwai, linux-sound, Yashraj Ghule

The HP Victus 15-fa1xxx with motherboard 8C3F is missing the
existing mute LED quirk for ALC245 codecs.

Add the 103c:8c3f subsystem ID to the existing
ALC245_FIXUP_HP_MUTE_LED_COEFBIT quirk.

Tested on HP Victus 15-fa1xxx (MB 8C3F). The mute LED works
as intended.

Signed-off-by: Yashraj Ghule <yashrajghule.221@gmail.com>
---
Changes in v2:
- Use Yashraj Ghule as the author and Signed-off-by identity.
- Place the 8c3f entry in PCI SSID order.

v1: Message-ID: <20260815163312.29030-1-yashrajghule.221@gmail.com>

 sound/hda/codecs/realtek/alc269.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
index 3f0e276fc606..c4a68d84bd60 100644
--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -7471,6 +7471,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x103c, 0x8c21, "HP Pavilion Plus Laptop 14-ey0XXX", ALC245_FIXUP_HP_X360_MUTE_LEDS),
 	SND_PCI_QUIRK(0x103c, 0x8c2d, "HP Victus 15-fa1xxx (MB 8C2D)", ALC245_FIXUP_HP_MUTE_LED_COEFBIT),
 	SND_PCI_QUIRK(0x103c, 0x8c30, "HP Victus 15-fb1xxx", ALC245_FIXUP_HP_MUTE_LED_COEFBIT),
+	SND_PCI_QUIRK(0x103c, 0x8c3f, "HP Victus 15-fa1xxx (MB 8C3F)", ALC245_FIXUP_HP_MUTE_LED_COEFBIT),
 	SND_PCI_QUIRK(0x103c, 0x8c46, "HP EliteBook 830 G11", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8c47, "HP EliteBook 840 G11", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8c48, "HP EliteBook 860 G11", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
-- 
2.55.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] ALSA: hda/realtek: Fix mute LED for HP Victus 15-fa1xxx (MB 8C3F)
  2026-08-16 11:06 ` [PATCH v2] " Yashraj Ghule
@ 2026-08-17  7:54   ` Takashi Iwai
  0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2026-08-17  7:54 UTC (permalink / raw)
  To: Yashraj Ghule; +Cc: perex, tiwai, linux-sound

On Sun, 16 Aug 2026 13:06:55 +0200,
Yashraj Ghule wrote:
> 
> The HP Victus 15-fa1xxx with motherboard 8C3F is missing the
> existing mute LED quirk for ALC245 codecs.
> 
> Add the 103c:8c3f subsystem ID to the existing
> ALC245_FIXUP_HP_MUTE_LED_COEFBIT quirk.
> 
> Tested on HP Victus 15-fa1xxx (MB 8C3F). The mute LED works
> as intended.
> 
> Signed-off-by: Yashraj Ghule <yashrajghule.221@gmail.com>

Applied now.  Thanks.


Takashi

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-08-17  7:54 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-15 16:33 [PATCH] ALSA: hda/realtek: Fix mute LED for HP Victus 15-fa1xxx (MB 8C3F) Yashraj221B
2026-08-16 10:42 ` Takashi Iwai
2026-08-16 11:06 ` [PATCH v2] " Yashraj Ghule
2026-08-17  7:54   ` Takashi Iwai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.