* [PATCH v6 01/64] target/arm: Implement ID_AA64ISAR3
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
@ 2026-05-20 18:21 ` Richard Henderson
2026-05-21 13:36 ` Peter Maydell
2026-05-21 15:22 ` Alex Bennée
2026-05-20 18:21 ` [PATCH v6 02/64] target/arm: Implement FEAT_FAMINMAX for AdvSIMD Richard Henderson
` (62 subsequent siblings)
63 siblings, 2 replies; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:21 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/cpu-features.h | 9 +++++++++
target/arm/helper.c | 8 ++++++--
target/arm/cpu-sysregs.h.inc | 1 +
3 files changed, 16 insertions(+), 2 deletions(-)
diff --git a/target/arm/cpu-features.h b/target/arm/cpu-features.h
index 4e44245a8b..50776347a5 100644
--- a/target/arm/cpu-features.h
+++ b/target/arm/cpu-features.h
@@ -244,6 +244,15 @@ FIELD(ID_AA64ISAR2, CSSC, 52, 4)
FIELD(ID_AA64ISAR2, LUT, 56, 4)
FIELD(ID_AA64ISAR2, ATS1A, 60, 4)
+FIELD(ID_AA64ISAR3, CPA, 0, 4)
+FIELD(ID_AA64ISAR3, FAMINMAX, 4, 4)
+FIELD(ID_AA64ISAR3, TLBIW, 8, 4)
+FIELD(ID_AA64ISAR3, PACM, 12, 4)
+FIELD(ID_AA64ISAR3, LSFE, 16, 4)
+FIELD(ID_AA64ISAR3, OCCMO, 20, 4)
+FIELD(ID_AA64ISAR3, LSUI, 24, 4)
+FIELD(ID_AA64ISAR3, FPRCVT, 28, 4)
+
FIELD(ID_AA64PFR0, EL0, 0, 4)
FIELD(ID_AA64PFR0, EL1, 4, 4)
FIELD(ID_AA64PFR0, EL2, 8, 4)
diff --git a/target/arm/helper.c b/target/arm/helper.c
index 8240f1b384..6ad01b345f 100644
--- a/target/arm/helper.c
+++ b/target/arm/helper.c
@@ -6519,11 +6519,11 @@ void register_cp_regs_for_features(ARMCPU *cpu)
.access = PL1_R, .type = ARM_CP_CONST,
.accessfn = access_tid3,
.resetvalue = GET_IDREG(isar, ID_AA64ISAR2)},
- { .name = "ID_AA64ISAR3_EL1_RESERVED", .state = ARM_CP_STATE_AA64,
+ { .name = "ID_AA64ISAR3_EL1", .state = ARM_CP_STATE_AA64,
.opc0 = 3, .opc1 = 0, .crn = 0, .crm = 6, .opc2 = 3,
.access = PL1_R, .type = ARM_CP_CONST,
.accessfn = access_tid3,
- .resetvalue = 0 },
+ .resetvalue = GET_IDREG(isar, ID_AA64ISAR3) },
{ .name = "ID_AA64ISAR4_EL1_RESERVED", .state = ARM_CP_STATE_AA64,
.opc0 = 3, .opc1 = 0, .crn = 0, .crm = 6, .opc2 = 4,
.access = PL1_R, .type = ARM_CP_CONST,
@@ -6752,6 +6752,10 @@ void register_cp_regs_for_features(ARMCPU *cpu)
R_ID_AA64ISAR2_BC_MASK |
R_ID_AA64ISAR2_RPRFM_MASK |
R_ID_AA64ISAR2_CSSC_MASK },
+ { .name = "ID_AA64ISAR3_EL1",
+ .exported_bits = R_ID_AA64ISAR3_FAMINMAX_MASK |
+ R_ID_AA64ISAR3_LSFE_MASK |
+ R_ID_AA64ISAR3_FPRCVT_MASK },
{ .name = "ID_AA64ISAR*_EL1_RESERVED",
.is_glob = true },
};
diff --git a/target/arm/cpu-sysregs.h.inc b/target/arm/cpu-sysregs.h.inc
index 3d1ed40f04..b99579f773 100644
--- a/target/arm/cpu-sysregs.h.inc
+++ b/target/arm/cpu-sysregs.h.inc
@@ -10,6 +10,7 @@ DEF(ID_AA64AFR1_EL1, 3, 0, 0, 5, 5)
DEF(ID_AA64ISAR0_EL1, 3, 0, 0, 6, 0)
DEF(ID_AA64ISAR1_EL1, 3, 0, 0, 6, 1)
DEF(ID_AA64ISAR2_EL1, 3, 0, 0, 6, 2)
+DEF(ID_AA64ISAR3_EL1, 3, 0, 0, 6, 3)
DEF(ID_AA64MMFR0_EL1, 3, 0, 0, 7, 0)
DEF(ID_AA64MMFR1_EL1, 3, 0, 0, 7, 1)
DEF(ID_AA64MMFR2_EL1, 3, 0, 0, 7, 2)
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread* Re: [PATCH v6 01/64] target/arm: Implement ID_AA64ISAR3
2026-05-20 18:21 ` [PATCH v6 01/64] target/arm: Implement ID_AA64ISAR3 Richard Henderson
@ 2026-05-21 13:36 ` Peter Maydell
2026-05-21 15:22 ` Alex Bennée
1 sibling, 0 replies; 105+ messages in thread
From: Peter Maydell @ 2026-05-21 13:36 UTC (permalink / raw)
To: Richard Henderson; +Cc: qemu-devel, qemu-arm
On Wed, 20 May 2026 at 19:22, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
^ permalink raw reply [flat|nested] 105+ messages in thread
* Re: [PATCH v6 01/64] target/arm: Implement ID_AA64ISAR3
2026-05-20 18:21 ` [PATCH v6 01/64] target/arm: Implement ID_AA64ISAR3 Richard Henderson
2026-05-21 13:36 ` Peter Maydell
@ 2026-05-21 15:22 ` Alex Bennée
2026-05-21 15:45 ` Peter Maydell
2026-05-22 18:31 ` Richard Henderson
1 sibling, 2 replies; 105+ messages in thread
From: Alex Bennée @ 2026-05-21 15:22 UTC (permalink / raw)
To: Richard Henderson; +Cc: qemu-devel, qemu-arm
Richard Henderson <richard.henderson@linaro.org> writes:
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/arm/cpu-features.h | 9 +++++++++
> target/arm/helper.c | 8 ++++++--
> target/arm/cpu-sysregs.h.inc | 1 +
> 3 files changed, 16 insertions(+), 2 deletions(-)
>
> diff --git a/target/arm/cpu-features.h b/target/arm/cpu-features.h
> index 4e44245a8b..50776347a5 100644
> --- a/target/arm/cpu-features.h
> +++ b/target/arm/cpu-features.h
> @@ -244,6 +244,15 @@ FIELD(ID_AA64ISAR2, CSSC, 52, 4)
> FIELD(ID_AA64ISAR2, LUT, 56, 4)
> FIELD(ID_AA64ISAR2, ATS1A, 60, 4)
>
> +FIELD(ID_AA64ISAR3, CPA, 0, 4)
> +FIELD(ID_AA64ISAR3, FAMINMAX, 4, 4)
> +FIELD(ID_AA64ISAR3, TLBIW, 8, 4)
> +FIELD(ID_AA64ISAR3, PACM, 12, 4)
> +FIELD(ID_AA64ISAR3, LSFE, 16, 4)
> +FIELD(ID_AA64ISAR3, OCCMO, 20, 4)
> +FIELD(ID_AA64ISAR3, LSUI, 24, 4)
> +FIELD(ID_AA64ISAR3, FPRCVT, 28, 4)
> +
> FIELD(ID_AA64PFR0, EL0, 0, 4)
> FIELD(ID_AA64PFR0, EL1, 4, 4)
> FIELD(ID_AA64PFR0, EL2, 8, 4)
> diff --git a/target/arm/helper.c b/target/arm/helper.c
> index 8240f1b384..6ad01b345f 100644
> --- a/target/arm/helper.c
> +++ b/target/arm/helper.c
> @@ -6519,11 +6519,11 @@ void register_cp_regs_for_features(ARMCPU *cpu)
> .access = PL1_R, .type = ARM_CP_CONST,
> .accessfn = access_tid3,
> .resetvalue = GET_IDREG(isar, ID_AA64ISAR2)},
> - { .name = "ID_AA64ISAR3_EL1_RESERVED", .state = ARM_CP_STATE_AA64,
> + { .name = "ID_AA64ISAR3_EL1", .state = ARM_CP_STATE_AA64,
> .opc0 = 3, .opc1 = 0, .crn = 0, .crm = 6, .opc2 = 3,
> .access = PL1_R, .type = ARM_CP_CONST,
> .accessfn = access_tid3,
> - .resetvalue = 0 },
> + .resetvalue = GET_IDREG(isar, ID_AA64ISAR3) },
> { .name = "ID_AA64ISAR4_EL1_RESERVED", .state = ARM_CP_STATE_AA64,
> .opc0 = 3, .opc1 = 0, .crn = 0, .crm = 6, .opc2 = 4,
> .access = PL1_R, .type = ARM_CP_CONST,
> @@ -6752,6 +6752,10 @@ void register_cp_regs_for_features(ARMCPU *cpu)
> R_ID_AA64ISAR2_BC_MASK |
> R_ID_AA64ISAR2_RPRFM_MASK |
> R_ID_AA64ISAR2_CSSC_MASK },
> + { .name = "ID_AA64ISAR3_EL1",
> + .exported_bits = R_ID_AA64ISAR3_FAMINMAX_MASK |
> + R_ID_AA64ISAR3_LSFE_MASK |
> + R_ID_AA64ISAR3_FPRCVT_MASK },
With this definition should we also add it to arm_clear_aarch64_idregs()
which clears the other ISARs with aarch64=off?
> { .name = "ID_AA64ISAR*_EL1_RESERVED",
> .is_glob = true },
> };
> diff --git a/target/arm/cpu-sysregs.h.inc b/target/arm/cpu-sysregs.h.inc
> index 3d1ed40f04..b99579f773 100644
> --- a/target/arm/cpu-sysregs.h.inc
> +++ b/target/arm/cpu-sysregs.h.inc
> @@ -10,6 +10,7 @@ DEF(ID_AA64AFR1_EL1, 3, 0, 0, 5, 5)
> DEF(ID_AA64ISAR0_EL1, 3, 0, 0, 6, 0)
> DEF(ID_AA64ISAR1_EL1, 3, 0, 0, 6, 1)
> DEF(ID_AA64ISAR2_EL1, 3, 0, 0, 6, 2)
> +DEF(ID_AA64ISAR3_EL1, 3, 0, 0, 6, 3)
> DEF(ID_AA64MMFR0_EL1, 3, 0, 0, 7, 0)
> DEF(ID_AA64MMFR1_EL1, 3, 0, 0, 7, 1)
> DEF(ID_AA64MMFR2_EL1, 3, 0, 0, 7, 2)
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
^ permalink raw reply [flat|nested] 105+ messages in thread* Re: [PATCH v6 01/64] target/arm: Implement ID_AA64ISAR3
2026-05-21 15:22 ` Alex Bennée
@ 2026-05-21 15:45 ` Peter Maydell
2026-05-22 18:31 ` Richard Henderson
1 sibling, 0 replies; 105+ messages in thread
From: Peter Maydell @ 2026-05-21 15:45 UTC (permalink / raw)
To: Alex Bennée; +Cc: Richard Henderson, qemu-devel, qemu-arm
On Thu, 21 May 2026 at 16:33, Alex Bennée <alex.bennee@linaro.org> wrote:
>
> Richard Henderson <richard.henderson@linaro.org> writes:
>
> > Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> > ---
> > target/arm/cpu-features.h | 9 +++++++++
> > target/arm/helper.c | 8 ++++++--
> > target/arm/cpu-sysregs.h.inc | 1 +
> > 3 files changed, 16 insertions(+), 2 deletions(-)
> >
> > diff --git a/target/arm/cpu-features.h b/target/arm/cpu-features.h
> > index 4e44245a8b..50776347a5 100644
> > --- a/target/arm/cpu-features.h
> > +++ b/target/arm/cpu-features.h
> > @@ -244,6 +244,15 @@ FIELD(ID_AA64ISAR2, CSSC, 52, 4)
> > FIELD(ID_AA64ISAR2, LUT, 56, 4)
> > FIELD(ID_AA64ISAR2, ATS1A, 60, 4)
> >
> > +FIELD(ID_AA64ISAR3, CPA, 0, 4)
> > +FIELD(ID_AA64ISAR3, FAMINMAX, 4, 4)
> > +FIELD(ID_AA64ISAR3, TLBIW, 8, 4)
> > +FIELD(ID_AA64ISAR3, PACM, 12, 4)
> > +FIELD(ID_AA64ISAR3, LSFE, 16, 4)
> > +FIELD(ID_AA64ISAR3, OCCMO, 20, 4)
> > +FIELD(ID_AA64ISAR3, LSUI, 24, 4)
> > +FIELD(ID_AA64ISAR3, FPRCVT, 28, 4)
> > +
> > FIELD(ID_AA64PFR0, EL0, 0, 4)
> > FIELD(ID_AA64PFR0, EL1, 4, 4)
> > FIELD(ID_AA64PFR0, EL2, 8, 4)
> > diff --git a/target/arm/helper.c b/target/arm/helper.c
> > index 8240f1b384..6ad01b345f 100644
> > --- a/target/arm/helper.c
> > +++ b/target/arm/helper.c
> > @@ -6519,11 +6519,11 @@ void register_cp_regs_for_features(ARMCPU *cpu)
> > .access = PL1_R, .type = ARM_CP_CONST,
> > .accessfn = access_tid3,
> > .resetvalue = GET_IDREG(isar, ID_AA64ISAR2)},
> > - { .name = "ID_AA64ISAR3_EL1_RESERVED", .state = ARM_CP_STATE_AA64,
> > + { .name = "ID_AA64ISAR3_EL1", .state = ARM_CP_STATE_AA64,
> > .opc0 = 3, .opc1 = 0, .crn = 0, .crm = 6, .opc2 = 3,
> > .access = PL1_R, .type = ARM_CP_CONST,
> > .accessfn = access_tid3,
> > - .resetvalue = 0 },
> > + .resetvalue = GET_IDREG(isar, ID_AA64ISAR3) },
> > { .name = "ID_AA64ISAR4_EL1_RESERVED", .state = ARM_CP_STATE_AA64,
> > .opc0 = 3, .opc1 = 0, .crn = 0, .crm = 6, .opc2 = 4,
> > .access = PL1_R, .type = ARM_CP_CONST,
> > @@ -6752,6 +6752,10 @@ void register_cp_regs_for_features(ARMCPU *cpu)
> > R_ID_AA64ISAR2_BC_MASK |
> > R_ID_AA64ISAR2_RPRFM_MASK |
> > R_ID_AA64ISAR2_CSSC_MASK },
> > + { .name = "ID_AA64ISAR3_EL1",
> > + .exported_bits = R_ID_AA64ISAR3_FAMINMAX_MASK |
> > + R_ID_AA64ISAR3_LSFE_MASK |
> > + R_ID_AA64ISAR3_FPRCVT_MASK },
>
> With this definition should we also add it to arm_clear_aarch64_idregs()
> which clears the other ISARs with aarch64=off?
Yes. I wonder if there's some way to get the new cpu-sysregs.h.inc
machinery to automatically produce code to zero any
ARMISARegisters::idregs[] element whose index is for
a register whose encoding is an AA64 idreg (which I think
means "CRm >= 4")...
-- PMM
^ permalink raw reply [flat|nested] 105+ messages in thread* Re: [PATCH v6 01/64] target/arm: Implement ID_AA64ISAR3
2026-05-21 15:22 ` Alex Bennée
2026-05-21 15:45 ` Peter Maydell
@ 2026-05-22 18:31 ` Richard Henderson
1 sibling, 0 replies; 105+ messages in thread
From: Richard Henderson @ 2026-05-22 18:31 UTC (permalink / raw)
To: Alex Bennée; +Cc: qemu-devel, qemu-arm
On 5/21/26 08:22, Alex Bennée wrote:
>> @@ -6752,6 +6752,10 @@ void register_cp_regs_for_features(ARMCPU *cpu)
>> R_ID_AA64ISAR2_BC_MASK |
>> R_ID_AA64ISAR2_RPRFM_MASK |
>> R_ID_AA64ISAR2_CSSC_MASK },
>> + { .name = "ID_AA64ISAR3_EL1",
>> + .exported_bits = R_ID_AA64ISAR3_FAMINMAX_MASK |
>> + R_ID_AA64ISAR3_LSFE_MASK |
>> + R_ID_AA64ISAR3_FPRCVT_MASK },
>
> With this definition should we also add it to arm_clear_aarch64_idregs()
> which clears the other ISARs with aarch64=off?
Fixed.
r~
^ permalink raw reply [flat|nested] 105+ messages in thread
* [PATCH v6 02/64] target/arm: Implement FEAT_FAMINMAX for AdvSIMD
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
2026-05-20 18:21 ` [PATCH v6 01/64] target/arm: Implement ID_AA64ISAR3 Richard Henderson
@ 2026-05-20 18:21 ` Richard Henderson
2026-05-21 8:25 ` Peter Maydell
2026-05-20 18:21 ` [PATCH v6 03/64] target/arm: Implement FEAT_FAMINMAX for SME Richard Henderson
` (61 subsequent siblings)
63 siblings, 1 reply; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:21 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/cpu-features.h | 5 +++++
target/arm/tcg/helper-a64-defs.h | 7 ++++++
target/arm/tcg/vec_internal.h | 7 ++++++
target/arm/tcg/translate-a64.c | 14 ++++++++++++
target/arm/tcg/vec_helper64.c | 37 ++++++++++++++++++++++++++++++++
target/arm/tcg/a64.decode | 5 +++++
6 files changed, 75 insertions(+)
diff --git a/target/arm/cpu-features.h b/target/arm/cpu-features.h
index 50776347a5..21a1f941dd 100644
--- a/target/arm/cpu-features.h
+++ b/target/arm/cpu-features.h
@@ -1062,6 +1062,11 @@ static inline bool isar_feature_aa64_ats1a(const ARMISARegisters *id)
return FIELD_EX64_IDREG(id, ID_AA64ISAR2, ATS1A);
}
+static inline bool isar_feature_aa64_faminmax(const ARMISARegisters *id)
+{
+ return FIELD_EX64_IDREG(id, ID_AA64ISAR3, FAMINMAX) != 0;
+}
+
static inline bool isar_feature_aa64_fp_simd(const ARMISARegisters *id)
{
/* We always set the AdvSIMD and FP fields identically. */
diff --git a/target/arm/tcg/helper-a64-defs.h b/target/arm/tcg/helper-a64-defs.h
index 3c3c5dddb7..215df1201b 100644
--- a/target/arm/tcg/helper-a64-defs.h
+++ b/target/arm/tcg/helper-a64-defs.h
@@ -145,6 +145,13 @@ DEF_HELPER_FLAGS_5(gvec_fmulx_idx_h, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, fpst,
DEF_HELPER_FLAGS_5(gvec_fmulx_idx_s, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, fpst, i32)
DEF_HELPER_FLAGS_5(gvec_fmulx_idx_d, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, fpst, i32)
+DEF_HELPER_FLAGS_5(gvec_famax_h, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, fpst, i32)
+DEF_HELPER_FLAGS_5(gvec_famin_h, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, fpst, i32)
+DEF_HELPER_FLAGS_5(gvec_famax_s, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, fpst, i32)
+DEF_HELPER_FLAGS_5(gvec_famin_s, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, fpst, i32)
+DEF_HELPER_FLAGS_5(gvec_famax_d, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, fpst, i32)
+DEF_HELPER_FLAGS_5(gvec_famin_d, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, fpst, i32)
+
#ifndef CONFIG_USER_ONLY
DEF_HELPER_2(exception_return, void, env, i64)
#endif
diff --git a/target/arm/tcg/vec_internal.h b/target/arm/tcg/vec_internal.h
index 4edd2b4fc1..5c3f51eed3 100644
--- a/target/arm/tcg/vec_internal.h
+++ b/target/arm/tcg/vec_internal.h
@@ -342,6 +342,13 @@ bfloat16 helper_sme2_ah_fmin_b16(bfloat16 a, bfloat16 b, float_status *fpst);
float32 sve_f16_to_f32(float16 f, float_status *fpst);
float16 sve_f32_to_f16(float32 f, float_status *fpst);
+float16 float16_famax(float16, float16, float_status *);
+float16 float16_famin(float16, float16, float_status *);
+float32 float32_famax(float32, float32, float_status *);
+float32 float32_famin(float32, float32, float_status *);
+float64 float64_famax(float64, float64, float_status *);
+float64 float64_famin(float64, float64, float_status *);
+
/*
* Decode helper functions for predicate as counter.
*/
diff --git a/target/arm/tcg/translate-a64.c b/target/arm/tcg/translate-a64.c
index 9a27c4c6ec..3c6559964b 100644
--- a/target/arm/tcg/translate-a64.c
+++ b/target/arm/tcg/translate-a64.c
@@ -6478,6 +6478,20 @@ static gen_helper_gvec_3_ptr * const f_vector_fminnmp[3] = {
};
TRANS(FMINNMP_v, do_fp3_vector, a, 0, f_vector_fminnmp)
+static gen_helper_gvec_3_ptr * const f_vector_famax[3] = {
+ gen_helper_gvec_famax_h,
+ gen_helper_gvec_famax_s,
+ gen_helper_gvec_famax_d,
+};
+TRANS_FEAT(FAMAX, aa64_faminmax, do_fp3_vector, a, 0, f_vector_famax)
+
+static gen_helper_gvec_3_ptr * const f_vector_famin[3] = {
+ gen_helper_gvec_famin_h,
+ gen_helper_gvec_famin_s,
+ gen_helper_gvec_famin_d,
+};
+TRANS_FEAT(FAMIN, aa64_faminmax, do_fp3_vector, a, 0, f_vector_famin)
+
static bool do_fmlal(DisasContext *s, arg_qrrr_e *a, bool is_s, bool is_2)
{
if (fp_access_check(s)) {
diff --git a/target/arm/tcg/vec_helper64.c b/target/arm/tcg/vec_helper64.c
index 249a257177..dce5e0505e 100644
--- a/target/arm/tcg/vec_helper64.c
+++ b/target/arm/tcg/vec_helper64.c
@@ -8,6 +8,7 @@
#include "qemu/osdep.h"
#include "cpu.h"
+#include "internals.h"
#include "helper.h"
#include "helper-a64.h"
#include "helper-sme.h"
@@ -140,3 +141,39 @@ void HELPER(simd_tblx)(void *vd, void *vm, CPUARMState *env, uint32_t desc)
memcpy(vd, &result, 16);
clear_tail(vd, oprsz, simd_maxsz(desc));
}
+
+/*
+ * Use float_minmax_ismag to get the absolute value min/max.
+ * Avoid float_minmax_is{num,number} so that we get normal NaN processing.
+ * If the result is not a nan, take the absolute value.
+ *
+ * Note this operation squashes FZ, FIZ, and AH to 0.
+ * Create a fresh status with default behaviour and propagate exceptions.
+ */
+#define DO_FAMINMAX(NAME, TYPE, MIN) \
+TYPE TYPE##_##NAME(TYPE a, TYPE b, float_status *s) \
+{ \
+ float_status local = {}; \
+ arm_set_default_fp_behaviours(&local); \
+ TYPE r = TYPE##_minmax(a, b, &local, MIN | float_minmax_ismag); \
+ if (!TYPE##_is_any_nan(r)) { \
+ r = TYPE##_abs(r); \
+ } \
+ float_raise(get_float_exception_flags(&local) \
+ & ~float_flag_input_denormal_used, s); \
+ return r; \
+}
+
+DO_FAMINMAX(famax, float16, 0)
+DO_FAMINMAX(famin, float16, float_minmax_ismin)
+DO_FAMINMAX(famax, float32, 0)
+DO_FAMINMAX(famin, float32, float_minmax_ismin)
+DO_FAMINMAX(famax, float64, 0)
+DO_FAMINMAX(famin, float64, float_minmax_ismin)
+
+DO_3OP(gvec_famax_h, float16_famax, float16)
+DO_3OP(gvec_famin_h, float16_famin, float16)
+DO_3OP(gvec_famax_s, float32_famax, float32)
+DO_3OP(gvec_famin_s, float32_famin, float32)
+DO_3OP(gvec_famax_d, float64_famax, float64)
+DO_3OP(gvec_famin_d, float64_famin, float64)
diff --git a/target/arm/tcg/a64.decode b/target/arm/tcg/a64.decode
index 01b1b3e38b..666a293540 100644
--- a/target/arm/tcg/a64.decode
+++ b/target/arm/tcg/a64.decode
@@ -1193,6 +1193,11 @@ RSUBHN 0.10 1110 ..1 ..... 01100 0 ..... ..... @qrrr_e
PMULL_p8 0.00 1110 001 ..... 11100 0 ..... ..... @qrrr_b
PMULL_p64 0.00 1110 111 ..... 11100 0 ..... ..... @qrrr_b
+FAMAX 0.00 1110 110 ..... 00011 1 ..... ..... @qrrr_h
+FAMAX 0.00 1110 1.1 ..... 11011 1 ..... ..... @qrrr_sd
+FAMIN 0.10 1110 110 ..... 00011 1 ..... ..... @qrrr_h
+FAMIN 0.10 1110 1.1 ..... 11011 1 ..... ..... @qrrr_sd
+
### Advanced SIMD scalar x indexed element
FMUL_si 0101 1111 00 .. .... 1001 . 0 ..... ..... @rrx_h
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread* Re: [PATCH v6 02/64] target/arm: Implement FEAT_FAMINMAX for AdvSIMD
2026-05-20 18:21 ` [PATCH v6 02/64] target/arm: Implement FEAT_FAMINMAX for AdvSIMD Richard Henderson
@ 2026-05-21 8:25 ` Peter Maydell
2026-05-22 18:34 ` Richard Henderson
0 siblings, 1 reply; 105+ messages in thread
From: Peter Maydell @ 2026-05-21 8:25 UTC (permalink / raw)
To: Richard Henderson; +Cc: qemu-devel, qemu-arm
On Wed, 20 May 2026 at 19:22, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> +/*
> + * Use float_minmax_ismag to get the absolute value min/max.
> + * Avoid float_minmax_is{num,number} so that we get normal NaN processing.
> + * If the result is not a nan, take the absolute value.
> + *
> + * Note this operation squashes FZ, FIZ, and AH to 0.
> + * Create a fresh status with default behaviour and propagate exceptions.
> + */
> +#define DO_FAMINMAX(NAME, TYPE, MIN) \
> +TYPE TYPE##_##NAME(TYPE a, TYPE b, float_status *s) \
> +{ \
> + float_status local = {}; \
> + arm_set_default_fp_behaviours(&local); \
This misses that we need to keep the default_nan_mode setting
from 's', otherwise we stop honouring FPCR.DN. This will fix it:
--- a/target/arm/tcg/vec_helper64.c
+++ b/target/arm/tcg/vec_helper64.c
@@ -155,6 +155,7 @@ TYPE TYPE##_##NAME(TYPE a, TYPE b, float_status
*s) \
{ \
float_status local = {}; \
arm_set_default_fp_behaviours(&local); \
+ set_default_nan_mode(get_default_nan_mode(s), &local); \
TYPE r = TYPE##_minmax(a, b, &local, MIN | float_minmax_ismag); \
if (!TYPE##_is_any_nan(r)) { \
r = TYPE##_abs(r); \
(or we could go back to copying 's' into 'local').
-- PMM
^ permalink raw reply [flat|nested] 105+ messages in thread* Re: [PATCH v6 02/64] target/arm: Implement FEAT_FAMINMAX for AdvSIMD
2026-05-21 8:25 ` Peter Maydell
@ 2026-05-22 18:34 ` Richard Henderson
0 siblings, 0 replies; 105+ messages in thread
From: Richard Henderson @ 2026-05-22 18:34 UTC (permalink / raw)
To: Peter Maydell; +Cc: qemu-devel, qemu-arm
On 5/21/26 01:25, Peter Maydell wrote:
> On Wed, 20 May 2026 at 19:22, Richard Henderson
> <richard.henderson@linaro.org> wrote:
>>
>> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
>
>> +/*
>> + * Use float_minmax_ismag to get the absolute value min/max.
>> + * Avoid float_minmax_is{num,number} so that we get normal NaN processing.
>> + * If the result is not a nan, take the absolute value.
>> + *
>> + * Note this operation squashes FZ, FIZ, and AH to 0.
>> + * Create a fresh status with default behaviour and propagate exceptions.
>> + */
>> +#define DO_FAMINMAX(NAME, TYPE, MIN) \
>> +TYPE TYPE##_##NAME(TYPE a, TYPE b, float_status *s) \
>> +{ \
>> + float_status local = {}; \
>> + arm_set_default_fp_behaviours(&local); \
>
> This misses that we need to keep the default_nan_mode setting
> from 's', otherwise we stop honouring FPCR.DN. This will fix it:
>
> --- a/target/arm/tcg/vec_helper64.c
> +++ b/target/arm/tcg/vec_helper64.c
> @@ -155,6 +155,7 @@ TYPE TYPE##_##NAME(TYPE a, TYPE b, float_status
> *s) \
> { \
> float_status local = {}; \
> arm_set_default_fp_behaviours(&local); \
> + set_default_nan_mode(get_default_nan_mode(s), &local); \
> TYPE r = TYPE##_minmax(a, b, &local, MIN | float_minmax_ismag); \
> if (!TYPE##_is_any_nan(r)) { \
> r = TYPE##_abs(r); \
>
> (or we could go back to copying 's' into 'local').
I went back to copying s into local. I should have known a blank slate was too good to be
true. :-)
r~
^ permalink raw reply [flat|nested] 105+ messages in thread
* [PATCH v6 03/64] target/arm: Implement FEAT_FAMINMAX for SME
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
2026-05-20 18:21 ` [PATCH v6 01/64] target/arm: Implement ID_AA64ISAR3 Richard Henderson
2026-05-20 18:21 ` [PATCH v6 02/64] target/arm: Implement FEAT_FAMINMAX for AdvSIMD Richard Henderson
@ 2026-05-20 18:21 ` Richard Henderson
2026-05-21 13:45 ` Peter Maydell
2026-05-20 18:21 ` [PATCH v6 04/64] target/arm: Implement FEAT_FAMINMAX for SVE Richard Henderson
` (60 subsequent siblings)
63 siblings, 1 reply; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:21 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm
Since there is no bfloat16 variant of FAMINMAX,
check for missing function pointer in do_z2z_nn_fpst.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/cpu-features.h | 5 +++++
target/arm/tcg/translate-sme.c | 23 +++++++++++++++++++++--
target/arm/tcg/sme.decode | 5 +++++
3 files changed, 31 insertions(+), 2 deletions(-)
diff --git a/target/arm/cpu-features.h b/target/arm/cpu-features.h
index 21a1f941dd..21b91b1503 100644
--- a/target/arm/cpu-features.h
+++ b/target/arm/cpu-features.h
@@ -1593,6 +1593,11 @@ static inline bool isar_feature_aa64_sme2_f64f64(const ARMISARegisters *id)
return isar_feature_aa64_sme2(id) && isar_feature_aa64_sme_f64f64(id);
}
+static inline bool isar_feature_aa64_sme2_faminmax(const ARMISARegisters *id)
+{
+ return isar_feature_aa64_sme2(id) && isar_feature_aa64_faminmax(id);
+}
+
static inline bool isar_feature_aa64_sve_i8mm(const ARMISARegisters *id)
{
return isar_feature_aa64_sve(id) && isar_feature_aa64_sme_sve_i8mm(id);
diff --git a/target/arm/tcg/translate-sme.c b/target/arm/tcg/translate-sme.c
index 08254b088e..a67501226f 100644
--- a/target/arm/tcg/translate-sme.c
+++ b/target/arm/tcg/translate-sme.c
@@ -19,6 +19,7 @@
#include "qemu/osdep.h"
#include "cpu.h"
+#include "helper-a64.h"
#include "helper-sme.h"
#include "helper-sve.h"
#include "translate.h"
@@ -742,9 +743,12 @@ static bool do_z2z_nn_fpst(DisasContext *s, arg_z2z_en *a,
gen_helper_gvec_3_ptr * const fns[4])
{
int esz = a->esz, n, dn, dm, vsz;
- gen_helper_gvec_3_ptr *fn;
+ gen_helper_gvec_3_ptr *fn = fns[esz];
TCGv_ptr fpst;
+ if (fn == NULL) {
+ return false;
+ }
if (esz == MO_8 && !dc_isar_feature(aa64_sme_b16b16, s)) {
return false;
}
@@ -753,7 +757,6 @@ static bool do_z2z_nn_fpst(DisasContext *s, arg_z2z_en *a,
}
fpst = fpstatus_ptr(esz == MO_16 ? FPST_A64_F16 : FPST_A64);
- fn = fns[esz];
n = a->n;
dn = a->zdn;
dm = a->zm;
@@ -812,6 +815,22 @@ static gen_helper_gvec_3_ptr * const f_vector_fminnm[4] = {
TRANS_FEAT(FMINNM_n1, aa64_sme2, do_z2z_n1_fpst, a, f_vector_fminnm)
TRANS_FEAT(FMINNM_nn, aa64_sme2, do_z2z_nn_fpst, a, f_vector_fminnm)
+static gen_helper_gvec_3_ptr * const f_vector_famax[4] = {
+ NULL,
+ gen_helper_gvec_famax_h,
+ gen_helper_gvec_famax_s,
+ gen_helper_gvec_famax_d,
+};
+TRANS_FEAT(FAMAX_nn, aa64_sme2_faminmax, do_z2z_nn_fpst, a, f_vector_famax)
+
+static gen_helper_gvec_3_ptr * const f_vector_famin[4] = {
+ NULL,
+ gen_helper_gvec_famin_h,
+ gen_helper_gvec_famin_s,
+ gen_helper_gvec_famin_d,
+};
+TRANS_FEAT(FAMIN_nn, aa64_sme2_faminmax, do_z2z_nn_fpst, a, f_vector_famin)
+
/* Add/Sub vector Z[m] to each Z[n*N] with result in ZA[d*N]. */
static bool do_azz_n1(DisasContext *s, arg_azz_n *a, int esz,
GVecGen3FnVar *fn)
diff --git a/target/arm/tcg/sme.decode b/target/arm/tcg/sme.decode
index 6bb9aa2a90..9dec7318a4 100644
--- a/target/arm/tcg/sme.decode
+++ b/target/arm/tcg/sme.decode
@@ -286,6 +286,11 @@ URSHL_nn 1100000 1 .. 1 ..... 1011.0 10001 .... 1 @z2z_4x4
SQDMULH_nn 1100000 1 .. 1 ..... 1011.1 00000 .... 0 @z2z_2x2
SQDMULH_nn 1100000 1 .. 1 ..... 1011.1 00000 .... 0 @z2z_4x4
+FAMAX_nn 1100000 1 .. 1 ..... 1011.0 01010 .... 0 @z2z_2x2
+FAMAX_nn 1100000 1 .. 1 ..... 1011.0 01010 .... 0 @z2z_4x4
+FAMIN_nn 1100000 1 .. 1 ..... 1011.0 01010 .... 1 @z2z_2x2
+FAMIN_nn 1100000 1 .. 1 ..... 1011.0 01010 .... 1 @z2z_4x4
+
### SME2 Multi-vector Multiple and Single Array Vectors
&azz_n n off rv zn zm
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread* [PATCH v6 04/64] target/arm: Implement FEAT_FAMINMAX for SVE
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
` (2 preceding siblings ...)
2026-05-20 18:21 ` [PATCH v6 03/64] target/arm: Implement FEAT_FAMINMAX for SME Richard Henderson
@ 2026-05-20 18:21 ` Richard Henderson
2026-05-21 13:56 ` Peter Maydell
2026-05-20 18:21 ` [PATCH v6 05/64] target/arm: Enable FEAT_FAMINMAX for -cpu max Richard Henderson
` (59 subsequent siblings)
63 siblings, 1 reply; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:21 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/cpu-features.h | 11 +++++++++++
target/arm/tcg/helper-sve-defs.h | 14 ++++++++++++++
target/arm/tcg/sve_helper.c | 8 ++++++++
target/arm/tcg/translate-sve.c | 2 ++
target/arm/tcg/sve.decode | 2 ++
5 files changed, 37 insertions(+)
diff --git a/target/arm/cpu-features.h b/target/arm/cpu-features.h
index 21b91b1503..a7ab7e2a31 100644
--- a/target/arm/cpu-features.h
+++ b/target/arm/cpu-features.h
@@ -1568,6 +1568,11 @@ static inline bool isar_feature_aa64_sme_or_sve2(const ARMISARegisters *id)
return isar_feature_aa64_sme(id) || isar_feature_aa64_sve2(id);
}
+static inline bool isar_feature_aa64_sme2_or_sve2(const ARMISARegisters *id)
+{
+ return isar_feature_aa64_sme2(id) || isar_feature_aa64_sve2(id);
+}
+
static inline bool isar_feature_aa64_sme_or_sve2p1(const ARMISARegisters *id)
{
return isar_feature_aa64_sme(id) || isar_feature_aa64_sve2p1(id);
@@ -1608,6 +1613,12 @@ static inline bool isar_feature_aa64_sve_bf16(const ARMISARegisters *id)
return isar_feature_aa64_sve(id) && isar_feature_aa64_sme_sve_bf16(id);
}
+static inline bool
+isar_feature_aa64_sme2_or_sve2_faminmax(const ARMISARegisters *id)
+{
+ return isar_feature_aa64_sme2_or_sve2(id) && isar_feature_aa64_faminmax(id);
+}
+
/*
* Feature tests for "does this exist in either 32-bit or 64-bit?"
*/
diff --git a/target/arm/tcg/helper-sve-defs.h b/target/arm/tcg/helper-sve-defs.h
index c3541a8ca8..1eebb64a29 100644
--- a/target/arm/tcg/helper-sve-defs.h
+++ b/target/arm/tcg/helper-sve-defs.h
@@ -3166,3 +3166,17 @@ DEF_HELPER_FLAGS_5(sve2p1_st1ss_le_c, TCG_CALL_NO_WG, void, env, ptr, tl, i32, i
DEF_HELPER_FLAGS_5(sve2p1_st1ss_be_c, TCG_CALL_NO_WG, void, env, ptr, tl, i32, i64)
DEF_HELPER_FLAGS_5(sve2p1_st1dd_le_c, TCG_CALL_NO_WG, void, env, ptr, tl, i32, i64)
DEF_HELPER_FLAGS_5(sve2p1_st1dd_be_c, TCG_CALL_NO_WG, void, env, ptr, tl, i32, i64)
+
+DEF_HELPER_FLAGS_6(sve2_famax_h, TCG_CALL_NO_RWG,
+ void, ptr, ptr, ptr, ptr, fpst, i32)
+DEF_HELPER_FLAGS_6(sve2_famax_s, TCG_CALL_NO_RWG,
+ void, ptr, ptr, ptr, ptr, fpst, i32)
+DEF_HELPER_FLAGS_6(sve2_famax_d, TCG_CALL_NO_RWG,
+ void, ptr, ptr, ptr, ptr, fpst, i32)
+
+DEF_HELPER_FLAGS_6(sve2_famin_h, TCG_CALL_NO_RWG,
+ void, ptr, ptr, ptr, ptr, fpst, i32)
+DEF_HELPER_FLAGS_6(sve2_famin_s, TCG_CALL_NO_RWG,
+ void, ptr, ptr, ptr, ptr, fpst, i32)
+DEF_HELPER_FLAGS_6(sve2_famin_d, TCG_CALL_NO_RWG,
+ void, ptr, ptr, ptr, ptr, fpst, i32)
diff --git a/target/arm/tcg/sve_helper.c b/target/arm/tcg/sve_helper.c
index 062d8881bd..9968600f75 100644
--- a/target/arm/tcg/sve_helper.c
+++ b/target/arm/tcg/sve_helper.c
@@ -4742,6 +4742,14 @@ DO_ZPZZ_FP(sve_fmulx_h, uint16_t, H1_2, helper_advsimd_mulxh)
DO_ZPZZ_FP(sve_fmulx_s, uint32_t, H1_4, helper_vfp_mulxs)
DO_ZPZZ_FP(sve_fmulx_d, uint64_t, H1_8, helper_vfp_mulxd)
+DO_ZPZZ_FP(sve2_famax_h, uint16_t, H1_2, float16_famax)
+DO_ZPZZ_FP(sve2_famax_s, uint32_t, H1_4, float32_famax)
+DO_ZPZZ_FP(sve2_famax_d, uint64_t, H1_8, float64_famax)
+
+DO_ZPZZ_FP(sve2_famin_h, uint16_t, H1_2, float16_famin)
+DO_ZPZZ_FP(sve2_famin_s, uint32_t, H1_4, float32_famin)
+DO_ZPZZ_FP(sve2_famin_d, uint64_t, H1_8, float64_famin)
+
#undef DO_ZPZZ_FP
/* Three-operand expander, with one scalar operand, controlled by
diff --git a/target/arm/tcg/translate-sve.c b/target/arm/tcg/translate-sve.c
index aa7d72a35e..db32230595 100644
--- a/target/arm/tcg/translate-sve.c
+++ b/target/arm/tcg/translate-sve.c
@@ -4253,6 +4253,8 @@ DO_ZPZZ_AH_FP(FABD, aa64_sme_or_sve, sve_fabd, sve_ah_fabd)
DO_ZPZZ_FP(FSCALE, aa64_sme_or_sve, sve_fscalbn)
DO_ZPZZ_FP(FDIV, aa64_sme_or_sve, sve_fdiv)
DO_ZPZZ_FP(FMULX, aa64_sme_or_sve, sve_fmulx)
+DO_ZPZZ_FP(FAMAX, aa64_sme2_or_sve2_faminmax, sve2_famax)
+DO_ZPZZ_FP(FAMIN, aa64_sme2_or_sve2_faminmax, sve2_famin)
typedef void gen_helper_sve_fp2scalar(TCGv_ptr, TCGv_ptr, TCGv_ptr,
TCGv_i64, TCGv_ptr, TCGv_i32);
diff --git a/target/arm/tcg/sve.decode b/target/arm/tcg/sve.decode
index ab63cfaa0f..078a085a79 100644
--- a/target/arm/tcg/sve.decode
+++ b/target/arm/tcg/sve.decode
@@ -1130,6 +1130,8 @@ FSCALE 01100101 .. 00 1001 100 ... ..... ..... @rdn_pg_rm
FMULX 01100101 .. 00 1010 100 ... ..... ..... @rdn_pg_rm
FDIV 01100101 .. 00 1100 100 ... ..... ..... @rdm_pg_rn # FDIVR
FDIV 01100101 .. 00 1101 100 ... ..... ..... @rdn_pg_rm
+FAMAX 01100101 .. 00 1110 100 ... ..... ..... @rdn_pg_rm
+FAMIN 01100101 .. 00 1111 100 ... ..... ..... @rdn_pg_rm
# SVE floating-point arithmetic with immediate (predicated)
FADD_zpzi 01100101 .. 011 000 100 ... 0000 . ..... @rdn_i1
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread* Re: [PATCH v6 04/64] target/arm: Implement FEAT_FAMINMAX for SVE
2026-05-20 18:21 ` [PATCH v6 04/64] target/arm: Implement FEAT_FAMINMAX for SVE Richard Henderson
@ 2026-05-21 13:56 ` Peter Maydell
2026-05-22 18:54 ` Richard Henderson
0 siblings, 1 reply; 105+ messages in thread
From: Peter Maydell @ 2026-05-21 13:56 UTC (permalink / raw)
To: Richard Henderson; +Cc: qemu-devel, qemu-arm
On Wed, 20 May 2026 at 19:25, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> diff --git a/target/arm/tcg/translate-sve.c b/target/arm/tcg/translate-sve.c
> index aa7d72a35e..db32230595 100644
> --- a/target/arm/tcg/translate-sve.c
> +++ b/target/arm/tcg/translate-sve.c
> @@ -4253,6 +4253,8 @@ DO_ZPZZ_AH_FP(FABD, aa64_sme_or_sve, sve_fabd, sve_ah_fabd)
> DO_ZPZZ_FP(FSCALE, aa64_sme_or_sve, sve_fscalbn)
> DO_ZPZZ_FP(FDIV, aa64_sme_or_sve, sve_fdiv)
> DO_ZPZZ_FP(FMULX, aa64_sme_or_sve, sve_fmulx)
> +DO_ZPZZ_FP(FAMAX, aa64_sme2_or_sve2_faminmax, sve2_famax)
> +DO_ZPZZ_FP(FAMIN, aa64_sme2_or_sve2_faminmax, sve2_famin)
Does this get the "OK in streaming-SVE mode only if SME2" check
if IsFeatureImplemented(FEAT_SME2) then CheckSVEEnabled(); else
CheckNonStreamingSVEEnabled(); end;
right? I have lost track of how we do the streaming checks...
thanks
-- PMM
^ permalink raw reply [flat|nested] 105+ messages in thread
* Re: [PATCH v6 04/64] target/arm: Implement FEAT_FAMINMAX for SVE
2026-05-21 13:56 ` Peter Maydell
@ 2026-05-22 18:54 ` Richard Henderson
0 siblings, 0 replies; 105+ messages in thread
From: Richard Henderson @ 2026-05-22 18:54 UTC (permalink / raw)
To: Peter Maydell; +Cc: qemu-devel, qemu-arm
On 5/21/26 06:56, Peter Maydell wrote:
> On Wed, 20 May 2026 at 19:25, Richard Henderson
> <richard.henderson@linaro.org> wrote:
>>
>> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
>
>> diff --git a/target/arm/tcg/translate-sve.c b/target/arm/tcg/translate-sve.c
>> index aa7d72a35e..db32230595 100644
>> --- a/target/arm/tcg/translate-sve.c
>> +++ b/target/arm/tcg/translate-sve.c
>> @@ -4253,6 +4253,8 @@ DO_ZPZZ_AH_FP(FABD, aa64_sme_or_sve, sve_fabd, sve_ah_fabd)
>> DO_ZPZZ_FP(FSCALE, aa64_sme_or_sve, sve_fscalbn)
>> DO_ZPZZ_FP(FDIV, aa64_sme_or_sve, sve_fdiv)
>> DO_ZPZZ_FP(FMULX, aa64_sme_or_sve, sve_fmulx)
>> +DO_ZPZZ_FP(FAMAX, aa64_sme2_or_sve2_faminmax, sve2_famax)
>> +DO_ZPZZ_FP(FAMIN, aa64_sme2_or_sve2_faminmax, sve2_famin)
>
> Does this get the "OK in streaming-SVE mode only if SME2" check
> if IsFeatureImplemented(FEAT_SME2) then CheckSVEEnabled(); else
> CheckNonStreamingSVEEnabled(); end;
> right? I have lost track of how we do the streaming checks...
I missed that for these.
I added TRANS_FEAT_STREAMING_SME2() handle it.
r~
^ permalink raw reply [flat|nested] 105+ messages in thread
* [PATCH v6 05/64] target/arm: Enable FEAT_FAMINMAX for -cpu max
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
` (3 preceding siblings ...)
2026-05-20 18:21 ` [PATCH v6 04/64] target/arm: Implement FEAT_FAMINMAX for SVE Richard Henderson
@ 2026-05-20 18:21 ` Richard Henderson
2026-05-21 13:57 ` Peter Maydell
2026-05-20 18:21 ` [PATCH v6 06/64] target/arm: Update SCR bits for Arm ARM M.a.a Richard Henderson
` (58 subsequent siblings)
63 siblings, 1 reply; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:21 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/tcg/cpu64.c | 4 ++++
docs/system/arm/emulation.rst | 1 +
2 files changed, 5 insertions(+)
diff --git a/target/arm/tcg/cpu64.c b/target/arm/tcg/cpu64.c
index 649d854a65..ff0c2b1c47 100644
--- a/target/arm/tcg/cpu64.c
+++ b/target/arm/tcg/cpu64.c
@@ -1266,6 +1266,10 @@ void aarch64_max_tcg_initfn(Object *obj)
t = FIELD_DP64(t, ID_AA64ISAR2, ATS1A, 1); /* FEAT_ATS1A */
SET_IDREG(isar, ID_AA64ISAR2, t);
+ t = GET_IDREG(isar, ID_AA64ISAR3);
+ t = FIELD_DP64(t, ID_AA64ISAR3, FAMINMAX, 1); /* FEAT_FAMINMAX */
+ SET_IDREG(isar, ID_AA64ISAR3, t);
+
t = GET_IDREG(isar, ID_AA64PFR0);
t = FIELD_DP64(t, ID_AA64PFR0, FP, 1); /* FEAT_FP16 */
t = FIELD_DP64(t, ID_AA64PFR0, ADVSIMD, 1); /* FEAT_FP16 */
diff --git a/docs/system/arm/emulation.rst b/docs/system/arm/emulation.rst
index 8cd7fe7b00..da5f7efce2 100644
--- a/docs/system/arm/emulation.rst
+++ b/docs/system/arm/emulation.rst
@@ -68,6 +68,7 @@ the following architecture extensions:
- FEAT_EVT (Enhanced Virtualization Traps)
- FEAT_F32MM (Single-precision Matrix Multiplication)
- FEAT_F64MM (Double-precision Matrix Multiplication)
+- FEAT_FAMINMAX (Floating-point maximum and minimum absolute value instructions)
- FEAT_FCMA (Floating-point complex number instructions)
- FEAT_FGT (Fine-Grained Traps)
- FEAT_FHM (Floating-point half-precision multiplication instructions)
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread* [PATCH v6 06/64] target/arm: Update SCR bits for Arm ARM M.a.a
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
` (4 preceding siblings ...)
2026-05-20 18:21 ` [PATCH v6 05/64] target/arm: Enable FEAT_FAMINMAX for -cpu max Richard Henderson
@ 2026-05-20 18:21 ` Richard Henderson
2026-05-21 14:03 ` Peter Maydell
2026-05-20 18:21 ` [PATCH v6 07/64] target/arm: Update HCRX " Richard Henderson
` (57 subsequent siblings)
63 siblings, 1 reply; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:21 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/cpu.h | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/target/arm/cpu.h b/target/arm/cpu.h
index 15a13b9292..0a11dd9002 100644
--- a/target/arm/cpu.h
+++ b/target/arm/cpu.h
@@ -1820,6 +1820,17 @@ static inline void xpsr_write(CPUARMState *env, uint32_t val, uint32_t mask)
#define SCR_AIEN (1ULL << 46)
#define SCR_GPF (1ULL << 48)
#define SCR_MECEN (1ULL << 49)
+#define SCR_ENFPM (1ULL << 50)
+#define SCR_TMEA (1ULL << 51)
+#define SCR_TWERR (1ULL << 52)
+#define SCR_PFAREN (1ULL << 53)
+#define SCR_SRMASKEN (1ULL << 54)
+#define SCR_ENIDCP128 (1ULL << 55)
+#define SCR_DSE (1ULL << 57)
+#define SCR_ENDSE (1ULL << 58)
+#define SCR_FGTEN2 (1ULL << 59)
+#define SCR_HDBSSEN (1ULL << 60)
+#define SCR_HACEBSEN (1ULL << 61)
#define SCR_NSE (1ULL << 62)
/* GCSCR_ELx fields */
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread* Re: [PATCH v6 06/64] target/arm: Update SCR bits for Arm ARM M.a.a
2026-05-20 18:21 ` [PATCH v6 06/64] target/arm: Update SCR bits for Arm ARM M.a.a Richard Henderson
@ 2026-05-21 14:03 ` Peter Maydell
0 siblings, 0 replies; 105+ messages in thread
From: Peter Maydell @ 2026-05-21 14:03 UTC (permalink / raw)
To: Richard Henderson; +Cc: qemu-devel, qemu-arm
On Wed, 20 May 2026 at 19:22, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/arm/cpu.h | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/target/arm/cpu.h b/target/arm/cpu.h
> index 15a13b9292..0a11dd9002 100644
> --- a/target/arm/cpu.h
> +++ b/target/arm/cpu.h
> @@ -1820,6 +1820,17 @@ static inline void xpsr_write(CPUARMState *env, uint32_t val, uint32_t mask)
> #define SCR_AIEN (1ULL << 46)
> #define SCR_GPF (1ULL << 48)
> #define SCR_MECEN (1ULL << 49)
> +#define SCR_ENFPM (1ULL << 50)
> +#define SCR_TMEA (1ULL << 51)
> +#define SCR_TWERR (1ULL << 52)
> +#define SCR_PFAREN (1ULL << 53)
> +#define SCR_SRMASKEN (1ULL << 54)
> +#define SCR_ENIDCP128 (1ULL << 55)
> +#define SCR_DSE (1ULL << 57)
> +#define SCR_ENDSE (1ULL << 58)
> +#define SCR_FGTEN2 (1ULL << 59)
> +#define SCR_HDBSSEN (1ULL << 60)
> +#define SCR_HACEBSEN (1ULL << 61)
Typo: should be HACDBSEN.
(Hardware Accelerator for Cleaning Dirty ??Bit?? State ENable.
The Arm ARM doesn't say what the "B" is for but it's in the
FEAT_HACDBS feature name and all the register names. "Bit"
is my guess.)
> #define SCR_NSE (1ULL << 62)
>
> /* GCSCR_ELx fields */
> --
> 2.43.0
Otherwise
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
^ permalink raw reply [flat|nested] 105+ messages in thread
* [PATCH v6 07/64] target/arm: Update HCRX bits for Arm ARM M.a.a
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
` (5 preceding siblings ...)
2026-05-20 18:21 ` [PATCH v6 06/64] target/arm: Update SCR bits for Arm ARM M.a.a Richard Henderson
@ 2026-05-20 18:21 ` Richard Henderson
2026-05-21 14:05 ` Peter Maydell
2026-05-20 18:21 ` [PATCH v6 08/64] target/arm: Introduce FPMR Richard Henderson
` (56 subsequent siblings)
63 siblings, 1 reply; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:21 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/internals.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/target/arm/internals.h b/target/arm/internals.h
index 00830b1724..f02d3c6a71 100644
--- a/target/arm/internals.h
+++ b/target/arm/internals.h
@@ -258,7 +258,9 @@ FIELD(VSTCR, SA, 30, 1)
#define HCRX_TCR2EN (1ULL << 14)
#define HCRX_SCTLR2EN (1ULL << 15)
#define HCRX_GCSEN (1ULL << 22)
-
+#define HCRX_ENFPM (1ULL << 23)
+#define HCRX_PACMEN (1ULL << 24)
+#define HCRX_SRMASKEN (1ULL << 26)
#define HPFAR_NS (1ULL << 63)
#define HSTR_TTEE (1 << 16)
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread* Re: [PATCH v6 07/64] target/arm: Update HCRX bits for Arm ARM M.a.a
2026-05-20 18:21 ` [PATCH v6 07/64] target/arm: Update HCRX " Richard Henderson
@ 2026-05-21 14:05 ` Peter Maydell
0 siblings, 0 replies; 105+ messages in thread
From: Peter Maydell @ 2026-05-21 14:05 UTC (permalink / raw)
To: Richard Henderson; +Cc: qemu-devel, qemu-arm
On Wed, 20 May 2026 at 19:26, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/arm/internals.h | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/target/arm/internals.h b/target/arm/internals.h
> index 00830b1724..f02d3c6a71 100644
> --- a/target/arm/internals.h
> +++ b/target/arm/internals.h
> @@ -258,7 +258,9 @@ FIELD(VSTCR, SA, 30, 1)
> #define HCRX_TCR2EN (1ULL << 14)
> #define HCRX_SCTLR2EN (1ULL << 15)
> #define HCRX_GCSEN (1ULL << 22)
> -
> +#define HCRX_ENFPM (1ULL << 23)
> +#define HCRX_PACMEN (1ULL << 24)
> +#define HCRX_SRMASKEN (1ULL << 26)
> #define HPFAR_NS (1ULL << 63)
We should keep the blank line separating the HCRX bit
definitions from HPFAR_NS. Otherwise
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
^ permalink raw reply [flat|nested] 105+ messages in thread
* [PATCH v6 08/64] target/arm: Introduce FPMR
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
` (6 preceding siblings ...)
2026-05-20 18:21 ` [PATCH v6 07/64] target/arm: Update HCRX " Richard Henderson
@ 2026-05-20 18:21 ` Richard Henderson
2026-05-21 14:12 ` Peter Maydell
2026-05-20 18:21 ` [PATCH v6 09/64] target/arm: Update SCTLR bits for FEAT_FPMR Richard Henderson
` (55 subsequent siblings)
63 siblings, 1 reply; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:21 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm
Introduce the special register FPMR and its fields.
Migrate it when present.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/cpregs.h | 5 +++++
target/arm/cpu-features.h | 5 +++++
target/arm/cpu.h | 1 +
target/arm/internals.h | 10 ++++++++++
target/arm/helper.c | 12 +++++++++++-
target/arm/machine.c | 20 ++++++++++++++++++++
6 files changed, 52 insertions(+), 1 deletion(-)
diff --git a/target/arm/cpregs.h b/target/arm/cpregs.h
index f5ec7484c1..391c0e322b 100644
--- a/target/arm/cpregs.h
+++ b/target/arm/cpregs.h
@@ -149,6 +149,11 @@ enum {
* should not trap to EL2 when HCR_EL2.NV is set.
*/
ARM_CP_NV_NO_TRAP = 1 << 22,
+ /*
+ * Flag: Access check for this sysreg is constrained by the
+ * ARM pseudocode function CheckFPMREnabled().
+ */
+ ARM_CP_FPMR = 1 << 23,
};
/*
diff --git a/target/arm/cpu-features.h b/target/arm/cpu-features.h
index a7ab7e2a31..e13c1c1331 100644
--- a/target/arm/cpu-features.h
+++ b/target/arm/cpu-features.h
@@ -1192,6 +1192,11 @@ static inline bool isar_feature_aa64_gcie(const ARMISARegisters *id)
return FIELD_EX64_IDREG(id, ID_AA64PFR2, GCIE) != 0;
}
+static inline bool isar_feature_aa64_fpmr(const ARMISARegisters *id)
+{
+ return FIELD_EX64_IDREG(id, ID_AA64PFR2, FPMR) != 0;
+}
+
static inline bool isar_feature_aa64_tgran4_lpa2(const ARMISARegisters *id)
{
return FIELD_SEX64_IDREG(id, ID_AA64MMFR0, TGRAN4) >= 1;
diff --git a/target/arm/cpu.h b/target/arm/cpu.h
index 0a11dd9002..498af7db08 100644
--- a/target/arm/cpu.h
+++ b/target/arm/cpu.h
@@ -713,6 +713,7 @@ typedef struct CPUArchState {
*/
uint64_t fpsr;
uint64_t fpcr;
+ uint64_t fpmr;
uint32_t xregs[16];
diff --git a/target/arm/internals.h b/target/arm/internals.h
index f02d3c6a71..b6efc4433d 100644
--- a/target/arm/internals.h
+++ b/target/arm/internals.h
@@ -292,6 +292,16 @@ FIELD(CNTHCTL, EVNTIS, 17, 1)
FIELD(CNTHCTL, CNTVMASK, 18, 1)
FIELD(CNTHCTL, CNTPMASK, 19, 1)
+FIELD(FPMR, F8S1, 0, 3)
+FIELD(FPMR, F8S2, 3, 3)
+FIELD(FPMR, F8D, 6, 3)
+FIELD(FPMR, OSM, 14, 1)
+FIELD(FPMR, OSC, 15, 1)
+FIELD(FPMR, LSCALE, 16, 7)
+FIELD(FPMR, NSCALE, 24, 8)
+FIELD(FPMR, NSCALE_F16, 24, 5)
+FIELD(FPMR, LSCALE2, 32, 6)
+
/* We use a few fake FSR values for internal purposes in M profile.
* M profile cores don't have A/R format FSRs, but currently our
* get_phys_addr() code assumes A/R profile and reports failures via
diff --git a/target/arm/helper.c b/target/arm/helper.c
index 6ad01b345f..ae1dd42dc4 100644
--- a/target/arm/helper.c
+++ b/target/arm/helper.c
@@ -6229,6 +6229,14 @@ static const ARMCPRegInfo aie_reginfo[] = {
.type = ARM_CP_CONST, .resetvalue = 0 },
};
+static const ARMCPRegInfo fpmr_reginfo[] = {
+ { .name = "FPMR", .state = ARM_CP_STATE_AA64,
+ .opc0 = 3, .opc1 = 3, .crn = 4, .crm = 4, .opc2 = 2,
+ .access = PL0_RW, .type = ARM_CP_FPU | ARM_CP_FPMR,
+ .fieldoffset = offsetof(CPUARMState, vfp.fpmr),
+ }
+};
+
void register_cp_regs_for_features(ARMCPU *cpu)
{
/* Register all the coprocessor registers based on feature bits */
@@ -7502,10 +7510,12 @@ void register_cp_regs_for_features(ARMCPU *cpu)
define_arm_cp_regs(cpu, mec_mte_reginfo);
}
}
-
if (cpu_isar_feature(aa64_aie, cpu)) {
define_arm_cp_regs(cpu, aie_reginfo);
}
+ if (cpu_isar_feature(aa64_fpmr, cpu)) {
+ define_arm_cp_regs(cpu, fpmr_reginfo);
+ }
if (cpu_isar_feature(any_predinv, cpu)) {
define_arm_cp_regs(cpu, predinv_reginfo);
diff --git a/target/arm/machine.c b/target/arm/machine.c
index 8dc766d322..58f8dfd53c 100644
--- a/target/arm/machine.c
+++ b/target/arm/machine.c
@@ -960,6 +960,25 @@ static const VMStateDescription vmstate_syndrome64 = {
},
};
+static bool fpmr_needed(void *opaque)
+{
+ ARMCPU *cpu = opaque;
+
+ return arm_feature(&cpu->env, ARM_FEATURE_AARCH64)
+ && cpu_isar_feature(aa64_fpmr, cpu);
+}
+
+static const VMStateDescription vmstate_fpmr = {
+ .name = "cpu/fpmr",
+ .version_id = 1,
+ .minimum_version_id = 1,
+ .needed = fpmr_needed,
+ .fields = (const VMStateField[]) {
+ VMSTATE_UINT64(env.vfp.fpmr, ARMCPU),
+ VMSTATE_END_OF_LIST()
+ },
+};
+
static int cpu_pre_save(void *opaque)
{
ARMCPU *cpu = opaque;
@@ -1323,6 +1342,7 @@ const VMStateDescription vmstate_arm_cpu = {
&vmstate_syndrome64,
&vmstate_pstate64,
&vmstate_event,
+ &vmstate_fpmr,
NULL
}
};
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread* [PATCH v6 09/64] target/arm: Update SCTLR bits for FEAT_FPMR
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
` (7 preceding siblings ...)
2026-05-20 18:21 ` [PATCH v6 08/64] target/arm: Introduce FPMR Richard Henderson
@ 2026-05-20 18:21 ` Richard Henderson
2026-05-21 14:11 ` Peter Maydell
2026-05-20 18:21 ` [PATCH v6 10/64] target/arm: Enable EnFPM " Richard Henderson
` (54 subsequent siblings)
63 siblings, 1 reply; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:21 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/cpu.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/target/arm/cpu.h b/target/arm/cpu.h
index 498af7db08..c114510446 100644
--- a/target/arm/cpu.h
+++ b/target/arm/cpu.h
@@ -1485,6 +1485,7 @@ void pmu_init(ARMCPU *cpu);
#define SCTLR_DSSBS_32 (1U << 31) /* v8.5, AArch32 only */
#define SCTLR_CMOW (1ULL << 32) /* FEAT_CMOW */
#define SCTLR_MSCEN (1ULL << 33) /* FEAT_MOPS */
+#define SCTLR_EnFPM (1ULL << 34) /* FEAT_FPMR */
#define SCTLR_BT0 (1ULL << 35) /* v8.5-BTI */
#define SCTLR_BT1 (1ULL << 36) /* v8.5-BTI */
#define SCTLR_ITFSB (1ULL << 37) /* v8.5-MemTag */
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread* [PATCH v6 10/64] target/arm: Enable EnFPM bits for FEAT_FPMR
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
` (8 preceding siblings ...)
2026-05-20 18:21 ` [PATCH v6 09/64] target/arm: Update SCTLR bits for FEAT_FPMR Richard Henderson
@ 2026-05-20 18:21 ` Richard Henderson
2026-05-21 14:15 ` Peter Maydell
2026-05-20 18:21 ` [PATCH v6 11/64] target/arm: Clear FPMR on ResetSVEState Richard Henderson
` (53 subsequent siblings)
63 siblings, 1 reply; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:21 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/helper.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/target/arm/helper.c b/target/arm/helper.c
index ae1dd42dc4..7eb7031294 100644
--- a/target/arm/helper.c
+++ b/target/arm/helper.c
@@ -787,6 +787,9 @@ static void scr_write(CPUARMState *env, const ARMCPRegInfo *ri, uint64_t value)
if (cpu_isar_feature(aa64_mec, cpu)) {
valid_mask |= SCR_MECEN;
}
+ if (cpu_isar_feature(aa64_fpmr, cpu)) {
+ valid_mask |= SCR_ENFPM;
+ }
} else {
valid_mask &= ~(SCR_RW | SCR_ST);
if (cpu_isar_feature(aa32_ras, cpu)) {
@@ -3973,6 +3976,9 @@ static void hcrx_write(CPUARMState *env, const ARMCPRegInfo *ri,
if (cpu_isar_feature(aa64_gcs, cpu)) {
valid_mask |= HCRX_GCSEN;
}
+ if (cpu_isar_feature(aa64_fpmr, cpu)) {
+ valid_mask |= HCRX_ENFPM;
+ }
/* Clear RES0 bits. */
env->cp15.hcrx_el2 = value & valid_mask;
@@ -4046,6 +4052,9 @@ uint64_t arm_hcrx_el2_eff(CPUARMState *env)
if (cpu_isar_feature(aa64_gcs, cpu)) {
hcrx |= HCRX_GCSEN;
}
+ if (cpu_isar_feature(aa64_fpmr, cpu)) {
+ hcrx |= HCRX_ENFPM;
+ }
return hcrx;
}
if (arm_feature(env, ARM_FEATURE_EL3) && !(env->cp15.scr_el3 & SCR_HXEN)) {
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread* Re: [PATCH v6 10/64] target/arm: Enable EnFPM bits for FEAT_FPMR
2026-05-20 18:21 ` [PATCH v6 10/64] target/arm: Enable EnFPM " Richard Henderson
@ 2026-05-21 14:15 ` Peter Maydell
2026-05-22 19:01 ` Richard Henderson
0 siblings, 1 reply; 105+ messages in thread
From: Peter Maydell @ 2026-05-21 14:15 UTC (permalink / raw)
To: Richard Henderson; +Cc: qemu-devel, qemu-arm
On Wed, 20 May 2026 at 19:24, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/arm/helper.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/target/arm/helper.c b/target/arm/helper.c
> index ae1dd42dc4..7eb7031294 100644
> --- a/target/arm/helper.c
> +++ b/target/arm/helper.c
> @@ -787,6 +787,9 @@ static void scr_write(CPUARMState *env, const ARMCPRegInfo *ri, uint64_t value)
> if (cpu_isar_feature(aa64_mec, cpu)) {
> valid_mask |= SCR_MECEN;
> }
> + if (cpu_isar_feature(aa64_fpmr, cpu)) {
> + valid_mask |= SCR_ENFPM;
> + }
> } else {
> valid_mask &= ~(SCR_RW | SCR_ST);
> if (cpu_isar_feature(aa32_ras, cpu)) {
> @@ -3973,6 +3976,9 @@ static void hcrx_write(CPUARMState *env, const ARMCPRegInfo *ri,
> if (cpu_isar_feature(aa64_gcs, cpu)) {
> valid_mask |= HCRX_GCSEN;
> }
> + if (cpu_isar_feature(aa64_fpmr, cpu)) {
> + valid_mask |= HCRX_ENFPM;
> + }
>
> /* Clear RES0 bits. */
> env->cp15.hcrx_el2 = value & valid_mask;
> @@ -4046,6 +4052,9 @@ uint64_t arm_hcrx_el2_eff(CPUARMState *env)
> if (cpu_isar_feature(aa64_gcs, cpu)) {
> hcrx |= HCRX_GCSEN;
> }
> + if (cpu_isar_feature(aa64_fpmr, cpu)) {
> + hcrx |= HCRX_ENFPM;
> + }
> return hcrx;
> }
> if (arm_feature(env, ARM_FEATURE_EL3) && !(env->cp15.scr_el3 & SCR_HXEN)) {
> --
> 2.43.0
I think we also need arm_emulate_firmware_reset() to
set SCR_ENFPM, so we get the "emulating EL3 but starting
guest at EL2" case right.
Otherwise
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
^ permalink raw reply [flat|nested] 105+ messages in thread
* [PATCH v6 11/64] target/arm: Clear FPMR on ResetSVEState
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
` (9 preceding siblings ...)
2026-05-20 18:21 ` [PATCH v6 10/64] target/arm: Enable EnFPM " Richard Henderson
@ 2026-05-20 18:21 ` Richard Henderson
2026-05-21 14:17 ` Peter Maydell
2026-05-20 18:21 ` [PATCH v6 12/64] target/arm: Add FPMR_EL to TBFLAGS Richard Henderson
` (52 subsequent siblings)
63 siblings, 1 reply; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:21 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm
FPMR is cleared when entering or exiting Streaming Mode.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/helper.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/target/arm/helper.c b/target/arm/helper.c
index 7eb7031294..3d6e7f1ccc 100644
--- a/target/arm/helper.c
+++ b/target/arm/helper.c
@@ -4856,6 +4856,7 @@ static void arm_reset_sve_state(CPUARMState *env)
/* Recall that FFR is stored as pregs[16]. */
memset(env->vfp.pregs, 0, sizeof(env->vfp.pregs));
vfp_set_fpsr(env, 0x0800009f);
+ env->vfp.fpmr = 0;
}
void aarch64_set_svcr(CPUARMState *env, uint64_t new, uint64_t mask)
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread* Re: [PATCH v6 11/64] target/arm: Clear FPMR on ResetSVEState
2026-05-20 18:21 ` [PATCH v6 11/64] target/arm: Clear FPMR on ResetSVEState Richard Henderson
@ 2026-05-21 14:17 ` Peter Maydell
0 siblings, 0 replies; 105+ messages in thread
From: Peter Maydell @ 2026-05-21 14:17 UTC (permalink / raw)
To: Richard Henderson; +Cc: qemu-devel, qemu-arm
On Wed, 20 May 2026 at 19:25, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> FPMR is cleared when entering or exiting Streaming Mode.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/arm/helper.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/target/arm/helper.c b/target/arm/helper.c
> index 7eb7031294..3d6e7f1ccc 100644
> --- a/target/arm/helper.c
> +++ b/target/arm/helper.c
> @@ -4856,6 +4856,7 @@ static void arm_reset_sve_state(CPUARMState *env)
> /* Recall that FFR is stored as pregs[16]. */
> memset(env->vfp.pregs, 0, sizeof(env->vfp.pregs));
> vfp_set_fpsr(env, 0x0800009f);
> + env->vfp.fpmr = 0;
> }
>
> void aarch64_set_svcr(CPUARMState *env, uint64_t new, uint64_t mask)
> --
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
^ permalink raw reply [flat|nested] 105+ messages in thread
* [PATCH v6 12/64] target/arm: Add FPMR_EL to TBFLAGS
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
` (10 preceding siblings ...)
2026-05-20 18:21 ` [PATCH v6 11/64] target/arm: Clear FPMR on ResetSVEState Richard Henderson
@ 2026-05-20 18:21 ` Richard Henderson
2026-05-21 14:38 ` Peter Maydell
2026-05-20 18:21 ` [PATCH v6 13/64] target/arm: Trap direct acceses to FPMR Richard Henderson
` (51 subsequent siblings)
63 siblings, 1 reply; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:21 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm
Prepare to perform access checks for direct and
indirect uses of FPMR.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/cpu.h | 1 +
target/arm/tcg/translate.h | 2 ++
target/arm/tcg/hflags.c | 41 ++++++++++++++++++++++++++++++++++
target/arm/tcg/translate-a64.c | 1 +
4 files changed, 45 insertions(+)
diff --git a/target/arm/cpu.h b/target/arm/cpu.h
index c114510446..9e637c1d80 100644
--- a/target/arm/cpu.h
+++ b/target/arm/cpu.h
@@ -2567,6 +2567,7 @@ FIELD(TBFLAG_A64, ZT0EXC_EL, 39, 2)
FIELD(TBFLAG_A64, GCS_EN, 41, 1)
FIELD(TBFLAG_A64, GCS_RVCEN, 42, 1)
FIELD(TBFLAG_A64, GCSSTR_EL, 43, 2)
+FIELD(TBFLAG_A64, FPMR_EL, 45, 2)
/*
* Helpers for using the above. Note that only the A64 accessors use
diff --git a/target/arm/tcg/translate.h b/target/arm/tcg/translate.h
index 77fdc5f3a1..1648c2c96f 100644
--- a/target/arm/tcg/translate.h
+++ b/target/arm/tcg/translate.h
@@ -199,6 +199,8 @@ typedef struct DisasContext {
uint8_t gm_blocksize;
/* True if the current insn_start has been updated. */
bool insn_start_updated;
+ /* FMPR exception EL or 0 if enabled. */
+ uint8_t fpmr_el;
/* Offset from VNCR_EL2 when FEAT_NV2 redirects this reg to memory */
uint32_t nv2_redirect_offset;
} DisasContext;
diff --git a/target/arm/tcg/hflags.c b/target/arm/tcg/hflags.c
index 7e6f8d3647..6759b36f28 100644
--- a/target/arm/tcg/hflags.c
+++ b/target/arm/tcg/hflags.c
@@ -237,6 +237,43 @@ static int zt0_exception_el(CPUARMState *env, int el)
return 0;
}
+/*
+ * Return the exception level to which exceptions should be taken for FPMR.
+ * C.f. the ARM pseudocode function CheckFPMREnabled.
+ */
+static int fpmr_exception_el(CPUARMState *env, int el)
+{
+ switch (el) {
+ case 0:
+ if (el_is_in_host(env, el)) {
+ if (!(env->cp15.sctlr_el[2] & SCTLR_EnFPM)) {
+ return 2;
+ }
+ break;
+ }
+ if (!(env->cp15.sctlr_el[1] & SCTLR_EnFPM)) {
+ return 1;
+ }
+ /* fall through */
+ case 1:
+ if (!(arm_hcrx_el2_eff(env) & HCRX_ENFPM)) {
+ return 2;
+ }
+ break;
+ case 2:
+ break;
+ case 3:
+ return 0;
+ default:
+ g_assert_not_reached();
+ }
+ if (arm_feature(env, ARM_FEATURE_EL3)
+ && !(env->cp15.scr_el3 & SCR_ENFPM)) {
+ return 3;
+ }
+ return 0;
+}
+
static CPUARMTBFlags rebuild_hflags_a64(CPUARMState *env, int el, int fp_el,
ARMMMUIdx mmu_idx)
{
@@ -500,6 +537,10 @@ static CPUARMTBFlags rebuild_hflags_a64(CPUARMState *env, int el, int fp_el,
}
}
+ if (cpu_isar_feature(aa64_fpmr, env_archcpu(env))) {
+ DP_TBFLAG_A64(flags, FPMR_EL, fpmr_exception_el(env, el));
+ }
+
return rebuild_hflags_common(env, fp_el, mmu_idx, flags);
}
diff --git a/target/arm/tcg/translate-a64.c b/target/arm/tcg/translate-a64.c
index 3c6559964b..b013dd51cb 100644
--- a/target/arm/tcg/translate-a64.c
+++ b/target/arm/tcg/translate-a64.c
@@ -10726,6 +10726,7 @@ static void aarch64_tr_init_disas_context(DisasContextBase *dcbase,
dc->gcs_en = EX_TBFLAG_A64(tb_flags, GCS_EN);
dc->gcs_rvcen = EX_TBFLAG_A64(tb_flags, GCS_RVCEN);
dc->gcsstr_el = EX_TBFLAG_A64(tb_flags, GCSSTR_EL);
+ dc->fpmr_el = EX_TBFLAG_A64(tb_flags, FPMR_EL);
dc->vec_len = 0;
dc->vec_stride = 0;
dc->cp_regs = arm_cpu->cp_regs;
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread* Re: [PATCH v6 12/64] target/arm: Add FPMR_EL to TBFLAGS
2026-05-20 18:21 ` [PATCH v6 12/64] target/arm: Add FPMR_EL to TBFLAGS Richard Henderson
@ 2026-05-21 14:38 ` Peter Maydell
0 siblings, 0 replies; 105+ messages in thread
From: Peter Maydell @ 2026-05-21 14:38 UTC (permalink / raw)
To: Richard Henderson; +Cc: qemu-devel, qemu-arm
On Wed, 20 May 2026 at 19:28, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Prepare to perform access checks for direct and
> indirect uses of FPMR.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/arm/cpu.h | 1 +
> target/arm/tcg/translate.h | 2 ++
> target/arm/tcg/hflags.c | 41 ++++++++++++++++++++++++++++++++++
> target/arm/tcg/translate-a64.c | 1 +
> 4 files changed, 45 insertions(+)
>
> diff --git a/target/arm/cpu.h b/target/arm/cpu.h
> index c114510446..9e637c1d80 100644
> --- a/target/arm/cpu.h
> +++ b/target/arm/cpu.h
> @@ -2567,6 +2567,7 @@ FIELD(TBFLAG_A64, ZT0EXC_EL, 39, 2)
> FIELD(TBFLAG_A64, GCS_EN, 41, 1)
> FIELD(TBFLAG_A64, GCS_RVCEN, 42, 1)
> FIELD(TBFLAG_A64, GCSSTR_EL, 43, 2)
> +FIELD(TBFLAG_A64, FPMR_EL, 45, 2)
>
> /*
> * Helpers for using the above. Note that only the A64 accessors use
> diff --git a/target/arm/tcg/translate.h b/target/arm/tcg/translate.h
> index 77fdc5f3a1..1648c2c96f 100644
> --- a/target/arm/tcg/translate.h
> +++ b/target/arm/tcg/translate.h
> @@ -199,6 +199,8 @@ typedef struct DisasContext {
> uint8_t gm_blocksize;
> /* True if the current insn_start has been updated. */
> bool insn_start_updated;
> + /* FMPR exception EL or 0 if enabled. */
"FPMR"
> +/*
> + * Return the exception level to which exceptions should be taken for FPMR.
> + * C.f. the ARM pseudocode function CheckFPMREnabled.
This pseudocode reference is a bit misleading, because that function
is for the indirect-access checks, which UNDEF to the preferred
exception level, but here we're returning the EL to use for a
trap on direct FPMR access.
We do end up mentioning that later in fpmr_access_check(),
but I think it would be useful also to say this in this
comment and to also refer the reader to the access
pseudocode for the FPMR register. We could also mention
that this only deals with the FPMR trap bits and that
generic "FP must be enabled" traps will be checked separately.
Otherwise
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
^ permalink raw reply [flat|nested] 105+ messages in thread
* [PATCH v6 13/64] target/arm: Trap direct acceses to FPMR
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
` (11 preceding siblings ...)
2026-05-20 18:21 ` [PATCH v6 12/64] target/arm: Add FPMR_EL to TBFLAGS Richard Henderson
@ 2026-05-20 18:21 ` Richard Henderson
2026-05-21 14:30 ` Peter Maydell
2026-05-20 18:21 ` [PATCH v6 14/64] tests/functional/aarch64/rme: update images to support FEAT_FP8 Richard Henderson
` (50 subsequent siblings)
63 siblings, 1 reply; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:21 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/tcg/translate-a64.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/target/arm/tcg/translate-a64.c b/target/arm/tcg/translate-a64.c
index b013dd51cb..d2a4b0fadc 100644
--- a/target/arm/tcg/translate-a64.c
+++ b/target/arm/tcg/translate-a64.c
@@ -2899,6 +2899,10 @@ static void handle_sys(DisasContext *s, bool isread,
}
if (!skip_fp_access_checks) {
+ if ((ri->type & ARM_CP_FPMR) && s->fpmr_el != 0) {
+ gen_exception_insn_el(s, 0, EXCP_UDEF, syndrome, s->fpmr_el);
+ return;
+ }
if ((ri->type & ARM_CP_FPU) && !fp_access_check_only(s)) {
return;
} else if ((ri->type & ARM_CP_SVE) && !sve_access_check(s)) {
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread* Re: [PATCH v6 13/64] target/arm: Trap direct acceses to FPMR
2026-05-20 18:21 ` [PATCH v6 13/64] target/arm: Trap direct acceses to FPMR Richard Henderson
@ 2026-05-21 14:30 ` Peter Maydell
0 siblings, 0 replies; 105+ messages in thread
From: Peter Maydell @ 2026-05-21 14:30 UTC (permalink / raw)
To: Richard Henderson; +Cc: qemu-devel, qemu-arm
On Wed, 20 May 2026 at 19:23, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/arm/tcg/translate-a64.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/target/arm/tcg/translate-a64.c b/target/arm/tcg/translate-a64.c
> index b013dd51cb..d2a4b0fadc 100644
> --- a/target/arm/tcg/translate-a64.c
> +++ b/target/arm/tcg/translate-a64.c
> @@ -2899,6 +2899,10 @@ static void handle_sys(DisasContext *s, bool isread,
> }
>
> if (!skip_fp_access_checks) {
> + if ((ri->type & ARM_CP_FPMR) && s->fpmr_el != 0) {
> + gen_exception_insn_el(s, 0, EXCP_UDEF, syndrome, s->fpmr_el);
> + return;
> + }
> if ((ri->type & ARM_CP_FPU) && !fp_access_check_only(s)) {
> return;
> } else if ((ri->type & ARM_CP_SVE) && !sve_access_check(s)) {
It took me a little while to work out how we do the traps on
CPACR_EL1.FPEN etc, but we mark the register as both ARM_CP_FPMR
and ARM_CP_FPU, and the latter handles the fp access trap part.
Hopefully nobody in future "simplifies" this if() into the
if...else if...else if ladder of ARM_CP_FPU/SVE/SME type checks :-)
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
^ permalink raw reply [flat|nested] 105+ messages in thread
* [PATCH v6 14/64] tests/functional/aarch64/rme: update images to support FEAT_FP8
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
` (12 preceding siblings ...)
2026-05-20 18:21 ` [PATCH v6 13/64] target/arm: Trap direct acceses to FPMR Richard Henderson
@ 2026-05-20 18:21 ` Richard Henderson
2026-05-21 14:39 ` Peter Maydell
2026-05-20 18:21 ` [PATCH v6 15/64] target/arm: Dump FPMR when present Richard Henderson
` (49 subsequent siblings)
63 siblings, 1 reply; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:21 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm, Pierrick Bouvier
From: Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>
As well, use -smp 1 since there is no visible speedup running with -smp 2.
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
tests/functional/aarch64/test_rme_sbsaref.py | 7 ++++---
tests/functional/aarch64/test_rme_virt.py | 7 ++++---
2 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/tests/functional/aarch64/test_rme_sbsaref.py b/tests/functional/aarch64/test_rme_sbsaref.py
index efea80c578..d252101ac6 100755
--- a/tests/functional/aarch64/test_rme_sbsaref.py
+++ b/tests/functional/aarch64/test_rme_sbsaref.py
@@ -20,12 +20,13 @@ class Aarch64RMESbsaRefMachine(QemuSystemTest):
# Stack is inspired from:
# https://linaro.atlassian.net/wiki/spaces/QEMU/pages/29051027459/
+ # Built from:
# https://github.com/p-b-o/qemu-linux-stack/tree/rme_sbsa_release
# ./build.sh && ./archive_artifacts.sh out.tar.xz
ASSET_RME_STACK_SBSA = Asset(
('https://github.com/p-b-o/qemu-linux-stack/'
- 'releases/download/build/rme_sbsa_release-6a2dfc5.tar.xz'),
- '5adba482aa069912292a8da746c6b21268224d9d81c97fe7c0bed690579ebdcb')
+ 'releases/download/build/rme_sbsa_release-74b7fab.tar.xz'),
+ '82a754bacea04e709cb1cf2759d1d12d09fabd612e014961eb32368723c7920a')
# This tests the FEAT_RME cpu implementation, by booting a VM supporting it,
# and launching a nested VM using it.
@@ -57,7 +58,7 @@ def test_aarch64_rme_sbsaref(self):
' --params "root=/dev/vda rw init=/init"')
self.vm.add_args('-cpu', 'max,x-rme=on')
- self.vm.add_args('-smp', '2')
+ self.vm.add_args('-smp', '1')
self.vm.add_args('-m', '2G')
self.vm.add_args('-M', 'sbsa-ref')
self.vm.add_args('-drive', f'file={pflash0},format=raw,if=pflash')
diff --git a/tests/functional/aarch64/test_rme_virt.py b/tests/functional/aarch64/test_rme_virt.py
index dcb18678bf..2afcdc6b07 100755
--- a/tests/functional/aarch64/test_rme_virt.py
+++ b/tests/functional/aarch64/test_rme_virt.py
@@ -19,12 +19,13 @@ class Aarch64RMEVirtMachine(QemuSystemTest):
# Stack is inspired from:
# https://linaro.atlassian.net/wiki/spaces/QEMU/pages/29051027459/
+ # Built from:
# https://github.com/p-b-o/qemu-linux-stack/tree/rme_release
# ./build.sh && ./archive_artifacts.sh out.tar.xz
ASSET_RME_STACK_VIRT = Asset(
('https://github.com/p-b-o/qemu-linux-stack/'
- 'releases/download/build/rme_release-56bc99e.tar.xz'),
- '0e3dc6b8a4b828dbae09c951a40dcb710eded084b32432b50c69cf4173ffa4be')
+ 'releases/download/build/rme_release-2701e89.tar.xz'),
+ '8c40af440f5bd1518f7add7d0a43b39289865ee48430979db8024cb897a74790')
# This tests the FEAT_RME cpu implementation, by booting a VM supporting it,
# and launching a nested VM using it.
@@ -44,7 +45,7 @@ def test_aarch64_rme_virt(self):
rootfs = join(rme_stack, 'out', 'host.ext4')
self.vm.add_args('-cpu', 'max,x-rme=on')
- self.vm.add_args('-smp', '2')
+ self.vm.add_args('-smp', '1')
self.vm.add_args('-m', '2G')
self.vm.add_args('-M', 'virt,acpi=off,'
'virtualization=on,'
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread* [PATCH v6 15/64] target/arm: Dump FPMR when present
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
` (13 preceding siblings ...)
2026-05-20 18:21 ` [PATCH v6 14/64] tests/functional/aarch64/rme: update images to support FEAT_FP8 Richard Henderson
@ 2026-05-20 18:21 ` Richard Henderson
2026-05-21 14:23 ` Peter Maydell
2026-05-20 18:21 ` [PATCH v6 16/64] target/arm: Enable FEAT_FPMR for -cpu max Richard Henderson
` (48 subsequent siblings)
63 siblings, 1 reply; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:21 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/cpu.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/target/arm/cpu.c b/target/arm/cpu.c
index c47b70ac69..868ba1bccd 100644
--- a/target/arm/cpu.c
+++ b/target/arm/cpu.c
@@ -969,8 +969,12 @@ static void aarch64_cpu_dump_state(CPUState *cs, FILE *f, int flags)
qemu_fprintf(f, " FPU disabled\n");
return;
}
- qemu_fprintf(f, " FPCR=%08x FPSR=%08x\n",
+ qemu_fprintf(f, " FPCR=%08x FPSR=%08x",
vfp_get_fpcr(env), vfp_get_fpsr(env));
+ if (cpu_isar_feature(aa64_fpmr, cpu)) {
+ qemu_fprintf(f, " FPMR=0x%" PRIx64, env->vfp.fpmr);
+ }
+ qemu_fprintf(f, "\n");
if (cpu_isar_feature(aa64_sme, cpu) && FIELD_EX64(env->svcr, SVCR, SM)) {
sve = sme_exception_el(env, el) == 0;
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread* [PATCH v6 16/64] target/arm: Enable FEAT_FPMR for -cpu max
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
` (14 preceding siblings ...)
2026-05-20 18:21 ` [PATCH v6 15/64] target/arm: Dump FPMR when present Richard Henderson
@ 2026-05-20 18:21 ` Richard Henderson
2026-05-21 14:24 ` Peter Maydell
2026-05-20 18:21 ` [PATCH v6 17/64] target/arm: Implement ID_AA64FPFR0 Richard Henderson
` (47 subsequent siblings)
63 siblings, 1 reply; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:21 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/tcg/cpu64.c | 4 ++++
docs/system/arm/emulation.rst | 1 +
2 files changed, 5 insertions(+)
diff --git a/target/arm/tcg/cpu64.c b/target/arm/tcg/cpu64.c
index ff0c2b1c47..a377f67b9c 100644
--- a/target/arm/tcg/cpu64.c
+++ b/target/arm/tcg/cpu64.c
@@ -1297,6 +1297,10 @@ void aarch64_max_tcg_initfn(Object *obj)
t = FIELD_DP64(t, ID_AA64PFR1, GCS, 1); /* FEAT_GCS */
SET_IDREG(isar, ID_AA64PFR1, t);
+ t = GET_IDREG(isar, ID_AA64PFR2);
+ t = FIELD_DP64(t, ID_AA64PFR2, FPMR, 1); /* FEAT_FPMR */
+ SET_IDREG(isar, ID_AA64PFR2, t);
+
t = GET_IDREG(isar, ID_AA64MMFR0);
t = FIELD_DP64(t, ID_AA64MMFR0, PARANGE, 6); /* FEAT_LPA: 52 bits */
t = FIELD_DP64(t, ID_AA64MMFR0, TGRAN16, 1); /* 16k pages supported */
diff --git a/docs/system/arm/emulation.rst b/docs/system/arm/emulation.rst
index da5f7efce2..44c7196d09 100644
--- a/docs/system/arm/emulation.rst
+++ b/docs/system/arm/emulation.rst
@@ -77,6 +77,7 @@ the following architecture extensions:
- FEAT_FPAC (Faulting on AUT* instructions)
- FEAT_FPACCOMBINE (Faulting on combined pointer authentication instructions)
- FEAT_FPACC_SPEC (Speculative behavior of combined pointer authentication instructions)
+- FEAT_FPMR (Floating-point mode register)
- FEAT_FRINTTS (Floating-point to integer instructions)
- FEAT_FlagM (Flag manipulation instructions v2)
- FEAT_FlagM2 (Enhancements to flag manipulation instructions)
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread* Re: [PATCH v6 16/64] target/arm: Enable FEAT_FPMR for -cpu max
2026-05-20 18:21 ` [PATCH v6 16/64] target/arm: Enable FEAT_FPMR for -cpu max Richard Henderson
@ 2026-05-21 14:24 ` Peter Maydell
0 siblings, 0 replies; 105+ messages in thread
From: Peter Maydell @ 2026-05-21 14:24 UTC (permalink / raw)
To: Richard Henderson; +Cc: qemu-devel, qemu-arm
On Wed, 20 May 2026 at 19:23, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/arm/tcg/cpu64.c | 4 ++++
> docs/system/arm/emulation.rst | 1 +
> 2 files changed, 5 insertions(+)
>
> diff --git a/target/arm/tcg/cpu64.c b/target/arm/tcg/cpu64.c
> index ff0c2b1c47..a377f67b9c 100644
> --- a/target/arm/tcg/cpu64.c
> +++ b/target/arm/tcg/cpu64.c
> @@ -1297,6 +1297,10 @@ void aarch64_max_tcg_initfn(Object *obj)
> t = FIELD_DP64(t, ID_AA64PFR1, GCS, 1); /* FEAT_GCS */
> SET_IDREG(isar, ID_AA64PFR1, t);
>
> + t = GET_IDREG(isar, ID_AA64PFR2);
> + t = FIELD_DP64(t, ID_AA64PFR2, FPMR, 1); /* FEAT_FPMR */
> + SET_IDREG(isar, ID_AA64PFR2, t);
> +
> t = GET_IDREG(isar, ID_AA64MMFR0);
> t = FIELD_DP64(t, ID_AA64MMFR0, PARANGE, 6); /* FEAT_LPA: 52 bits */
> t = FIELD_DP64(t, ID_AA64MMFR0, TGRAN16, 1); /* 16k pages supported */
> diff --git a/docs/system/arm/emulation.rst b/docs/system/arm/emulation.rst
> index da5f7efce2..44c7196d09 100644
> --- a/docs/system/arm/emulation.rst
> +++ b/docs/system/arm/emulation.rst
> @@ -77,6 +77,7 @@ the following architecture extensions:
> - FEAT_FPAC (Faulting on AUT* instructions)
> - FEAT_FPACCOMBINE (Faulting on combined pointer authentication instructions)
> - FEAT_FPACC_SPEC (Speculative behavior of combined pointer authentication instructions)
> +- FEAT_FPMR (Floating-point mode register)
I generally keep to the capitalization the Arm ARM uses in
the section where it describes each feature, which in this
case is "Floating-point Mode Register".
> - FEAT_FRINTTS (Floating-point to integer instructions)
> - FEAT_FlagM (Flag manipulation instructions v2)
Otherwise
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
^ permalink raw reply [flat|nested] 105+ messages in thread
* [PATCH v6 17/64] target/arm: Implement ID_AA64FPFR0
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
` (15 preceding siblings ...)
2026-05-20 18:21 ` [PATCH v6 16/64] target/arm: Enable FEAT_FPMR for -cpu max Richard Henderson
@ 2026-05-20 18:21 ` Richard Henderson
2026-05-21 14:44 ` Peter Maydell
2026-05-20 18:21 ` [PATCH v6 18/64] target/arm: Add isar_feature_aa64_f8cvt Richard Henderson
` (46 subsequent siblings)
63 siblings, 1 reply; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:21 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/cpu-features.h | 9 +++++++++
target/arm/helper.c | 13 +++++++++++--
target/arm/cpu-sysregs.h.inc | 1 +
3 files changed, 21 insertions(+), 2 deletions(-)
diff --git a/target/arm/cpu-features.h b/target/arm/cpu-features.h
index e13c1c1331..1bb77d78da 100644
--- a/target/arm/cpu-features.h
+++ b/target/arm/cpu-features.h
@@ -410,6 +410,15 @@ FIELD(ID_AA64SMFR0, I16I64, 52, 4)
FIELD(ID_AA64SMFR0, SMEVER, 56, 4)
FIELD(ID_AA64SMFR0, FA64, 63, 1)
+FIELD(ID_AA64FPFR0, F8E5M2, 0, 1)
+FIELD(ID_AA64FPFR0, F8E4M3, 1, 1)
+FIELD(ID_AA64FPFR0, F8MM4, 26, 1)
+FIELD(ID_AA64FPFR0, F8MM8, 27, 1)
+FIELD(ID_AA64FPFR0, F8DP2, 28, 1)
+FIELD(ID_AA64FPFR0, F8DP4, 29, 1)
+FIELD(ID_AA64FPFR0, F8FMA, 30, 1)
+FIELD(ID_AA64FPFR0, F8CVT, 31, 1)
+
FIELD(ID_DFR0, COPDBG, 0, 4)
FIELD(ID_DFR0, COPSDBG, 4, 4)
FIELD(ID_DFR0, MMAPDBG, 8, 4)
diff --git a/target/arm/helper.c b/target/arm/helper.c
index 3d6e7f1ccc..34487eeaa3 100644
--- a/target/arm/helper.c
+++ b/target/arm/helper.c
@@ -6477,11 +6477,11 @@ void register_cp_regs_for_features(ARMCPU *cpu)
.access = PL1_R, .type = ARM_CP_CONST,
.accessfn = access_tid3,
.resetvalue = 0 },
- { .name = "ID_AA64PFR7_EL1_RESERVED", .state = ARM_CP_STATE_AA64,
+ { .name = "ID_AA64FPFR0_EL1", .state = ARM_CP_STATE_AA64,
.opc0 = 3, .opc1 = 0, .crn = 0, .crm = 4, .opc2 = 7,
.access = PL1_R, .type = ARM_CP_CONST,
.accessfn = access_tid3,
- .resetvalue = 0 },
+ .resetvalue = GET_IDREG(isar, ID_AA64FPFR0) },
{ .name = "ID_AA64DFR0_EL1", .state = ARM_CP_STATE_AA64,
.opc0 = 3, .opc1 = 0, .crn = 0, .crm = 5, .opc2 = 0,
.access = PL1_R, .type = ARM_CP_CONST,
@@ -6712,6 +6712,15 @@ void register_cp_regs_for_features(ARMCPU *cpu)
R_ID_AA64SMFR0_I16I64_MASK |
R_ID_AA64SMFR0_SMEVER_MASK |
R_ID_AA64SMFR0_FA64_MASK },
+ { .name = "ID_AA64FPFR0_EL1",
+ .exported_bits = R_ID_AA64FPFR0_F8E5M2_MASK |
+ R_ID_AA64FPFR0_F8E4M3_MASK |
+ R_ID_AA64FPFR0_F8MM4_MASK |
+ R_ID_AA64FPFR0_F8MM8_MASK |
+ R_ID_AA64FPFR0_F8DP2_MASK |
+ R_ID_AA64FPFR0_F8DP4_MASK |
+ R_ID_AA64FPFR0_F8FMA_MASK |
+ R_ID_AA64FPFR0_F8CVT_MASK },
{ .name = "ID_AA64MMFR0_EL1",
.exported_bits = R_ID_AA64MMFR0_ECV_MASK,
.fixed_bits = (0xfu << R_ID_AA64MMFR0_TGRAN64_SHIFT) |
diff --git a/target/arm/cpu-sysregs.h.inc b/target/arm/cpu-sysregs.h.inc
index b99579f773..6e8b335b8f 100644
--- a/target/arm/cpu-sysregs.h.inc
+++ b/target/arm/cpu-sysregs.h.inc
@@ -3,6 +3,7 @@ DEF(ID_AA64PFR0_EL1, 3, 0, 0, 4, 0)
DEF(ID_AA64PFR1_EL1, 3, 0, 0, 4, 1)
DEF(ID_AA64PFR2_EL1, 3, 0, 0, 4, 2)
DEF(ID_AA64SMFR0_EL1, 3, 0, 0, 4, 5)
+DEF(ID_AA64FPFR0_EL1, 3, 0, 0, 4, 7)
DEF(ID_AA64DFR0_EL1, 3, 0, 0, 5, 0)
DEF(ID_AA64DFR1_EL1, 3, 0, 0, 5, 1)
DEF(ID_AA64AFR0_EL1, 3, 0, 0, 5, 4)
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread* [PATCH v6 18/64] target/arm: Add isar_feature_aa64_f8cvt
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
` (16 preceding siblings ...)
2026-05-20 18:21 ` [PATCH v6 17/64] target/arm: Implement ID_AA64FPFR0 Richard Henderson
@ 2026-05-20 18:21 ` Richard Henderson
2026-05-21 14:44 ` Peter Maydell
2026-05-20 18:21 ` [PATCH v6 19/64] target/arm: Implement FSCALE for AdvSIMD Richard Henderson
` (45 subsequent siblings)
63 siblings, 1 reply; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:21 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/cpu-features.h | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/target/arm/cpu-features.h b/target/arm/cpu-features.h
index 1bb77d78da..1fde3e9231 100644
--- a/target/arm/cpu-features.h
+++ b/target/arm/cpu-features.h
@@ -1569,6 +1569,11 @@ static inline bool isar_feature_aa64_sme2p1(const ARMISARegisters *id)
return FIELD_EX64_IDREG(id, ID_AA64SMFR0, SMEVER) >= 2;
}
+static inline bool isar_feature_aa64_f8cvt(const ARMISARegisters *id)
+{
+ return FIELD_EX64_IDREG(id, ID_AA64FPFR0, F8CVT);
+}
+
/*
* Combinations of feature tests, for ease of use with TRANS_FEAT.
*/
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread* [PATCH v6 19/64] target/arm: Implement FSCALE for AdvSIMD
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
` (17 preceding siblings ...)
2026-05-20 18:21 ` [PATCH v6 18/64] target/arm: Add isar_feature_aa64_f8cvt Richard Henderson
@ 2026-05-20 18:21 ` Richard Henderson
2026-05-21 15:30 ` Peter Maydell
2026-05-21 15:35 ` Peter Maydell
2026-05-20 18:21 ` [PATCH v6 20/64] target/arm: Implement FSCALE for SME Richard Henderson
` (44 subsequent siblings)
63 siblings, 2 replies; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:21 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/tcg/helper-a64-defs.h | 4 ++++
target/arm/tcg/vec_internal.h | 4 ++++
target/arm/tcg/translate-a64.c | 7 +++++++
target/arm/tcg/vec_helper64.c | 16 ++++++++++++++++
target/arm/tcg/a64.decode | 3 +++
5 files changed, 34 insertions(+)
diff --git a/target/arm/tcg/helper-a64-defs.h b/target/arm/tcg/helper-a64-defs.h
index 215df1201b..b7880f773e 100644
--- a/target/arm/tcg/helper-a64-defs.h
+++ b/target/arm/tcg/helper-a64-defs.h
@@ -152,6 +152,10 @@ DEF_HELPER_FLAGS_5(gvec_famin_s, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, fpst, i32
DEF_HELPER_FLAGS_5(gvec_famax_d, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, fpst, i32)
DEF_HELPER_FLAGS_5(gvec_famin_d, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, fpst, i32)
+DEF_HELPER_FLAGS_5(gvec_fscale_h, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, fpst, i32)
+DEF_HELPER_FLAGS_5(gvec_fscale_s, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, fpst, i32)
+DEF_HELPER_FLAGS_5(gvec_fscale_d, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, fpst, i32)
+
#ifndef CONFIG_USER_ONLY
DEF_HELPER_2(exception_return, void, env, i64)
#endif
diff --git a/target/arm/tcg/vec_internal.h b/target/arm/tcg/vec_internal.h
index 5c3f51eed3..b647399b18 100644
--- a/target/arm/tcg/vec_internal.h
+++ b/target/arm/tcg/vec_internal.h
@@ -349,6 +349,10 @@ float32 float32_famin(float32, float32, float_status *);
float64 float64_famax(float64, float64, float_status *);
float64 float64_famin(float64, float64, float_status *);
+#define float16_fscale float16_scalbn
+#define float32_fscale float32_scalbn
+float64 float64_fscale(float64, int64_t, float_status *);
+
/*
* Decode helper functions for predicate as counter.
*/
diff --git a/target/arm/tcg/translate-a64.c b/target/arm/tcg/translate-a64.c
index d2a4b0fadc..ac18ceeeab 100644
--- a/target/arm/tcg/translate-a64.c
+++ b/target/arm/tcg/translate-a64.c
@@ -6496,6 +6496,13 @@ static gen_helper_gvec_3_ptr * const f_vector_famin[3] = {
};
TRANS_FEAT(FAMIN, aa64_faminmax, do_fp3_vector, a, 0, f_vector_famin)
+static gen_helper_gvec_3_ptr * const f_vector_fscale[3] = {
+ gen_helper_gvec_fscale_h,
+ gen_helper_gvec_fscale_s,
+ gen_helper_gvec_fscale_d,
+};
+TRANS_FEAT(FSCALE, aa64_f8cvt, do_fp3_vector, a, 0, f_vector_fscale)
+
static bool do_fmlal(DisasContext *s, arg_qrrr_e *a, bool is_s, bool is_2)
{
if (fp_access_check(s)) {
diff --git a/target/arm/tcg/vec_helper64.c b/target/arm/tcg/vec_helper64.c
index dce5e0505e..7d403adfba 100644
--- a/target/arm/tcg/vec_helper64.c
+++ b/target/arm/tcg/vec_helper64.c
@@ -177,3 +177,19 @@ DO_3OP(gvec_famax_s, float32_famax, float32)
DO_3OP(gvec_famin_s, float32_famin, float32)
DO_3OP(gvec_famax_d, float64_famax, float64)
DO_3OP(gvec_famin_d, float64_famin, float64)
+
+float64 float64_fscale(float64 n, int64_t m, float_status *s)
+{
+ /*
+ * Given the 'int' parameter of float64_scalbn, we have to saturate
+ * the 'int64_t' parameter of the operation to some value. Since
+ * float64 has an 11-bit exponent, saturating to 12 bits is sufficient
+ * to ensure that DBL_TRUE_MIN can be made to overflow.
+ */
+ int sat_m = MIN(MAX(m, -0xfff), 0xfff);
+ return float64_scalbn(n, sat_m, s);
+}
+
+DO_3OP(gvec_fscale_h, float16_fscale, int16_t)
+DO_3OP(gvec_fscale_s, float32_fscale, int32_t)
+DO_3OP(gvec_fscale_d, float64_fscale, int64_t)
diff --git a/target/arm/tcg/a64.decode b/target/arm/tcg/a64.decode
index 666a293540..02c7264cb9 100644
--- a/target/arm/tcg/a64.decode
+++ b/target/arm/tcg/a64.decode
@@ -1198,6 +1198,9 @@ FAMAX 0.00 1110 1.1 ..... 11011 1 ..... ..... @qrrr_sd
FAMIN 0.10 1110 110 ..... 00011 1 ..... ..... @qrrr_h
FAMIN 0.10 1110 1.1 ..... 11011 1 ..... ..... @qrrr_sd
+FSCALE 0.10 1110 110 ..... 00111 1 ..... ..... @qrrr_h
+FSCALE 0.10 1110 1.1 ..... 11111 1 ..... ..... @qrrr_sd
+
### Advanced SIMD scalar x indexed element
FMUL_si 0101 1111 00 .. .... 1001 . 0 ..... ..... @rrx_h
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread* Re: [PATCH v6 19/64] target/arm: Implement FSCALE for AdvSIMD
2026-05-20 18:21 ` [PATCH v6 19/64] target/arm: Implement FSCALE for AdvSIMD Richard Henderson
@ 2026-05-21 15:30 ` Peter Maydell
2026-05-21 15:35 ` Peter Maydell
1 sibling, 0 replies; 105+ messages in thread
From: Peter Maydell @ 2026-05-21 15:30 UTC (permalink / raw)
To: Richard Henderson; +Cc: qemu-devel, qemu-arm
On Wed, 20 May 2026 at 19:28, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
^ permalink raw reply [flat|nested] 105+ messages in thread
* Re: [PATCH v6 19/64] target/arm: Implement FSCALE for AdvSIMD
2026-05-20 18:21 ` [PATCH v6 19/64] target/arm: Implement FSCALE for AdvSIMD Richard Henderson
2026-05-21 15:30 ` Peter Maydell
@ 2026-05-21 15:35 ` Peter Maydell
2026-05-22 19:19 ` Richard Henderson
1 sibling, 1 reply; 105+ messages in thread
From: Peter Maydell @ 2026-05-21 15:35 UTC (permalink / raw)
To: Richard Henderson; +Cc: qemu-devel, qemu-arm
On Wed, 20 May 2026 at 19:28, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/arm/tcg/helper-a64-defs.h | 4 ++++
> target/arm/tcg/vec_internal.h | 4 ++++
> target/arm/tcg/translate-a64.c | 7 +++++++
> target/arm/tcg/vec_helper64.c | 16 ++++++++++++++++
> target/arm/tcg/a64.decode | 3 +++
> 5 files changed, 34 insertions(+)
>
> diff --git a/target/arm/tcg/helper-a64-defs.h b/target/arm/tcg/helper-a64-defs.h
> index 215df1201b..b7880f773e 100644
> --- a/target/arm/tcg/helper-a64-defs.h
> +++ b/target/arm/tcg/helper-a64-defs.h
> @@ -152,6 +152,10 @@ DEF_HELPER_FLAGS_5(gvec_famin_s, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, fpst, i32
> DEF_HELPER_FLAGS_5(gvec_famax_d, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, fpst, i32)
> DEF_HELPER_FLAGS_5(gvec_famin_d, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, fpst, i32)
>
> +DEF_HELPER_FLAGS_5(gvec_fscale_h, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, fpst, i32)
> +DEF_HELPER_FLAGS_5(gvec_fscale_s, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, fpst, i32)
> +DEF_HELPER_FLAGS_5(gvec_fscale_d, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, fpst, i32)
> +
> #ifndef CONFIG_USER_ONLY
> DEF_HELPER_2(exception_return, void, env, i64)
> #endif
> diff --git a/target/arm/tcg/vec_internal.h b/target/arm/tcg/vec_internal.h
> index 5c3f51eed3..b647399b18 100644
> --- a/target/arm/tcg/vec_internal.h
> +++ b/target/arm/tcg/vec_internal.h
> @@ -349,6 +349,10 @@ float32 float32_famin(float32, float32, float_status *);
> float64 float64_famax(float64, float64, float_status *);
> float64 float64_famin(float64, float64, float_status *);
>
> +#define float16_fscale float16_scalbn
> +#define float32_fscale float32_scalbn
> +float64 float64_fscale(float64, int64_t, float_status *);
> +
> /*
> * Decode helper functions for predicate as counter.
> */
> diff --git a/target/arm/tcg/translate-a64.c b/target/arm/tcg/translate-a64.c
> index d2a4b0fadc..ac18ceeeab 100644
> --- a/target/arm/tcg/translate-a64.c
> +++ b/target/arm/tcg/translate-a64.c
> @@ -6496,6 +6496,13 @@ static gen_helper_gvec_3_ptr * const f_vector_famin[3] = {
> };
> TRANS_FEAT(FAMIN, aa64_faminmax, do_fp3_vector, a, 0, f_vector_famin)
>
> +static gen_helper_gvec_3_ptr * const f_vector_fscale[3] = {
> + gen_helper_gvec_fscale_h,
> + gen_helper_gvec_fscale_s,
> + gen_helper_gvec_fscale_d,
> +};
> +TRANS_FEAT(FSCALE, aa64_f8cvt, do_fp3_vector, a, 0, f_vector_fscale)
> +
> static bool do_fmlal(DisasContext *s, arg_qrrr_e *a, bool is_s, bool is_2)
> {
> if (fp_access_check(s)) {
> diff --git a/target/arm/tcg/vec_helper64.c b/target/arm/tcg/vec_helper64.c
> index dce5e0505e..7d403adfba 100644
> --- a/target/arm/tcg/vec_helper64.c
> +++ b/target/arm/tcg/vec_helper64.c
> @@ -177,3 +177,19 @@ DO_3OP(gvec_famax_s, float32_famax, float32)
> DO_3OP(gvec_famin_s, float32_famin, float32)
> DO_3OP(gvec_famax_d, float64_famax, float64)
> DO_3OP(gvec_famin_d, float64_famin, float64)
> +
> +float64 float64_fscale(float64 n, int64_t m, float_status *s)
> +{
> + /*
> + * Given the 'int' parameter of float64_scalbn, we have to saturate
> + * the 'int64_t' parameter of the operation to some value. Since
> + * float64 has an 11-bit exponent, saturating to 12 bits is sufficient
> + * to ensure that DBL_TRUE_MIN can be made to overflow.
> + */
> + int sat_m = MIN(MAX(m, -0xfff), 0xfff);
> + return float64_scalbn(n, sat_m, s);
> +}
> +
I just noticed that this seems to be reinventing the
existing scalbn_d() in sve_helper.c. Could we share the code?
-- PMM
^ permalink raw reply [flat|nested] 105+ messages in thread* Re: [PATCH v6 19/64] target/arm: Implement FSCALE for AdvSIMD
2026-05-21 15:35 ` Peter Maydell
@ 2026-05-22 19:19 ` Richard Henderson
0 siblings, 0 replies; 105+ messages in thread
From: Richard Henderson @ 2026-05-22 19:19 UTC (permalink / raw)
To: Peter Maydell; +Cc: qemu-devel, qemu-arm
On 5/21/26 08:35, Peter Maydell wrote:
>> +float64 float64_fscale(float64 n, int64_t m, float_status *s)
>> +{
>> + /*
>> + * Given the 'int' parameter of float64_scalbn, we have to saturate
>> + * the 'int64_t' parameter of the operation to some value. Since
>> + * float64 has an 11-bit exponent, saturating to 12 bits is sufficient
>> + * to ensure that DBL_TRUE_MIN can be made to overflow.
>> + */
>> + int sat_m = MIN(MAX(m, -0xfff), 0xfff);
>> + return float64_scalbn(n, sat_m, s);
>> +}
>> +
>
> I just noticed that this seems to be reinventing the
> existing scalbn_d() in sve_helper.c. Could we share the code?
Ah, thanks. I knew this seemed familiar.
I've moved scalbn_d to vec_internal.h.
r~
^ permalink raw reply [flat|nested] 105+ messages in thread
* [PATCH v6 20/64] target/arm: Implement FSCALE for SME
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
` (18 preceding siblings ...)
2026-05-20 18:21 ` [PATCH v6 19/64] target/arm: Implement FSCALE for AdvSIMD Richard Henderson
@ 2026-05-20 18:21 ` Richard Henderson
2026-05-21 15:39 ` Peter Maydell
2026-05-20 18:21 ` [PATCH v6 21/64] target/arm: Split vector-type.h from cpu.h Richard Henderson
` (43 subsequent siblings)
63 siblings, 1 reply; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:21 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/cpu-features.h | 5 +++++
target/arm/tcg/translate-sme.c | 15 +++++++++++++--
target/arm/tcg/sme.decode | 6 ++++++
3 files changed, 24 insertions(+), 2 deletions(-)
diff --git a/target/arm/cpu-features.h b/target/arm/cpu-features.h
index 1fde3e9231..f9c979d20b 100644
--- a/target/arm/cpu-features.h
+++ b/target/arm/cpu-features.h
@@ -1622,6 +1622,11 @@ static inline bool isar_feature_aa64_sme2_faminmax(const ARMISARegisters *id)
return isar_feature_aa64_sme2(id) && isar_feature_aa64_faminmax(id);
}
+static inline bool isar_feature_aa64_sme2_f8cvt(const ARMISARegisters *id)
+{
+ return isar_feature_aa64_sme2(id) && isar_feature_aa64_f8cvt(id);
+}
+
static inline bool isar_feature_aa64_sve_i8mm(const ARMISARegisters *id)
{
return isar_feature_aa64_sve(id) && isar_feature_aa64_sme_sve_i8mm(id);
diff --git a/target/arm/tcg/translate-sme.c b/target/arm/tcg/translate-sme.c
index a67501226f..e2d17de165 100644
--- a/target/arm/tcg/translate-sme.c
+++ b/target/arm/tcg/translate-sme.c
@@ -707,9 +707,12 @@ static bool do_z2z_n1_fpst(DisasContext *s, arg_z2z_en *a,
{
int esz = a->esz, n, dn, vsz, mofs;
bool overlap = false;
- gen_helper_gvec_3_ptr *fn;
+ gen_helper_gvec_3_ptr *fn = fns[esz];
TCGv_ptr fpst;
+ if (fn == NULL) {
+ return false;
+ }
/* These insns use MO_8 to encode BFloat16. */
if (esz == MO_8 && !dc_isar_feature(aa64_sme_b16b16, s)) {
return false;
@@ -719,7 +722,6 @@ static bool do_z2z_n1_fpst(DisasContext *s, arg_z2z_en *a,
}
fpst = fpstatus_ptr(esz == MO_16 ? FPST_A64_F16 : FPST_A64);
- fn = fns[esz];
n = a->n;
dn = a->zdn;
mofs = vec_full_reg_offset(s, a->zm);
@@ -831,6 +833,15 @@ static gen_helper_gvec_3_ptr * const f_vector_famin[4] = {
};
TRANS_FEAT(FAMIN_nn, aa64_sme2_faminmax, do_z2z_nn_fpst, a, f_vector_famin)
+static gen_helper_gvec_3_ptr * const f_vector_fscale[4] = {
+ NULL,
+ gen_helper_gvec_fscale_h,
+ gen_helper_gvec_fscale_s,
+ gen_helper_gvec_fscale_d,
+};
+TRANS_FEAT(FSCALE_n1, aa64_sme2_f8cvt, do_z2z_n1_fpst, a, f_vector_fscale)
+TRANS_FEAT(FSCALE_nn, aa64_sme2_f8cvt, do_z2z_nn_fpst, a, f_vector_fscale)
+
/* Add/Sub vector Z[m] to each Z[n*N] with result in ZA[d*N]. */
static bool do_azz_n1(DisasContext *s, arg_azz_n *a, int esz,
GVecGen3FnVar *fn)
diff --git a/target/arm/tcg/sme.decode b/target/arm/tcg/sme.decode
index 9dec7318a4..ee874be1a6 100644
--- a/target/arm/tcg/sme.decode
+++ b/target/arm/tcg/sme.decode
@@ -250,6 +250,9 @@ ADD_n1 1100000 1 .. 10 .... 1010.0 11000 .... 0 @z2z_4x1
SQDMULH_n1 1100000 1 .. 10 .... 1010.1 00000 .... 0 @z2z_2x1
SQDMULH_n1 1100000 1 .. 10 .... 1010.1 00000 .... 0 @z2z_4x1
+FSCALE_n1 1100000 1 .. 10 .... 1010.0 01100 .... 0 @z2z_2x1
+FSCALE_n1 1100000 1 .. 10 .... 1010.0 01100 .... 0 @z2z_4x1
+
### SME2 Multi-vector Multiple Vectors SVE Destructive
%zm_ax2 17:4 !function=times_2
@@ -291,6 +294,9 @@ FAMAX_nn 1100000 1 .. 1 ..... 1011.0 01010 .... 0 @z2z_4x4
FAMIN_nn 1100000 1 .. 1 ..... 1011.0 01010 .... 1 @z2z_2x2
FAMIN_nn 1100000 1 .. 1 ..... 1011.0 01010 .... 1 @z2z_4x4
+FSCALE_nn 1100000 1 .. 1 ..... 1011.0 01100 .... 0 @z2z_2x2
+FSCALE_nn 1100000 1 .. 1 ..... 1011.0 01100 .... 0 @z2z_4x4
+
### SME2 Multi-vector Multiple and Single Array Vectors
&azz_n n off rv zn zm
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread* [PATCH v6 21/64] target/arm: Split vector-type.h from cpu.h
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
` (19 preceding siblings ...)
2026-05-20 18:21 ` [PATCH v6 20/64] target/arm: Implement FSCALE for SME Richard Henderson
@ 2026-05-20 18:21 ` Richard Henderson
2026-05-20 18:21 ` [PATCH v6 22/64] target/arm: Move vectors_overlap to vec_internal.h Richard Henderson
` (42 subsequent siblings)
63 siblings, 0 replies; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:21 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm, Philippe Mathieu-Daudé
We want to be able to reference ARMVectorType etc from
common code, so move it out of cpu.h.
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/cpu.h | 38 +---------------------------------
target/arm/vector-type.h | 44 ++++++++++++++++++++++++++++++++++++++++
2 files changed, 45 insertions(+), 37 deletions(-)
create mode 100644 target/arm/vector-type.h
diff --git a/target/arm/cpu.h b/target/arm/cpu.h
index 9e637c1d80..9f5da3d863 100644
--- a/target/arm/cpu.h
+++ b/target/arm/cpu.h
@@ -35,6 +35,7 @@
#include "target/arm/cpu-sysregs.h"
#include "target/arm/mmuidx.h"
#include "hw/intc/arm_gicv5_types.h"
+#include "target/arm/vector-type.h"
#define EXCP_UDEF 1 /* undefined instruction */
#define EXCP_SWI 2 /* software interrupt */
@@ -140,43 +141,6 @@ typedef struct ARMGenericTimer {
uint64_t ctl; /* Timer Control register */
} ARMGenericTimer;
-/* Define a maximum sized vector register.
- * For 32-bit, this is a 128-bit NEON/AdvSIMD register.
- * For 64-bit, this is a 2048-bit SVE register.
- *
- * Note that the mapping between S, D, and Q views of the register bank
- * differs between AArch64 and AArch32.
- * In AArch32:
- * Qn = regs[n].d[1]:regs[n].d[0]
- * Dn = regs[n / 2].d[n & 1]
- * Sn = regs[n / 4].d[n % 4 / 2],
- * bits 31..0 for even n, and bits 63..32 for odd n
- * (and regs[16] to regs[31] are inaccessible)
- * In AArch64:
- * Zn = regs[n].d[*]
- * Qn = regs[n].d[1]:regs[n].d[0]
- * Dn = regs[n].d[0]
- * Sn = regs[n].d[0] bits 31..0
- * Hn = regs[n].d[0] bits 15..0
- *
- * This corresponds to the architecturally defined mapping between
- * the two execution states, and means we do not need to explicitly
- * map these registers when changing states.
- *
- * Align the data for use with TCG host vector operations.
- */
-
-#define ARM_MAX_VQ 16
-
-typedef struct ARMVectorReg {
- uint64_t d[2 * ARM_MAX_VQ] QEMU_ALIGNED(16);
-} ARMVectorReg;
-
-/* In AArch32 mode, predicate registers do not exist at all. */
-typedef struct ARMPredicateReg {
- uint64_t p[DIV_ROUND_UP(2 * ARM_MAX_VQ, 8)] QEMU_ALIGNED(16);
-} ARMPredicateReg;
-
/* In AArch32 mode, PAC keys do not exist at all. */
typedef struct ARMPACKey {
uint64_t lo, hi;
diff --git a/target/arm/vector-type.h b/target/arm/vector-type.h
new file mode 100644
index 0000000000..d94c0d986e
--- /dev/null
+++ b/target/arm/vector-type.h
@@ -0,0 +1,44 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+
+#ifndef TARGET_ARM_VECTOR_TYPE_H
+#define TARGET_ARM_VECTOR_TYPE_H
+
+/*
+ * Define a maximum sized vector register.
+ * For 32-bit, this is a 128-bit NEON/AdvSIMD register.
+ * For 64-bit, this is a 2048-bit SVE register.
+ *
+ * Note that the mapping between S, D, and Q views of the register bank
+ * differs between AArch64 and AArch32.
+ * In AArch32:
+ * Qn = regs[n].d[1]:regs[n].d[0]
+ * Dn = regs[n / 2].d[n & 1]
+ * Sn = regs[n / 4].d[n % 4 / 2],
+ * bits 31..0 for even n, and bits 63..32 for odd n
+ * (and regs[16] to regs[31] are inaccessible)
+ * In AArch64:
+ * Zn = regs[n].d[*]
+ * Qn = regs[n].d[1]:regs[n].d[0]
+ * Dn = regs[n].d[0]
+ * Sn = regs[n].d[0] bits 31..0
+ * Hn = regs[n].d[0] bits 15..0
+ *
+ * This corresponds to the architecturally defined mapping between
+ * the two execution states, and means we do not need to explicitly
+ * map these registers when changing states.
+ *
+ * Align the data for use with TCG host vector operations.
+ */
+
+#define ARM_MAX_VQ 16
+
+typedef struct ARMVectorReg {
+ uint64_t d[2 * ARM_MAX_VQ] QEMU_ALIGNED(16);
+} ARMVectorReg;
+
+/* In AArch32 mode, predicate registers do not exist at all. */
+typedef struct ARMPredicateReg {
+ uint64_t p[DIV_ROUND_UP(2 * ARM_MAX_VQ, 8)] QEMU_ALIGNED(16);
+} ARMPredicateReg;
+
+#endif
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread* [PATCH v6 22/64] target/arm: Move vectors_overlap to vec_internal.h
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
` (20 preceding siblings ...)
2026-05-20 18:21 ` [PATCH v6 21/64] target/arm: Split vector-type.h from cpu.h Richard Henderson
@ 2026-05-20 18:21 ` Richard Henderson
2026-05-20 18:21 ` [PATCH v6 23/64] target/arm: Set e4m3_nan_is_snan Richard Henderson
` (41 subsequent siblings)
63 siblings, 0 replies; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:21 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm, Philippe Mathieu-Daudé
We will shortly need this outside of sme_helper.c.
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/tcg/vec_internal.h | 8 ++++++++
target/arm/tcg/sme_helper.c | 6 ------
2 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/target/arm/tcg/vec_internal.h b/target/arm/tcg/vec_internal.h
index b647399b18..dbc098d49a 100644
--- a/target/arm/tcg/vec_internal.h
+++ b/target/arm/tcg/vec_internal.h
@@ -21,6 +21,7 @@
#define TARGET_ARM_VEC_INTERNAL_H
#include "fpu/softfloat.h"
+#include "vector-type.h"
typedef struct CPUArchState CPUARMState;
@@ -461,6 +462,13 @@ static inline void depositn(uint64_t *p, unsigned pos,
}
}
+/* Determine if [x, x+nx) overlaps [y, y+ny). */
+static inline bool vectors_overlap(ARMVectorReg *x, unsigned nx,
+ ARMVectorReg *y, unsigned ny)
+{
+ return !(x + nx <= y || y + ny <= x);
+}
+
#define DO_3OP(NAME, FUNC, TYPE) \
void HELPER(NAME)(void *vd, void *vn, void *vm, \
float_status * stat, uint32_t desc) \
diff --git a/target/arm/tcg/sme_helper.c b/target/arm/tcg/sme_helper.c
index ab5999c592..0055e97a2b 100644
--- a/target/arm/tcg/sme_helper.c
+++ b/target/arm/tcg/sme_helper.c
@@ -33,12 +33,6 @@
#define HELPER_H "tcg/helper-sme-defs.h"
#include "exec/helper-info.c.inc"
-static bool vectors_overlap(ARMVectorReg *x, unsigned nx,
- ARMVectorReg *y, unsigned ny)
-{
- return !(x + nx <= y || y + ny <= x);
-}
-
void helper_set_svcr(CPUARMState *env, uint32_t val, uint32_t mask)
{
aarch64_set_svcr(env, val, mask);
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread* [PATCH v6 23/64] target/arm: Set e4m3_nan_is_snan
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
` (21 preceding siblings ...)
2026-05-20 18:21 ` [PATCH v6 22/64] target/arm: Move vectors_overlap to vec_internal.h Richard Henderson
@ 2026-05-20 18:21 ` Richard Henderson
2026-05-21 15:12 ` Peter Maydell
2026-05-20 18:21 ` [PATCH v6 24/64] target/arm: Implement BF1CVTL, BF1CVTL2, BF2CVTL, BF2CVTL2 for AdvSIMD Richard Henderson
` (40 subsequent siblings)
63 siblings, 1 reply; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:21 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm
The unique e4m3 nan encoding is SNaN for Arm.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/tcg/vfp_helper.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/target/arm/tcg/vfp_helper.c b/target/arm/tcg/vfp_helper.c
index 8d3f6e3a2e..c10b085f08 100644
--- a/target/arm/tcg/vfp_helper.c
+++ b/target/arm/tcg/vfp_helper.c
@@ -46,6 +46,7 @@ void arm_set_default_fp_behaviours(float_status *s)
set_float_3nan_prop_rule(float_3nan_prop_s_cab, s);
set_float_infzeronan_rule(float_infzeronan_dnan_if_qnan, s);
set_float_default_nan_pattern(0b01000000, s);
+ set_float_e4m3_nan_is_snan(true, s);
}
/*
@@ -67,6 +68,7 @@ void arm_set_ah_fp_behaviours(float_status *s)
set_float_infzeronan_rule(float_infzeronan_dnan_never |
float_infzeronan_suppress_invalid, s);
set_float_default_nan_pattern(0b11000000, s);
+ set_float_e4m3_nan_is_snan(true, s);
}
/* Convert host exception flags to vfp form. */
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread* Re: [PATCH v6 23/64] target/arm: Set e4m3_nan_is_snan
2026-05-20 18:21 ` [PATCH v6 23/64] target/arm: Set e4m3_nan_is_snan Richard Henderson
@ 2026-05-21 15:12 ` Peter Maydell
2026-05-22 19:49 ` Richard Henderson
0 siblings, 1 reply; 105+ messages in thread
From: Peter Maydell @ 2026-05-21 15:12 UTC (permalink / raw)
To: Richard Henderson; +Cc: qemu-devel, qemu-arm
On Wed, 20 May 2026 at 19:25, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> The unique e4m3 nan encoding is SNaN for Arm.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/arm/tcg/vfp_helper.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/target/arm/tcg/vfp_helper.c b/target/arm/tcg/vfp_helper.c
> index 8d3f6e3a2e..c10b085f08 100644
> --- a/target/arm/tcg/vfp_helper.c
> +++ b/target/arm/tcg/vfp_helper.c
> @@ -46,6 +46,7 @@ void arm_set_default_fp_behaviours(float_status *s)
> set_float_3nan_prop_rule(float_3nan_prop_s_cab, s);
> set_float_infzeronan_rule(float_infzeronan_dnan_if_qnan, s);
> set_float_default_nan_pattern(0b01000000, s);
> + set_float_e4m3_nan_is_snan(true, s);
> }
>
> /*
> @@ -67,6 +68,7 @@ void arm_set_ah_fp_behaviours(float_status *s)
> set_float_infzeronan_rule(float_infzeronan_dnan_never |
> float_infzeronan_suppress_invalid, s);
> set_float_default_nan_pattern(0b11000000, s);
> + set_float_e4m3_nan_is_snan(true, s);
> }
>
> /* Convert host exception flags to vfp form. */
These functions are supposed to set only the bits of the
FP config that change between AH=0 and AH=1; we call them
when FPCR.AH is toggled. Conveniently, up until now all
the FP config that remains the same across AH=0 and AH=1
has been the same as the default fpu config, so we haven't
needed a place to do "initialize float_status to the other
parts of what Arm uses", and arm_cpu_reset_hold has been
able to just call one or the other of these functions starting
from a zeroed-out fp_status, and then adjust the default
NaN mode and the ftz config for a few of the fp_status words.
So ideally we should set the e4m3_nan_is_snan elsewhere,
except that setting it on all 8 of our fp_status fields
is a bit tedious. Maybe something like:
/*
* Fully initialize an fp_status to the usual Arm
* behaviours. If you want the AH=1 choices you can
* call arm_set_ah_fp_behaviours() afterwards.
*/
arm_init_fp_status(float_status *s);
and have the implementation be
*s = (float_status){};
arm_set_default_fp_behaviours(s);
set_float_e4m3_nan_is_snan(true, s);
/* We want 0 for all other settings */
?
Then reset can do
for (int i = 0; i < FPST_COUNT; i++) {
arm_init_fp_status(&env->vfp.fp_status[i]);
}
set_flush_to_zero(1, &env->vfp.fp_status[FPST_STD]);
set_flush_inputs_to_zero(1, &env->vfp.fp_status[FPST_STD]);
set_default_nan_mode(1, &env->vfp.fp_status[FPST_STD]);
set_default_nan_mode(1, &env->vfp.fp_status[FPST_STD_F16]);
set_default_nan_mode(1, &env->vfp.fp_status[FPST_ZA]);
set_default_nan_mode(1, &env->vfp.fp_status[FPST_ZA_F16]);
arm_set_ah_fp_behaviours(&env->vfp.fp_status[FPST_AH]);
set_flush_to_zero(1, &env->vfp.fp_status[FPST_AH]);
set_flush_inputs_to_zero(1, &env->vfp.fp_status[FPST_AH]);
arm_set_ah_fp_behaviours(&env->vfp.fp_status[FPST_AH_F16]);
and the code we want to add for fp8 can init its local
fp_status by calling arm_init_fp_status.
thanks
-- PMM
^ permalink raw reply [flat|nested] 105+ messages in thread* Re: [PATCH v6 23/64] target/arm: Set e4m3_nan_is_snan
2026-05-21 15:12 ` Peter Maydell
@ 2026-05-22 19:49 ` Richard Henderson
0 siblings, 0 replies; 105+ messages in thread
From: Richard Henderson @ 2026-05-22 19:49 UTC (permalink / raw)
To: Peter Maydell; +Cc: qemu-devel, qemu-arm
On 5/21/26 08:12, Peter Maydell wrote:
> /*
> * Fully initialize an fp_status to the usual Arm
> * behaviours. If you want the AH=1 choices you can
> * call arm_set_ah_fp_behaviours() afterwards.
> */
> arm_init_fp_status(float_status *s);
>
> and have the implementation be
> *s = (float_status){};
> arm_set_default_fp_behaviours(s);
> set_float_e4m3_nan_is_snan(true, s);
> /* We want 0 for all other settings */
>
> ?
>
> Then reset can do
> for (int i = 0; i < FPST_COUNT; i++) {
> arm_init_fp_status(&env->vfp.fp_status[i]);
> }
> set_flush_to_zero(1, &env->vfp.fp_status[FPST_STD]);
> set_flush_inputs_to_zero(1, &env->vfp.fp_status[FPST_STD]);
> set_default_nan_mode(1, &env->vfp.fp_status[FPST_STD]);
> set_default_nan_mode(1, &env->vfp.fp_status[FPST_STD_F16]);
> set_default_nan_mode(1, &env->vfp.fp_status[FPST_ZA]);
> set_default_nan_mode(1, &env->vfp.fp_status[FPST_ZA_F16]);
> arm_set_ah_fp_behaviours(&env->vfp.fp_status[FPST_AH]);
> set_flush_to_zero(1, &env->vfp.fp_status[FPST_AH]);
> set_flush_inputs_to_zero(1, &env->vfp.fp_status[FPST_AH]);
> arm_set_ah_fp_behaviours(&env->vfp.fp_status[FPST_AH_F16]);
I've created arm_init_fp_status, local to cpu.c, and which incorporates this mess too. I
think it's a bit clearer to read.
Setting the e4m3 knob happens in arm_init_fp_status in a separate patch.
> and the code we want to add for fp8 can init its local
> fp_status by calling arm_init_fp_status.
I wonder about that. I'm happy to keep copying so far...
r~
^ permalink raw reply [flat|nested] 105+ messages in thread
* [PATCH v6 24/64] target/arm: Implement BF1CVTL, BF1CVTL2, BF2CVTL, BF2CVTL2 for AdvSIMD
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
` (22 preceding siblings ...)
2026-05-20 18:21 ` [PATCH v6 23/64] target/arm: Set e4m3_nan_is_snan Richard Henderson
@ 2026-05-20 18:21 ` Richard Henderson
2026-05-21 16:18 ` Peter Maydell
2026-05-20 18:21 ` [PATCH v6 25/64] target/arm: Implement BF1CVT, BF1CVTLT, BF2CVT, BF2CVTLT for SVE Richard Henderson
` (39 subsequent siblings)
63 siblings, 1 reply; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:21 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/helper-fp8.h | 14 ++++
target/arm/tcg/helper-fp8-defs.h | 6 ++
target/arm/tcg/translate-a64.h | 1 +
target/arm/tcg/fp8_helper.c | 124 +++++++++++++++++++++++++++++++
target/arm/tcg/translate-a64.c | 34 +++++++++
target/arm/tcg/a64.decode | 3 +
target/arm/tcg/meson.build | 1 +
7 files changed, 183 insertions(+)
create mode 100644 target/arm/helper-fp8.h
create mode 100644 target/arm/tcg/helper-fp8-defs.h
create mode 100644 target/arm/tcg/fp8_helper.c
diff --git a/target/arm/helper-fp8.h b/target/arm/helper-fp8.h
new file mode 100644
index 0000000000..c45211ba22
--- /dev/null
+++ b/target/arm/helper-fp8.h
@@ -0,0 +1,14 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+
+#ifndef HELPER_FP8_H
+#define HELPER_FP8_H
+
+#include "exec/helper-proto-common.h"
+#include "exec/helper-gen-common.h"
+
+#define HELPER_H "tcg/helper-fp8-defs.h"
+#include "exec/helper-proto.h.inc"
+#include "exec/helper-gen.h.inc"
+#undef HELPER_H
+
+#endif /* HELPER_FP8_H */
diff --git a/target/arm/tcg/helper-fp8-defs.h b/target/arm/tcg/helper-fp8-defs.h
new file mode 100644
index 0000000000..0caaf63749
--- /dev/null
+++ b/target/arm/tcg/helper-fp8-defs.h
@@ -0,0 +1,6 @@
+/*
+ * AArch64 FP8 helper definitions
+ * SPDX-License-Identifier: GPL-2.0-or-later
+ */
+
+DEF_HELPER_FLAGS_4(advsimd_bfcvtl, TCG_CALL_NO_RWG, void, ptr, ptr, env, i32)
diff --git a/target/arm/tcg/translate-a64.h b/target/arm/tcg/translate-a64.h
index 9c45f89305..35f8d4f82e 100644
--- a/target/arm/tcg/translate-a64.h
+++ b/target/arm/tcg/translate-a64.h
@@ -25,6 +25,7 @@ TCGv_i64 read_cpu_reg_sp(DisasContext *s, int reg, int sf);
void write_fp_dreg(DisasContext *s, int reg, TCGv_i64 v);
bool logic_imm_decode_wmask(uint64_t *result, unsigned int immn,
unsigned int imms, unsigned int immr);
+bool fpmr_access_check(DisasContext *s);
bool sve_access_check(DisasContext *s);
bool sme_enabled_check(DisasContext *s);
bool sme_enabled_check_with_svcr(DisasContext *s, unsigned);
diff --git a/target/arm/tcg/fp8_helper.c b/target/arm/tcg/fp8_helper.c
new file mode 100644
index 0000000000..bb3e8dae5f
--- /dev/null
+++ b/target/arm/tcg/fp8_helper.c
@@ -0,0 +1,124 @@
+/*
+ * AArch64 FP8 Operations
+ * SPDX-License-Identifier: GPL-2.0-or-later
+ */
+
+#include "qemu/osdep.h"
+#include "cpu.h"
+#include "internals.h"
+#include "tcg/tcg-gvec-desc.h"
+#include "fpu/softfloat.h"
+#include "fpu/softfloat-parts.h"
+#include "helper-fp8.h"
+#include "vec_internal.h"
+
+#define HELPER_H "tcg/helper-fp8-defs.h"
+#include "exec/helper-info.c.inc"
+
+typedef enum FPMRType {
+ OFP8_E5M2 = 0,
+ OFP8_E4M3 = 1,
+} FPMRType;
+
+typedef struct FP8Context {
+ float_status stat;
+ ARMFPStatusFlavour fpst;
+ FPMRType f8fmt;
+ int scale;
+ bool high;
+} FP8Context;
+
+static FP8Context fp8_start(CPUARMState *env, uint32_t desc,
+ FPMRType f8fmt, int scale)
+{
+ ARMFPStatusFlavour fpst = extract32(desc, SIMD_DATA_SHIFT + 2, 4);
+
+ FP8Context ret = {
+ .stat = env->vfp.fp_status[fpst],
+ .fpst = fpst,
+ .f8fmt = f8fmt,
+ .scale = scale,
+ .high = extract32(desc, SIMD_DATA_SHIFT + 1, 1),
+ };
+
+ set_flush_to_zero(0, &ret.stat);
+ set_flush_inputs_to_zero(0, &ret.stat);
+ set_default_nan_mode(true, &ret.stat);
+ set_float_rounding_mode(float_round_nearest_even, &ret.stat);
+
+ return ret;
+}
+
+static void fp8_cvt_finish(CPUARMState *env, FP8Context *c)
+{
+ /* FP8 convert insns don't update FPSR.IDC */
+ int e = get_float_exception_flags(&c->stat);
+ float_raise(e & ~float_flag_input_denormal_used,
+ &env->vfp.fp_status[c->fpst]);
+}
+
+static FP8Context fp8_src_start(CPUARMState *env, uint32_t desc, int scale_mask)
+{
+ bool issrc2 = extract32(desc, SIMD_DATA_SHIFT, 1);
+ uint64_t fpmr = env->vfp.fpmr;
+ FPMRType f8fmt = (issrc2
+ ? FIELD_EX64(fpmr, FPMR, F8S2)
+ : FIELD_EX64(fpmr, FPMR, F8S1));
+ int scale;
+
+ scale = fpmr >> (issrc2 ? R_FPMR_LSCALE2_SHIFT : R_FPMR_LSCALE_SHIFT);
+ scale = -(scale & scale_mask);
+
+ return fp8_start(env, desc, f8fmt, scale);
+}
+
+/*
+ * Invalid input format: we could take one of the usual set of
+ * CONSTRAINED UNPREDICTABLE options for use of a reserved value,
+ * but choose to take the additional option provided by the FPMR
+ * register specification, of treating the input as if it were an SNaN.
+ *
+ * One of the uses of the input will convert to default nan (because
+ * all fp8 operations use default_nan_mode) and raise invalid (which
+ * the operation might suppress by not updating IOC).
+ */
+static FloatParts64 fp8_invalid_input(uint8_t x, float_status *s)
+{
+ return (FloatParts64){ .cls = float_class_snan };
+}
+
+typedef FloatParts64 fp8_input_fn(uint8_t x, float_status *s);
+
+static fp8_input_fn * const fp8_input_fmt[8] = {
+ [0 ... 7] = fp8_invalid_input,
+ [OFP8_E5M2] = float8_e5m2_unpack_canonical,
+ [OFP8_E4M3] = float8_e4m3_unpack_canonical,
+};
+
+static bfloat16 fcvt_fp8_to_b16(uint8_t x, fp8_input_fn *f8fmt,
+ int scale, float_status *s)
+{
+ FloatParts64 p = f8fmt(x, s);
+ p = parts64_scalbn(&p, scale, s);
+ return bfloat16_round_pack_canonical(&p, s);
+}
+
+void HELPER(advsimd_bfcvtl)(void *vd, void *vn, CPUARMState *env, uint32_t desc)
+{
+ FP8Context ctx = fp8_src_start(env, desc, 0x3f);
+ fp8_input_fn *input_fmt = fp8_input_fmt[ctx.f8fmt];
+ uint8_t *n = vn, scratch[16];
+ bfloat16 *d = vd;
+
+ if (vd == vn) {
+ n = memcpy(scratch, vn, 16);
+ }
+ n += ctx.high * 8;
+
+ for (size_t i = 0; i < 8; ++i) {
+ d[H2(i)] = fcvt_fp8_to_b16(n[H1(i)], input_fmt, ctx.scale, &ctx.stat);
+ }
+
+ fp8_cvt_finish(env, &ctx);
+ clear_tail(vd, 16, simd_maxsz(desc));
+}
diff --git a/target/arm/tcg/translate-a64.c b/target/arm/tcg/translate-a64.c
index ac18ceeeab..085e7e3b95 100644
--- a/target/arm/tcg/translate-a64.c
+++ b/target/arm/tcg/translate-a64.c
@@ -22,6 +22,7 @@
#include "helper-a64.h"
#include "helper-sme.h"
#include "helper-sve.h"
+#include "helper-fp8.h"
#include "translate.h"
#include "translate-a64.h"
#include "tcg/tcg-op.h"
@@ -1457,6 +1458,24 @@ static bool fp_access_check(DisasContext *s)
return fp_access_check_only(s) && nonstreaming_check(s);
}
+/*
+ * Check that FPMR access is enabled, for an indirect reference by a
+ * vector instruction. See CheckFPMREnabled().
+ */
+bool fpmr_access_check(DisasContext *s)
+{
+ if (s->fpmr_el) {
+ /*
+ * While denied direct access to the FPMR raises SystemRegisterTrap
+ * and targets a specific EL, denied indirect access to the FPMR
+ * results in a simple UNDEFINED to the default exception level.
+ */
+ unallocated_encoding(s);
+ return false;
+ }
+ return true;
+}
+
/*
* Return <0 for non-supported element sizes, with MO_16 controlled by
* FEAT_FP16; return 0 for fp disabled; otherwise return >0 for success.
@@ -10612,6 +10631,21 @@ static bool trans_FCVTL_v(DisasContext *s, arg_qrr_e *a)
return true;
}
+static bool do_f8cvt(DisasContext *s, arg_qrr_e *a,
+ gen_helper_gvec_2_ptr *fn, bool issrc2)
+{
+ if (fpmr_access_check(s) && fp_access_check(s)) {
+ tcg_gen_gvec_2_ptr(vec_full_reg_offset(s, a->rd),
+ vec_full_reg_offset(s, a->rn),
+ tcg_env, 16, vec_full_reg_size(s),
+ issrc2 | (a->q << 1) | (FPST_A64 << 2), fn);
+ }
+ return true;
+}
+
+TRANS_FEAT(BF1CVTL, aa64_f8cvt, do_f8cvt, a, gen_helper_advsimd_bfcvtl, false)
+TRANS_FEAT(BF2CVTL, aa64_f8cvt, do_f8cvt, a, gen_helper_advsimd_bfcvtl, true)
+
static bool trans_OK(DisasContext *s, arg_OK *a)
{
return true;
diff --git a/target/arm/tcg/a64.decode b/target/arm/tcg/a64.decode
index 02c7264cb9..b7aac148f2 100644
--- a/target/arm/tcg/a64.decode
+++ b/target/arm/tcg/a64.decode
@@ -1910,6 +1910,9 @@ URSQRTE_v 0.10 1110 101 00001 11001 0 ..... ..... @qrr_s
FCVTL_v 0.00 1110 0.1 00001 01111 0 ..... ..... @qrr_sd
+BF1CVTL 0.10 1110 101 00001 01111 0 ..... ..... @qrr_h
+BF2CVTL 0.10 1110 111 00001 01111 0 ..... ..... @qrr_h
+
&fcvt_q rd rn esz q shift
@fcvtq_h . q:1 . ...... 001 .... ...... rn:5 rd:5 \
&fcvt_q esz=1 shift=%fcvt_f_sh_h
diff --git a/target/arm/tcg/meson.build b/target/arm/tcg/meson.build
index 1b751d5918..c1b3d8e340 100644
--- a/target/arm/tcg/meson.build
+++ b/target/arm/tcg/meson.build
@@ -46,6 +46,7 @@ arm_ss.add(when: 'TARGET_AARCH64', if_true: files(
'sme_helper.c',
'sve_helper.c',
'vec_helper64.c',
+ 'fp8_helper.c',
))
arm_common_system_ss.add(when: 'CONFIG_ARM_V7M', if_true: files('cpu-v7m.c'))
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread* Re: [PATCH v6 24/64] target/arm: Implement BF1CVTL, BF1CVTL2, BF2CVTL, BF2CVTL2 for AdvSIMD
2026-05-20 18:21 ` [PATCH v6 24/64] target/arm: Implement BF1CVTL, BF1CVTL2, BF2CVTL, BF2CVTL2 for AdvSIMD Richard Henderson
@ 2026-05-21 16:18 ` Peter Maydell
0 siblings, 0 replies; 105+ messages in thread
From: Peter Maydell @ 2026-05-21 16:18 UTC (permalink / raw)
To: Richard Henderson; +Cc: qemu-devel, qemu-arm
On Wed, 20 May 2026 at 19:25, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/arm/helper-fp8.h | 14 ++++
> target/arm/tcg/helper-fp8-defs.h | 6 ++
> target/arm/tcg/translate-a64.h | 1 +
> target/arm/tcg/fp8_helper.c | 124 +++++++++++++++++++++++++++++++
> target/arm/tcg/translate-a64.c | 34 +++++++++
> target/arm/tcg/a64.decode | 3 +
> target/arm/tcg/meson.build | 1 +
> 7 files changed, 183 insertions(+)
> create mode 100644 target/arm/helper-fp8.h
> create mode 100644 target/arm/tcg/helper-fp8-defs.h
> create mode 100644 target/arm/tcg/fp8_helper.c
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
^ permalink raw reply [flat|nested] 105+ messages in thread
* [PATCH v6 25/64] target/arm: Implement BF1CVT, BF1CVTLT, BF2CVT, BF2CVTLT for SVE
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
` (23 preceding siblings ...)
2026-05-20 18:21 ` [PATCH v6 24/64] target/arm: Implement BF1CVTL, BF1CVTL2, BF2CVTL, BF2CVTL2 for AdvSIMD Richard Henderson
@ 2026-05-20 18:21 ` Richard Henderson
2026-05-21 16:37 ` Peter Maydell
2026-05-20 18:21 ` [PATCH v6 26/64] target/arm: Rename SME BFCVT patterns to BFCVT_hs Richard Henderson
` (38 subsequent siblings)
63 siblings, 1 reply; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:21 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/cpu-features.h | 6 ++++++
target/arm/tcg/helper-fp8-defs.h | 1 +
target/arm/tcg/fp8_helper.c | 16 ++++++++++++++++
target/arm/tcg/translate-sve.c | 23 +++++++++++++++++++++++
target/arm/tcg/sve.decode | 6 ++++++
5 files changed, 52 insertions(+)
diff --git a/target/arm/cpu-features.h b/target/arm/cpu-features.h
index f9c979d20b..fd09bbc5cf 100644
--- a/target/arm/cpu-features.h
+++ b/target/arm/cpu-features.h
@@ -1643,6 +1643,12 @@ isar_feature_aa64_sme2_or_sve2_faminmax(const ARMISARegisters *id)
return isar_feature_aa64_sme2_or_sve2(id) && isar_feature_aa64_faminmax(id);
}
+static inline bool
+isar_feature_aa64_sme2_or_sve2_f8cvt(const ARMISARegisters *id)
+{
+ return isar_feature_aa64_sme2_or_sve2(id) && isar_feature_aa64_f8cvt(id);
+}
+
/*
* Feature tests for "does this exist in either 32-bit or 64-bit?"
*/
diff --git a/target/arm/tcg/helper-fp8-defs.h b/target/arm/tcg/helper-fp8-defs.h
index 0caaf63749..18ff483bb0 100644
--- a/target/arm/tcg/helper-fp8-defs.h
+++ b/target/arm/tcg/helper-fp8-defs.h
@@ -4,3 +4,4 @@
*/
DEF_HELPER_FLAGS_4(advsimd_bfcvtl, TCG_CALL_NO_RWG, void, ptr, ptr, env, i32)
+DEF_HELPER_FLAGS_4(sve2_bfcvt, TCG_CALL_NO_RWG, void, ptr, ptr, env, i32)
diff --git a/target/arm/tcg/fp8_helper.c b/target/arm/tcg/fp8_helper.c
index bb3e8dae5f..c62fb2ffd6 100644
--- a/target/arm/tcg/fp8_helper.c
+++ b/target/arm/tcg/fp8_helper.c
@@ -122,3 +122,19 @@ void HELPER(advsimd_bfcvtl)(void *vd, void *vn, CPUARMState *env, uint32_t desc)
fp8_cvt_finish(env, &ctx);
clear_tail(vd, 16, simd_maxsz(desc));
}
+
+void HELPER(sve2_bfcvt)(void *vd, void *vn, CPUARMState *env, uint32_t desc)
+{
+ FP8Context ctx = fp8_src_start(env, desc, 0x3f);
+ fp8_input_fn *input_fmt = fp8_input_fmt[ctx.f8fmt];
+ uint8_t *n = vn;
+ uint16_t *d = vd;
+ size_t nelem = simd_oprsz(desc) / 2;
+
+ for (size_t i = 0; i < nelem; ++i) {
+ d[H2(i)] = fcvt_fp8_to_b16(n[H1(2 * i + ctx.high)],
+ input_fmt, ctx.scale, &ctx.stat);
+ }
+
+ fp8_cvt_finish(env, &ctx);
+}
diff --git a/target/arm/tcg/translate-sve.c b/target/arm/tcg/translate-sve.c
index db32230595..9bab5feb93 100644
--- a/target/arm/tcg/translate-sve.c
+++ b/target/arm/tcg/translate-sve.c
@@ -21,6 +21,7 @@
#include "cpu.h"
#include "helper-sme.h"
#include "helper-sve.h"
+#include "helper-fp8.h"
#include "translate.h"
#include "translate-a64.h"
#include "tcg/tcg-op.h"
@@ -4067,6 +4068,28 @@ TRANS_FEAT(FRSQRTE, aa64_sme_or_sve, gen_gvec_fpst_ah_arg_zz,
s->fpcr_ah && dc_isar_feature(aa64_rpres, s) ?
frsqrte_rpres_fns[a->esz] : frsqrte_fns[a->esz], a, 0)
+static bool do_f8cvt(DisasContext *s, arg_rr_esz *a,
+ gen_helper_gvec_2_ptr *fn, bool issrc2, bool isodd)
+{
+ if (fpmr_access_check(s) && sve_access_check(s)) {
+ unsigned vsz = vec_full_reg_size(s);
+ tcg_gen_gvec_2_ptr(vec_full_reg_offset(s, a->rd),
+ vec_full_reg_offset(s, a->rn),
+ tcg_env, vsz, vsz,
+ issrc2 | (isodd << 1) | (FPST_A64 << 2), fn);
+ }
+ return true;
+}
+
+TRANS_FEAT(BF1CVT, aa64_sme2_or_sve2_f8cvt, do_f8cvt, a,
+ gen_helper_sve2_bfcvt, false, false)
+TRANS_FEAT(BF2CVT, aa64_sme2_or_sve2_f8cvt, do_f8cvt, a,
+ gen_helper_sve2_bfcvt, true, false)
+TRANS_FEAT(BF1CVTLT, aa64_sme2_or_sve2_f8cvt, do_f8cvt, a,
+ gen_helper_sve2_bfcvt, false, true)
+TRANS_FEAT(BF2CVTLT, aa64_sme2_or_sve2_f8cvt, do_f8cvt, a,
+ gen_helper_sve2_bfcvt, true, true)
+
/*
*** SVE Floating Point Compare with Zero Group
*/
diff --git a/target/arm/tcg/sve.decode b/target/arm/tcg/sve.decode
index 078a085a79..e7984fa8e0 100644
--- a/target/arm/tcg/sve.decode
+++ b/target/arm/tcg/sve.decode
@@ -108,6 +108,7 @@
# Two operand
@pd_pn ........ esz:2 .. .... ....... rn:4 . rd:4 &rr_esz
@rd_rn ........ esz:2 ...... ...... rn:5 rd:5 &rr_esz
+@rd_rn_e0 ........ .. ...... ...... rn:5 rd:5 &rr_esz esz=0
@rd_rnx2 ........ ... ..... ...... ..... rd:5 &rr_esz rn=%rn_ax2
# Two operand with governing predicate, flags setting
@@ -1090,6 +1091,11 @@ FMINQV 01100100 .. 010 111 101 ... ..... ..... @rd_pg_rn
FRECPE 01100101 .. 001 110 001100 ..... ..... @rd_rn
FRSQRTE 01100101 .. 001 111 001100 ..... ..... @rd_rn
+BF1CVT 01100101 00 001 000 001110 ..... ..... @rd_rn_e0
+BF2CVT 01100101 00 001 000 001111 ..... ..... @rd_rn_e0
+BF1CVTLT 01100101 00 001 001 001110 ..... ..... @rd_rn_e0
+BF2CVTLT 01100101 00 001 001 001111 ..... ..... @rd_rn_e0
+
### SVE FP Compare with Zero Group
FCMGE_ppz0 01100101 .. 0100 00 001 ... ..... 0 .... @pd_pg_rn
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread* Re: [PATCH v6 25/64] target/arm: Implement BF1CVT, BF1CVTLT, BF2CVT, BF2CVTLT for SVE
2026-05-20 18:21 ` [PATCH v6 25/64] target/arm: Implement BF1CVT, BF1CVTLT, BF2CVT, BF2CVTLT for SVE Richard Henderson
@ 2026-05-21 16:37 ` Peter Maydell
2026-05-22 19:53 ` Richard Henderson
0 siblings, 1 reply; 105+ messages in thread
From: Peter Maydell @ 2026-05-21 16:37 UTC (permalink / raw)
To: Richard Henderson; +Cc: qemu-devel, qemu-arm
On Wed, 20 May 2026 at 19:26, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/arm/cpu-features.h | 6 ++++++
> target/arm/tcg/helper-fp8-defs.h | 1 +
> target/arm/tcg/fp8_helper.c | 16 ++++++++++++++++
> target/arm/tcg/translate-sve.c | 23 +++++++++++++++++++++++
> target/arm/tcg/sve.decode | 6 ++++++
> 5 files changed, 52 insertions(+)
> +static bool do_f8cvt(DisasContext *s, arg_rr_esz *a,
> + gen_helper_gvec_2_ptr *fn, bool issrc2, bool isodd)
> +{
> + if (fpmr_access_check(s) && sve_access_check(s)) {
> + unsigned vsz = vec_full_reg_size(s);
> + tcg_gen_gvec_2_ptr(vec_full_reg_offset(s, a->rd),
> + vec_full_reg_offset(s, a->rn),
> + tcg_env, vsz, vsz,
> + issrc2 | (isodd << 1) | (FPST_A64 << 2), fn);
> + }
> + return true;
> +}
> +
> +TRANS_FEAT(BF1CVT, aa64_sme2_or_sve2_f8cvt, do_f8cvt, a,
> + gen_helper_sve2_bfcvt, false, false)
> +TRANS_FEAT(BF2CVT, aa64_sme2_or_sve2_f8cvt, do_f8cvt, a,
> + gen_helper_sve2_bfcvt, true, false)
> +TRANS_FEAT(BF1CVTLT, aa64_sme2_or_sve2_f8cvt, do_f8cvt, a,
> + gen_helper_sve2_bfcvt, false, true)
> +TRANS_FEAT(BF2CVTLT, aa64_sme2_or_sve2_f8cvt, do_f8cvt, a,
> + gen_helper_sve2_bfcvt, true, true)
Again, I'm not sure if this gets the "only legal in streaming
mode from SME2" logic right, but otherwise this looks good.
-- PMM
^ permalink raw reply [flat|nested] 105+ messages in thread* Re: [PATCH v6 25/64] target/arm: Implement BF1CVT, BF1CVTLT, BF2CVT, BF2CVTLT for SVE
2026-05-21 16:37 ` Peter Maydell
@ 2026-05-22 19:53 ` Richard Henderson
0 siblings, 0 replies; 105+ messages in thread
From: Richard Henderson @ 2026-05-22 19:53 UTC (permalink / raw)
To: Peter Maydell; +Cc: qemu-devel, qemu-arm
On 5/21/26 09:37, Peter Maydell wrote:
>> +TRANS_FEAT(BF1CVT, aa64_sme2_or_sve2_f8cvt, do_f8cvt, a,
>> + gen_helper_sve2_bfcvt, false, false)
>> +TRANS_FEAT(BF2CVT, aa64_sme2_or_sve2_f8cvt, do_f8cvt, a,
>> + gen_helper_sve2_bfcvt, true, false)
>> +TRANS_FEAT(BF1CVTLT, aa64_sme2_or_sve2_f8cvt, do_f8cvt, a,
>> + gen_helper_sve2_bfcvt, false, true)
>> +TRANS_FEAT(BF2CVTLT, aa64_sme2_or_sve2_f8cvt, do_f8cvt, a,
>> + gen_helper_sve2_bfcvt, true, true)
>
> Again, I'm not sure if this gets the "only legal in streaming
> mode from SME2" logic right, but otherwise this looks good.
Fixed.
r~
^ permalink raw reply [flat|nested] 105+ messages in thread
* [PATCH v6 26/64] target/arm: Rename SME BFCVT patterns to BFCVT_hs
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
` (24 preceding siblings ...)
2026-05-20 18:21 ` [PATCH v6 25/64] target/arm: Implement BF1CVT, BF1CVTLT, BF2CVT, BF2CVTLT for SVE Richard Henderson
@ 2026-05-20 18:21 ` Richard Henderson
2026-05-21 16:39 ` Peter Maydell
2026-05-20 18:21 ` [PATCH v6 27/64] target/arm: Implement BF1CVT, BF1CVTL, BF2CVT, BF2CVTL for SME Richard Henderson
` (37 subsequent siblings)
63 siblings, 1 reply; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:21 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm
The existing pattern is BFCVT (single-precision to BFloat16).
In preparation for introducing more insns of the same name,
append the operand sizes.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/tcg/helper-sme-defs.h | 2 +-
target/arm/tcg/sme_helper.c | 2 +-
target/arm/tcg/translate-sme.c | 4 ++--
target/arm/tcg/sme.decode | 2 +-
4 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/target/arm/tcg/helper-sme-defs.h b/target/arm/tcg/helper-sme-defs.h
index c551797c6f..01aad4c231 100644
--- a/target/arm/tcg/helper-sme-defs.h
+++ b/target/arm/tcg/helper-sme-defs.h
@@ -250,7 +250,7 @@ DEF_HELPER_FLAGS_5(sme2_umlsll_idx_d, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, ptr,
DEF_HELPER_FLAGS_5(sme2_usmlall_idx_s, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, ptr, i32)
DEF_HELPER_FLAGS_5(sme2_sumlall_idx_s, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, ptr, i32)
-DEF_HELPER_FLAGS_4(sme2_bfcvt, TCG_CALL_NO_RWG, void, ptr, ptr, fpst, i32)
+DEF_HELPER_FLAGS_4(sme2_bfcvt_hs, TCG_CALL_NO_RWG, void, ptr, ptr, fpst, i32)
DEF_HELPER_FLAGS_4(sme2_bfcvtn, TCG_CALL_NO_RWG, void, ptr, ptr, fpst, i32)
DEF_HELPER_FLAGS_4(sme2_fcvt_n, TCG_CALL_NO_RWG, void, ptr, ptr, fpst, i32)
DEF_HELPER_FLAGS_4(sme2_fcvtn, TCG_CALL_NO_RWG, void, ptr, ptr, fpst, i32)
diff --git a/target/arm/tcg/sme_helper.c b/target/arm/tcg/sme_helper.c
index 0055e97a2b..a0f03c4671 100644
--- a/target/arm/tcg/sme_helper.c
+++ b/target/arm/tcg/sme_helper.c
@@ -1742,7 +1742,7 @@ DO_MLALL_IDX(sme2_sumlall_idx_s, uint32_t, int8_t, uint8_t, H4, H1, +)
#undef DO_MLALL_IDX
/* Convert and compress */
-void HELPER(sme2_bfcvt)(void *vd, void *vs, float_status *fpst, uint32_t desc)
+void HELPER(sme2_bfcvt_hs)(void *vd, void *vs, float_status *fpst, uint32_t desc)
{
ARMVectorReg scratch;
size_t oprsz = simd_oprsz(desc);
diff --git a/target/arm/tcg/translate-sme.c b/target/arm/tcg/translate-sme.c
index e2d17de165..88c1d78c40 100644
--- a/target/arm/tcg/translate-sme.c
+++ b/target/arm/tcg/translate-sme.c
@@ -1448,8 +1448,8 @@ static bool do_zz_fpst(DisasContext *s, arg_zz_n *a, int data,
return true;
}
-TRANS_FEAT(BFCVT, aa64_sme2, do_zz_fpst, a, 0,
- FPST_A64, gen_helper_sme2_bfcvt)
+TRANS_FEAT(BFCVT_hs, aa64_sme2, do_zz_fpst, a, 0,
+ FPST_A64, gen_helper_sme2_bfcvt_hs)
TRANS_FEAT(BFCVTN, aa64_sme2, do_zz_fpst, a, 0,
FPST_A64, gen_helper_sme2_bfcvtn)
TRANS_FEAT(FCVT_n, aa64_sme2, do_zz_fpst, a, 0,
diff --git a/target/arm/tcg/sme.decode b/target/arm/tcg/sme.decode
index ee874be1a6..7a8e1abb59 100644
--- a/target/arm/tcg/sme.decode
+++ b/target/arm/tcg/sme.decode
@@ -789,7 +789,7 @@ SUB_aaz_d 11000001 111 000010 .. 111 ...00 11 ... @az_4x4_o3
@zz_4x2_n1 ........ ... ..... ...... .... . ..... \
&zz_n n=1 zd=%zd_ax4 zn=%zn_ax2
-BFCVT 11000001 011 00000 111000 ....0 ..... @zz_1x2
+BFCVT_hs 11000001 011 00000 111000 ....0 ..... @zz_1x2
BFCVTN 11000001 011 00000 111000 ....1 ..... @zz_1x2
FCVT_n 11000001 001 00000 111000 ....0 ..... @zz_1x2
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread* [PATCH v6 27/64] target/arm: Implement BF1CVT, BF1CVTL, BF2CVT, BF2CVTL for SME
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
` (25 preceding siblings ...)
2026-05-20 18:21 ` [PATCH v6 26/64] target/arm: Rename SME BFCVT patterns to BFCVT_hs Richard Henderson
@ 2026-05-20 18:21 ` Richard Henderson
2026-05-20 18:21 ` [PATCH v6 28/64] target/arm: Implement F1CVTL, F1CVTL2, F2CVTL, F2CVTL2 for AdvSIMD Richard Henderson
` (36 subsequent siblings)
63 siblings, 0 replies; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:21 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/tcg/helper-fp8-defs.h | 2 ++
target/arm/tcg/fp8_helper.c | 47 ++++++++++++++++++++++++++++++++
target/arm/tcg/translate-sme.c | 19 +++++++++++++
target/arm/tcg/sme.decode | 5 ++++
4 files changed, 73 insertions(+)
diff --git a/target/arm/tcg/helper-fp8-defs.h b/target/arm/tcg/helper-fp8-defs.h
index 18ff483bb0..966f83d796 100644
--- a/target/arm/tcg/helper-fp8-defs.h
+++ b/target/arm/tcg/helper-fp8-defs.h
@@ -5,3 +5,5 @@
DEF_HELPER_FLAGS_4(advsimd_bfcvtl, TCG_CALL_NO_RWG, void, ptr, ptr, env, i32)
DEF_HELPER_FLAGS_4(sve2_bfcvt, TCG_CALL_NO_RWG, void, ptr, ptr, env, i32)
+DEF_HELPER_FLAGS_4(sme2_bfcvt_hb, TCG_CALL_NO_RWG, void, ptr, ptr, env, i32)
+DEF_HELPER_FLAGS_4(sme2_bfcvtl_hb, TCG_CALL_NO_RWG, void, ptr, ptr, env, i32)
diff --git a/target/arm/tcg/fp8_helper.c b/target/arm/tcg/fp8_helper.c
index c62fb2ffd6..aad03b0817 100644
--- a/target/arm/tcg/fp8_helper.c
+++ b/target/arm/tcg/fp8_helper.c
@@ -138,3 +138,50 @@ void HELPER(sve2_bfcvt)(void *vd, void *vn, CPUARMState *env, uint32_t desc)
fp8_cvt_finish(env, &ctx);
}
+
+void HELPER(sme2_bfcvt_hb)(void *vd, void *vn, CPUARMState *env, uint32_t desc)
+{
+ FP8Context ctx = fp8_src_start(env, desc, 0x3f);
+ fp8_input_fn *input_fmt = fp8_input_fmt[ctx.f8fmt];
+ uint8_t *n = vn;
+ uint16_t *d0 = vd;
+ uint16_t *d1 = vd + sizeof(ARMVectorReg);
+ size_t oprsz = simd_oprsz(desc);
+ size_t nelem = oprsz / 2;
+ ARMVectorReg scratch;
+
+ if (vectors_overlap(vd, 2, vn, 1)) {
+ n = memcpy(&scratch, vn, oprsz);
+ }
+
+ for (size_t i = 0; i < nelem; ++i) {
+ d0[H2(i)] = fcvt_fp8_to_b16(n[H1(i)], input_fmt,
+ ctx.scale, &ctx.stat);
+ }
+ for (size_t i = 0; i < nelem; ++i) {
+ d1[H2(i)] = fcvt_fp8_to_b16(n[H1(i + nelem)], input_fmt,
+ ctx.scale, &ctx.stat);
+ }
+
+ fp8_cvt_finish(env, &ctx);
+}
+
+void HELPER(sme2_bfcvtl_hb)(void *vd, void *vn, CPUARMState *env, uint32_t desc)
+{
+ FP8Context ctx = fp8_src_start(env, desc, 0x3f);
+ fp8_input_fn *input_fmt = fp8_input_fmt[ctx.f8fmt];
+ uint8_t *n = vn;
+ uint16_t *d0 = vd;
+ uint16_t *d1 = vd + sizeof(ARMVectorReg);
+ size_t oprsz = simd_oprsz(desc);
+ size_t nelem = oprsz / 2;
+
+ for (size_t i = 0; i < nelem; ++i) {
+ uint8_t e0 = n[H1(2 * i + 0)];
+ uint8_t e1 = n[H1(2 * i + 1)];
+ d0[H2(i)] = fcvt_fp8_to_b16(e0, input_fmt, ctx.scale, &ctx.stat);
+ d1[H2(i)] = fcvt_fp8_to_b16(e1, input_fmt, ctx.scale, &ctx.stat);
+ }
+
+ fp8_cvt_finish(env, &ctx);
+}
diff --git a/target/arm/tcg/translate-sme.c b/target/arm/tcg/translate-sme.c
index 88c1d78c40..2841b2b8cb 100644
--- a/target/arm/tcg/translate-sme.c
+++ b/target/arm/tcg/translate-sme.c
@@ -22,6 +22,7 @@
#include "helper-a64.h"
#include "helper-sme.h"
#include "helper-sve.h"
+#include "helper-fp8.h"
#include "translate.h"
#include "translate-a64.h"
#include "tcg/tcg-op.h"
@@ -1532,6 +1533,24 @@ TRANS_FEAT(UUNPK_4bh, aa64_sme2, do_zz, a, 0, gen_helper_sme2_uunpk4_bh)
TRANS_FEAT(UUNPK_4hs, aa64_sme2, do_zz, a, 0, gen_helper_sme2_uunpk4_hs)
TRANS_FEAT(UUNPK_4sd, aa64_sme2, do_zz, a, 0, gen_helper_sme2_uunpk4_sd)
+static bool do_f8cvt(DisasContext *s, arg_zz_n *a,
+ gen_helper_gvec_2_ptr *fn, bool issrc2)
+{
+ if (fpmr_access_check(s) && sme_sm_enabled_check(s)) {
+ int svl = streaming_vec_reg_size(s);
+ tcg_gen_gvec_2_ptr(vec_full_reg_offset(s, a->zd),
+ vec_full_reg_offset(s, a->zn),
+ tcg_env, svl, svl,
+ issrc2 | (FPST_ZA << 2), fn);
+ }
+ return true;
+}
+
+TRANS_FEAT(BF1CVT, aa64_sme2_f8cvt, do_f8cvt, a, gen_helper_sme2_bfcvt_hb, 0)
+TRANS_FEAT(BF2CVT, aa64_sme2_f8cvt, do_f8cvt, a, gen_helper_sme2_bfcvt_hb, 1)
+TRANS_FEAT(BF1CVTL, aa64_sme2_f8cvt, do_f8cvt, a, gen_helper_sme2_bfcvtl_hb, 0)
+TRANS_FEAT(BF2CVTL, aa64_sme2_f8cvt, do_f8cvt, a, gen_helper_sme2_bfcvtl_hb, 1)
+
static bool do_zipuzp_4(DisasContext *s, arg_zz_e *a,
gen_helper_gvec_2 * const fn[5])
{
diff --git a/target/arm/tcg/sme.decode b/target/arm/tcg/sme.decode
index 7a8e1abb59..df9586c1a5 100644
--- a/target/arm/tcg/sme.decode
+++ b/target/arm/tcg/sme.decode
@@ -853,6 +853,11 @@ UUNPK_4bh 11000001 011 10101 111000 ....0 ...01 @zz_4x2_n1
UUNPK_4hs 11000001 101 10101 111000 ....0 ...01 @zz_4x2_n1
UUNPK_4sd 11000001 111 10101 111000 ....0 ...01 @zz_4x2_n1
+BF1CVT 11000001 011 00110 111000 ..... ....0 @zz_2x1
+BF2CVT 11000001 111 00110 111000 ..... ....0 @zz_2x1
+BF1CVTL 11000001 011 00110 111000 ..... ....1 @zz_2x1
+BF2CVTL 11000001 111 00110 111000 ..... ....1 @zz_2x1
+
ZIP_4 11000001 esz:2 1 10110 111000 ...00 ... 00 \
&zz_e zd=%zd_ax4 zn=%zn_ax4
ZIP_4 11000001 001 10111 111000 ...00 ... 00 \
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread* [PATCH v6 28/64] target/arm: Implement F1CVTL, F1CVTL2, F2CVTL, F2CVTL2 for AdvSIMD
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
` (26 preceding siblings ...)
2026-05-20 18:21 ` [PATCH v6 27/64] target/arm: Implement BF1CVT, BF1CVTL, BF2CVT, BF2CVTL for SME Richard Henderson
@ 2026-05-20 18:21 ` Richard Henderson
2026-05-20 18:21 ` [PATCH v6 29/64] target/arm: Implement F1CVT, F1CVTLT, F2CVT, F2CVTLT for SVE Richard Henderson
` (35 subsequent siblings)
63 siblings, 0 replies; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:21 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/tcg/helper-fp8-defs.h | 2 ++
target/arm/tcg/fp8_helper.c | 29 +++++++++++++++++++++++++++++
target/arm/tcg/translate-a64.c | 3 +++
target/arm/tcg/a64.decode | 3 +++
4 files changed, 37 insertions(+)
diff --git a/target/arm/tcg/helper-fp8-defs.h b/target/arm/tcg/helper-fp8-defs.h
index 966f83d796..718463422b 100644
--- a/target/arm/tcg/helper-fp8-defs.h
+++ b/target/arm/tcg/helper-fp8-defs.h
@@ -7,3 +7,5 @@ DEF_HELPER_FLAGS_4(advsimd_bfcvtl, TCG_CALL_NO_RWG, void, ptr, ptr, env, i32)
DEF_HELPER_FLAGS_4(sve2_bfcvt, TCG_CALL_NO_RWG, void, ptr, ptr, env, i32)
DEF_HELPER_FLAGS_4(sme2_bfcvt_hb, TCG_CALL_NO_RWG, void, ptr, ptr, env, i32)
DEF_HELPER_FLAGS_4(sme2_bfcvtl_hb, TCG_CALL_NO_RWG, void, ptr, ptr, env, i32)
+
+DEF_HELPER_FLAGS_4(advsimd_fcvtl_hb, TCG_CALL_NO_RWG, void, ptr, ptr, env, i32)
diff --git a/target/arm/tcg/fp8_helper.c b/target/arm/tcg/fp8_helper.c
index aad03b0817..0f3c279696 100644
--- a/target/arm/tcg/fp8_helper.c
+++ b/target/arm/tcg/fp8_helper.c
@@ -103,6 +103,14 @@ static bfloat16 fcvt_fp8_to_b16(uint8_t x, fp8_input_fn *f8fmt,
return bfloat16_round_pack_canonical(&p, s);
}
+static float16 fcvt_fp8_to_f16(uint8_t x, fp8_input_fn *f8fmt,
+ int scale, float_status *s)
+{
+ FloatParts64 p = f8fmt(x, s);
+ p = parts64_scalbn(&p, scale, s);
+ return float16_round_pack_canonical(&p, s);
+}
+
void HELPER(advsimd_bfcvtl)(void *vd, void *vn, CPUARMState *env, uint32_t desc)
{
FP8Context ctx = fp8_src_start(env, desc, 0x3f);
@@ -123,6 +131,27 @@ void HELPER(advsimd_bfcvtl)(void *vd, void *vn, CPUARMState *env, uint32_t desc)
clear_tail(vd, 16, simd_maxsz(desc));
}
+void HELPER(advsimd_fcvtl_hb)(void *vd, void *vn,
+ CPUARMState *env, uint32_t desc)
+{
+ FP8Context ctx = fp8_src_start(env, desc, 0xf);
+ fp8_input_fn *input_fmt = fp8_input_fmt[ctx.f8fmt];
+ uint8_t *n = vn, scratch[16];
+ float16 *d = vd;
+
+ if (vd == vn) {
+ n = memcpy(scratch, vn, 16);
+ }
+ n += ctx.high * 8;
+
+ for (size_t i = 0; i < 8; ++i) {
+ d[H2(i)] = fcvt_fp8_to_f16(n[H1(i)], input_fmt, ctx.scale, &ctx.stat);
+ }
+
+ fp8_cvt_finish(env, &ctx);
+ clear_tail(vd, 16, simd_maxsz(desc));
+}
+
void HELPER(sve2_bfcvt)(void *vd, void *vn, CPUARMState *env, uint32_t desc)
{
FP8Context ctx = fp8_src_start(env, desc, 0x3f);
diff --git a/target/arm/tcg/translate-a64.c b/target/arm/tcg/translate-a64.c
index 085e7e3b95..565053a1a4 100644
--- a/target/arm/tcg/translate-a64.c
+++ b/target/arm/tcg/translate-a64.c
@@ -10643,6 +10643,9 @@ static bool do_f8cvt(DisasContext *s, arg_qrr_e *a,
return true;
}
+TRANS_FEAT(F1CVTL, aa64_f8cvt, do_f8cvt, a, gen_helper_advsimd_fcvtl_hb, false)
+TRANS_FEAT(F2CVTL, aa64_f8cvt, do_f8cvt, a, gen_helper_advsimd_fcvtl_hb, true)
+
TRANS_FEAT(BF1CVTL, aa64_f8cvt, do_f8cvt, a, gen_helper_advsimd_bfcvtl, false)
TRANS_FEAT(BF2CVTL, aa64_f8cvt, do_f8cvt, a, gen_helper_advsimd_bfcvtl, true)
diff --git a/target/arm/tcg/a64.decode b/target/arm/tcg/a64.decode
index b7aac148f2..26d31d0a33 100644
--- a/target/arm/tcg/a64.decode
+++ b/target/arm/tcg/a64.decode
@@ -1910,6 +1910,9 @@ URSQRTE_v 0.10 1110 101 00001 11001 0 ..... ..... @qrr_s
FCVTL_v 0.00 1110 0.1 00001 01111 0 ..... ..... @qrr_sd
+F1CVTL 0.10 1110 001 00001 01111 0 ..... ..... @qrr_h
+F2CVTL 0.10 1110 011 00001 01111 0 ..... ..... @qrr_h
+
BF1CVTL 0.10 1110 101 00001 01111 0 ..... ..... @qrr_h
BF2CVTL 0.10 1110 111 00001 01111 0 ..... ..... @qrr_h
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread* [PATCH v6 29/64] target/arm: Implement F1CVT, F1CVTLT, F2CVT, F2CVTLT for SVE
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
` (27 preceding siblings ...)
2026-05-20 18:21 ` [PATCH v6 28/64] target/arm: Implement F1CVTL, F1CVTL2, F2CVTL, F2CVTL2 for AdvSIMD Richard Henderson
@ 2026-05-20 18:21 ` Richard Henderson
2026-05-20 18:21 ` [PATCH v6 30/64] target/arm: Implement F1CVT, F1CVTL, F2CVT, F2CVTL for SME Richard Henderson
` (34 subsequent siblings)
63 siblings, 0 replies; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:21 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/tcg/helper-fp8-defs.h | 1 +
target/arm/tcg/fp8_helper.c | 16 ++++++++++++++++
target/arm/tcg/translate-sve.c | 9 +++++++++
target/arm/tcg/sve.decode | 5 +++++
4 files changed, 31 insertions(+)
diff --git a/target/arm/tcg/helper-fp8-defs.h b/target/arm/tcg/helper-fp8-defs.h
index 718463422b..3021dafd44 100644
--- a/target/arm/tcg/helper-fp8-defs.h
+++ b/target/arm/tcg/helper-fp8-defs.h
@@ -9,3 +9,4 @@ DEF_HELPER_FLAGS_4(sme2_bfcvt_hb, TCG_CALL_NO_RWG, void, ptr, ptr, env, i32)
DEF_HELPER_FLAGS_4(sme2_bfcvtl_hb, TCG_CALL_NO_RWG, void, ptr, ptr, env, i32)
DEF_HELPER_FLAGS_4(advsimd_fcvtl_hb, TCG_CALL_NO_RWG, void, ptr, ptr, env, i32)
+DEF_HELPER_FLAGS_4(sve2_fcvt_hb, TCG_CALL_NO_RWG, void, ptr, ptr, env, i32)
diff --git a/target/arm/tcg/fp8_helper.c b/target/arm/tcg/fp8_helper.c
index 0f3c279696..75c89203fe 100644
--- a/target/arm/tcg/fp8_helper.c
+++ b/target/arm/tcg/fp8_helper.c
@@ -168,6 +168,22 @@ void HELPER(sve2_bfcvt)(void *vd, void *vn, CPUARMState *env, uint32_t desc)
fp8_cvt_finish(env, &ctx);
}
+void HELPER(sve2_fcvt_hb)(void *vd, void *vn, CPUARMState *env, uint32_t desc)
+{
+ FP8Context ctx = fp8_src_start(env, desc, 0xf);
+ fp8_input_fn *input_fmt = fp8_input_fmt[ctx.f8fmt];
+ uint8_t *n = vn;
+ uint16_t *d = vd;
+ size_t nelem = simd_oprsz(desc) / 2;
+
+ for (size_t i = 0; i < nelem; ++i) {
+ d[H2(i)] = fcvt_fp8_to_f16(n[H1(2 * i + ctx.high)],
+ input_fmt, ctx.scale, &ctx.stat);
+ }
+
+ fp8_cvt_finish(env, &ctx);
+}
+
void HELPER(sme2_bfcvt_hb)(void *vd, void *vn, CPUARMState *env, uint32_t desc)
{
FP8Context ctx = fp8_src_start(env, desc, 0x3f);
diff --git a/target/arm/tcg/translate-sve.c b/target/arm/tcg/translate-sve.c
index 9bab5feb93..5200f3d034 100644
--- a/target/arm/tcg/translate-sve.c
+++ b/target/arm/tcg/translate-sve.c
@@ -4081,6 +4081,15 @@ static bool do_f8cvt(DisasContext *s, arg_rr_esz *a,
return true;
}
+TRANS_FEAT(F1CVT, aa64_sme2_or_sve2_f8cvt, do_f8cvt, a,
+ gen_helper_sve2_fcvt_hb, false, false)
+TRANS_FEAT(F2CVT, aa64_sme2_or_sve2_f8cvt, do_f8cvt, a,
+ gen_helper_sve2_fcvt_hb, true, false)
+TRANS_FEAT(F1CVTLT, aa64_sme2_or_sve2_f8cvt, do_f8cvt, a,
+ gen_helper_sve2_fcvt_hb, false, true)
+TRANS_FEAT(F2CVTLT, aa64_sme2_or_sve2_f8cvt, do_f8cvt, a,
+ gen_helper_sve2_fcvt_hb, true, true)
+
TRANS_FEAT(BF1CVT, aa64_sme2_or_sve2_f8cvt, do_f8cvt, a,
gen_helper_sve2_bfcvt, false, false)
TRANS_FEAT(BF2CVT, aa64_sme2_or_sve2_f8cvt, do_f8cvt, a,
diff --git a/target/arm/tcg/sve.decode b/target/arm/tcg/sve.decode
index e7984fa8e0..ca110f4bc1 100644
--- a/target/arm/tcg/sve.decode
+++ b/target/arm/tcg/sve.decode
@@ -1091,6 +1091,11 @@ FMINQV 01100100 .. 010 111 101 ... ..... ..... @rd_pg_rn
FRECPE 01100101 .. 001 110 001100 ..... ..... @rd_rn
FRSQRTE 01100101 .. 001 111 001100 ..... ..... @rd_rn
+F1CVT 01100101 00 001 000 001100 ..... ..... @rd_rn_e0
+F2CVT 01100101 00 001 000 001101 ..... ..... @rd_rn_e0
+F1CVTLT 01100101 00 001 001 001100 ..... ..... @rd_rn_e0
+F2CVTLT 01100101 00 001 001 001101 ..... ..... @rd_rn_e0
+
BF1CVT 01100101 00 001 000 001110 ..... ..... @rd_rn_e0
BF2CVT 01100101 00 001 000 001111 ..... ..... @rd_rn_e0
BF1CVTLT 01100101 00 001 001 001110 ..... ..... @rd_rn_e0
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread* [PATCH v6 30/64] target/arm: Implement F1CVT, F1CVTL, F2CVT, F2CVTL for SME
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
` (28 preceding siblings ...)
2026-05-20 18:21 ` [PATCH v6 29/64] target/arm: Implement F1CVT, F1CVTLT, F2CVT, F2CVTLT for SVE Richard Henderson
@ 2026-05-20 18:21 ` Richard Henderson
2026-05-20 18:21 ` [PATCH v6 31/64] target/arm: Implement BFCVTN for SVE Richard Henderson
` (33 subsequent siblings)
63 siblings, 0 replies; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:21 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/tcg/helper-fp8-defs.h | 2 ++
target/arm/tcg/fp8_helper.c | 47 ++++++++++++++++++++++++++++++++
target/arm/tcg/translate-sme.c | 5 ++++
target/arm/tcg/sme.decode | 5 ++++
4 files changed, 59 insertions(+)
diff --git a/target/arm/tcg/helper-fp8-defs.h b/target/arm/tcg/helper-fp8-defs.h
index 3021dafd44..b5dc2b7064 100644
--- a/target/arm/tcg/helper-fp8-defs.h
+++ b/target/arm/tcg/helper-fp8-defs.h
@@ -10,3 +10,5 @@ DEF_HELPER_FLAGS_4(sme2_bfcvtl_hb, TCG_CALL_NO_RWG, void, ptr, ptr, env, i32)
DEF_HELPER_FLAGS_4(advsimd_fcvtl_hb, TCG_CALL_NO_RWG, void, ptr, ptr, env, i32)
DEF_HELPER_FLAGS_4(sve2_fcvt_hb, TCG_CALL_NO_RWG, void, ptr, ptr, env, i32)
+DEF_HELPER_FLAGS_4(sme2_fcvt_hb, TCG_CALL_NO_RWG, void, ptr, ptr, env, i32)
+DEF_HELPER_FLAGS_4(sme2_fcvtl_hb, TCG_CALL_NO_RWG, void, ptr, ptr, env, i32)
diff --git a/target/arm/tcg/fp8_helper.c b/target/arm/tcg/fp8_helper.c
index 75c89203fe..e2330177ec 100644
--- a/target/arm/tcg/fp8_helper.c
+++ b/target/arm/tcg/fp8_helper.c
@@ -211,6 +211,33 @@ void HELPER(sme2_bfcvt_hb)(void *vd, void *vn, CPUARMState *env, uint32_t desc)
fp8_cvt_finish(env, &ctx);
}
+void HELPER(sme2_fcvt_hb)(void *vd, void *vn, CPUARMState *env, uint32_t desc)
+{
+ FP8Context ctx = fp8_src_start(env, desc, 0xf);
+ fp8_input_fn *input_fmt = fp8_input_fmt[ctx.f8fmt];
+ uint8_t *n = vn;
+ uint16_t *d0 = vd;
+ uint16_t *d1 = vd + sizeof(ARMVectorReg);
+ size_t oprsz = simd_oprsz(desc);
+ size_t nelem = oprsz / 2;
+ ARMVectorReg scratch;
+
+ if (vectors_overlap(vd, 2, vn, 1)) {
+ n = memcpy(&scratch, vn, oprsz);
+ }
+
+ for (size_t i = 0; i < nelem; ++i) {
+ d0[H2(i)] = fcvt_fp8_to_f16(n[H1(i)], input_fmt,
+ ctx.scale, &ctx.stat);
+ }
+ for (size_t i = 0; i < nelem; ++i) {
+ d1[H2(i)] = fcvt_fp8_to_f16(n[H1(i + nelem)], input_fmt,
+ ctx.scale, &ctx.stat);
+ }
+
+ fp8_cvt_finish(env, &ctx);
+}
+
void HELPER(sme2_bfcvtl_hb)(void *vd, void *vn, CPUARMState *env, uint32_t desc)
{
FP8Context ctx = fp8_src_start(env, desc, 0x3f);
@@ -230,3 +257,23 @@ void HELPER(sme2_bfcvtl_hb)(void *vd, void *vn, CPUARMState *env, uint32_t desc)
fp8_cvt_finish(env, &ctx);
}
+
+void HELPER(sme2_fcvtl_hb)(void *vd, void *vn, CPUARMState *env, uint32_t desc)
+{
+ FP8Context ctx = fp8_src_start(env, desc, 0xf);
+ fp8_input_fn *input_fmt = fp8_input_fmt[ctx.f8fmt];
+ uint8_t *n = vn;
+ uint16_t *d0 = vd;
+ uint16_t *d1 = vd + sizeof(ARMVectorReg);
+ size_t oprsz = simd_oprsz(desc);
+ size_t nelem = oprsz / 2;
+
+ for (size_t i = 0; i < nelem; ++i) {
+ uint8_t e0 = n[H1(2 * i + 0)];
+ uint8_t e1 = n[H1(2 * i + 1)];
+ d0[H2(i)] = fcvt_fp8_to_f16(e0, input_fmt, ctx.scale, &ctx.stat);
+ d1[H2(i)] = fcvt_fp8_to_f16(e1, input_fmt, ctx.scale, &ctx.stat);
+ }
+
+ fp8_cvt_finish(env, &ctx);
+}
diff --git a/target/arm/tcg/translate-sme.c b/target/arm/tcg/translate-sme.c
index 2841b2b8cb..0cbad3e006 100644
--- a/target/arm/tcg/translate-sme.c
+++ b/target/arm/tcg/translate-sme.c
@@ -1546,6 +1546,11 @@ static bool do_f8cvt(DisasContext *s, arg_zz_n *a,
return true;
}
+TRANS_FEAT(F1CVT, aa64_sme2_f8cvt, do_f8cvt, a, gen_helper_sme2_fcvt_hb, 0)
+TRANS_FEAT(F2CVT, aa64_sme2_f8cvt, do_f8cvt, a, gen_helper_sme2_fcvt_hb, 1)
+TRANS_FEAT(F1CVTL, aa64_sme2_f8cvt, do_f8cvt, a, gen_helper_sme2_fcvtl_hb, 0)
+TRANS_FEAT(F2CVTL, aa64_sme2_f8cvt, do_f8cvt, a, gen_helper_sme2_fcvtl_hb, 1)
+
TRANS_FEAT(BF1CVT, aa64_sme2_f8cvt, do_f8cvt, a, gen_helper_sme2_bfcvt_hb, 0)
TRANS_FEAT(BF2CVT, aa64_sme2_f8cvt, do_f8cvt, a, gen_helper_sme2_bfcvt_hb, 1)
TRANS_FEAT(BF1CVTL, aa64_sme2_f8cvt, do_f8cvt, a, gen_helper_sme2_bfcvtl_hb, 0)
diff --git a/target/arm/tcg/sme.decode b/target/arm/tcg/sme.decode
index df9586c1a5..d6192eb59d 100644
--- a/target/arm/tcg/sme.decode
+++ b/target/arm/tcg/sme.decode
@@ -853,6 +853,11 @@ UUNPK_4bh 11000001 011 10101 111000 ....0 ...01 @zz_4x2_n1
UUNPK_4hs 11000001 101 10101 111000 ....0 ...01 @zz_4x2_n1
UUNPK_4sd 11000001 111 10101 111000 ....0 ...01 @zz_4x2_n1
+F1CVT 11000001 001 00110 111000 ..... ....0 @zz_2x1
+F2CVT 11000001 101 00110 111000 ..... ....0 @zz_2x1
+F1CVTL 11000001 001 00110 111000 ..... ....1 @zz_2x1
+F2CVTL 11000001 101 00110 111000 ..... ....1 @zz_2x1
+
BF1CVT 11000001 011 00110 111000 ..... ....0 @zz_2x1
BF2CVT 11000001 111 00110 111000 ..... ....0 @zz_2x1
BF1CVTL 11000001 011 00110 111000 ..... ....1 @zz_2x1
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread* [PATCH v6 31/64] target/arm: Implement BFCVTN for SVE
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
` (29 preceding siblings ...)
2026-05-20 18:21 ` [PATCH v6 30/64] target/arm: Implement F1CVT, F1CVTL, F2CVT, F2CVTL for SME Richard Henderson
@ 2026-05-20 18:21 ` Richard Henderson
2026-05-21 9:01 ` Peter Maydell
2026-05-20 18:21 ` [PATCH v6 32/64] target/arm: Implement FCVTN (16- to 8-bit fp) for AdvSIMD Richard Henderson
` (32 subsequent siblings)
63 siblings, 1 reply; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:21 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/tcg/helper-fp8-defs.h | 2 +
target/arm/tcg/fp8_helper.c | 93 ++++++++++++++++++++++++++++++++
target/arm/tcg/translate-sve.c | 3 ++
target/arm/tcg/sve.decode | 2 +
4 files changed, 100 insertions(+)
diff --git a/target/arm/tcg/helper-fp8-defs.h b/target/arm/tcg/helper-fp8-defs.h
index b5dc2b7064..bbc8d69e28 100644
--- a/target/arm/tcg/helper-fp8-defs.h
+++ b/target/arm/tcg/helper-fp8-defs.h
@@ -12,3 +12,5 @@ DEF_HELPER_FLAGS_4(advsimd_fcvtl_hb, TCG_CALL_NO_RWG, void, ptr, ptr, env, i32)
DEF_HELPER_FLAGS_4(sve2_fcvt_hb, TCG_CALL_NO_RWG, void, ptr, ptr, env, i32)
DEF_HELPER_FLAGS_4(sme2_fcvt_hb, TCG_CALL_NO_RWG, void, ptr, ptr, env, i32)
DEF_HELPER_FLAGS_4(sme2_fcvtl_hb, TCG_CALL_NO_RWG, void, ptr, ptr, env, i32)
+
+DEF_HELPER_FLAGS_4(sve2_bfcvtn_bh, TCG_CALL_NO_RWG, void, ptr, ptr, env, i32)
diff --git a/target/arm/tcg/fp8_helper.c b/target/arm/tcg/fp8_helper.c
index e2330177ec..0a4f603c8a 100644
--- a/target/arm/tcg/fp8_helper.c
+++ b/target/arm/tcg/fp8_helper.c
@@ -72,6 +72,17 @@ static FP8Context fp8_src_start(CPUARMState *env, uint32_t desc, int scale_mask)
return fp8_start(env, desc, f8fmt, scale);
}
+static FP8Context fp8_dst_start(CPUARMState *env, uint32_t desc, bool is_f16)
+{
+ uint64_t fpmr = env->vfp.fpmr;
+ FPMRType f8fmt = FIELD_EX64(fpmr, FPMR, F8D);
+ int scale = (is_f16
+ ? FIELD_SEX64(fpmr, FPMR, NSCALE_F16)
+ : FIELD_SEX64(fpmr, FPMR, NSCALE));
+
+ return fp8_start(env, desc, f8fmt, scale);
+}
+
/*
* Invalid input format: we could take one of the usual set of
* CONSTRAINED UNPREDICTABLE options for use of a reserved value,
@@ -111,6 +122,65 @@ static float16 fcvt_fp8_to_f16(uint8_t x, fp8_input_fn *f8fmt,
return float16_round_pack_canonical(&p, s);
}
+/*
+ * Invalid output format: we could take one of the usual set of
+ * CONSTRAINED UNPREDICTABLE options for use of a reserved value,
+ * but choose to take the additional option provided by the FPMR
+ * register specification, of setting the result to 0xff and
+ * signaling Invalid Operation.
+ */
+static uint8_t fcvt_fp8_invalid_output(FloatParts64 *p, int scale,
+ bool saturate, float_status *s)
+{
+ float_raise(float_flag_invalid, s);
+ return 0xff;
+}
+
+static uint8_t fcvt_fp8_e4m3_output(FloatParts64 *p, int scale,
+ bool saturate, float_status *s)
+{
+ *p = parts64_scalbn(p, scale, s);
+ /*
+ * Saturating Inf -> Max handled in uncanon_e4m3_overflow
+ * because there is no infinity encoding.
+ */
+ return float8_e4m3_round_pack_canonical(p, s, saturate);
+}
+
+static uint8_t fcvt_fp8_e5m2_output(FloatParts64 *p, int scale,
+ bool saturate, float_status *s)
+{
+ /*
+ * Because e5m2 has an infinity encoding, we need to handle
+ * saturation conversion of Inf -> Max manually.
+ */
+ if (unlikely(p->cls == float_class_inf)) {
+ if (saturate) {
+ p->cls = float_class_normal;
+ p->exp = float8_e5m2_params.exp_max;
+ p->frac = -1ull << float8_e5m2_params.frac_shift;
+ }
+ } else {
+ *p = parts64_scalbn(p, scale, s);
+ }
+ return float8_e5m2_round_pack_canonical(p, s, saturate);
+}
+
+typedef uint8_t fcvt_fp8_output_fn(FloatParts64 *, int, bool, float_status *);
+
+static fcvt_fp8_output_fn * const fcvt_fp8_output_fmt[8] = {
+ [0 ... 7] = fcvt_fp8_invalid_output,
+ [OFP8_E5M2] = fcvt_fp8_e5m2_output,
+ [OFP8_E4M3] = fcvt_fp8_e4m3_output,
+};
+
+static uint8_t fcvt_b16_to_fp8(bfloat16 x, fcvt_fp8_output_fn *f8fmt,
+ int scale, bool saturate, float_status *s)
+{
+ FloatParts64 p = bfloat16_unpack_canonical(x, s);
+ return f8fmt(&p, scale, saturate, s);
+}
+
void HELPER(advsimd_bfcvtl)(void *vd, void *vn, CPUARMState *env, uint32_t desc)
{
FP8Context ctx = fp8_src_start(env, desc, 0x3f);
@@ -277,3 +347,26 @@ void HELPER(sme2_fcvtl_hb)(void *vd, void *vn, CPUARMState *env, uint32_t desc)
fp8_cvt_finish(env, &ctx);
}
+
+void HELPER(sve2_bfcvtn_bh)(void *vd, void *vn, CPUARMState *env, uint32_t desc)
+{
+ FP8Context ctx = fp8_dst_start(env, desc, false);
+ fcvt_fp8_output_fn *output_fmt = fcvt_fp8_output_fmt[ctx.f8fmt];
+ uint16_t *n0 = vn;
+ uint16_t *n1 = vn + sizeof(ARMVectorReg);
+ uint8_t *d = vd;
+ size_t oprsz = simd_oprsz(desc);
+ size_t nelem = oprsz / 2;
+ bool osc = FIELD_EX64(env->vfp.fpmr, FPMR, OSC);
+
+ for (size_t i = 0; i < nelem; ++i) {
+ bfloat16 e0 = n0[H2(i)];
+ bfloat16 e1 = n1[H2(i)];
+ d[H1(2 * i + 0)] = fcvt_b16_to_fp8(e0, output_fmt,
+ ctx.scale, osc, &ctx.stat);
+ d[H1(2 * i + 1)] = fcvt_b16_to_fp8(e1, output_fmt,
+ ctx.scale, osc, &ctx.stat);
+ }
+
+ fp8_cvt_finish(env, &ctx);
+}
diff --git a/target/arm/tcg/translate-sve.c b/target/arm/tcg/translate-sve.c
index 5200f3d034..7276d9c44a 100644
--- a/target/arm/tcg/translate-sve.c
+++ b/target/arm/tcg/translate-sve.c
@@ -4099,6 +4099,9 @@ TRANS_FEAT(BF1CVTLT, aa64_sme2_or_sve2_f8cvt, do_f8cvt, a,
TRANS_FEAT(BF2CVTLT, aa64_sme2_or_sve2_f8cvt, do_f8cvt, a,
gen_helper_sve2_bfcvt, true, true)
+TRANS_FEAT(BFCVTN, aa64_sme2_or_sve2_f8cvt, do_f8cvt,
+ a, gen_helper_sve2_bfcvtn_bh, false, false)
+
/*
*** SVE Floating Point Compare with Zero Group
*/
diff --git a/target/arm/tcg/sve.decode b/target/arm/tcg/sve.decode
index ca110f4bc1..b6ef8ed8de 100644
--- a/target/arm/tcg/sve.decode
+++ b/target/arm/tcg/sve.decode
@@ -1101,6 +1101,8 @@ BF2CVT 01100101 00 001 000 001111 ..... ..... @rd_rn_e0
BF1CVTLT 01100101 00 001 001 001110 ..... ..... @rd_rn_e0
BF2CVTLT 01100101 00 001 001 001111 ..... ..... @rd_rn_e0
+BFCVTN 01100101 00 001 010 001110 ....0 ..... @rd_rnx2 esz=1
+
### SVE FP Compare with Zero Group
FCMGE_ppz0 01100101 .. 0100 00 001 ... ..... 0 .... @pd_pg_rn
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread* Re: [PATCH v6 31/64] target/arm: Implement BFCVTN for SVE
2026-05-20 18:21 ` [PATCH v6 31/64] target/arm: Implement BFCVTN for SVE Richard Henderson
@ 2026-05-21 9:01 ` Peter Maydell
2026-05-22 19:59 ` Richard Henderson
0 siblings, 1 reply; 105+ messages in thread
From: Peter Maydell @ 2026-05-21 9:01 UTC (permalink / raw)
To: Richard Henderson; +Cc: qemu-devel, qemu-arm
On Wed, 20 May 2026 at 19:24, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> +static uint8_t fcvt_fp8_e5m2_output(FloatParts64 *p, int scale,
> + bool saturate, float_status *s)
> +{
> + /*
> + * Because e5m2 has an infinity encoding, we need to handle
> + * saturation conversion of Inf -> Max manually.
> + */
> + if (unlikely(p->cls == float_class_inf)) {
> + if (saturate) {
> + p->cls = float_class_normal;
> + p->exp = float8_e5m2_params.exp_max;
> + p->frac = -1ull << float8_e5m2_params.frac_shift;
This value is larger than the maximum representable normal,
so although round_pack_canonical will correctly saturate it
down to the maximum normal, it will also set Inexact and
Overflow in the process. In the pseudocode FPConvertFP8(),
input Infinity is special-cased and returns either Infinity
or the maximum normal without setting any exception flags.
To get the exact maximum normal you want
p->exp = float8_e5m2_params.exp_max -
float8_e5m2_params.exp_bias - 1;
Or we could shortcut the packing process and just return
the right value:
/* maximum or minimum normal value for E5M2 */
return 0x7b | (p->sign << 7);
> + }
> + } else {
> + *p = parts64_scalbn(p, scale, s);
> + }
> + return float8_e5m2_round_pack_canonical(p, s, saturate);
> +}
-- PMM
^ permalink raw reply [flat|nested] 105+ messages in thread
* [PATCH v6 32/64] target/arm: Implement FCVTN (16- to 8-bit fp) for AdvSIMD
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
` (30 preceding siblings ...)
2026-05-20 18:21 ` [PATCH v6 31/64] target/arm: Implement BFCVTN for SVE Richard Henderson
@ 2026-05-20 18:21 ` Richard Henderson
2026-05-20 18:21 ` [PATCH v6 33/64] target/arm: Implement FCVTN, FCVTN2 (32- " Richard Henderson
` (31 subsequent siblings)
63 siblings, 0 replies; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:21 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/tcg/helper-fp8-defs.h | 2 ++
target/arm/tcg/fp8_helper.c | 37 ++++++++++++++++++++++++++++++++
target/arm/tcg/translate-a64.c | 15 +++++++++++++
target/arm/tcg/a64.decode | 2 ++
4 files changed, 56 insertions(+)
diff --git a/target/arm/tcg/helper-fp8-defs.h b/target/arm/tcg/helper-fp8-defs.h
index bbc8d69e28..6530d1a6da 100644
--- a/target/arm/tcg/helper-fp8-defs.h
+++ b/target/arm/tcg/helper-fp8-defs.h
@@ -14,3 +14,5 @@ DEF_HELPER_FLAGS_4(sme2_fcvt_hb, TCG_CALL_NO_RWG, void, ptr, ptr, env, i32)
DEF_HELPER_FLAGS_4(sme2_fcvtl_hb, TCG_CALL_NO_RWG, void, ptr, ptr, env, i32)
DEF_HELPER_FLAGS_4(sve2_bfcvtn_bh, TCG_CALL_NO_RWG, void, ptr, ptr, env, i32)
+
+DEF_HELPER_FLAGS_5(gvec_fcvt_bh, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, env, i32)
diff --git a/target/arm/tcg/fp8_helper.c b/target/arm/tcg/fp8_helper.c
index 0a4f603c8a..a8337a8fb7 100644
--- a/target/arm/tcg/fp8_helper.c
+++ b/target/arm/tcg/fp8_helper.c
@@ -181,6 +181,13 @@ static uint8_t fcvt_b16_to_fp8(bfloat16 x, fcvt_fp8_output_fn *f8fmt,
return f8fmt(&p, scale, saturate, s);
}
+static uint8_t fcvt_f16_to_fp8(float16 x, fcvt_fp8_output_fn *f8fmt,
+ int scale, bool saturate, float_status *s)
+{
+ FloatParts64 p = float16_unpack_canonical(x, s);
+ return f8fmt(&p, scale, saturate, s);
+}
+
void HELPER(advsimd_bfcvtl)(void *vd, void *vn, CPUARMState *env, uint32_t desc)
{
FP8Context ctx = fp8_src_start(env, desc, 0x3f);
@@ -370,3 +377,33 @@ void HELPER(sve2_bfcvtn_bh)(void *vd, void *vn, CPUARMState *env, uint32_t desc)
fp8_cvt_finish(env, &ctx);
}
+
+void HELPER(gvec_fcvt_bh)(void *vd, void *vn, void *vm,
+ CPUARMState *env, uint32_t desc)
+{
+ FP8Context ctx = fp8_dst_start(env, desc, true);
+ fcvt_fp8_output_fn *output_fmt = fcvt_fp8_output_fmt[ctx.f8fmt];
+ uint16_t *n = vn;
+ uint16_t *m = vm;
+ uint8_t *d = vd;
+ bool osc = FIELD_EX64(env->vfp.fpmr, FPMR, OSC);
+ size_t oprsz = simd_oprsz(desc);
+ size_t nelem = oprsz / 2;
+ ARMVectorReg scratch;
+
+ if (vd == vm) {
+ m = memcpy(&scratch, vm, oprsz);
+ }
+
+ for (size_t i = 0; i < nelem; ++i) {
+ d[H1(i)] = fcvt_f16_to_fp8(n[H2(i)], output_fmt,
+ ctx.scale, osc, &ctx.stat);
+ }
+ for (size_t i = 0; i < nelem; ++i) {
+ d[H1(i) + nelem] = fcvt_f16_to_fp8(m[H2(i)], output_fmt,
+ ctx.scale, osc, &ctx.stat);
+ }
+
+ fp8_cvt_finish(env, &ctx);
+ clear_tail(vd, oprsz, simd_maxsz(desc));
+}
diff --git a/target/arm/tcg/translate-a64.c b/target/arm/tcg/translate-a64.c
index 565053a1a4..0927eb6516 100644
--- a/target/arm/tcg/translate-a64.c
+++ b/target/arm/tcg/translate-a64.c
@@ -6522,6 +6522,21 @@ static gen_helper_gvec_3_ptr * const f_vector_fscale[3] = {
};
TRANS_FEAT(FSCALE, aa64_f8cvt, do_fp3_vector, a, 0, f_vector_fscale)
+static bool trans_FCVTN_bh(DisasContext *s, arg_qrrr_e *a)
+{
+ if (!dc_isar_feature(aa64_f8cvt, s)) {
+ return false;
+ }
+ if (fpmr_access_check(s) && fp_access_check(s)) {
+ tcg_gen_gvec_3_ptr(vec_full_reg_offset(s, a->rd),
+ vec_full_reg_offset(s, a->rn),
+ vec_full_reg_offset(s, a->rm),
+ tcg_env, a->q ? 16 : 8, vec_full_reg_size(s),
+ FPST_A64 << 2, gen_helper_gvec_fcvt_bh);
+ }
+ return true;
+}
+
static bool do_fmlal(DisasContext *s, arg_qrrr_e *a, bool is_s, bool is_2)
{
if (fp_access_check(s)) {
diff --git a/target/arm/tcg/a64.decode b/target/arm/tcg/a64.decode
index 26d31d0a33..71456d44e1 100644
--- a/target/arm/tcg/a64.decode
+++ b/target/arm/tcg/a64.decode
@@ -1201,6 +1201,8 @@ FAMIN 0.10 1110 1.1 ..... 11011 1 ..... ..... @qrrr_sd
FSCALE 0.10 1110 110 ..... 00111 1 ..... ..... @qrrr_h
FSCALE 0.10 1110 1.1 ..... 11111 1 ..... ..... @qrrr_sd
+FCVTN_bh 0.00 1110 010 ..... 11110 1 ..... ..... @qrrr_h
+
### Advanced SIMD scalar x indexed element
FMUL_si 0101 1111 00 .. .... 1001 . 0 ..... ..... @rrx_h
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread* [PATCH v6 33/64] target/arm: Implement FCVTN, FCVTN2 (32- to 8-bit fp) for AdvSIMD
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
` (31 preceding siblings ...)
2026-05-20 18:21 ` [PATCH v6 32/64] target/arm: Implement FCVTN (16- to 8-bit fp) for AdvSIMD Richard Henderson
@ 2026-05-20 18:21 ` Richard Henderson
2026-05-20 18:21 ` [PATCH v6 34/64] target/arm: Implement FCVTN (16- to 8-bit fp) for SVE Richard Henderson
` (30 subsequent siblings)
63 siblings, 0 replies; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:21 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/tcg/helper-fp8-defs.h | 2 ++
target/arm/tcg/fp8_helper.c | 33 ++++++++++++++++++++++++++++++++
target/arm/tcg/translate-a64.c | 16 ++++++++++++++++
target/arm/tcg/a64.decode | 1 +
4 files changed, 52 insertions(+)
diff --git a/target/arm/tcg/helper-fp8-defs.h b/target/arm/tcg/helper-fp8-defs.h
index 6530d1a6da..023a49e12f 100644
--- a/target/arm/tcg/helper-fp8-defs.h
+++ b/target/arm/tcg/helper-fp8-defs.h
@@ -16,3 +16,5 @@ DEF_HELPER_FLAGS_4(sme2_fcvtl_hb, TCG_CALL_NO_RWG, void, ptr, ptr, env, i32)
DEF_HELPER_FLAGS_4(sve2_bfcvtn_bh, TCG_CALL_NO_RWG, void, ptr, ptr, env, i32)
DEF_HELPER_FLAGS_5(gvec_fcvt_bh, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, env, i32)
+
+DEF_HELPER_FLAGS_5(advsimd_fcvt_bs, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, env, i32)
diff --git a/target/arm/tcg/fp8_helper.c b/target/arm/tcg/fp8_helper.c
index a8337a8fb7..f6b3eb6953 100644
--- a/target/arm/tcg/fp8_helper.c
+++ b/target/arm/tcg/fp8_helper.c
@@ -188,6 +188,13 @@ static uint8_t fcvt_f16_to_fp8(float16 x, fcvt_fp8_output_fn *f8fmt,
return f8fmt(&p, scale, saturate, s);
}
+static uint8_t fcvt_f32_to_fp8(float32 x, fcvt_fp8_output_fn *f8fmt,
+ int scale, bool saturate, float_status *s)
+{
+ FloatParts64 p = float32_unpack_canonical(x, s);
+ return f8fmt(&p, scale, saturate, s);
+}
+
void HELPER(advsimd_bfcvtl)(void *vd, void *vn, CPUARMState *env, uint32_t desc)
{
FP8Context ctx = fp8_src_start(env, desc, 0x3f);
@@ -407,3 +414,29 @@ void HELPER(gvec_fcvt_bh)(void *vd, void *vn, void *vm,
fp8_cvt_finish(env, &ctx);
clear_tail(vd, oprsz, simd_maxsz(desc));
}
+
+void HELPER(advsimd_fcvt_bs)(void *vd, void *vn, void *vm,
+ CPUARMState *env, uint32_t desc)
+{
+ FP8Context ctx = fp8_dst_start(env, desc, false);
+ fcvt_fp8_output_fn *output_fmt = fcvt_fp8_output_fmt[ctx.f8fmt];
+ uint32_t *n = vn, *m = vm, scratch[4];
+ uint8_t *d = vd + 8 * ctx.high;
+ bool osc = FIELD_EX64(env->vfp.fpmr, FPMR, OSC);
+
+ if (vd == vm) {
+ m = memcpy(scratch, vm, 16);
+ }
+
+ for (size_t i = 0; i < 4; ++i) {
+ d[H1(i + 0)] = fcvt_f32_to_fp8(n[H4(i)], output_fmt,
+ ctx.scale, osc, &ctx.stat);
+ }
+ for (size_t i = 0; i < 4; ++i) {
+ d[H1(i + 4)] = fcvt_f32_to_fp8(m[H4(i)], output_fmt,
+ ctx.scale, osc, &ctx.stat);
+ }
+
+ fp8_cvt_finish(env, &ctx);
+ clear_tail(vd, ctx.high ? 16 : 8, simd_maxsz(desc));
+}
diff --git a/target/arm/tcg/translate-a64.c b/target/arm/tcg/translate-a64.c
index 0927eb6516..3c784afc99 100644
--- a/target/arm/tcg/translate-a64.c
+++ b/target/arm/tcg/translate-a64.c
@@ -6537,6 +6537,22 @@ static bool trans_FCVTN_bh(DisasContext *s, arg_qrrr_e *a)
return true;
}
+static bool trans_FCVTN_bs(DisasContext *s, arg_qrrr_e *a)
+{
+ if (!dc_isar_feature(aa64_f8cvt, s)) {
+ return false;
+ }
+ if (fpmr_access_check(s) && fp_access_check(s)) {
+ tcg_gen_gvec_3_ptr(vec_full_reg_offset(s, a->rd),
+ vec_full_reg_offset(s, a->rn),
+ vec_full_reg_offset(s, a->rm),
+ tcg_env, 16, vec_full_reg_size(s),
+ (a->q << 1) | FPST_A64 << 2,
+ gen_helper_advsimd_fcvt_bs);
+ }
+ return true;
+}
+
static bool do_fmlal(DisasContext *s, arg_qrrr_e *a, bool is_s, bool is_2)
{
if (fp_access_check(s)) {
diff --git a/target/arm/tcg/a64.decode b/target/arm/tcg/a64.decode
index 71456d44e1..a9cf259b9b 100644
--- a/target/arm/tcg/a64.decode
+++ b/target/arm/tcg/a64.decode
@@ -1202,6 +1202,7 @@ FSCALE 0.10 1110 110 ..... 00111 1 ..... ..... @qrrr_h
FSCALE 0.10 1110 1.1 ..... 11111 1 ..... ..... @qrrr_sd
FCVTN_bh 0.00 1110 010 ..... 11110 1 ..... ..... @qrrr_h
+FCVTN_bs 0.00 1110 000 ..... 11110 1 ..... ..... @qrrr_h
### Advanced SIMD scalar x indexed element
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread* [PATCH v6 34/64] target/arm: Implement FCVTN (16- to 8-bit fp) for SVE
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
` (32 preceding siblings ...)
2026-05-20 18:21 ` [PATCH v6 33/64] target/arm: Implement FCVTN, FCVTN2 (32- " Richard Henderson
@ 2026-05-20 18:21 ` Richard Henderson
2026-05-20 18:21 ` [PATCH v6 35/64] target/arm: Implement FCVTNB, FCVTNT " Richard Henderson
` (29 subsequent siblings)
63 siblings, 0 replies; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:21 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/tcg/helper-fp8-defs.h | 1 +
target/arm/tcg/fp8_helper.c | 23 +++++++++++++++++++++++
target/arm/tcg/translate-sve.c | 2 ++
target/arm/tcg/sve.decode | 1 +
4 files changed, 27 insertions(+)
diff --git a/target/arm/tcg/helper-fp8-defs.h b/target/arm/tcg/helper-fp8-defs.h
index 023a49e12f..e67fb191c2 100644
--- a/target/arm/tcg/helper-fp8-defs.h
+++ b/target/arm/tcg/helper-fp8-defs.h
@@ -16,5 +16,6 @@ DEF_HELPER_FLAGS_4(sme2_fcvtl_hb, TCG_CALL_NO_RWG, void, ptr, ptr, env, i32)
DEF_HELPER_FLAGS_4(sve2_bfcvtn_bh, TCG_CALL_NO_RWG, void, ptr, ptr, env, i32)
DEF_HELPER_FLAGS_5(gvec_fcvt_bh, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, env, i32)
+DEF_HELPER_FLAGS_4(sve2_fcvtn_bh, TCG_CALL_NO_RWG, void, ptr, ptr, env, i32)
DEF_HELPER_FLAGS_5(advsimd_fcvt_bs, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, env, i32)
diff --git a/target/arm/tcg/fp8_helper.c b/target/arm/tcg/fp8_helper.c
index f6b3eb6953..ad810852b8 100644
--- a/target/arm/tcg/fp8_helper.c
+++ b/target/arm/tcg/fp8_helper.c
@@ -415,6 +415,29 @@ void HELPER(gvec_fcvt_bh)(void *vd, void *vn, void *vm,
clear_tail(vd, oprsz, simd_maxsz(desc));
}
+void HELPER(sve2_fcvtn_bh)(void *vd, void *vn, CPUARMState *env, uint32_t desc)
+{
+ FP8Context ctx = fp8_dst_start(env, desc, true);
+ fcvt_fp8_output_fn *output_fmt = fcvt_fp8_output_fmt[ctx.f8fmt];
+ uint16_t *n0 = vn;
+ uint16_t *n1 = vn + sizeof(ARMVectorReg);
+ uint8_t *d = vd;
+ bool osc = FIELD_EX64(env->vfp.fpmr, FPMR, OSC);
+ size_t oprsz = simd_oprsz(desc);
+ size_t nelem = oprsz / 2;
+
+ for (size_t i = 0; i < nelem; ++i) {
+ float16 e0 = n0[H2(i)];
+ float16 e1 = n1[H2(i)];
+ d[H1(2 * i + 0)] = fcvt_f16_to_fp8(e0, output_fmt,
+ ctx.scale, osc, &ctx.stat);
+ d[H1(2 * i + 1)] = fcvt_f16_to_fp8(e1, output_fmt,
+ ctx.scale, osc, &ctx.stat);
+ }
+
+ fp8_cvt_finish(env, &ctx);
+}
+
void HELPER(advsimd_fcvt_bs)(void *vd, void *vn, void *vm,
CPUARMState *env, uint32_t desc)
{
diff --git a/target/arm/tcg/translate-sve.c b/target/arm/tcg/translate-sve.c
index 7276d9c44a..c7fcf27183 100644
--- a/target/arm/tcg/translate-sve.c
+++ b/target/arm/tcg/translate-sve.c
@@ -4099,6 +4099,8 @@ TRANS_FEAT(BF1CVTLT, aa64_sme2_or_sve2_f8cvt, do_f8cvt, a,
TRANS_FEAT(BF2CVTLT, aa64_sme2_or_sve2_f8cvt, do_f8cvt, a,
gen_helper_sve2_bfcvt, true, true)
+TRANS_FEAT(FCVTN, aa64_sme2_or_sve2_f8cvt, do_f8cvt,
+ a, gen_helper_sve2_fcvtn_bh, false, false)
TRANS_FEAT(BFCVTN, aa64_sme2_or_sve2_f8cvt, do_f8cvt,
a, gen_helper_sve2_bfcvtn_bh, false, false)
diff --git a/target/arm/tcg/sve.decode b/target/arm/tcg/sve.decode
index b6ef8ed8de..806953bc35 100644
--- a/target/arm/tcg/sve.decode
+++ b/target/arm/tcg/sve.decode
@@ -1101,6 +1101,7 @@ BF2CVT 01100101 00 001 000 001111 ..... ..... @rd_rn_e0
BF1CVTLT 01100101 00 001 001 001110 ..... ..... @rd_rn_e0
BF2CVTLT 01100101 00 001 001 001111 ..... ..... @rd_rn_e0
+FCVTN 01100101 00 001 010 001100 ....0 ..... @rd_rnx2 esz=1
BFCVTN 01100101 00 001 010 001110 ....0 ..... @rd_rnx2 esz=1
### SVE FP Compare with Zero Group
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread* [PATCH v6 35/64] target/arm: Implement FCVTNB, FCVTNT for SVE
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
` (33 preceding siblings ...)
2026-05-20 18:21 ` [PATCH v6 34/64] target/arm: Implement FCVTN (16- to 8-bit fp) for SVE Richard Henderson
@ 2026-05-20 18:21 ` Richard Henderson
2026-05-20 18:21 ` [PATCH v6 36/64] target/arm: Implement FCVT (FP16 to FP8) for SME Richard Henderson
` (28 subsequent siblings)
63 siblings, 0 replies; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:21 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/tcg/helper-fp8-defs.h | 2 ++
target/arm/tcg/fp8_helper.c | 47 ++++++++++++++++++++++++++++++++
target/arm/tcg/translate-sve.c | 4 +++
target/arm/tcg/sve.decode | 2 ++
4 files changed, 55 insertions(+)
diff --git a/target/arm/tcg/helper-fp8-defs.h b/target/arm/tcg/helper-fp8-defs.h
index e67fb191c2..5863a6dbb8 100644
--- a/target/arm/tcg/helper-fp8-defs.h
+++ b/target/arm/tcg/helper-fp8-defs.h
@@ -19,3 +19,5 @@ DEF_HELPER_FLAGS_5(gvec_fcvt_bh, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, env, i32)
DEF_HELPER_FLAGS_4(sve2_fcvtn_bh, TCG_CALL_NO_RWG, void, ptr, ptr, env, i32)
DEF_HELPER_FLAGS_5(advsimd_fcvt_bs, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, env, i32)
+DEF_HELPER_FLAGS_4(sve2_fcvtnb_bs, TCG_CALL_NO_RWG, void, ptr, ptr, env, i32)
+DEF_HELPER_FLAGS_4(sve2_fcvtnt_bs, TCG_CALL_NO_RWG, void, ptr, ptr, env, i32)
diff --git a/target/arm/tcg/fp8_helper.c b/target/arm/tcg/fp8_helper.c
index ad810852b8..faa8df692e 100644
--- a/target/arm/tcg/fp8_helper.c
+++ b/target/arm/tcg/fp8_helper.c
@@ -463,3 +463,50 @@ void HELPER(advsimd_fcvt_bs)(void *vd, void *vn, void *vm,
fp8_cvt_finish(env, &ctx);
clear_tail(vd, ctx.high ? 16 : 8, simd_maxsz(desc));
}
+
+void HELPER(sve2_fcvtnb_bs)(void *vd, void *vn, CPUARMState *env, uint32_t desc)
+{
+ FP8Context ctx = fp8_dst_start(env, desc, false);
+ fcvt_fp8_output_fn *output_fmt = fcvt_fp8_output_fmt[ctx.f8fmt];
+ uint32_t *n0 = vn;
+ uint32_t *n1 = vn + sizeof(ARMVectorReg);
+ uint16_t *d = vd;
+ bool osc = FIELD_EX64(env->vfp.fpmr, FPMR, OSC);
+ size_t oprsz = simd_oprsz(desc);
+ size_t nelem = oprsz / 4;
+
+ for (size_t i = 0; i < nelem; ++i) {
+ float32 e0 = n0[H4(i)];
+ float32 e1 = n1[H4(i)];
+ /* Zero-extend uint8_t to clear the odd lanes. */
+ d[H2(2 * i + 0)] = fcvt_f32_to_fp8(e0, output_fmt,
+ ctx.scale, osc, &ctx.stat);
+ d[H2(2 * i + 1)] = fcvt_f32_to_fp8(e1, output_fmt,
+ ctx.scale, osc, &ctx.stat);
+ }
+
+ fp8_cvt_finish(env, &ctx);
+}
+
+void HELPER(sve2_fcvtnt_bs)(void *vd, void *vn, CPUARMState *env, uint32_t desc)
+{
+ FP8Context ctx = fp8_dst_start(env, desc, false);
+ fcvt_fp8_output_fn *output_fmt = fcvt_fp8_output_fmt[ctx.f8fmt];
+ uint32_t *n0 = vn;
+ uint32_t *n1 = vn + sizeof(ARMVectorReg);
+ uint8_t *d = vd;
+ bool osc = FIELD_EX64(env->vfp.fpmr, FPMR, OSC);
+ size_t oprsz = simd_oprsz(desc);
+ size_t nelem = oprsz / 4;
+
+ for (size_t i = 0; i < nelem; ++i) {
+ float32 e0 = n0[H4(i)];
+ float32 e1 = n1[H4(i)];
+ d[H1(4 * i + 1)] = fcvt_f32_to_fp8(e0, output_fmt,
+ ctx.scale, osc, &ctx.stat);
+ d[H1(4 * i + 3)] = fcvt_f32_to_fp8(e1, output_fmt,
+ ctx.scale, osc, &ctx.stat);
+ }
+
+ fp8_cvt_finish(env, &ctx);
+}
diff --git a/target/arm/tcg/translate-sve.c b/target/arm/tcg/translate-sve.c
index c7fcf27183..13f7ab01af 100644
--- a/target/arm/tcg/translate-sve.c
+++ b/target/arm/tcg/translate-sve.c
@@ -4103,6 +4103,10 @@ TRANS_FEAT(FCVTN, aa64_sme2_or_sve2_f8cvt, do_f8cvt,
a, gen_helper_sve2_fcvtn_bh, false, false)
TRANS_FEAT(BFCVTN, aa64_sme2_or_sve2_f8cvt, do_f8cvt,
a, gen_helper_sve2_bfcvtn_bh, false, false)
+TRANS_FEAT(FCVTNB, aa64_sme2_or_sve2_f8cvt, do_f8cvt,
+ a, gen_helper_sve2_fcvtnb_bs, false, false)
+TRANS_FEAT(FCVTNT, aa64_sme2_or_sve2_f8cvt, do_f8cvt,
+ a, gen_helper_sve2_fcvtnt_bs, false, false)
/*
*** SVE Floating Point Compare with Zero Group
diff --git a/target/arm/tcg/sve.decode b/target/arm/tcg/sve.decode
index 806953bc35..72755b27af 100644
--- a/target/arm/tcg/sve.decode
+++ b/target/arm/tcg/sve.decode
@@ -1103,6 +1103,8 @@ BF2CVTLT 01100101 00 001 001 001111 ..... ..... @rd_rn_e0
FCVTN 01100101 00 001 010 001100 ....0 ..... @rd_rnx2 esz=1
BFCVTN 01100101 00 001 010 001110 ....0 ..... @rd_rnx2 esz=1
+FCVTNB 01100101 00 001 010 001101 ....0 ..... @rd_rnx2 esz=2
+FCVTNT 01100101 00 001 010 001111 ....0 ..... @rd_rnx2 esz=2
### SVE FP Compare with Zero Group
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread* [PATCH v6 36/64] target/arm: Implement FCVT (FP16 to FP8) for SME
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
` (34 preceding siblings ...)
2026-05-20 18:21 ` [PATCH v6 35/64] target/arm: Implement FCVTNB, FCVTNT " Richard Henderson
@ 2026-05-20 18:21 ` Richard Henderson
2026-05-20 18:21 ` [PATCH v6 37/64] target/arm: Implement FCVT, FCVTN (FP32 " Richard Henderson
` (27 subsequent siblings)
63 siblings, 0 replies; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:21 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/tcg/translate-sme.c | 16 ++++++++++++++++
target/arm/tcg/sme.decode | 2 ++
2 files changed, 18 insertions(+)
diff --git a/target/arm/tcg/translate-sme.c b/target/arm/tcg/translate-sme.c
index 0cbad3e006..050c3cfefe 100644
--- a/target/arm/tcg/translate-sme.c
+++ b/target/arm/tcg/translate-sme.c
@@ -1556,6 +1556,22 @@ TRANS_FEAT(BF2CVT, aa64_sme2_f8cvt, do_f8cvt, a, gen_helper_sme2_bfcvt_hb, 1)
TRANS_FEAT(BF1CVTL, aa64_sme2_f8cvt, do_f8cvt, a, gen_helper_sme2_bfcvtl_hb, 0)
TRANS_FEAT(BF2CVTL, aa64_sme2_f8cvt, do_f8cvt, a, gen_helper_sme2_bfcvtl_hb, 1)
+static bool trans_FCVT_bh(DisasContext *s, arg_zz_n *a)
+{
+ if (!dc_isar_feature(aa64_sme2_f8cvt, s)) {
+ return false;
+ }
+ if (fpmr_access_check(s) && sme_sm_enabled_check(s)) {
+ int svl = streaming_vec_reg_size(s);
+ tcg_gen_gvec_3_ptr(vec_full_reg_offset(s, a->zd),
+ vec_full_reg_offset(s, a->zn),
+ vec_full_reg_offset(s, a->zn + 1),
+ tcg_env, svl, svl,
+ FPST_ZA << 2, gen_helper_gvec_fcvt_bh);
+ }
+ return true;
+}
+
static bool do_zipuzp_4(DisasContext *s, arg_zz_e *a,
gen_helper_gvec_2 * const fn[5])
{
diff --git a/target/arm/tcg/sme.decode b/target/arm/tcg/sme.decode
index d6192eb59d..a02bcc0e22 100644
--- a/target/arm/tcg/sme.decode
+++ b/target/arm/tcg/sme.decode
@@ -863,6 +863,8 @@ BF2CVT 11000001 111 00110 111000 ..... ....0 @zz_2x1
BF1CVTL 11000001 011 00110 111000 ..... ....1 @zz_2x1
BF2CVTL 11000001 111 00110 111000 ..... ....1 @zz_2x1
+FCVT_bh 11000001 001 00100 111000 ....0 ..... @zz_1x2
+
ZIP_4 11000001 esz:2 1 10110 111000 ...00 ... 00 \
&zz_e zd=%zd_ax4 zn=%zn_ax4
ZIP_4 11000001 001 10111 111000 ...00 ... 00 \
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread* [PATCH v6 37/64] target/arm: Implement FCVT, FCVTN (FP32 to FP8) for SME
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
` (35 preceding siblings ...)
2026-05-20 18:21 ` [PATCH v6 36/64] target/arm: Implement FCVT (FP16 to FP8) for SME Richard Henderson
@ 2026-05-20 18:21 ` Richard Henderson
2026-05-20 18:21 ` [PATCH v6 38/64] target/arm: Implement LUTI2, LUTI4 for AdvSIMD Richard Henderson
` (26 subsequent siblings)
63 siblings, 0 replies; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:21 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/tcg/helper-fp8-defs.h | 2 ++
target/arm/tcg/fp8_helper.c | 59 ++++++++++++++++++++++++++++++++
target/arm/tcg/translate-sme.c | 3 ++
target/arm/tcg/sme.decode | 3 ++
4 files changed, 67 insertions(+)
diff --git a/target/arm/tcg/helper-fp8-defs.h b/target/arm/tcg/helper-fp8-defs.h
index 5863a6dbb8..36ae977431 100644
--- a/target/arm/tcg/helper-fp8-defs.h
+++ b/target/arm/tcg/helper-fp8-defs.h
@@ -21,3 +21,5 @@ DEF_HELPER_FLAGS_4(sve2_fcvtn_bh, TCG_CALL_NO_RWG, void, ptr, ptr, env, i32)
DEF_HELPER_FLAGS_5(advsimd_fcvt_bs, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, env, i32)
DEF_HELPER_FLAGS_4(sve2_fcvtnb_bs, TCG_CALL_NO_RWG, void, ptr, ptr, env, i32)
DEF_HELPER_FLAGS_4(sve2_fcvtnt_bs, TCG_CALL_NO_RWG, void, ptr, ptr, env, i32)
+DEF_HELPER_FLAGS_4(sme2_fcvt_bs, TCG_CALL_NO_RWG, void, ptr, ptr, env, i32)
+DEF_HELPER_FLAGS_4(sme2_fcvtn_bs, TCG_CALL_NO_RWG, void, ptr, ptr, env, i32)
diff --git a/target/arm/tcg/fp8_helper.c b/target/arm/tcg/fp8_helper.c
index faa8df692e..8c999655ba 100644
--- a/target/arm/tcg/fp8_helper.c
+++ b/target/arm/tcg/fp8_helper.c
@@ -510,3 +510,62 @@ void HELPER(sve2_fcvtnt_bs)(void *vd, void *vn, CPUARMState *env, uint32_t desc)
fp8_cvt_finish(env, &ctx);
}
+
+void HELPER(sme2_fcvt_bs)(void *vd, void *vn, CPUARMState *env, uint32_t desc)
+{
+ ARMVectorReg scratch[4];
+ FP8Context ctx = fp8_dst_start(env, desc, false);
+ fcvt_fp8_output_fn *output_fmt = fcvt_fp8_output_fmt[ctx.f8fmt];
+ uint32_t *n = vn;
+ uint8_t *d = vd;
+ bool osc = FIELD_EX64(env->vfp.fpmr, FPMR, OSC);
+ size_t oprsz = simd_oprsz(desc);
+ size_t nelem = oprsz / 4;
+ size_t stride = sizeof(ARMVectorReg) / 4;
+
+ if (vectors_overlap(vd, 1, vn, 4)) {
+ n = memcpy(scratch, vn, sizeof(scratch));
+ }
+
+ for (size_t i = 0; i < nelem; i++) {
+ for (size_t j = 0; j < 4; j++) {
+ d[H1(i + nelem * j)] = fcvt_f32_to_fp8(n[H4(i) + stride * j],
+ output_fmt, ctx.scale,
+ osc, &ctx.stat);
+ }
+ }
+
+ fp8_cvt_finish(env, &ctx);
+}
+
+void HELPER(sme2_fcvtn_bs)(void *vd, void *vn, CPUARMState *env, uint32_t desc)
+{
+ FP8Context ctx = fp8_dst_start(env, desc, false);
+ fcvt_fp8_output_fn *output_fmt = fcvt_fp8_output_fmt[ctx.f8fmt];
+ uint32_t *n0 = vn;
+ uint32_t *n1 = vn + sizeof(ARMVectorReg);
+ uint32_t *n2 = vn + sizeof(ARMVectorReg) * 2;
+ uint32_t *n3 = vn + sizeof(ARMVectorReg) * 3;
+ uint8_t *d = vd;
+ bool osc = FIELD_EX64(env->vfp.fpmr, FPMR, OSC);
+ size_t oprsz = simd_oprsz(desc);
+ size_t nelem = oprsz / 4;
+
+ for (size_t i = 0; i < nelem; ++i) {
+ float32 e0 = n0[H4(i)];
+ float32 e1 = n1[H4(i)];
+ float32 e2 = n2[H4(i)];
+ float32 e3 = n3[H4(i)];
+
+ d[H1(4 * i + 0)] = fcvt_f32_to_fp8(e0, output_fmt,
+ ctx.scale, osc, &ctx.stat);
+ d[H1(4 * i + 1)] = fcvt_f32_to_fp8(e1, output_fmt,
+ ctx.scale, osc, &ctx.stat);
+ d[H1(4 * i + 2)] = fcvt_f32_to_fp8(e2, output_fmt,
+ ctx.scale, osc, &ctx.stat);
+ d[H1(4 * i + 3)] = fcvt_f32_to_fp8(e3, output_fmt,
+ ctx.scale, osc, &ctx.stat);
+ }
+
+ fp8_cvt_finish(env, &ctx);
+}
diff --git a/target/arm/tcg/translate-sme.c b/target/arm/tcg/translate-sme.c
index 050c3cfefe..2f79c458e1 100644
--- a/target/arm/tcg/translate-sme.c
+++ b/target/arm/tcg/translate-sme.c
@@ -1572,6 +1572,9 @@ static bool trans_FCVT_bh(DisasContext *s, arg_zz_n *a)
return true;
}
+TRANS_FEAT(FCVT_bs, aa64_sme2_f8cvt, do_f8cvt, a, gen_helper_sme2_fcvt_bs, 0)
+TRANS_FEAT(FCVTN_bs, aa64_sme2_f8cvt, do_f8cvt, a, gen_helper_sme2_fcvtn_bs, 0)
+
static bool do_zipuzp_4(DisasContext *s, arg_zz_e *a,
gen_helper_gvec_2 * const fn[5])
{
diff --git a/target/arm/tcg/sme.decode b/target/arm/tcg/sme.decode
index a02bcc0e22..2b9e41a75a 100644
--- a/target/arm/tcg/sme.decode
+++ b/target/arm/tcg/sme.decode
@@ -865,6 +865,9 @@ BF2CVTL 11000001 111 00110 111000 ..... ....1 @zz_2x1
FCVT_bh 11000001 001 00100 111000 ....0 ..... @zz_1x2
+FCVT_bs 11000001 001 10100 111000 ...00 ..... @zz_1x4
+FCVTN_bs 11000001 001 10100 111000 ...01 ..... @zz_1x4
+
ZIP_4 11000001 esz:2 1 10110 111000 ...00 ... 00 \
&zz_e zd=%zd_ax4 zn=%zn_ax4
ZIP_4 11000001 001 10111 111000 ...00 ... 00 \
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread* [PATCH v6 38/64] target/arm: Implement LUTI2, LUTI4 for AdvSIMD
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
` (36 preceding siblings ...)
2026-05-20 18:21 ` [PATCH v6 37/64] target/arm: Implement FCVT, FCVTN (FP32 " Richard Henderson
@ 2026-05-20 18:21 ` Richard Henderson
2026-05-20 18:21 ` [PATCH v6 39/64] target/arm: Implement LUTI2, LUTI4 for SVE Richard Henderson
` (25 subsequent siblings)
63 siblings, 0 replies; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:21 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/tcg/helper-defs.h | 5 ++++
target/arm/tcg/translate-a64.c | 38 +++++++++++++++++++++++++
target/arm/tcg/vec_helper.c | 52 ++++++++++++++++++++++++++++++++++
target/arm/tcg/a64.decode | 6 ++++
4 files changed, 101 insertions(+)
diff --git a/target/arm/tcg/helper-defs.h b/target/arm/tcg/helper-defs.h
index a05f2258f2..05ccf795e8 100644
--- a/target/arm/tcg/helper-defs.h
+++ b/target/arm/tcg/helper-defs.h
@@ -1122,3 +1122,8 @@ DEF_HELPER_FLAGS_4(sme2_luti4_2s, TCG_CALL_NO_RWG, void, ptr, ptr, env, i32)
DEF_HELPER_FLAGS_4(sme2_luti4_4h, TCG_CALL_NO_RWG, void, ptr, ptr, env, i32)
DEF_HELPER_FLAGS_4(sme2_luti4_4s, TCG_CALL_NO_RWG, void, ptr, ptr, env, i32)
+
+DEF_HELPER_FLAGS_4(gvec_luti2_b, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i32)
+DEF_HELPER_FLAGS_4(gvec_luti2_h, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i32)
+DEF_HELPER_FLAGS_4(gvec_luti4_b, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i32)
+DEF_HELPER_FLAGS_4(gvec_luti4_h, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i32)
diff --git a/target/arm/tcg/translate-a64.c b/target/arm/tcg/translate-a64.c
index 3c784afc99..508d8e377b 100644
--- a/target/arm/tcg/translate-a64.c
+++ b/target/arm/tcg/translate-a64.c
@@ -5405,6 +5405,44 @@ static bool trans_TBL_TBX(DisasContext *s, arg_TBL_TBX *a)
return true;
}
+static bool do_lut_1(DisasContext *s, arg_rrx_e *a, gen_helper_gvec_3 *fn)
+{
+ if (fp_access_check(s)) {
+ gen_gvec_op3_ool(s, true, a->rd, a->rn, a->rm, a->idx, fn);
+ }
+ return true;
+}
+
+TRANS_FEAT(LUTI2_1b, aa64_lut, do_lut_1, a, gen_helper_gvec_luti2_b)
+TRANS_FEAT(LUTI2_1h, aa64_lut, do_lut_1, a, gen_helper_gvec_luti2_h)
+TRANS_FEAT(LUTI4_1b, aa64_lut, do_lut_1, a, gen_helper_gvec_luti4_b)
+
+static bool trans_LUTI4_2h(DisasContext *s, arg_rrx_e *a)
+{
+ if (!dc_isar_feature(aa64_lut, s)) {
+ return false;
+ }
+ if (fp_access_check(s)) {
+ /*
+ * (Ab)use preg_tmp to merge two disjoint 128-bit quantities
+ * into a sequential 256-bit table.
+ */
+ QEMU_BUILD_BUG_ON(sizeof_field(CPUARMState, vfp.preg_tmp) < 32);
+ unsigned tmp_ofs = offsetof(CPUARMState, vfp.preg_tmp);
+ unsigned rn0_ofs = vec_full_reg_offset(s, a->rn);
+ unsigned rn1_ofs = vec_full_reg_offset(s, (a->rn + 1) % 32);
+
+ tcg_gen_gvec_mov(MO_64, tmp_ofs, rn0_ofs, 16, 16);
+ tcg_gen_gvec_mov(MO_64, tmp_ofs + 16, rn1_ofs, 16, 16);
+
+ tcg_gen_gvec_3_ool(vec_full_reg_offset(s, a->rd), tmp_ofs,
+ vec_full_reg_offset(s, a->rm),
+ 16, vec_full_reg_size(s),
+ a->idx, gen_helper_gvec_luti4_h);
+ }
+ return true;
+}
+
typedef int simd_permute_idx_fn(int i, int part, int elements);
static bool do_simd_permute(DisasContext *s, arg_qrrr_e *a,
diff --git a/target/arm/tcg/vec_helper.c b/target/arm/tcg/vec_helper.c
index 91e98d28ae..cb633817d7 100644
--- a/target/arm/tcg/vec_helper.c
+++ b/target/arm/tcg/vec_helper.c
@@ -3348,3 +3348,55 @@ DO_SME2_LUT(4,4,h, 2)
DO_SME2_LUT(4,4,s, 4)
#undef DO_SME2_LUT
+
+void HELPER(gvec_luti2_b)(void *vd, void *vn, void *vm, uint32_t desc)
+{
+ unsigned part = simd_data(desc);
+ unsigned vl = simd_oprsz(desc);
+ unsigned elements = vl / 1;
+ unsigned ibase = elements * part;
+ ARMVectorReg scratch;
+
+ do_lut_b(&scratch, vm, vn, elements, ibase, 0, 2, 8, 1);
+ memcpy(vd, &scratch, vl);
+ clear_tail(vd, vl, simd_maxsz(desc));
+}
+
+void HELPER(gvec_luti2_h)(void *vd, void *vn, void *vm, uint32_t desc)
+{
+ unsigned part = simd_data(desc);
+ unsigned vl = simd_oprsz(desc);
+ unsigned elements = vl / 2;
+ unsigned ibase = elements * part;
+ ARMVectorReg scratch;
+
+ do_lut_h(&scratch, vm, vn, elements, ibase, 0, 2, 16, 1);
+ memcpy(vd, &scratch, vl);
+ clear_tail(vd, vl, simd_maxsz(desc));
+}
+
+void HELPER(gvec_luti4_b)(void *vd, void *vn, void *vm, uint32_t desc)
+{
+ unsigned part = simd_data(desc);
+ unsigned vl = simd_oprsz(desc);
+ unsigned elements = vl / 1;
+ unsigned ibase = elements * part;
+ ARMVectorReg scratch;
+
+ do_lut_b(&scratch, vm, vn, elements, ibase, 0, 4, 8, 1);
+ memcpy(vd, &scratch, vl);
+ clear_tail(vd, vl, simd_maxsz(desc));
+}
+
+void HELPER(gvec_luti4_h)(void *vd, void *vn, void *vm, uint32_t desc)
+{
+ unsigned part = simd_data(desc);
+ unsigned vl = simd_oprsz(desc);
+ unsigned elements = vl / 2;
+ unsigned ibase = elements * part;
+ ARMVectorReg scratch;
+
+ do_lut_h(&scratch, vm, vn, elements, ibase, 0, 4, 16, 1);
+ memcpy(vd, &scratch, vl);
+ clear_tail(vd, vl, simd_maxsz(desc));
+}
diff --git a/target/arm/tcg/a64.decode b/target/arm/tcg/a64.decode
index a9cf259b9b..6aea3ce89f 100644
--- a/target/arm/tcg/a64.decode
+++ b/target/arm/tcg/a64.decode
@@ -1344,6 +1344,12 @@ EXT_q 0110 1110 00 0 rm:5 0 imm:4 0 rn:5 rd:5
TBL_TBX 0 q:1 00 1110 000 rm:5 0 len:2 tbx:1 00 rn:5 rd:5
+LUTI2_1b 0100 1110 100 rm:5 0 idx:2 100 rn:5 rd:5 &rrx_e esz=0
+LUTI2_1h 0100 1110 110 rm:5 0 idx:3 00 rn:5 rd:5 &rrx_e esz=1
+
+LUTI4_1b 0100 1110 010 rm:5 0 idx:1 1000 rn:5 rd:5 &rrx_e esz=0
+LUTI4_2h 0100 1110 010 rm:5 0 idx:2 100 rn:5 rd:5 &rrx_e esz=1
+
# Advanced SIMD Permute
UZP1 0.00 1110 .. 0 ..... 0 001 10 ..... ..... @qrrr_e
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread* [PATCH v6 39/64] target/arm: Implement LUTI2, LUTI4 for SVE
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
` (37 preceding siblings ...)
2026-05-20 18:21 ` [PATCH v6 38/64] target/arm: Implement LUTI2, LUTI4 for AdvSIMD Richard Henderson
@ 2026-05-20 18:21 ` Richard Henderson
2026-05-20 18:21 ` [PATCH v6 40/64] target/arm: Enable FEAT_LUT for -cpu max Richard Henderson
` (24 subsequent siblings)
63 siblings, 0 replies; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:21 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/cpu-features.h | 6 +++
target/arm/tcg/translate.h | 8 ++++
target/arm/tcg/translate-a64.c | 1 +
target/arm/tcg/translate-sve.c | 68 ++++++++++++++++++++++++++++++++++
target/arm/tcg/sve.decode | 11 +++++-
5 files changed, 93 insertions(+), 1 deletion(-)
diff --git a/target/arm/cpu-features.h b/target/arm/cpu-features.h
index fd09bbc5cf..6d5994450f 100644
--- a/target/arm/cpu-features.h
+++ b/target/arm/cpu-features.h
@@ -1649,6 +1649,12 @@ isar_feature_aa64_sme2_or_sve2_f8cvt(const ARMISARegisters *id)
return isar_feature_aa64_sme2_or_sve2(id) && isar_feature_aa64_f8cvt(id);
}
+static inline bool
+isar_feature_aa64_sme2_or_sve2_lut(const ARMISARegisters *id)
+{
+ return isar_feature_aa64_sme2_or_sve2(id) && isar_feature_aa64_lut(id);
+}
+
/*
* Feature tests for "does this exist in either 32-bit or 64-bit?"
*/
diff --git a/target/arm/tcg/translate.h b/target/arm/tcg/translate.h
index 1648c2c96f..b703e75b70 100644
--- a/target/arm/tcg/translate.h
+++ b/target/arm/tcg/translate.h
@@ -90,6 +90,7 @@ typedef struct DisasContext {
int vl; /* current vector length in bytes */
int svl; /* current streaming vector length in bytes */
int max_svl; /* maximum implemented streaming vector length */
+ int max_any_vl; /* maximum implemented vector length */
bool vfp_enabled; /* FP enabled via FPSCR.EN */
int vec_len;
int vec_stride;
@@ -874,4 +875,11 @@ static inline void gen_restore_rmode(TCGv_i32 old, TCGv_ptr fpst)
return dc_isar_feature(FEAT, s) && FUNC(s, __VA_ARGS__); \
}
+#define TRANS_FEAT_SME1_NONSTREAMING(NAME, FEAT, FUNC, ...) \
+ static bool trans_##NAME(DisasContext *s, arg_##NAME *a) \
+ { \
+ s->is_nonstreaming = !dc_isar_feature(aa64_sme2, s); \
+ return dc_isar_feature(FEAT, s) && FUNC(s, __VA_ARGS__); \
+ }
+
#endif /* TARGET_ARM_TRANSLATE_H */
diff --git a/target/arm/tcg/translate-a64.c b/target/arm/tcg/translate-a64.c
index 508d8e377b..ee71c63116 100644
--- a/target/arm/tcg/translate-a64.c
+++ b/target/arm/tcg/translate-a64.c
@@ -10820,6 +10820,7 @@ static void aarch64_tr_init_disas_context(DisasContextBase *dcbase,
dc->vl = (EX_TBFLAG_A64(tb_flags, VL) + 1) * 16;
dc->svl = (EX_TBFLAG_A64(tb_flags, SVL) + 1) * 16;
dc->max_svl = arm_cpu->sme_max_vq * 16;
+ dc->max_any_vl = MAX(dc->max_svl, arm_cpu->sve_max_vq * 16);
dc->pauth_active = EX_TBFLAG_A64(tb_flags, PAUTH_ACTIVE);
dc->bt = EX_TBFLAG_A64(tb_flags, BT);
dc->btype = EX_TBFLAG_A64(tb_flags, BTYPE);
diff --git a/target/arm/tcg/translate-sve.c b/target/arm/tcg/translate-sve.c
index 13f7ab01af..ea0d66178e 100644
--- a/target/arm/tcg/translate-sve.c
+++ b/target/arm/tcg/translate-sve.c
@@ -8268,3 +8268,71 @@ TRANS_FEAT(LD1_zcrr_stride, aa64_sme2, gen_ldst_zcrr_c, a, false, true)
TRANS_FEAT(LD1_zcri_stride, aa64_sme2, gen_ldst_zcri_c, a, false, true)
TRANS_FEAT(ST1_zcrr_stride, aa64_sme2, gen_ldst_zcrr_c, a, true, true)
TRANS_FEAT(ST1_zcri_stride, aa64_sme2, gen_ldst_zcri_c, a, true, true)
+
+TRANS_FEAT_SME1_NONSTREAMING(LUTI2_1b, aa64_sme2_or_sve2_lut,
+ gen_gvec_ool_zzz, gen_helper_gvec_luti2_b,
+ a->rd, a->rn, a->rm, a->index)
+TRANS_FEAT_SME1_NONSTREAMING(LUTI2_1h, aa64_sme2_or_sve2_lut,
+ gen_gvec_ool_zzz, gen_helper_gvec_luti2_h,
+ a->rd, a->rn, a->rm, a->index)
+TRANS_FEAT_SME1_NONSTREAMING(LUTI4_1b, aa64_sme2_or_sve2_lut,
+ gen_gvec_ool_zzz, gen_helper_gvec_luti4_b,
+ a->rd, a->rn, a->rm, a->index)
+
+static bool trans_LUTI4_1h(DisasContext *s, arg_LUTI4_1h *a)
+{
+ if (!dc_isar_feature(aa64_sme2_or_sve2_lut, s)) {
+ return false;
+ }
+ s->is_nonstreaming = !dc_isar_feature(aa64_sme2, s);
+
+ /*
+ * The MaxImplementedAnyVL check happens in the decode pseudocode,
+ * before the Check*SVEEnabled check in the operation pseudocode.
+ */
+ if (s->max_any_vl < 32) {
+ unallocated_encoding(s);
+ } else if (sve_access_check(s)) {
+ unsigned vsz = vec_full_reg_size(s);
+
+ /* Then there's a second check against CurrentVL. */
+ if (vsz < 32) {
+ unallocated_encoding(s);
+ } else {
+ tcg_gen_gvec_3_ool(vec_full_reg_offset(s, a->rd),
+ vec_full_reg_offset(s, a->rn),
+ vec_full_reg_offset(s, a->rm),
+ vsz, vsz, a->index,
+ gen_helper_gvec_luti4_h);
+ }
+ }
+ return true;
+}
+
+static bool trans_LUTI4_2h(DisasContext *s, arg_LUTI4_2h *a)
+{
+ if (!dc_isar_feature(aa64_sme2_or_sve2_lut, s)) {
+ return false;
+ }
+ s->is_nonstreaming = !dc_isar_feature(aa64_sme2, s);
+
+ if (sve_access_check(s)) {
+ unsigned vsz = vec_full_reg_size(s);
+ /*
+ * (Ab)use preg_tmp to merge two disjoint 128-bit quantities
+ * into a sequential 256-bit table.
+ */
+ QEMU_BUILD_BUG_ON(sizeof_field(CPUARMState, vfp.preg_tmp) < 32);
+ unsigned tmp_ofs = offsetof(CPUARMState, vfp.preg_tmp);
+ unsigned rn0_ofs = vec_full_reg_offset(s, a->rn);
+ unsigned rn1_ofs = vec_full_reg_offset(s, (a->rn + 1) % 32);
+
+ tcg_gen_gvec_mov(MO_64, tmp_ofs, rn0_ofs, 16, 16);
+ tcg_gen_gvec_mov(MO_64, tmp_ofs + 16, rn1_ofs, 16, 16);
+
+ tcg_gen_gvec_3_ool(vec_full_reg_offset(s, a->rd), tmp_ofs,
+ vec_full_reg_offset(s, a->rm),
+ vsz, vsz, a->index, gen_helper_gvec_luti4_h);
+ }
+ return true;
+}
diff --git a/target/arm/tcg/sve.decode b/target/arm/tcg/sve.decode
index 72755b27af..e2106fc7f5 100644
--- a/target/arm/tcg/sve.decode
+++ b/target/arm/tcg/sve.decode
@@ -31,6 +31,7 @@
%dtype_23_13 23:2 13:2
%index3_22_19 22:1 19:2
%index3_22_17 22:1 17:2
+%index3_22_12 22:2 12:1
%index3_19_11 19:2 11:1
%index2_20_11 20:1 11:1
@@ -1737,11 +1738,19 @@ RSUBHNT 01000101 .. 1 ..... 011 111 ..... ..... @rd_rn_rm
MATCH 01000101 .. 1 ..... 100 ... ..... 0 .... @pd_pg_rn_rm
NMATCH 01000101 .. 1 ..... 100 ... ..... 1 .... @pd_pg_rn_rm
-### SVE2 Histogram Computation
+### SVE2 Histogram Computation and Lookup Table
HISTCNT 01000101 .. 1 ..... 110 ... ..... ..... @rd_pg_rn_rm
HISTSEG 01000101 .. 1 ..... 101 000 ..... ..... @rd_rn_rm
+LUTI2_1b 01000101 index:2 1 rm:5 101100 rn:5 rd:5 &rrx_esz esz=0
+LUTI2_1h 01000101 .. 1 rm:5 101.10 rn:5 rd:5 \
+ &rrx_esz esz=1 index=%index3_22_12
+
+LUTI4_1b 01000101 index:1 11 rm:5 101001 rn:5 rd:5 &rrx_esz esz=0
+LUTI4_1h 01000101 index:2 1 rm:5 101111 rn:5 rd:5 &rrx_esz esz=1
+LUTI4_2h 01000101 index:2 1 rm:5 101101 rn:5 rd:5 &rrx_esz esz=1
+
## SVE2 floating-point pairwise operations
FADDP 01100100 .. 010 00 0 100 ... ..... ..... @rdn_pg_rm
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread* [PATCH v6 40/64] target/arm: Enable FEAT_LUT for -cpu max
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
` (38 preceding siblings ...)
2026-05-20 18:21 ` [PATCH v6 39/64] target/arm: Implement LUTI2, LUTI4 for SVE Richard Henderson
@ 2026-05-20 18:21 ` Richard Henderson
2026-05-20 18:21 ` [PATCH v6 41/64] target/arm: Enable FEAT_FP8 " Richard Henderson
` (23 subsequent siblings)
63 siblings, 0 replies; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:21 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/tcg/cpu64.c | 1 +
docs/system/arm/emulation.rst | 1 +
2 files changed, 2 insertions(+)
diff --git a/target/arm/tcg/cpu64.c b/target/arm/tcg/cpu64.c
index a377f67b9c..bc866c5a67 100644
--- a/target/arm/tcg/cpu64.c
+++ b/target/arm/tcg/cpu64.c
@@ -1263,6 +1263,7 @@ void aarch64_max_tcg_initfn(Object *obj)
t = FIELD_DP64(t, ID_AA64ISAR2, BC, 1); /* FEAT_HBC */
t = FIELD_DP64(t, ID_AA64ISAR2, WFXT, 2); /* FEAT_WFxT */
t = FIELD_DP64(t, ID_AA64ISAR2, CSSC, 1); /* FEAT_CSSC */
+ t = FIELD_DP64(t, ID_AA64ISAR2, LUT, 1); /* FEAT_LUT */
t = FIELD_DP64(t, ID_AA64ISAR2, ATS1A, 1); /* FEAT_ATS1A */
SET_IDREG(isar, ID_AA64ISAR2, t);
diff --git a/docs/system/arm/emulation.rst b/docs/system/arm/emulation.rst
index 44c7196d09..cf8771d541 100644
--- a/docs/system/arm/emulation.rst
+++ b/docs/system/arm/emulation.rst
@@ -101,6 +101,7 @@ the following architecture extensions:
- FEAT_LSE (Large System Extensions)
- FEAT_LSE2 (Large System Extensions v2)
- FEAT_LSE128 (128-bit Atomics)
+- FEAT_LUT (Lookup table instructions with 2-bit and 4-bit indices)
- FEAT_LVA (Large Virtual Address space)
- FEAT_MEC (Memory Encryption Contexts)
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread* [PATCH v6 41/64] target/arm: Enable FEAT_FP8 for -cpu max
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
` (39 preceding siblings ...)
2026-05-20 18:21 ` [PATCH v6 40/64] target/arm: Enable FEAT_LUT for -cpu max Richard Henderson
@ 2026-05-20 18:21 ` Richard Henderson
2026-05-20 18:21 ` [PATCH v6 42/64] target/arm: Update ID_AA64SMFR0_EL1 fields to ARM M.b Richard Henderson
` (22 subsequent siblings)
63 siblings, 0 replies; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:21 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/tcg/cpu64.c | 6 ++++++
docs/system/arm/emulation.rst | 1 +
2 files changed, 7 insertions(+)
diff --git a/target/arm/tcg/cpu64.c b/target/arm/tcg/cpu64.c
index bc866c5a67..8d0c057902 100644
--- a/target/arm/tcg/cpu64.c
+++ b/target/arm/tcg/cpu64.c
@@ -1391,6 +1391,12 @@ void aarch64_max_tcg_initfn(Object *obj)
t = FIELD_DP64(t, ID_AA64SMFR0, FA64, 1); /* FEAT_SME_FA64 */
SET_IDREG(isar, ID_AA64SMFR0, t);
+ t = GET_IDREG(isar, ID_AA64FPFR0);
+ t = FIELD_DP64(t, ID_AA64FPFR0, F8E5M2, 1); /* FEAT_FP8 */
+ t = FIELD_DP64(t, ID_AA64FPFR0, F8E4M3, 1); /* FEAT_FP8 */
+ t = FIELD_DP64(t, ID_AA64FPFR0, F8CVT, 1); /* FEAT_FP8 */
+ SET_IDREG(isar, ID_AA64FPFR0, t);
+
/* Replicate the same data to the 32-bit id registers. */
aa32_max_features(cpu);
diff --git a/docs/system/arm/emulation.rst b/docs/system/arm/emulation.rst
index cf8771d541..b6f0ca9351 100644
--- a/docs/system/arm/emulation.rst
+++ b/docs/system/arm/emulation.rst
@@ -74,6 +74,7 @@ the following architecture extensions:
- FEAT_FHM (Floating-point half-precision multiplication instructions)
- FEAT_FP (Floating Point extensions)
- FEAT_FP16 (Half-precision floating-point data processing)
+- FEAT_FP8 (FP8 convert instructions)
- FEAT_FPAC (Faulting on AUT* instructions)
- FEAT_FPACCOMBINE (Faulting on combined pointer authentication instructions)
- FEAT_FPACC_SPEC (Speculative behavior of combined pointer authentication instructions)
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread* [PATCH v6 42/64] target/arm: Update ID_AA64SMFR0_EL1 fields to ARM M.b
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
` (40 preceding siblings ...)
2026-05-20 18:21 ` [PATCH v6 41/64] target/arm: Enable FEAT_FP8 " Richard Henderson
@ 2026-05-20 18:21 ` Richard Henderson
2026-05-21 16:41 ` Peter Maydell
2026-05-20 18:21 ` [PATCH v6 43/64] target/arm: Implement MOVT (vector to table) Richard Henderson
` (21 subsequent siblings)
63 siblings, 1 reply; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:21 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/cpu-features.h | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/target/arm/cpu-features.h b/target/arm/cpu-features.h
index 6d5994450f..811f2a7291 100644
--- a/target/arm/cpu-features.h
+++ b/target/arm/cpu-features.h
@@ -397,17 +397,28 @@ FIELD(ID_AA64ZFR0, F16MM, 48, 4)
FIELD(ID_AA64ZFR0, F32MM, 52, 4)
FIELD(ID_AA64ZFR0, F64MM, 56, 4)
+FIELD(ID_AA64SMFR0, SMOP4, 0, 1)
+FIELD(ID_AA64SMFR0, STMOP, 16, 1)
+FIELD(ID_AA64SMFR0, SFEXPA, 23, 1)
+FIELD(ID_AA64SMFR0, AES, 24, 1)
+FIELD(ID_AA64SMFR0, SBITPERM, 25, 1)
+FIELD(ID_AA64SMFR0, SF8DP2, 28, 1)
+FIELD(ID_AA64SMFR0, SF8DP4, 29, 1)
+FIELD(ID_AA64SMFR0, SF8FMA, 30, 1)
FIELD(ID_AA64SMFR0, F32F32, 32, 1)
FIELD(ID_AA64SMFR0, BI32I32, 33, 1)
FIELD(ID_AA64SMFR0, B16F32, 34, 1)
FIELD(ID_AA64SMFR0, F16F32, 35, 1)
FIELD(ID_AA64SMFR0, I8I32, 36, 4)
+FIELD(ID_AA64SMFR0, F8F32, 40, 1)
+FIELD(ID_AA64SMFR0, F8F16, 41, 1)
FIELD(ID_AA64SMFR0, F16F16, 42, 1)
FIELD(ID_AA64SMFR0, B16B16, 43, 1)
FIELD(ID_AA64SMFR0, I16I32, 44, 4)
FIELD(ID_AA64SMFR0, F64F64, 48, 1)
FIELD(ID_AA64SMFR0, I16I64, 52, 4)
FIELD(ID_AA64SMFR0, SMEVER, 56, 4)
+FIELD(ID_AA64SMFR0, LUTv2, 60, 1)
FIELD(ID_AA64SMFR0, FA64, 63, 1)
FIELD(ID_AA64FPFR0, F8E5M2, 0, 1)
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread* [PATCH v6 43/64] target/arm: Implement MOVT (vector to table)
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
` (41 preceding siblings ...)
2026-05-20 18:21 ` [PATCH v6 42/64] target/arm: Update ID_AA64SMFR0_EL1 fields to ARM M.b Richard Henderson
@ 2026-05-20 18:21 ` Richard Henderson
2026-05-20 18:21 ` [PATCH v6 44/64] target/arm: Implement LUTI4 (four registers, 8-bit) Richard Henderson
` (20 subsequent siblings)
63 siblings, 0 replies; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:21 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/cpu-features.h | 5 +++++
target/arm/tcg/translate-sme.c | 18 ++++++++++++++++++
target/arm/tcg/sme.decode | 2 ++
3 files changed, 25 insertions(+)
diff --git a/target/arm/cpu-features.h b/target/arm/cpu-features.h
index 811f2a7291..29d0464a03 100644
--- a/target/arm/cpu-features.h
+++ b/target/arm/cpu-features.h
@@ -1570,6 +1570,11 @@ static inline bool isar_feature_aa64_sme_fa64(const ARMISARegisters *id)
return FIELD_EX64_IDREG(id, ID_AA64SMFR0, FA64);
}
+static inline bool isar_feature_aa64_sme_lutv2(const ARMISARegisters *id)
+{
+ return FIELD_EX64_IDREG(id, ID_AA64SMFR0, LUTv2);
+}
+
static inline bool isar_feature_aa64_sme2(const ARMISARegisters *id)
{
return FIELD_EX64_IDREG(id, ID_AA64SMFR0, SMEVER) != 0;
diff --git a/target/arm/tcg/translate-sme.c b/target/arm/tcg/translate-sme.c
index 2f79c458e1..214427db1f 100644
--- a/target/arm/tcg/translate-sme.c
+++ b/target/arm/tcg/translate-sme.c
@@ -391,6 +391,24 @@ static bool do_movt(DisasContext *s, arg_MOVT_rzt *a,
TRANS_FEAT(MOVT_rzt, aa64_sme2, do_movt, a, tcg_gen_ld_i64)
TRANS_FEAT(MOVT_ztr, aa64_sme2, do_movt, a, tcg_gen_st_i64)
+static bool trans_MOVT_ztz(DisasContext *s, arg_MOVT_ztz *a)
+{
+ if (!dc_isar_feature(aa64_sme_lutv2, s)) {
+ return false;
+ }
+ if (sme_sm_enabled_check(s) && sme2_zt0_enabled_check(s)) {
+ int svl = streaming_vec_reg_size(s);
+ int tsize = MIN(svl, 64);
+ int offset = (a->off % (64 / tsize)) * tsize;
+
+ tcg_gen_gvec_mov(MO_64,
+ offsetof(CPUARMState, za_state.zt0) + offset,
+ vec_full_reg_offset(s, a->rt), tsize,
+ offset ? tsize : 64);
+ }
+ return true;
+}
+
static bool trans_LDST1(DisasContext *s, arg_LDST1 *a)
{
typedef void GenLdSt1(TCGv_env, TCGv_ptr, TCGv_ptr, TCGv, TCGv_i64);
diff --git a/target/arm/tcg/sme.decode b/target/arm/tcg/sme.decode
index 2b9e41a75a..339de72b8a 100644
--- a/target/arm/tcg/sme.decode
+++ b/target/arm/tcg/sme.decode
@@ -141,6 +141,8 @@ MOVAZ_zt4 11000000 11 00011 0 v:1 .. 00110 za:3 zr:3 00 \
MOVT_rzt 1100 0000 0100 1100 0 off:3 00 11111 rt:5
MOVT_ztr 1100 0000 0100 1110 0 off:3 00 11111 rt:5
+MOVT_ztz 1100 0000 0100 1111 00 off:2 00 11111 rt:5
+
### SME Memory
&ldst esz rs pg rn rm za off v:bool st:bool
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread* [PATCH v6 44/64] target/arm: Implement LUTI4 (four registers, 8-bit)
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
` (42 preceding siblings ...)
2026-05-20 18:21 ` [PATCH v6 43/64] target/arm: Implement MOVT (vector to table) Richard Henderson
@ 2026-05-20 18:21 ` Richard Henderson
2026-05-20 18:21 ` [PATCH v6 45/64] target/arm: Enable FEAT_SME_LUTv2 for -cpu max Richard Henderson
` (19 subsequent siblings)
63 siblings, 0 replies; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:21 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/cpu-features.h | 5 +++++
target/arm/tcg/helper-defs.h | 1 +
target/arm/tcg/translate-sme.c | 6 ++++++
target/arm/tcg/vec_helper.c | 14 ++++++++++++++
target/arm/tcg/sme.decode | 6 ++++++
5 files changed, 32 insertions(+)
diff --git a/target/arm/cpu-features.h b/target/arm/cpu-features.h
index 29d0464a03..007e656ed4 100644
--- a/target/arm/cpu-features.h
+++ b/target/arm/cpu-features.h
@@ -1643,6 +1643,11 @@ static inline bool isar_feature_aa64_sme2_f8cvt(const ARMISARegisters *id)
return isar_feature_aa64_sme2(id) && isar_feature_aa64_f8cvt(id);
}
+static inline bool isar_feature_aa64_sme2p1_lutv2(const ARMISARegisters *id)
+{
+ return isar_feature_aa64_sme2p1(id) && isar_feature_aa64_sme_lutv2(id);
+}
+
static inline bool isar_feature_aa64_sve_i8mm(const ARMISARegisters *id)
{
return isar_feature_aa64_sve(id) && isar_feature_aa64_sme_sve_i8mm(id);
diff --git a/target/arm/tcg/helper-defs.h b/target/arm/tcg/helper-defs.h
index 05ccf795e8..8ec6c16319 100644
--- a/target/arm/tcg/helper-defs.h
+++ b/target/arm/tcg/helper-defs.h
@@ -1120,6 +1120,7 @@ DEF_HELPER_FLAGS_4(sme2_luti4_2b, TCG_CALL_NO_RWG, void, ptr, ptr, env, i32)
DEF_HELPER_FLAGS_4(sme2_luti4_2h, TCG_CALL_NO_RWG, void, ptr, ptr, env, i32)
DEF_HELPER_FLAGS_4(sme2_luti4_2s, TCG_CALL_NO_RWG, void, ptr, ptr, env, i32)
+DEF_HELPER_FLAGS_4(sme2_luti4_4b, TCG_CALL_NO_RWG, void, ptr, ptr, env, i32)
DEF_HELPER_FLAGS_4(sme2_luti4_4h, TCG_CALL_NO_RWG, void, ptr, ptr, env, i32)
DEF_HELPER_FLAGS_4(sme2_luti4_4s, TCG_CALL_NO_RWG, void, ptr, ptr, env, i32)
diff --git a/target/arm/tcg/translate-sme.c b/target/arm/tcg/translate-sme.c
index 214427db1f..0af133c1c4 100644
--- a/target/arm/tcg/translate-sme.c
+++ b/target/arm/tcg/translate-sme.c
@@ -1846,6 +1846,9 @@ TRANS_FEAT(LUTI4_c_2s, aa64_sme2, do_lut, a, gen_helper_sme2_luti4_2s, false)
TRANS_FEAT(LUTI4_c_4h, aa64_sme2, do_lut, a, gen_helper_sme2_luti4_4h, false)
TRANS_FEAT(LUTI4_c_4s, aa64_sme2, do_lut, a, gen_helper_sme2_luti4_4s, false)
+TRANS_FEAT(LUTI4_c_4b, aa64_sme_lutv2, do_lut, a,
+ gen_helper_sme2_luti4_4b, false)
+
static bool do_lut_s4(DisasContext *s, arg_lut *a, gen_helper_gvec_2_ptr *fn)
{
return !(a->zd & 0b01100) && do_lut(s, a, fn, true);
@@ -1866,3 +1869,6 @@ TRANS_FEAT(LUTI4_s_2b, aa64_sme2p1, do_lut_s8, a, gen_helper_sme2_luti4_2b)
TRANS_FEAT(LUTI4_s_2h, aa64_sme2p1, do_lut_s8, a, gen_helper_sme2_luti4_2h)
TRANS_FEAT(LUTI4_s_4h, aa64_sme2p1, do_lut_s4, a, gen_helper_sme2_luti4_4h)
+
+TRANS_FEAT(LUTI4_s_4b, aa64_sme2p1_lutv2, do_lut_s4, a,
+ gen_helper_sme2_luti4_4b)
diff --git a/target/arm/tcg/vec_helper.c b/target/arm/tcg/vec_helper.c
index cb633817d7..eaf15a0cb5 100644
--- a/target/arm/tcg/vec_helper.c
+++ b/target/arm/tcg/vec_helper.c
@@ -3349,6 +3349,20 @@ DO_SME2_LUT(4,4,s, 4)
#undef DO_SME2_LUT
+void helper_sme2_luti4_4b(void *zd, void *zn, CPUARMState *env, uint32_t desc)
+{
+ unsigned vl = simd_oprsz(desc);
+ unsigned strided = extract32(desc, SIMD_DATA_SHIFT, 1);
+ unsigned dstride = !strided ? 1 : 4;
+ uint64_t indexes[ARM_MAX_VQ * 4];
+
+ memcpy(&indexes, zn, vl);
+ memcpy((void *)&indexes + vl, zn + sizeof(ARMVectorReg), vl);
+
+ do_lut_b(zd, indexes, (void *)env->za_state.zt0, vl, 0,
+ dstride * sizeof(ARMVectorReg), 4, 32, 4);
+}
+
void HELPER(gvec_luti2_b)(void *vd, void *vn, void *vm, uint32_t desc)
{
unsigned part = simd_data(desc);
diff --git a/target/arm/tcg/sme.decode b/target/arm/tcg/sme.decode
index 339de72b8a..495330aed7 100644
--- a/target/arm/tcg/sme.decode
+++ b/target/arm/tcg/sme.decode
@@ -1014,8 +1014,14 @@ LUTI4_c_2s 1100 0000 1000 101 idx:2 1 10 00 zn:5 .... 0 &lut zd=%zd_ax2
LUTI4_c_4h 1100 0000 1000 101 idx:1 10 01 00 zn:5 ... 00 &lut zd=%zd_ax4
LUTI4_c_4s 1100 0000 1000 101 idx:1 10 10 00 zn:5 ... 00 &lut zd=%zd_ax4
+LUTI4_c_4b 1100 0000 1000 101 1 00 00 00 ....0 ...00 \
+ &lut zd=%zd_ax4 zn=%zn_ax2 idx=0
+
# LUTI4, strided (must check zd alignment)
LUTI4_s_2b 1100 0000 1001 101 idx:2 1 00 00 zn:5 zd:5 &lut
LUTI4_s_2h 1100 0000 1001 101 idx:2 1 01 00 zn:5 zd:5 &lut
LUTI4_s_4h 1100 0000 1001 101 idx:1 10 01 00 zn:5 zd:5 &lut
+
+LUTI4_s_4b 1100 0000 1001 101 1 00 00 00 ....0 zd:5 \
+ &lut zn=%zn_ax2 idx=0
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread* [PATCH v6 45/64] target/arm: Enable FEAT_SME_LUTv2 for -cpu max
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
` (43 preceding siblings ...)
2026-05-20 18:21 ` [PATCH v6 44/64] target/arm: Implement LUTI4 (four registers, 8-bit) Richard Henderson
@ 2026-05-20 18:21 ` Richard Henderson
2026-05-20 18:21 ` [PATCH v6 46/64] target/arm: Implement FMLALB, FMLALT for AdvSIMD Richard Henderson
` (18 subsequent siblings)
63 siblings, 0 replies; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:21 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/tcg/cpu64.c | 1 +
docs/system/arm/emulation.rst | 1 +
2 files changed, 2 insertions(+)
diff --git a/target/arm/tcg/cpu64.c b/target/arm/tcg/cpu64.c
index 8d0c057902..90214a355a 100644
--- a/target/arm/tcg/cpu64.c
+++ b/target/arm/tcg/cpu64.c
@@ -1388,6 +1388,7 @@ void aarch64_max_tcg_initfn(Object *obj)
t = FIELD_DP64(t, ID_AA64SMFR0, F64F64, 1); /* FEAT_SME_F64F64 */
t = FIELD_DP64(t, ID_AA64SMFR0, I16I64, 0xf); /* FEAT_SME_I16I64 */
t = FIELD_DP64(t, ID_AA64SMFR0, SMEVER, 2); /* FEAT_SME2p1 */
+ t = FIELD_DP64(t, ID_AA64SMFR0, LUTv2, 1); /* FEAT_SME_LUTv2 */
t = FIELD_DP64(t, ID_AA64SMFR0, FA64, 1); /* FEAT_SME_FA64 */
SET_IDREG(isar, ID_AA64SMFR0, t);
diff --git a/docs/system/arm/emulation.rst b/docs/system/arm/emulation.rst
index b6f0ca9351..0dd6b554a0 100644
--- a/docs/system/arm/emulation.rst
+++ b/docs/system/arm/emulation.rst
@@ -158,6 +158,7 @@ the following architecture extensions:
- FEAT_SME_F16F16 (Non-widening half-precision FP16 arithmetic for SME2)
- FEAT_SME_F64F64 (Double-precision floating-point outer product instructions)
- FEAT_SME_I16I64 (16-bit to 64-bit integer widening outer product instructions)
+- FEAT_SME_LUTv2 (Lookup table instructions with 4-bit indices and 8-bit elements)
- FEAT_SVE (Scalable Vector Extension)
- FEAT_SVE_AES (Scalable Vector AES instructions)
- FEAT_SVE_B16B16 (Non-widening BFloat16 arithmetic for SVE2)
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread* [PATCH v6 46/64] target/arm: Implement FMLALB, FMLALT for AdvSIMD
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
` (44 preceding siblings ...)
2026-05-20 18:21 ` [PATCH v6 45/64] target/arm: Enable FEAT_SME_LUTv2 for -cpu max Richard Henderson
@ 2026-05-20 18:21 ` Richard Henderson
2026-05-20 18:21 ` [PATCH v6 47/64] target/arm: Implement FMLALB, FMLALT (FP8 to FP16) for SVE Richard Henderson
` (17 subsequent siblings)
63 siblings, 0 replies; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:21 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/cpu-features.h | 5 ++
target/arm/tcg/helper-fp8-defs.h | 3 +
target/arm/tcg/fp8_helper.c | 105 +++++++++++++++++++++++++++++++
target/arm/tcg/translate-a64.c | 16 +++++
target/arm/tcg/a64.decode | 8 +++
5 files changed, 137 insertions(+)
diff --git a/target/arm/cpu-features.h b/target/arm/cpu-features.h
index 007e656ed4..ee20d74164 100644
--- a/target/arm/cpu-features.h
+++ b/target/arm/cpu-features.h
@@ -1590,6 +1590,11 @@ static inline bool isar_feature_aa64_f8cvt(const ARMISARegisters *id)
return FIELD_EX64_IDREG(id, ID_AA64FPFR0, F8CVT);
}
+static inline bool isar_feature_aa64_f8fma(const ARMISARegisters *id)
+{
+ return FIELD_EX64_IDREG(id, ID_AA64FPFR0, F8FMA);
+}
+
/*
* Combinations of feature tests, for ease of use with TRANS_FEAT.
*/
diff --git a/target/arm/tcg/helper-fp8-defs.h b/target/arm/tcg/helper-fp8-defs.h
index 36ae977431..7aa8366d94 100644
--- a/target/arm/tcg/helper-fp8-defs.h
+++ b/target/arm/tcg/helper-fp8-defs.h
@@ -23,3 +23,6 @@ DEF_HELPER_FLAGS_4(sve2_fcvtnb_bs, TCG_CALL_NO_RWG, void, ptr, ptr, env, i32)
DEF_HELPER_FLAGS_4(sve2_fcvtnt_bs, TCG_CALL_NO_RWG, void, ptr, ptr, env, i32)
DEF_HELPER_FLAGS_4(sme2_fcvt_bs, TCG_CALL_NO_RWG, void, ptr, ptr, env, i32)
DEF_HELPER_FLAGS_4(sme2_fcvtn_bs, TCG_CALL_NO_RWG, void, ptr, ptr, env, i32)
+
+DEF_HELPER_FLAGS_5(gvec_fmla_hb, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, env, i32)
+DEF_HELPER_FLAGS_5(gvec_fmla_idx_hb, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, env, i32)
diff --git a/target/arm/tcg/fp8_helper.c b/target/arm/tcg/fp8_helper.c
index 8c999655ba..d86d3d0bfb 100644
--- a/target/arm/tcg/fp8_helper.c
+++ b/target/arm/tcg/fp8_helper.c
@@ -569,3 +569,108 @@ void HELPER(sme2_fcvtn_bs)(void *vd, void *vn, CPUARMState *env, uint32_t desc)
fp8_cvt_finish(env, &ctx);
}
+
+typedef struct FP8MulContext {
+ float_status stat;
+ fp8_input_fn *fmt1;
+ fp8_input_fn *fmt2;
+ int scale;
+} FP8MulContext;
+
+static FP8MulContext fp8_mul_start(CPUARMState *env, int scale_mask)
+{
+ uint64_t fpmr = env->vfp.fpmr;
+
+ FP8MulContext ret = {
+ .stat = env->vfp.fp_status[FPST_A64],
+ .fmt1 = fp8_input_fmt[FIELD_EX64(fpmr, FPMR, F8S1)],
+ .fmt2 = fp8_input_fmt[FIELD_EX64(fpmr, FPMR, F8S2)],
+ .scale = -(FIELD_EX64(fpmr, FPMR, LSCALE) & scale_mask),
+ };
+
+ set_flush_to_zero(0, &ret.stat);
+ set_flush_inputs_to_zero(0, &ret.stat);
+ set_default_nan_mode(true, &ret.stat);
+ set_float_rounding_mode(FIELD_EX64(fpmr, FPMR, OSM)
+ ? float_round_nearest_even_max
+ : float_round_nearest_even, &ret.stat);
+
+ /*
+ * FP8 multiplies don't update FPSR.{IDC,IOC,IXC,UFC}.
+ * Since this is multiply-add, DZC does not apply and only OFC remains.
+ */
+ return ret;
+}
+
+static FloatParts64 f8dot(uint64_t a, uint64_t b, int n, FP8MulContext *ctx)
+{
+ /*
+ * Because of default_nan_mode, NaNs need no special handling.
+ * We'll simply get the default NaN out at the end of the sequence.
+ */
+ FloatParts64 p0 = ctx->fmt1(a & 0xff, &ctx->stat);
+ FloatParts64 p1 = ctx->fmt2(b & 0xff, &ctx->stat);
+ FloatParts64 pr = parts64_mul(&p0, &p1, &ctx->stat);
+
+ for (int i = 1; i < n; ++i) {
+ p0 = ctx->fmt1(extract64(a, i * 8, 8), &ctx->stat);
+ p1 = ctx->fmt2(extract64(b, i * 8, 8), &ctx->stat);
+ pr = parts64_muladd(&p0, &p1, &pr, 0, &ctx->stat);
+ }
+ return parts64_scalbn(&pr, ctx->scale, &ctx->stat);
+}
+
+static float16 f8dotadd_h(uint64_t a, uint64_t b, int n, float16 c,
+ FP8MulContext *ctx)
+{
+ FloatParts64 p0 = f8dot(a, b, n, ctx);
+ FloatParts64 p1 = float16_unpack_canonical(c, &ctx->stat);
+
+ p0 = parts64_addsub(&p0, &p1, &ctx->stat, false);
+ return float16_round_pack_canonical(&p0, &ctx->stat);
+}
+
+void HELPER(gvec_fmla_hb)(void *vd, void *vn, void *vm,
+ CPUARMState *env, uint32_t desc)
+{
+ FP8MulContext ctx = fp8_mul_start(env, 0xf);
+ bool high = extract32(desc, SIMD_DATA_SHIFT, 1);
+ size_t oprsz = simd_oprsz(desc);
+ size_t nelem = oprsz / 2;
+ uint8_t *n = vn;
+ uint8_t *m = vm;
+ float16 *d = vd;
+
+ for (size_t i = 0; i < nelem; i++) {
+ uint8_t e0 = n[H1(2 * i + high)];
+ uint8_t e1 = m[H1(2 * i + high)];
+
+ d[H2(i)] = f8dotadd_h(e0, e1, 1, d[H2(i)], &ctx);
+ }
+
+ clear_tail(vd, oprsz, simd_maxsz(desc));
+}
+
+void HELPER(gvec_fmla_idx_hb)(void *vd, void *vn, void *vm,
+ CPUARMState *env, uint32_t desc)
+{
+ FP8MulContext ctx = fp8_mul_start(env, 0xf);
+ bool idx_n = extract32(desc, SIMD_DATA_SHIFT, 1);
+ size_t idx_m = extract32(desc, SIMD_DATA_SHIFT + 2, 4);
+ size_t oprsz = simd_oprsz(desc);
+ size_t nelem = oprsz / 2;
+ uint8_t *n = vn;
+ uint8_t *m = vm;
+ float16 *d = vd;
+ size_t i = 0;
+
+ do {
+ uint8_t e1 = m[2 * i + H1(idx_m)];
+ do {
+ uint8_t e0 = n[H1(2 * i + idx_n)];
+ d[H2(i)] = f8dotadd_h(e0, e1, 1, d[H2(i)], &ctx);
+ } while (++i % 8 != 0);
+ } while (i < nelem);
+
+ clear_tail(vd, oprsz, simd_maxsz(desc));
+}
diff --git a/target/arm/tcg/translate-a64.c b/target/arm/tcg/translate-a64.c
index ee71c63116..1c1d4ad2f7 100644
--- a/target/arm/tcg/translate-a64.c
+++ b/target/arm/tcg/translate-a64.c
@@ -7384,6 +7384,22 @@ TRANS_FEAT(FMLSL_vi, aa64_fhm, do_fmlal_idx, a, true, false)
TRANS_FEAT(FMLAL2_vi, aa64_fhm, do_fmlal_idx, a, false, true)
TRANS_FEAT(FMLSL2_vi, aa64_fhm, do_fmlal_idx, a, true, true)
+static bool do_fmla_fp8(DisasContext *s, arg_rxx *a,
+ gen_helper_gvec_3_ptr *fn)
+{
+ if (fpmr_access_check(s) && fp_access_check(s)) {
+ tcg_gen_gvec_3_ptr(vec_full_reg_offset(s, a->rd),
+ vec_full_reg_offset(s, a->rn),
+ vec_full_reg_offset(s, a->rm),
+ tcg_env, 16, vec_full_reg_size(s),
+ a->idxn | (a->idxm << 2), fn);
+ }
+ return true;
+}
+
+TRANS_FEAT(FMLAL_hb_v, aa64_f8fma, do_fmla_fp8, a, gen_helper_gvec_fmla_hb)
+TRANS_FEAT(FMLAL_hb_vi, aa64_f8fma, do_fmla_fp8, a, gen_helper_gvec_fmla_idx_hb)
+
static bool do_int3_vector_idx(DisasContext *s, arg_qrrx_e *a,
gen_helper_gvec_3 * const fns[2])
{
diff --git a/target/arm/tcg/a64.decode b/target/arm/tcg/a64.decode
index 6aea3ce89f..b89e83ce76 100644
--- a/target/arm/tcg/a64.decode
+++ b/target/arm/tcg/a64.decode
@@ -25,6 +25,7 @@
%esz_hsd 22:2 !function=xor_2
%hl 11:1 21:1
%hlm 11:1 20:2
+%hlm4 11:1 19:3
&r rn
&rrr rd rn rm
@@ -38,6 +39,7 @@
&rri_e rd rn imm esz
&rrr_e rd rn rm esz
&rrx_e rd rn rm idx esz
+&rxx rd rn rm idxn idxm
&rrrr_e rd rn rm ra esz
&qrr_e q rd rn esz
&qrri_e q rd rn imm esz
@@ -1204,6 +1206,9 @@ FSCALE 0.10 1110 1.1 ..... 11111 1 ..... ..... @qrrr_sd
FCVTN_bh 0.00 1110 010 ..... 11110 1 ..... ..... @qrrr_h
FCVTN_bs 0.00 1110 000 ..... 11110 1 ..... ..... @qrrr_h
+FMLAL_hb_v 0 idxn:1 00 1110 110 rm:5 11111 1 rn:5 rd:5 \
+ &rxx idxm=0
+
### Advanced SIMD scalar x indexed element
FMUL_si 0101 1111 00 .. .... 1001 . 0 ..... ..... @rrx_h
@@ -1322,6 +1327,9 @@ SQDMLAL_vi 0.00 1111 10 . ..... 0011 . 0 ..... ..... @qrrx_s
SQDMLSL_vi 0.00 1111 01 .. .... 0111 . 0 ..... ..... @qrrx_h
SQDMLSL_vi 0.00 1111 10 . ..... 0111 . 0 ..... ..... @qrrx_s
+FMLAL_hb_vi 0 idxn:1 00 1111 11 ... rm:3 0000 . 0 rn:5 rd:5 \
+ &rxx idxm=%hlm4
+
# Floating-point conditional select
FCSEL 0001 1110 .. 1 rm:5 cond:4 11 rn:5 rd:5 esz=%esz_hsd
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread* [PATCH v6 47/64] target/arm: Implement FMLALB, FMLALT (FP8 to FP16) for SVE
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
` (45 preceding siblings ...)
2026-05-20 18:21 ` [PATCH v6 46/64] target/arm: Implement FMLALB, FMLALT for AdvSIMD Richard Henderson
@ 2026-05-20 18:21 ` Richard Henderson
2026-05-20 18:21 ` [PATCH v6 48/64] target/arm: Implement FMLALL{BB, BT, TB, TT} for AdvSIMD Richard Henderson
` (16 subsequent siblings)
63 siblings, 0 replies; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:21 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/cpu-features.h | 5 +++++
target/arm/tcg/translate-sve.c | 33 +++++++++++++++++++++++++++++++++
target/arm/tcg/sve.decode | 7 +++++++
3 files changed, 45 insertions(+)
diff --git a/target/arm/cpu-features.h b/target/arm/cpu-features.h
index ee20d74164..c0b646415c 100644
--- a/target/arm/cpu-features.h
+++ b/target/arm/cpu-features.h
@@ -1545,6 +1545,11 @@ static inline bool isar_feature_aa64_sve_b16b16(const ARMISARegisters *id)
return FIELD_EX64_IDREG(id, ID_AA64ZFR0, B16B16);
}
+static inline bool isar_feature_aa64_ssve_f8fma(const ARMISARegisters *id)
+{
+ return FIELD_EX64_IDREG(id, ID_AA64SMFR0, SF8FMA);
+}
+
static inline bool isar_feature_aa64_sme_b16b16(const ARMISARegisters *id)
{
return FIELD_EX64_IDREG(id, ID_AA64SMFR0, B16B16);
diff --git a/target/arm/tcg/translate-sve.c b/target/arm/tcg/translate-sve.c
index ea0d66178e..aa785fa0c3 100644
--- a/target/arm/tcg/translate-sve.c
+++ b/target/arm/tcg/translate-sve.c
@@ -8336,3 +8336,36 @@ static bool trans_LUTI4_2h(DisasContext *s, arg_LUTI4_2h *a)
}
return true;
}
+
+static bool do_fmla_fp8(DisasContext *s, arg_rxx *a, gen_helper_gvec_3_ptr *fn)
+{
+ bool fp8fma = dc_isar_feature(aa64_f8fma, s);
+ bool ssve_fp8fma = dc_isar_feature(aa64_ssve_f8fma, s);
+ bool ok = false;
+
+ /* Feature detection and enabling are complex here. */
+ if (!(ssve_fp8fma || (fp8fma && dc_isar_feature(aa64_sve2, s)))) {
+ return false;
+ }
+ if (fpmr_access_check(s)) {
+ if (fp8fma) {
+ s->is_nonstreaming = !ssve_fp8fma;
+ ok = sve_access_check(s);
+ } else {
+ ok = sme_sm_enabled_check(s);
+ }
+ }
+
+ if (ok) {
+ unsigned vsz = vec_full_reg_size(s);
+ tcg_gen_gvec_3_ptr(vec_full_reg_offset(s, a->rd),
+ vec_full_reg_offset(s, a->rn),
+ vec_full_reg_offset(s, a->rm),
+ tcg_env, vsz, vsz,
+ a->idxn | (a->idxm << 2), fn);
+ }
+ return true;
+}
+
+TRANS(FMLAL_hb, do_fmla_fp8, a, gen_helper_gvec_fmla_hb)
+TRANS(FMLAL_idx_hb, do_fmla_fp8, a, gen_helper_gvec_fmla_idx_hb)
diff --git a/target/arm/tcg/sve.decode b/target/arm/tcg/sve.decode
index e2106fc7f5..71ec09393c 100644
--- a/target/arm/tcg/sve.decode
+++ b/target/arm/tcg/sve.decode
@@ -29,6 +29,7 @@
%imm9_16_10 16:s6 10:3
%size_23 23:2
%dtype_23_13 23:2 13:2
+%index4_19_10 19:2 10:2
%index3_22_19 22:1 19:2
%index3_22_17 22:1 17:2
%index3_22_12 22:2 12:1
@@ -73,6 +74,7 @@
&rri rd rn imm
&rr_dbm rd rn dbm
&rrri rd rn rm imm
+&rxx rd rn rm idxn idxm
&rri_esz rd rn imm esz
&rrri_esz rd rn rm imm esz
&rrr_esz rd rn rm esz
@@ -1864,6 +1866,8 @@ BFMLALT_zzzw 01100100 11 1 ..... 10 0 00 1 ..... ..... @rda_rn_rm_ex esz=2
BFMLSLB_zzzw 01100100 11 1 ..... 10 1 00 0 ..... ..... @rda_rn_rm_ex esz=2
BFMLSLT_zzzw 01100100 11 1 ..... 10 1 00 1 ..... ..... @rda_rn_rm_ex esz=2
+FMLAL_hb 01100100 10 1 rm:5 100 idxn:1 10 rn:5 rd:5 &rxx idxm=0
+
### SVE2 floating-point dot-product
FDOT_zzzz 01100100 00 1 ..... 10 0 00 0 ..... ..... @rda_rn_rm_ex esz=2
BFDOT_zzzz 01100100 01 1 ..... 10 0 00 0 ..... ..... @rda_rn_rm_ex esz=2
@@ -1880,6 +1884,9 @@ BFMLALT_zzxw 01100100 11 1 ..... 0100.1 ..... ..... @rrxr_3a esz=2
BFMLSLB_zzxw 01100100 11 1 ..... 0110.0 ..... ..... @rrxr_3a esz=2
BFMLSLT_zzxw 01100100 11 1 ..... 0110.1 ..... ..... @rrxr_3a esz=2
+FMLAL_idx_hb 01100100 idxn:1 01 .. rm:3 0101 .. rn:5 rd:5 \
+ &rxx idxm=%index4_19_10
+
### SVE2 floating-point dot-product (indexed)
FDOT_zzxz 01100100 00 1 ..... 010000 ..... ..... @rrxr_2 esz=2
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread* [PATCH v6 48/64] target/arm: Implement FMLALL{BB, BT, TB, TT} for AdvSIMD
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
` (46 preceding siblings ...)
2026-05-20 18:21 ` [PATCH v6 47/64] target/arm: Implement FMLALB, FMLALT (FP8 to FP16) for SVE Richard Henderson
@ 2026-05-20 18:21 ` Richard Henderson
2026-05-20 18:21 ` [PATCH v6 49/64] target/arm: Implement FMLALL{BB,BT,TB,TT} for SVE Richard Henderson
` (15 subsequent siblings)
63 siblings, 0 replies; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:21 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/tcg/helper-fp8-defs.h | 3 ++
target/arm/tcg/fp8_helper.c | 55 ++++++++++++++++++++++++++++++++
target/arm/tcg/translate-a64.c | 3 ++
target/arm/tcg/a64.decode | 7 ++++
4 files changed, 68 insertions(+)
diff --git a/target/arm/tcg/helper-fp8-defs.h b/target/arm/tcg/helper-fp8-defs.h
index 7aa8366d94..802a3b430e 100644
--- a/target/arm/tcg/helper-fp8-defs.h
+++ b/target/arm/tcg/helper-fp8-defs.h
@@ -26,3 +26,6 @@ DEF_HELPER_FLAGS_4(sme2_fcvtn_bs, TCG_CALL_NO_RWG, void, ptr, ptr, env, i32)
DEF_HELPER_FLAGS_5(gvec_fmla_hb, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, env, i32)
DEF_HELPER_FLAGS_5(gvec_fmla_idx_hb, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, env, i32)
+
+DEF_HELPER_FLAGS_5(gvec_fmla_sb, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, env, i32)
+DEF_HELPER_FLAGS_5(gvec_fmla_idx_sb, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, env, i32)
diff --git a/target/arm/tcg/fp8_helper.c b/target/arm/tcg/fp8_helper.c
index d86d3d0bfb..a6e989f6b3 100644
--- a/target/arm/tcg/fp8_helper.c
+++ b/target/arm/tcg/fp8_helper.c
@@ -630,6 +630,16 @@ static float16 f8dotadd_h(uint64_t a, uint64_t b, int n, float16 c,
return float16_round_pack_canonical(&p0, &ctx->stat);
}
+static float32 f8dotadd_s(uint64_t a, uint64_t b, int n, float32 c,
+ FP8MulContext *ctx)
+{
+ FloatParts64 p0 = f8dot(a, b, n, ctx);
+ FloatParts64 p1 = float32_unpack_canonical(c, &ctx->stat);
+
+ p0 = parts64_addsub(&p0, &p1, &ctx->stat, false);
+ return float32_round_pack_canonical(&p0, &ctx->stat);
+}
+
void HELPER(gvec_fmla_hb)(void *vd, void *vn, void *vm,
CPUARMState *env, uint32_t desc)
{
@@ -674,3 +684,48 @@ void HELPER(gvec_fmla_idx_hb)(void *vd, void *vn, void *vm,
clear_tail(vd, oprsz, simd_maxsz(desc));
}
+
+void HELPER(gvec_fmla_sb)(void *vd, void *vn, void *vm,
+ CPUARMState *env, uint32_t desc)
+{
+ FP8MulContext ctx = fp8_mul_start(env, -1);
+ size_t idx = extract32(desc, SIMD_DATA_SHIFT, 2);
+ size_t oprsz = simd_oprsz(desc);
+ size_t nelem = oprsz / 4;
+ uint8_t *n = vn;
+ uint8_t *m = vm;
+ float32 *d = vd;
+
+ for (size_t i = 0; i < nelem; i++) {
+ uint8_t e0 = n[H1(4 * i + idx)];
+ uint8_t e1 = m[H1(4 * i + idx)];
+
+ d[H4(i)] = f8dotadd_s(e0, e1, 1, d[H4(i)], &ctx);
+ }
+
+ clear_tail(vd, oprsz, simd_maxsz(desc));
+}
+
+void HELPER(gvec_fmla_idx_sb)(void *vd, void *vn, void *vm,
+ CPUARMState *env, uint32_t desc)
+{
+ FP8MulContext ctx = fp8_mul_start(env, -1);
+ size_t idx_n = extract32(desc, SIMD_DATA_SHIFT, 2);
+ size_t idx_m = extract32(desc, SIMD_DATA_SHIFT + 2, 4);
+ size_t oprsz = simd_oprsz(desc);
+ size_t nelem = oprsz / 4;
+ uint8_t *n = vn;
+ uint8_t *m = vm;
+ float32 *d = vd;
+ size_t i = 0;
+
+ do {
+ uint8_t e1 = m[4 * i + H1(idx_m)];
+ do {
+ uint8_t e0 = n[H1(4 * i + idx_n)];
+ d[H4(i)] = f8dotadd_s(e0, e1, 1, d[H4(i)], &ctx);
+ } while (++i % 4 != 0);
+ } while (i < nelem);
+
+ clear_tail(vd, oprsz, simd_maxsz(desc));
+}
diff --git a/target/arm/tcg/translate-a64.c b/target/arm/tcg/translate-a64.c
index 1c1d4ad2f7..946c16d439 100644
--- a/target/arm/tcg/translate-a64.c
+++ b/target/arm/tcg/translate-a64.c
@@ -7400,6 +7400,9 @@ static bool do_fmla_fp8(DisasContext *s, arg_rxx *a,
TRANS_FEAT(FMLAL_hb_v, aa64_f8fma, do_fmla_fp8, a, gen_helper_gvec_fmla_hb)
TRANS_FEAT(FMLAL_hb_vi, aa64_f8fma, do_fmla_fp8, a, gen_helper_gvec_fmla_idx_hb)
+TRANS_FEAT(FMLALL_sb_v, aa64_f8fma, do_fmla_fp8, a, gen_helper_gvec_fmla_sb)
+TRANS_FEAT(FMLALL_sb_vi, aa64_f8fma, do_fmla_fp8, a, gen_helper_gvec_fmla_idx_sb)
+
static bool do_int3_vector_idx(DisasContext *s, arg_qrrx_e *a,
gen_helper_gvec_3 * const fns[2])
{
diff --git a/target/arm/tcg/a64.decode b/target/arm/tcg/a64.decode
index b89e83ce76..ef6d7dfeaa 100644
--- a/target/arm/tcg/a64.decode
+++ b/target/arm/tcg/a64.decode
@@ -1209,6 +1209,10 @@ FCVTN_bs 0.00 1110 000 ..... 11110 1 ..... ..... @qrrr_h
FMLAL_hb_v 0 idxn:1 00 1110 110 rm:5 11111 1 rn:5 rd:5 \
&rxx idxm=0
+%fmlall_idxn 30:1 22:1
+FMLALL_sb_v 0.00 1110 0.0 rm:5 110001 rn:5 rd:5 \
+ &rxx idxm=0 idxn=%fmlall_idxn
+
### Advanced SIMD scalar x indexed element
FMUL_si 0101 1111 00 .. .... 1001 . 0 ..... ..... @rrx_h
@@ -1330,6 +1334,9 @@ SQDMLSL_vi 0.00 1111 10 . ..... 0111 . 0 ..... ..... @qrrx_s
FMLAL_hb_vi 0 idxn:1 00 1111 11 ... rm:3 0000 . 0 rn:5 rd:5 \
&rxx idxm=%hlm4
+FMLALL_sb_vi 0 . 10 1111 0 . ... rm:3 1000 . 0 rn:5 rd:5 \
+ &rxx idxm=%hlm4 idxn=%fmlall_idxn
+
# Floating-point conditional select
FCSEL 0001 1110 .. 1 rm:5 cond:4 11 rn:5 rd:5 esz=%esz_hsd
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread* [PATCH v6 49/64] target/arm: Implement FMLALL{BB,BT,TB,TT} for SVE
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
` (47 preceding siblings ...)
2026-05-20 18:21 ` [PATCH v6 48/64] target/arm: Implement FMLALL{BB, BT, TB, TT} for AdvSIMD Richard Henderson
@ 2026-05-20 18:21 ` Richard Henderson
2026-05-20 18:21 ` [PATCH v6 50/64] target/arm: Enable FEAT_FP8FMA, FEAT_SSVE_FP8FMA for -cpu max Richard Henderson
` (14 subsequent siblings)
63 siblings, 0 replies; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:21 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/tcg/translate-sve.c | 3 +++
target/arm/tcg/sve.decode | 5 +++++
2 files changed, 8 insertions(+)
diff --git a/target/arm/tcg/translate-sve.c b/target/arm/tcg/translate-sve.c
index aa785fa0c3..e23ca43f55 100644
--- a/target/arm/tcg/translate-sve.c
+++ b/target/arm/tcg/translate-sve.c
@@ -8369,3 +8369,6 @@ static bool do_fmla_fp8(DisasContext *s, arg_rxx *a, gen_helper_gvec_3_ptr *fn)
TRANS(FMLAL_hb, do_fmla_fp8, a, gen_helper_gvec_fmla_hb)
TRANS(FMLAL_idx_hb, do_fmla_fp8, a, gen_helper_gvec_fmla_idx_hb)
+
+TRANS(FMLALL_sb, do_fmla_fp8, a, gen_helper_gvec_fmla_sb)
+TRANS(FMLALL_idx_sb, do_fmla_fp8, a, gen_helper_gvec_fmla_idx_sb)
diff --git a/target/arm/tcg/sve.decode b/target/arm/tcg/sve.decode
index 71ec09393c..06bbd7fa63 100644
--- a/target/arm/tcg/sve.decode
+++ b/target/arm/tcg/sve.decode
@@ -1868,6 +1868,8 @@ BFMLSLT_zzzw 01100100 11 1 ..... 10 1 00 1 ..... ..... @rda_rn_rm_ex esz=2
FMLAL_hb 01100100 10 1 rm:5 100 idxn:1 10 rn:5 rd:5 &rxx idxm=0
+FMLALL_sb 01100100 00 1 rm:5 10 idxn:2 10 rn:5 rd:5 &rxx idxm=0
+
### SVE2 floating-point dot-product
FDOT_zzzz 01100100 00 1 ..... 10 0 00 0 ..... ..... @rda_rn_rm_ex esz=2
BFDOT_zzzz 01100100 01 1 ..... 10 0 00 0 ..... ..... @rda_rn_rm_ex esz=2
@@ -1887,6 +1889,9 @@ BFMLSLT_zzxw 01100100 11 1 ..... 0110.1 ..... ..... @rrxr_3a esz=2
FMLAL_idx_hb 01100100 idxn:1 01 .. rm:3 0101 .. rn:5 rd:5 \
&rxx idxm=%index4_19_10
+FMLALL_idx_sb 01100100 idxn:2 1 .. rm:3 1100 .. rn:5 rd:5 \
+ &rxx idxm=%index4_19_10
+
### SVE2 floating-point dot-product (indexed)
FDOT_zzxz 01100100 00 1 ..... 010000 ..... ..... @rrxr_2 esz=2
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread* [PATCH v6 50/64] target/arm: Enable FEAT_FP8FMA, FEAT_SSVE_FP8FMA for -cpu max
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
` (48 preceding siblings ...)
2026-05-20 18:21 ` [PATCH v6 49/64] target/arm: Implement FMLALL{BB,BT,TB,TT} for SVE Richard Henderson
@ 2026-05-20 18:21 ` Richard Henderson
2026-05-20 18:22 ` [PATCH v6 51/64] target/arm: Implement FDOT (FP8 to FP32) for AdvSIMD Richard Henderson
` (13 subsequent siblings)
63 siblings, 0 replies; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:21 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/tcg/cpu64.c | 2 ++
docs/system/arm/emulation.rst | 2 ++
2 files changed, 4 insertions(+)
diff --git a/target/arm/tcg/cpu64.c b/target/arm/tcg/cpu64.c
index 90214a355a..93cd7ee1a6 100644
--- a/target/arm/tcg/cpu64.c
+++ b/target/arm/tcg/cpu64.c
@@ -1377,6 +1377,7 @@ void aarch64_max_tcg_initfn(Object *obj)
SET_IDREG(isar, ID_AA64DFR0, t);
t = GET_IDREG(isar, ID_AA64SMFR0);
+ t = FIELD_DP64(t, ID_AA64SMFR0, SF8FMA, 1); /* FEAT_SSVE_FP8FMA */
t = FIELD_DP64(t, ID_AA64SMFR0, F32F32, 1); /* FEAT_SME */
t = FIELD_DP64(t, ID_AA64SMFR0, BI32I32, 1); /* FEAT_SME2 */
t = FIELD_DP64(t, ID_AA64SMFR0, B16F32, 1); /* FEAT_SME */
@@ -1395,6 +1396,7 @@ void aarch64_max_tcg_initfn(Object *obj)
t = GET_IDREG(isar, ID_AA64FPFR0);
t = FIELD_DP64(t, ID_AA64FPFR0, F8E5M2, 1); /* FEAT_FP8 */
t = FIELD_DP64(t, ID_AA64FPFR0, F8E4M3, 1); /* FEAT_FP8 */
+ t = FIELD_DP64(t, ID_AA64FPFR0, F8FMA, 1); /* FEAT_FP8FMA */
t = FIELD_DP64(t, ID_AA64FPFR0, F8CVT, 1); /* FEAT_FP8 */
SET_IDREG(isar, ID_AA64FPFR0, t);
diff --git a/docs/system/arm/emulation.rst b/docs/system/arm/emulation.rst
index 0dd6b554a0..a6b48f9c60 100644
--- a/docs/system/arm/emulation.rst
+++ b/docs/system/arm/emulation.rst
@@ -75,6 +75,7 @@ the following architecture extensions:
- FEAT_FP (Floating Point extensions)
- FEAT_FP16 (Half-precision floating-point data processing)
- FEAT_FP8 (FP8 convert instructions)
+- FEAT_FP8FMA (FP8 multiply-accumulate to half-precision and single-precision instructions)
- FEAT_FPAC (Faulting on AUT* instructions)
- FEAT_FPACCOMBINE (Faulting on combined pointer authentication instructions)
- FEAT_FPACC_SPEC (Speculative behavior of combined pointer authentication instructions)
@@ -159,6 +160,7 @@ the following architecture extensions:
- FEAT_SME_F64F64 (Double-precision floating-point outer product instructions)
- FEAT_SME_I16I64 (16-bit to 64-bit integer widening outer product instructions)
- FEAT_SME_LUTv2 (Lookup table instructions with 4-bit indices and 8-bit elements)
+- FEAT_SSVE_FP8FMA (SVE2 FP8 multiply-accumulate to half-precision and single-precision instructions in Streaming SVE mode)
- FEAT_SVE (Scalable Vector Extension)
- FEAT_SVE_AES (Scalable Vector AES instructions)
- FEAT_SVE_B16B16 (Non-widening BFloat16 arithmetic for SVE2)
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread* [PATCH v6 51/64] target/arm: Implement FDOT (FP8 to FP32) for AdvSIMD
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
` (49 preceding siblings ...)
2026-05-20 18:21 ` [PATCH v6 50/64] target/arm: Enable FEAT_FP8FMA, FEAT_SSVE_FP8FMA for -cpu max Richard Henderson
@ 2026-05-20 18:22 ` Richard Henderson
2026-05-20 18:22 ` [PATCH v6 52/64] target/arm: Implement FDOT (FP8 to FP32) for SVE Richard Henderson
` (12 subsequent siblings)
63 siblings, 0 replies; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:22 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/cpu-features.h | 5 ++++
target/arm/tcg/helper-fp8-defs.h | 3 +++
target/arm/tcg/fp8_helper.c | 39 ++++++++++++++++++++++++++++++++
target/arm/tcg/translate-a64.c | 30 ++++++++++++++++++++++++
target/arm/tcg/a64.decode | 4 ++++
5 files changed, 81 insertions(+)
diff --git a/target/arm/cpu-features.h b/target/arm/cpu-features.h
index c0b646415c..fbce0386ef 100644
--- a/target/arm/cpu-features.h
+++ b/target/arm/cpu-features.h
@@ -1600,6 +1600,11 @@ static inline bool isar_feature_aa64_f8fma(const ARMISARegisters *id)
return FIELD_EX64_IDREG(id, ID_AA64FPFR0, F8FMA);
}
+static inline bool isar_feature_aa64_f8dp4(const ARMISARegisters *id)
+{
+ return FIELD_EX64_IDREG(id, ID_AA64FPFR0, F8DP4);
+}
+
/*
* Combinations of feature tests, for ease of use with TRANS_FEAT.
*/
diff --git a/target/arm/tcg/helper-fp8-defs.h b/target/arm/tcg/helper-fp8-defs.h
index 802a3b430e..ee6f2e9236 100644
--- a/target/arm/tcg/helper-fp8-defs.h
+++ b/target/arm/tcg/helper-fp8-defs.h
@@ -29,3 +29,6 @@ DEF_HELPER_FLAGS_5(gvec_fmla_idx_hb, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, env,
DEF_HELPER_FLAGS_5(gvec_fmla_sb, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, env, i32)
DEF_HELPER_FLAGS_5(gvec_fmla_idx_sb, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, env, i32)
+
+DEF_HELPER_FLAGS_5(gvec_fdot_sb, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, env, i32)
+DEF_HELPER_FLAGS_5(gvec_fdot_idx_sb, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, env, i32)
diff --git a/target/arm/tcg/fp8_helper.c b/target/arm/tcg/fp8_helper.c
index a6e989f6b3..c9659eac35 100644
--- a/target/arm/tcg/fp8_helper.c
+++ b/target/arm/tcg/fp8_helper.c
@@ -729,3 +729,42 @@ void HELPER(gvec_fmla_idx_sb)(void *vd, void *vn, void *vm,
clear_tail(vd, oprsz, simd_maxsz(desc));
}
+
+void HELPER(gvec_fdot_sb)(void *vd, void *vn, void *vm,
+ CPUARMState *env, uint32_t desc)
+{
+ FP8MulContext ctx = fp8_mul_start(env, -1);
+ size_t oprsz = simd_oprsz(desc);
+ size_t nelem = oprsz / 4;
+ uint32_t *n = vn;
+ uint32_t *m = vm;
+ float32 *d = vd;
+
+ for (size_t i = 0; i < nelem; i++) {
+ d[i] = f8dotadd_s(n[i], m[i], 4, d[i], &ctx);
+ }
+
+ clear_tail(vd, oprsz, simd_maxsz(desc));
+}
+
+void HELPER(gvec_fdot_idx_sb)(void *vd, void *vn, void *vm,
+ CPUARMState *env, uint32_t desc)
+{
+ FP8MulContext ctx = fp8_mul_start(env, -1);
+ size_t idx = simd_data(desc);
+ size_t oprsz = simd_oprsz(desc);
+ size_t nelem = oprsz / 4;
+ uint32_t *n = vn;
+ uint32_t *m = vm;
+ float32 *d = vd;
+ size_t i = 0;
+
+ do {
+ uint32_t e1 = m[i + H4(idx)];
+ do {
+ d[i] = f8dotadd_s(n[i], e1, 4, d[i], &ctx);
+ } while (++i % 4 != 0);
+ } while (i < nelem);
+
+ clear_tail(vd, oprsz, simd_maxsz(desc));
+}
diff --git a/target/arm/tcg/translate-a64.c b/target/arm/tcg/translate-a64.c
index 946c16d439..8ea63e94fe 100644
--- a/target/arm/tcg/translate-a64.c
+++ b/target/arm/tcg/translate-a64.c
@@ -7403,6 +7403,36 @@ TRANS_FEAT(FMLAL_hb_vi, aa64_f8fma, do_fmla_fp8, a, gen_helper_gvec_fmla_idx_hb)
TRANS_FEAT(FMLALL_sb_v, aa64_f8fma, do_fmla_fp8, a, gen_helper_gvec_fmla_sb)
TRANS_FEAT(FMLALL_sb_vi, aa64_f8fma, do_fmla_fp8, a, gen_helper_gvec_fmla_idx_sb)
+static bool do_f8dot(DisasContext *s, arg_qrrr_e *a,
+ gen_helper_gvec_3_ptr *fn)
+{
+ if (fpmr_access_check(s) && fp_access_check(s)) {
+ tcg_gen_gvec_3_ptr(vec_full_reg_offset(s, a->rd),
+ vec_full_reg_offset(s, a->rn),
+ vec_full_reg_offset(s, a->rm),
+ tcg_env, a->q ? 16 : 8, vec_full_reg_size(s),
+ 0, fn);
+ }
+ return true;
+}
+
+TRANS_FEAT(FDOT_sb_v, aa64_f8dp4, do_f8dot, a, gen_helper_gvec_fdot_sb)
+
+static bool do_f8dot_idx(DisasContext *s, arg_qrrx_e *a,
+ gen_helper_gvec_3_ptr *fn)
+{
+ if (fpmr_access_check(s) && fp_access_check(s)) {
+ tcg_gen_gvec_3_ptr(vec_full_reg_offset(s, a->rd),
+ vec_full_reg_offset(s, a->rn),
+ vec_full_reg_offset(s, a->rm),
+ tcg_env, a->q ? 16 : 8, vec_full_reg_size(s),
+ a->idx, fn);
+ }
+ return true;
+}
+
+TRANS_FEAT(FDOT_sb_vi, aa64_f8dp4, do_f8dot_idx, a, gen_helper_gvec_fdot_idx_sb)
+
static bool do_int3_vector_idx(DisasContext *s, arg_qrrx_e *a,
gen_helper_gvec_3 * const fns[2])
{
diff --git a/target/arm/tcg/a64.decode b/target/arm/tcg/a64.decode
index ef6d7dfeaa..d78a3d5486 100644
--- a/target/arm/tcg/a64.decode
+++ b/target/arm/tcg/a64.decode
@@ -1213,6 +1213,8 @@ FMLAL_hb_v 0 idxn:1 00 1110 110 rm:5 11111 1 rn:5 rd:5 \
FMLALL_sb_v 0.00 1110 0.0 rm:5 110001 rn:5 rd:5 \
&rxx idxm=0 idxn=%fmlall_idxn
+FDOT_sb_v 0.00 1110 000 ..... 11111 1 ..... ..... @qrrr_s
+
### Advanced SIMD scalar x indexed element
FMUL_si 0101 1111 00 .. .... 1001 . 0 ..... ..... @rrx_h
@@ -1337,6 +1339,8 @@ FMLAL_hb_vi 0 idxn:1 00 1111 11 ... rm:3 0000 . 0 rn:5 rd:5 \
FMLALL_sb_vi 0 . 10 1111 0 . ... rm:3 1000 . 0 rn:5 rd:5 \
&rxx idxm=%hlm4 idxn=%fmlall_idxn
+FDOT_sb_vi 0.00 1111 00 . ..... 0000 . 0 ..... ..... @qrrx_s
+
# Floating-point conditional select
FCSEL 0001 1110 .. 1 rm:5 cond:4 11 rn:5 rd:5 esz=%esz_hsd
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread* [PATCH v6 52/64] target/arm: Implement FDOT (FP8 to FP32) for SVE
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
` (50 preceding siblings ...)
2026-05-20 18:22 ` [PATCH v6 51/64] target/arm: Implement FDOT (FP8 to FP32) for AdvSIMD Richard Henderson
@ 2026-05-20 18:22 ` Richard Henderson
2026-05-20 18:22 ` [PATCH v6 53/64] target/arm: Enable FEAT_FP8DOT4, FEAT_SSVE_FP8DOT4 for -cpu max Richard Henderson
` (11 subsequent siblings)
63 siblings, 0 replies; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:22 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/cpu-features.h | 5 +++++
target/arm/tcg/translate-sve.c | 35 ++++++++++++++++++++++++++++++++++
target/arm/tcg/sve.decode | 4 ++++
3 files changed, 44 insertions(+)
diff --git a/target/arm/cpu-features.h b/target/arm/cpu-features.h
index fbce0386ef..17d6acc14d 100644
--- a/target/arm/cpu-features.h
+++ b/target/arm/cpu-features.h
@@ -1550,6 +1550,11 @@ static inline bool isar_feature_aa64_ssve_f8fma(const ARMISARegisters *id)
return FIELD_EX64_IDREG(id, ID_AA64SMFR0, SF8FMA);
}
+static inline bool isar_feature_aa64_ssve_f8dp4(const ARMISARegisters *id)
+{
+ return FIELD_EX64_IDREG(id, ID_AA64SMFR0, SF8DP4);
+}
+
static inline bool isar_feature_aa64_sme_b16b16(const ARMISARegisters *id)
{
return FIELD_EX64_IDREG(id, ID_AA64SMFR0, B16B16);
diff --git a/target/arm/tcg/translate-sve.c b/target/arm/tcg/translate-sve.c
index e23ca43f55..88e6148b83 100644
--- a/target/arm/tcg/translate-sve.c
+++ b/target/arm/tcg/translate-sve.c
@@ -8372,3 +8372,38 @@ TRANS(FMLAL_idx_hb, do_fmla_fp8, a, gen_helper_gvec_fmla_idx_hb)
TRANS(FMLALL_sb, do_fmla_fp8, a, gen_helper_gvec_fmla_sb)
TRANS(FMLALL_idx_sb, do_fmla_fp8, a, gen_helper_gvec_fmla_idx_sb)
+
+static bool do_f8dp4(DisasContext *s, gen_helper_gvec_3_ptr *fn,
+ int rd, int rn, int rm, int index)
+{
+ bool fp8dp4 = dc_isar_feature(aa64_f8dp4, s);
+ bool ssve_fp8dp4 = dc_isar_feature(aa64_ssve_f8dp4, s);
+ bool ok = false;
+
+ /* Feature detection and enabling are complex here. */
+ if (!(ssve_fp8dp4 || (fp8dp4 && dc_isar_feature(aa64_sve2, s)))) {
+ return false;
+ }
+ if (fpmr_access_check(s)) {
+ if (fp8dp4) {
+ s->is_nonstreaming = !ssve_fp8dp4;
+ ok = sve_access_check(s);
+ } else {
+ ok = sme_sm_enabled_check(s);
+ }
+ }
+
+ if (ok) {
+ unsigned vsz = vec_full_reg_size(s);
+ tcg_gen_gvec_3_ptr(vec_full_reg_offset(s, rd),
+ vec_full_reg_offset(s, rn),
+ vec_full_reg_offset(s, rm),
+ tcg_env, vsz, vsz,
+ index, fn);
+ }
+ return true;
+}
+
+TRANS(FDOT_sb, do_f8dp4, gen_helper_gvec_fdot_sb, a->rd, a->rn, a->rm, 0)
+TRANS(FDOT_idx_sb, do_f8dp4, gen_helper_gvec_fdot_idx_sb,
+ a->rd, a->rn, a->rm, a->index)
diff --git a/target/arm/tcg/sve.decode b/target/arm/tcg/sve.decode
index 06bbd7fa63..c49e992f10 100644
--- a/target/arm/tcg/sve.decode
+++ b/target/arm/tcg/sve.decode
@@ -1874,6 +1874,8 @@ FMLALL_sb 01100100 00 1 rm:5 10 idxn:2 10 rn:5 rd:5 &rxx idxm=0
FDOT_zzzz 01100100 00 1 ..... 10 0 00 0 ..... ..... @rda_rn_rm_ex esz=2
BFDOT_zzzz 01100100 01 1 ..... 10 0 00 0 ..... ..... @rda_rn_rm_ex esz=2
+FDOT_sb 01100100 01 1 ..... 10 0 00 1 ..... ..... @rda_rn_rm_ex esz=2
+
### SVE2 floating-point multiply-add long (indexed)
FMLALB_zzxw 01100100 10 1 ..... 0100.0 ..... ..... @rrxr_3a esz=2
@@ -1897,6 +1899,8 @@ FMLALL_idx_sb 01100100 idxn:2 1 .. rm:3 1100 .. rn:5 rd:5 \
FDOT_zzxz 01100100 00 1 ..... 010000 ..... ..... @rrxr_2 esz=2
BFDOT_zzxz 01100100 01 1 ..... 010000 ..... ..... @rrxr_2 esz=2
+FDOT_idx_sb 01100100 01 1 ..... 010001 ..... ..... @rrxr_2 esz=2
+
### SVE broadcast predicate element
&psel esz pd pn pm rv imm
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread* [PATCH v6 53/64] target/arm: Enable FEAT_FP8DOT4, FEAT_SSVE_FP8DOT4 for -cpu max
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
` (51 preceding siblings ...)
2026-05-20 18:22 ` [PATCH v6 52/64] target/arm: Implement FDOT (FP8 to FP32) for SVE Richard Henderson
@ 2026-05-20 18:22 ` Richard Henderson
2026-05-20 18:22 ` [PATCH v6 54/64] target/arm: Implement FDOT (FP8 to FP16) for AdvSIMD Richard Henderson
` (10 subsequent siblings)
63 siblings, 0 replies; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:22 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/tcg/cpu64.c | 2 ++
docs/system/arm/emulation.rst | 2 ++
2 files changed, 4 insertions(+)
diff --git a/target/arm/tcg/cpu64.c b/target/arm/tcg/cpu64.c
index 93cd7ee1a6..6dec7e045d 100644
--- a/target/arm/tcg/cpu64.c
+++ b/target/arm/tcg/cpu64.c
@@ -1377,6 +1377,7 @@ void aarch64_max_tcg_initfn(Object *obj)
SET_IDREG(isar, ID_AA64DFR0, t);
t = GET_IDREG(isar, ID_AA64SMFR0);
+ t = FIELD_DP64(t, ID_AA64SMFR0, SF8DP4, 1); /* FEAT_SSVE_FP8DOT4 */
t = FIELD_DP64(t, ID_AA64SMFR0, SF8FMA, 1); /* FEAT_SSVE_FP8FMA */
t = FIELD_DP64(t, ID_AA64SMFR0, F32F32, 1); /* FEAT_SME */
t = FIELD_DP64(t, ID_AA64SMFR0, BI32I32, 1); /* FEAT_SME2 */
@@ -1396,6 +1397,7 @@ void aarch64_max_tcg_initfn(Object *obj)
t = GET_IDREG(isar, ID_AA64FPFR0);
t = FIELD_DP64(t, ID_AA64FPFR0, F8E5M2, 1); /* FEAT_FP8 */
t = FIELD_DP64(t, ID_AA64FPFR0, F8E4M3, 1); /* FEAT_FP8 */
+ t = FIELD_DP64(t, ID_AA64FPFR0, F8DP4, 1); /* FEAT_FP8DOT4 */
t = FIELD_DP64(t, ID_AA64FPFR0, F8FMA, 1); /* FEAT_FP8FMA */
t = FIELD_DP64(t, ID_AA64FPFR0, F8CVT, 1); /* FEAT_FP8 */
SET_IDREG(isar, ID_AA64FPFR0, t);
diff --git a/docs/system/arm/emulation.rst b/docs/system/arm/emulation.rst
index a6b48f9c60..bee4e36dc6 100644
--- a/docs/system/arm/emulation.rst
+++ b/docs/system/arm/emulation.rst
@@ -75,6 +75,7 @@ the following architecture extensions:
- FEAT_FP (Floating Point extensions)
- FEAT_FP16 (Half-precision floating-point data processing)
- FEAT_FP8 (FP8 convert instructions)
+- FEAT_FP8DOT4 (FP8 4-way dot product to single-precision instructions)
- FEAT_FP8FMA (FP8 multiply-accumulate to half-precision and single-precision instructions)
- FEAT_FPAC (Faulting on AUT* instructions)
- FEAT_FPACCOMBINE (Faulting on combined pointer authentication instructions)
@@ -160,6 +161,7 @@ the following architecture extensions:
- FEAT_SME_F64F64 (Double-precision floating-point outer product instructions)
- FEAT_SME_I16I64 (16-bit to 64-bit integer widening outer product instructions)
- FEAT_SME_LUTv2 (Lookup table instructions with 4-bit indices and 8-bit elements)
+- FEAT_SSVE_FP8DOT4 (SVE2 FP8 4-way dot product to single-precision instructions in Streaming SVE mode)
- FEAT_SSVE_FP8FMA (SVE2 FP8 multiply-accumulate to half-precision and single-precision instructions in Streaming SVE mode)
- FEAT_SVE (Scalable Vector Extension)
- FEAT_SVE_AES (Scalable Vector AES instructions)
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread* [PATCH v6 54/64] target/arm: Implement FDOT (FP8 to FP16) for AdvSIMD
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
` (52 preceding siblings ...)
2026-05-20 18:22 ` [PATCH v6 53/64] target/arm: Enable FEAT_FP8DOT4, FEAT_SSVE_FP8DOT4 for -cpu max Richard Henderson
@ 2026-05-20 18:22 ` Richard Henderson
2026-05-20 18:22 ` [PATCH v6 55/64] target/arm: Implement FDOT (FP8 to FP16) for SVE Richard Henderson
` (9 subsequent siblings)
63 siblings, 0 replies; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:22 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/cpu-features.h | 5 ++++
target/arm/tcg/helper-fp8-defs.h | 3 +++
target/arm/tcg/fp8_helper.c | 39 ++++++++++++++++++++++++++++++++
target/arm/tcg/translate-a64.c | 2 ++
target/arm/tcg/a64.decode | 2 ++
5 files changed, 51 insertions(+)
diff --git a/target/arm/cpu-features.h b/target/arm/cpu-features.h
index 17d6acc14d..7bedc293fd 100644
--- a/target/arm/cpu-features.h
+++ b/target/arm/cpu-features.h
@@ -1610,6 +1610,11 @@ static inline bool isar_feature_aa64_f8dp4(const ARMISARegisters *id)
return FIELD_EX64_IDREG(id, ID_AA64FPFR0, F8DP4);
}
+static inline bool isar_feature_aa64_f8dp2(const ARMISARegisters *id)
+{
+ return FIELD_EX64_IDREG(id, ID_AA64FPFR0, F8DP2);
+}
+
/*
* Combinations of feature tests, for ease of use with TRANS_FEAT.
*/
diff --git a/target/arm/tcg/helper-fp8-defs.h b/target/arm/tcg/helper-fp8-defs.h
index ee6f2e9236..5995d77577 100644
--- a/target/arm/tcg/helper-fp8-defs.h
+++ b/target/arm/tcg/helper-fp8-defs.h
@@ -32,3 +32,6 @@ DEF_HELPER_FLAGS_5(gvec_fmla_idx_sb, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, env,
DEF_HELPER_FLAGS_5(gvec_fdot_sb, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, env, i32)
DEF_HELPER_FLAGS_5(gvec_fdot_idx_sb, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, env, i32)
+
+DEF_HELPER_FLAGS_5(gvec_fdot_hb, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, env, i32)
+DEF_HELPER_FLAGS_5(gvec_fdot_idx_hb, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, env, i32)
diff --git a/target/arm/tcg/fp8_helper.c b/target/arm/tcg/fp8_helper.c
index c9659eac35..d3bbea1735 100644
--- a/target/arm/tcg/fp8_helper.c
+++ b/target/arm/tcg/fp8_helper.c
@@ -768,3 +768,42 @@ void HELPER(gvec_fdot_idx_sb)(void *vd, void *vn, void *vm,
clear_tail(vd, oprsz, simd_maxsz(desc));
}
+
+void HELPER(gvec_fdot_hb)(void *vd, void *vn, void *vm,
+ CPUARMState *env, uint32_t desc)
+{
+ FP8MulContext ctx = fp8_mul_start(env, 0xf);
+ size_t oprsz = simd_oprsz(desc);
+ size_t nelem = oprsz / 2;
+ uint16_t *n = vn;
+ uint16_t *m = vm;
+ float16 *d = vd;
+
+ for (size_t i = 0; i < nelem; i++) {
+ d[i] = f8dotadd_h(n[i], m[i], 2, d[i], &ctx);
+ }
+
+ clear_tail(vd, oprsz, simd_maxsz(desc));
+}
+
+void HELPER(gvec_fdot_idx_hb)(void *vd, void *vn, void *vm,
+ CPUARMState *env, uint32_t desc)
+{
+ FP8MulContext ctx = fp8_mul_start(env, 0xf);
+ size_t idx = simd_data(desc);
+ size_t oprsz = simd_oprsz(desc);
+ size_t nelem = oprsz / 2;
+ uint16_t *n = vn;
+ uint16_t *m = vm;
+ float16 *d = vd;
+ size_t i = 0;
+
+ do {
+ uint16_t e1 = m[i + H2(idx)];
+ do {
+ d[i] = f8dotadd_h(n[i], e1, 2, d[i], &ctx);
+ } while (++i % 8 != 0);
+ } while (i < nelem);
+
+ clear_tail(vd, oprsz, simd_maxsz(desc));
+}
diff --git a/target/arm/tcg/translate-a64.c b/target/arm/tcg/translate-a64.c
index 8ea63e94fe..c5ea6b27a9 100644
--- a/target/arm/tcg/translate-a64.c
+++ b/target/arm/tcg/translate-a64.c
@@ -7417,6 +7417,7 @@ static bool do_f8dot(DisasContext *s, arg_qrrr_e *a,
}
TRANS_FEAT(FDOT_sb_v, aa64_f8dp4, do_f8dot, a, gen_helper_gvec_fdot_sb)
+TRANS_FEAT(FDOT_hb_v, aa64_f8dp2, do_f8dot, a, gen_helper_gvec_fdot_hb)
static bool do_f8dot_idx(DisasContext *s, arg_qrrx_e *a,
gen_helper_gvec_3_ptr *fn)
@@ -7432,6 +7433,7 @@ static bool do_f8dot_idx(DisasContext *s, arg_qrrx_e *a,
}
TRANS_FEAT(FDOT_sb_vi, aa64_f8dp4, do_f8dot_idx, a, gen_helper_gvec_fdot_idx_sb)
+TRANS_FEAT(FDOT_hb_vi, aa64_f8dp2, do_f8dot_idx, a, gen_helper_gvec_fdot_idx_hb)
static bool do_int3_vector_idx(DisasContext *s, arg_qrrx_e *a,
gen_helper_gvec_3 * const fns[2])
diff --git a/target/arm/tcg/a64.decode b/target/arm/tcg/a64.decode
index d78a3d5486..d1254355b6 100644
--- a/target/arm/tcg/a64.decode
+++ b/target/arm/tcg/a64.decode
@@ -1214,6 +1214,7 @@ FMLALL_sb_v 0.00 1110 0.0 rm:5 110001 rn:5 rd:5 \
&rxx idxm=0 idxn=%fmlall_idxn
FDOT_sb_v 0.00 1110 000 ..... 11111 1 ..... ..... @qrrr_s
+FDOT_hb_v 0.00 1110 010 ..... 11111 1 ..... ..... @qrrr_h
### Advanced SIMD scalar x indexed element
@@ -1340,6 +1341,7 @@ FMLALL_sb_vi 0 . 10 1111 0 . ... rm:3 1000 . 0 rn:5 rd:5 \
&rxx idxm=%hlm4 idxn=%fmlall_idxn
FDOT_sb_vi 0.00 1111 00 . ..... 0000 . 0 ..... ..... @qrrx_s
+FDOT_hb_vi 0.00 1111 01 .. .... 0000 . 0 ..... ..... @qrrx_h
# Floating-point conditional select
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread* [PATCH v6 55/64] target/arm: Implement FDOT (FP8 to FP16) for SVE
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
` (53 preceding siblings ...)
2026-05-20 18:22 ` [PATCH v6 54/64] target/arm: Implement FDOT (FP8 to FP16) for AdvSIMD Richard Henderson
@ 2026-05-20 18:22 ` Richard Henderson
2026-05-20 18:22 ` [PATCH v6 56/64] target/arm: Enable FEAT_FP8DOT2, FEAT_SSVE_FP8DOT2 for -cpu max Richard Henderson
` (8 subsequent siblings)
63 siblings, 0 replies; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:22 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/cpu-features.h | 5 +++++
target/arm/tcg/translate-sve.c | 35 ++++++++++++++++++++++++++++++++++
target/arm/tcg/sve.decode | 2 ++
3 files changed, 42 insertions(+)
diff --git a/target/arm/cpu-features.h b/target/arm/cpu-features.h
index 7bedc293fd..90098c3cbe 100644
--- a/target/arm/cpu-features.h
+++ b/target/arm/cpu-features.h
@@ -1555,6 +1555,11 @@ static inline bool isar_feature_aa64_ssve_f8dp4(const ARMISARegisters *id)
return FIELD_EX64_IDREG(id, ID_AA64SMFR0, SF8DP4);
}
+static inline bool isar_feature_aa64_ssve_f8dp2(const ARMISARegisters *id)
+{
+ return FIELD_EX64_IDREG(id, ID_AA64SMFR0, SF8DP2);
+}
+
static inline bool isar_feature_aa64_sme_b16b16(const ARMISARegisters *id)
{
return FIELD_EX64_IDREG(id, ID_AA64SMFR0, B16B16);
diff --git a/target/arm/tcg/translate-sve.c b/target/arm/tcg/translate-sve.c
index 88e6148b83..8d622f9a1c 100644
--- a/target/arm/tcg/translate-sve.c
+++ b/target/arm/tcg/translate-sve.c
@@ -8407,3 +8407,38 @@ static bool do_f8dp4(DisasContext *s, gen_helper_gvec_3_ptr *fn,
TRANS(FDOT_sb, do_f8dp4, gen_helper_gvec_fdot_sb, a->rd, a->rn, a->rm, 0)
TRANS(FDOT_idx_sb, do_f8dp4, gen_helper_gvec_fdot_idx_sb,
a->rd, a->rn, a->rm, a->index)
+
+static bool do_f8dp2(DisasContext *s, gen_helper_gvec_3_ptr *fn,
+ int rd, int rn, int rm, int index)
+{
+ bool fp8dp2 = dc_isar_feature(aa64_f8dp2, s);
+ bool ssve_fp8dp2 = dc_isar_feature(aa64_ssve_f8dp2, s);
+ bool ok = false;
+
+ /* Feature detection and enabling are complex here. */
+ if (!(ssve_fp8dp2 || (fp8dp2 && dc_isar_feature(aa64_sve2, s)))) {
+ return false;
+ }
+ if (fpmr_access_check(s)) {
+ if (fp8dp2) {
+ s->is_nonstreaming = !ssve_fp8dp2;
+ ok = sve_access_check(s);
+ } else {
+ ok = sme_sm_enabled_check(s);
+ }
+ }
+
+ if (ok) {
+ unsigned vsz = vec_full_reg_size(s);
+ tcg_gen_gvec_3_ptr(vec_full_reg_offset(s, rd),
+ vec_full_reg_offset(s, rn),
+ vec_full_reg_offset(s, rm),
+ tcg_env, vsz, vsz,
+ index, fn);
+ }
+ return true;
+}
+
+TRANS(FDOT_hb, do_f8dp2, gen_helper_gvec_fdot_hb, a->rd, a->rn, a->rm, 0)
+TRANS(FDOT_idx_hb, do_f8dp2, gen_helper_gvec_fdot_idx_hb,
+ a->rd, a->rn, a->rm, a->index)
diff --git a/target/arm/tcg/sve.decode b/target/arm/tcg/sve.decode
index c49e992f10..26b3c7697a 100644
--- a/target/arm/tcg/sve.decode
+++ b/target/arm/tcg/sve.decode
@@ -1875,6 +1875,7 @@ FDOT_zzzz 01100100 00 1 ..... 10 0 00 0 ..... ..... @rda_rn_rm_ex esz=2
BFDOT_zzzz 01100100 01 1 ..... 10 0 00 0 ..... ..... @rda_rn_rm_ex esz=2
FDOT_sb 01100100 01 1 ..... 10 0 00 1 ..... ..... @rda_rn_rm_ex esz=2
+FDOT_hb 01100100 00 1 ..... 10 0 00 1 ..... ..... @rda_rn_rm_ex esz=1
### SVE2 floating-point multiply-add long (indexed)
@@ -1900,6 +1901,7 @@ FDOT_zzxz 01100100 00 1 ..... 010000 ..... ..... @rrxr_2 esz=2
BFDOT_zzxz 01100100 01 1 ..... 010000 ..... ..... @rrxr_2 esz=2
FDOT_idx_sb 01100100 01 1 ..... 010001 ..... ..... @rrxr_2 esz=2
+FDOT_idx_hb 01100100 00 1 ..... 0100.1 ..... ..... @rrx_3a esz=1
### SVE broadcast predicate element
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread* [PATCH v6 56/64] target/arm: Enable FEAT_FP8DOT2, FEAT_SSVE_FP8DOT2 for -cpu max
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
` (54 preceding siblings ...)
2026-05-20 18:22 ` [PATCH v6 55/64] target/arm: Implement FDOT (FP8 to FP16) for SVE Richard Henderson
@ 2026-05-20 18:22 ` Richard Henderson
2026-05-20 18:22 ` [PATCH v6 57/64] target/arm: Implement FMMLA (FP8 to FP32) for AdvSIMD Richard Henderson
` (7 subsequent siblings)
63 siblings, 0 replies; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:22 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/tcg/cpu64.c | 2 ++
docs/system/arm/emulation.rst | 2 ++
2 files changed, 4 insertions(+)
diff --git a/target/arm/tcg/cpu64.c b/target/arm/tcg/cpu64.c
index 6dec7e045d..a43b6367a4 100644
--- a/target/arm/tcg/cpu64.c
+++ b/target/arm/tcg/cpu64.c
@@ -1377,6 +1377,7 @@ void aarch64_max_tcg_initfn(Object *obj)
SET_IDREG(isar, ID_AA64DFR0, t);
t = GET_IDREG(isar, ID_AA64SMFR0);
+ t = FIELD_DP64(t, ID_AA64SMFR0, SF8DP2, 1); /* FEAT_SSVE_FP8DOT2 */
t = FIELD_DP64(t, ID_AA64SMFR0, SF8DP4, 1); /* FEAT_SSVE_FP8DOT4 */
t = FIELD_DP64(t, ID_AA64SMFR0, SF8FMA, 1); /* FEAT_SSVE_FP8FMA */
t = FIELD_DP64(t, ID_AA64SMFR0, F32F32, 1); /* FEAT_SME */
@@ -1397,6 +1398,7 @@ void aarch64_max_tcg_initfn(Object *obj)
t = GET_IDREG(isar, ID_AA64FPFR0);
t = FIELD_DP64(t, ID_AA64FPFR0, F8E5M2, 1); /* FEAT_FP8 */
t = FIELD_DP64(t, ID_AA64FPFR0, F8E4M3, 1); /* FEAT_FP8 */
+ t = FIELD_DP64(t, ID_AA64FPFR0, F8DP2, 1); /* FEAT_FP8DOT2 */
t = FIELD_DP64(t, ID_AA64FPFR0, F8DP4, 1); /* FEAT_FP8DOT4 */
t = FIELD_DP64(t, ID_AA64FPFR0, F8FMA, 1); /* FEAT_FP8FMA */
t = FIELD_DP64(t, ID_AA64FPFR0, F8CVT, 1); /* FEAT_FP8 */
diff --git a/docs/system/arm/emulation.rst b/docs/system/arm/emulation.rst
index bee4e36dc6..875716d18f 100644
--- a/docs/system/arm/emulation.rst
+++ b/docs/system/arm/emulation.rst
@@ -75,6 +75,7 @@ the following architecture extensions:
- FEAT_FP (Floating Point extensions)
- FEAT_FP16 (Half-precision floating-point data processing)
- FEAT_FP8 (FP8 convert instructions)
+- FEAT_FP8DOT2 (FP8 2-way dot product to half-precision instructions)
- FEAT_FP8DOT4 (FP8 4-way dot product to single-precision instructions)
- FEAT_FP8FMA (FP8 multiply-accumulate to half-precision and single-precision instructions)
- FEAT_FPAC (Faulting on AUT* instructions)
@@ -161,6 +162,7 @@ the following architecture extensions:
- FEAT_SME_F64F64 (Double-precision floating-point outer product instructions)
- FEAT_SME_I16I64 (16-bit to 64-bit integer widening outer product instructions)
- FEAT_SME_LUTv2 (Lookup table instructions with 4-bit indices and 8-bit elements)
+- FEAT_SSVE_FP8DOT2 (SVE2 FP8 2-way dot product to half-precision instructions in Streaming SVE mode)
- FEAT_SSVE_FP8DOT4 (SVE2 FP8 4-way dot product to single-precision instructions in Streaming SVE mode)
- FEAT_SSVE_FP8FMA (SVE2 FP8 multiply-accumulate to half-precision and single-precision instructions in Streaming SVE mode)
- FEAT_SVE (Scalable Vector Extension)
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread* [PATCH v6 57/64] target/arm: Implement FMMLA (FP8 to FP32) for AdvSIMD
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
` (55 preceding siblings ...)
2026-05-20 18:22 ` [PATCH v6 56/64] target/arm: Enable FEAT_FP8DOT2, FEAT_SSVE_FP8DOT2 for -cpu max Richard Henderson
@ 2026-05-20 18:22 ` Richard Henderson
2026-05-20 18:22 ` [PATCH v6 58/64] target/arm: Implement FMMLA (FP8 to FP32) for SVE Richard Henderson
` (6 subsequent siblings)
63 siblings, 0 replies; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:22 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/cpu-features.h | 5 +++++
target/arm/tcg/helper-fp8-defs.h | 2 ++
target/arm/tcg/fp8_helper.c | 25 +++++++++++++++++++++++++
target/arm/tcg/translate-a64.c | 1 +
target/arm/tcg/a64.decode | 2 ++
5 files changed, 35 insertions(+)
diff --git a/target/arm/cpu-features.h b/target/arm/cpu-features.h
index 90098c3cbe..67b9d7e982 100644
--- a/target/arm/cpu-features.h
+++ b/target/arm/cpu-features.h
@@ -1620,6 +1620,11 @@ static inline bool isar_feature_aa64_f8dp2(const ARMISARegisters *id)
return FIELD_EX64_IDREG(id, ID_AA64FPFR0, F8DP2);
}
+static inline bool isar_feature_aa64_f8mm8(const ARMISARegisters *id)
+{
+ return FIELD_EX64_IDREG(id, ID_AA64FPFR0, F8MM8);
+}
+
/*
* Combinations of feature tests, for ease of use with TRANS_FEAT.
*/
diff --git a/target/arm/tcg/helper-fp8-defs.h b/target/arm/tcg/helper-fp8-defs.h
index 5995d77577..3c74f02022 100644
--- a/target/arm/tcg/helper-fp8-defs.h
+++ b/target/arm/tcg/helper-fp8-defs.h
@@ -35,3 +35,5 @@ DEF_HELPER_FLAGS_5(gvec_fdot_idx_sb, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, env,
DEF_HELPER_FLAGS_5(gvec_fdot_hb, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, env, i32)
DEF_HELPER_FLAGS_5(gvec_fdot_idx_hb, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, env, i32)
+
+DEF_HELPER_FLAGS_5(gvec_fmmla_sb, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, env, i32)
diff --git a/target/arm/tcg/fp8_helper.c b/target/arm/tcg/fp8_helper.c
index d3bbea1735..160850be53 100644
--- a/target/arm/tcg/fp8_helper.c
+++ b/target/arm/tcg/fp8_helper.c
@@ -807,3 +807,28 @@ void HELPER(gvec_fdot_idx_hb)(void *vd, void *vn, void *vm,
clear_tail(vd, oprsz, simd_maxsz(desc));
}
+
+void HELPER(gvec_fmmla_sb)(void *vd, void *vn, void *vm,
+ CPUARMState *env, uint32_t desc)
+{
+ FP8MulContext ctx = fp8_mul_start(env, -1);
+ size_t oprsz = simd_oprsz(desc);
+ size_t nseg = oprsz / 16;
+ uint64_t *n = vn;
+ uint64_t *m = vm;
+ float32 *d = vd;
+
+ for (size_t seg = 0; seg < nseg; seg++, d += 4, n += 2, m += 2) {
+ float32 d0 = f8dotadd_s(n[0], m[0], 8, d[H4(0)], &ctx);
+ float32 d1 = f8dotadd_s(n[0], m[1], 8, d[H4(1)], &ctx);
+ float32 d2 = f8dotadd_s(n[1], m[0], 8, d[H4(2)], &ctx);
+ float32 d3 = f8dotadd_s(n[1], m[1], 8, d[H4(3)], &ctx);
+
+ d[H4(0)] = d0;
+ d[H4(1)] = d1;
+ d[H4(2)] = d2;
+ d[H4(3)] = d3;
+ }
+
+ clear_tail(vd, oprsz, simd_maxsz(desc));
+}
diff --git a/target/arm/tcg/translate-a64.c b/target/arm/tcg/translate-a64.c
index c5ea6b27a9..02d5e007f9 100644
--- a/target/arm/tcg/translate-a64.c
+++ b/target/arm/tcg/translate-a64.c
@@ -7418,6 +7418,7 @@ static bool do_f8dot(DisasContext *s, arg_qrrr_e *a,
TRANS_FEAT(FDOT_sb_v, aa64_f8dp4, do_f8dot, a, gen_helper_gvec_fdot_sb)
TRANS_FEAT(FDOT_hb_v, aa64_f8dp2, do_f8dot, a, gen_helper_gvec_fdot_hb)
+TRANS_FEAT(FMMLA_sb, aa64_f8mm8, do_f8dot, a, gen_helper_gvec_fmmla_sb)
static bool do_f8dot_idx(DisasContext *s, arg_qrrx_e *a,
gen_helper_gvec_3_ptr *fn)
diff --git a/target/arm/tcg/a64.decode b/target/arm/tcg/a64.decode
index d1254355b6..6404c26540 100644
--- a/target/arm/tcg/a64.decode
+++ b/target/arm/tcg/a64.decode
@@ -1216,6 +1216,8 @@ FMLALL_sb_v 0.00 1110 0.0 rm:5 110001 rn:5 rd:5 \
FDOT_sb_v 0.00 1110 000 ..... 11111 1 ..... ..... @qrrr_s
FDOT_hb_v 0.00 1110 010 ..... 11111 1 ..... ..... @qrrr_h
+FMMLA_sb 0110 1110 100 ..... 11101 1 ..... ..... @rrr_q1e0
+
### Advanced SIMD scalar x indexed element
FMUL_si 0101 1111 00 .. .... 1001 . 0 ..... ..... @rrx_h
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread* [PATCH v6 58/64] target/arm: Implement FMMLA (FP8 to FP32) for SVE
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
` (56 preceding siblings ...)
2026-05-20 18:22 ` [PATCH v6 57/64] target/arm: Implement FMMLA (FP8 to FP32) for AdvSIMD Richard Henderson
@ 2026-05-20 18:22 ` Richard Henderson
2026-05-20 18:22 ` [PATCH v6 59/64] target/arm: Enable FEAT_F8F32MM for -cpu max Richard Henderson
` (5 subsequent siblings)
63 siblings, 0 replies; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:22 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/cpu-features.h | 5 +++++
target/arm/tcg/translate-sve.c | 16 ++++++++++++++++
target/arm/tcg/sve.decode | 2 ++
3 files changed, 23 insertions(+)
diff --git a/target/arm/cpu-features.h b/target/arm/cpu-features.h
index 67b9d7e982..8f6cc2974f 100644
--- a/target/arm/cpu-features.h
+++ b/target/arm/cpu-features.h
@@ -1693,6 +1693,11 @@ static inline bool isar_feature_aa64_sve_bf16(const ARMISARegisters *id)
return isar_feature_aa64_sve(id) && isar_feature_aa64_sme_sve_bf16(id);
}
+static inline bool isar_feature_aa64_sve2_f8mm8(const ARMISARegisters *id)
+{
+ return isar_feature_aa64_sve2(id) && isar_feature_aa64_f8mm8(id);
+}
+
static inline bool
isar_feature_aa64_sme2_or_sve2_faminmax(const ARMISARegisters *id)
{
diff --git a/target/arm/tcg/translate-sve.c b/target/arm/tcg/translate-sve.c
index 8d622f9a1c..5bda5f6c01 100644
--- a/target/arm/tcg/translate-sve.c
+++ b/target/arm/tcg/translate-sve.c
@@ -8442,3 +8442,19 @@ static bool do_f8dp2(DisasContext *s, gen_helper_gvec_3_ptr *fn,
TRANS(FDOT_hb, do_f8dp2, gen_helper_gvec_fdot_hb, a->rd, a->rn, a->rm, 0)
TRANS(FDOT_idx_hb, do_f8dp2, gen_helper_gvec_fdot_idx_hb,
a->rd, a->rn, a->rm, a->index)
+
+static bool do_fmmla_fp8(DisasContext *s, arg_rrrr_esz *a,
+ gen_helper_gvec_3_ptr *fn)
+{
+ if (fpmr_access_check(s) && sve_access_check(s)) {
+ unsigned vsz = vec_full_reg_size(s);
+ tcg_gen_gvec_3_ptr(vec_full_reg_offset(s, a->rd),
+ vec_full_reg_offset(s, a->rn),
+ vec_full_reg_offset(s, a->rm),
+ tcg_env, vsz, vsz, 0, fn);
+ }
+ return true;
+}
+
+TRANS_FEAT_NONSTREAMING(FMMLA_sb, aa64_sve2_f8mm8, do_fmmla_fp8, a,
+ gen_helper_gvec_fmmla_sb)
diff --git a/target/arm/tcg/sve.decode b/target/arm/tcg/sve.decode
index 26b3c7697a..6610432528 100644
--- a/target/arm/tcg/sve.decode
+++ b/target/arm/tcg/sve.decode
@@ -1808,6 +1808,8 @@ BFMMLA 01100100 01 1 ..... 111 001 ..... ..... @rda_rn_rm_ex esz=1
FMMLA_s 01100100 10 1 ..... 111 001 ..... ..... @rda_rn_rm_ex esz=2
FMMLA_d 01100100 11 1 ..... 111 001 ..... ..... @rda_rn_rm_ex esz=3
+FMMLA_sb 01100100 00 1 ..... 111 000 ..... ..... @rda_rn_rm_ex esz=2
+
### SVE2 Memory Gather Load Group
# SVE2 64-bit gather non-temporal load (scalar plus 64-bit unscaled offsets)
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread* [PATCH v6 59/64] target/arm: Enable FEAT_F8F32MM for -cpu max
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
` (57 preceding siblings ...)
2026-05-20 18:22 ` [PATCH v6 58/64] target/arm: Implement FMMLA (FP8 to FP32) for SVE Richard Henderson
@ 2026-05-20 18:22 ` Richard Henderson
2026-05-20 18:22 ` [PATCH v6 60/64] target/arm: Implement FMMLA (FP8 to FP16) for AdvSIMD Richard Henderson
` (4 subsequent siblings)
63 siblings, 0 replies; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:22 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/tcg/cpu64.c | 1 +
docs/system/arm/emulation.rst | 1 +
2 files changed, 2 insertions(+)
diff --git a/target/arm/tcg/cpu64.c b/target/arm/tcg/cpu64.c
index a43b6367a4..7a47af9f5a 100644
--- a/target/arm/tcg/cpu64.c
+++ b/target/arm/tcg/cpu64.c
@@ -1398,6 +1398,7 @@ void aarch64_max_tcg_initfn(Object *obj)
t = GET_IDREG(isar, ID_AA64FPFR0);
t = FIELD_DP64(t, ID_AA64FPFR0, F8E5M2, 1); /* FEAT_FP8 */
t = FIELD_DP64(t, ID_AA64FPFR0, F8E4M3, 1); /* FEAT_FP8 */
+ t = FIELD_DP64(t, ID_AA64FPFR0, F8MM8, 1); /* FEAT_F8F32MM */
t = FIELD_DP64(t, ID_AA64FPFR0, F8DP2, 1); /* FEAT_FP8DOT2 */
t = FIELD_DP64(t, ID_AA64FPFR0, F8DP4, 1); /* FEAT_FP8DOT4 */
t = FIELD_DP64(t, ID_AA64FPFR0, F8FMA, 1); /* FEAT_FP8FMA */
diff --git a/docs/system/arm/emulation.rst b/docs/system/arm/emulation.rst
index 875716d18f..83967da12d 100644
--- a/docs/system/arm/emulation.rst
+++ b/docs/system/arm/emulation.rst
@@ -66,6 +66,7 @@ the following architecture extensions:
- FEAT_EPAC (Enhanced pointer authentication)
- FEAT_ETS2 (Enhanced Translation Synchronization)
- FEAT_EVT (Enhanced Virtualization Traps)
+- FEAT_F8F32MM (8-bit floating-point matrix multiply-accumulate to single-precision)
- FEAT_F32MM (Single-precision Matrix Multiplication)
- FEAT_F64MM (Double-precision Matrix Multiplication)
- FEAT_FAMINMAX (Floating-point maximum and minimum absolute value instructions)
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread* [PATCH v6 60/64] target/arm: Implement FMMLA (FP8 to FP16) for AdvSIMD
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
` (58 preceding siblings ...)
2026-05-20 18:22 ` [PATCH v6 59/64] target/arm: Enable FEAT_F8F32MM for -cpu max Richard Henderson
@ 2026-05-20 18:22 ` Richard Henderson
2026-05-21 9:52 ` Peter Maydell
2026-05-20 18:22 ` [PATCH v6 61/64] target/arm: Implement FMMLA (FP8 to FP16) for SVE Richard Henderson
` (3 subsequent siblings)
63 siblings, 1 reply; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:22 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/cpu-features.h | 5 +++++
target/arm/tcg/helper-fp8-defs.h | 1 +
target/arm/tcg/fp8_helper.c | 25 +++++++++++++++++++++++++
target/arm/tcg/translate-a64.c | 1 +
target/arm/tcg/a64.decode | 1 +
5 files changed, 33 insertions(+)
diff --git a/target/arm/cpu-features.h b/target/arm/cpu-features.h
index 8f6cc2974f..fce38dfbb0 100644
--- a/target/arm/cpu-features.h
+++ b/target/arm/cpu-features.h
@@ -1625,6 +1625,11 @@ static inline bool isar_feature_aa64_f8mm8(const ARMISARegisters *id)
return FIELD_EX64_IDREG(id, ID_AA64FPFR0, F8MM8);
}
+static inline bool isar_feature_aa64_f8mm4(const ARMISARegisters *id)
+{
+ return FIELD_EX64_IDREG(id, ID_AA64FPFR0, F8MM4);
+}
+
/*
* Combinations of feature tests, for ease of use with TRANS_FEAT.
*/
diff --git a/target/arm/tcg/helper-fp8-defs.h b/target/arm/tcg/helper-fp8-defs.h
index 3c74f02022..e942308af4 100644
--- a/target/arm/tcg/helper-fp8-defs.h
+++ b/target/arm/tcg/helper-fp8-defs.h
@@ -37,3 +37,4 @@ DEF_HELPER_FLAGS_5(gvec_fdot_hb, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, env, i32)
DEF_HELPER_FLAGS_5(gvec_fdot_idx_hb, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, env, i32)
DEF_HELPER_FLAGS_5(gvec_fmmla_sb, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, env, i32)
+DEF_HELPER_FLAGS_5(gvec_fmmla_hb, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, env, i32)
diff --git a/target/arm/tcg/fp8_helper.c b/target/arm/tcg/fp8_helper.c
index 160850be53..b6ce4826fb 100644
--- a/target/arm/tcg/fp8_helper.c
+++ b/target/arm/tcg/fp8_helper.c
@@ -832,3 +832,28 @@ void HELPER(gvec_fmmla_sb)(void *vd, void *vn, void *vm,
clear_tail(vd, oprsz, simd_maxsz(desc));
}
+
+void HELPER(gvec_fmmla_hb)(void *vd, void *vn, void *vm,
+ CPUARMState *env, uint32_t desc)
+{
+ FP8MulContext ctx = fp8_mul_start(env, 0xf);
+ size_t oprsz = simd_oprsz(desc);
+ size_t nseg = oprsz / 16;
+ uint32_t *n = vn;
+ uint32_t *m = vm;
+ float16 *d = vd;
+
+ for (size_t seg = 0; seg < nseg; seg++, d += 4, n += 2, m += 2) {
+ float16 d0 = f8dotadd_h(n[0], m[0], 4, d[H4(0)], &ctx);
+ float16 d1 = f8dotadd_h(n[0], m[1], 4, d[H4(1)], &ctx);
+ float16 d2 = f8dotadd_h(n[1], m[0], 4, d[H4(2)], &ctx);
+ float16 d3 = f8dotadd_h(n[1], m[1], 4, d[H4(3)], &ctx);
+
+ d[H4(0)] = d0;
+ d[H4(1)] = d1;
+ d[H4(2)] = d2;
+ d[H4(3)] = d3;
+ }
+
+ clear_tail(vd, oprsz, simd_maxsz(desc));
+}
diff --git a/target/arm/tcg/translate-a64.c b/target/arm/tcg/translate-a64.c
index 02d5e007f9..aff0f332ac 100644
--- a/target/arm/tcg/translate-a64.c
+++ b/target/arm/tcg/translate-a64.c
@@ -7419,6 +7419,7 @@ static bool do_f8dot(DisasContext *s, arg_qrrr_e *a,
TRANS_FEAT(FDOT_sb_v, aa64_f8dp4, do_f8dot, a, gen_helper_gvec_fdot_sb)
TRANS_FEAT(FDOT_hb_v, aa64_f8dp2, do_f8dot, a, gen_helper_gvec_fdot_hb)
TRANS_FEAT(FMMLA_sb, aa64_f8mm8, do_f8dot, a, gen_helper_gvec_fmmla_sb)
+TRANS_FEAT(FMMLA_hb, aa64_f8mm4, do_f8dot, a, gen_helper_gvec_fmmla_hb)
static bool do_f8dot_idx(DisasContext *s, arg_qrrx_e *a,
gen_helper_gvec_3_ptr *fn)
diff --git a/target/arm/tcg/a64.decode b/target/arm/tcg/a64.decode
index 6404c26540..e7f2f30abb 100644
--- a/target/arm/tcg/a64.decode
+++ b/target/arm/tcg/a64.decode
@@ -1217,6 +1217,7 @@ FDOT_sb_v 0.00 1110 000 ..... 11111 1 ..... ..... @qrrr_s
FDOT_hb_v 0.00 1110 010 ..... 11111 1 ..... ..... @qrrr_h
FMMLA_sb 0110 1110 100 ..... 11101 1 ..... ..... @rrr_q1e0
+FMMLA_hb 0110 1110 000 ..... 11101 1 ..... ..... @rrr_q1e0
### Advanced SIMD scalar x indexed element
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread* Re: [PATCH v6 60/64] target/arm: Implement FMMLA (FP8 to FP16) for AdvSIMD
2026-05-20 18:22 ` [PATCH v6 60/64] target/arm: Implement FMMLA (FP8 to FP16) for AdvSIMD Richard Henderson
@ 2026-05-21 9:52 ` Peter Maydell
2026-05-22 20:04 ` Richard Henderson
0 siblings, 1 reply; 105+ messages in thread
From: Peter Maydell @ 2026-05-21 9:52 UTC (permalink / raw)
To: Richard Henderson; +Cc: qemu-devel, qemu-arm
On Wed, 20 May 2026 at 19:29, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> +void HELPER(gvec_fmmla_hb)(void *vd, void *vn, void *vm,
> + CPUARMState *env, uint32_t desc)
This still has some lurking copy-and-paste issues from the _sb
version:
> +{
> + FP8MulContext ctx = fp8_mul_start(env, 0xf);
> + size_t oprsz = simd_oprsz(desc);
> + size_t nseg = oprsz / 16;
Each loop here handles 4 16-bit halfprec outputs == 8 bytes,
so we want oprsz / 8.
> + uint32_t *n = vn;
> + uint32_t *m = vm;
> + float16 *d = vd;
> +
> + for (size_t seg = 0; seg < nseg; seg++, d += 4, n += 2, m += 2) {
> + float16 d0 = f8dotadd_h(n[0], m[0], 4, d[H4(0)], &ctx);
> + float16 d1 = f8dotadd_h(n[0], m[1], 4, d[H4(1)], &ctx);
> + float16 d2 = f8dotadd_h(n[1], m[0], 4, d[H4(2)], &ctx);
> + float16 d3 = f8dotadd_h(n[1], m[1], 4, d[H4(3)], &ctx);
> +
> + d[H4(0)] = d0;
> + d[H4(1)] = d1;
> + d[H4(2)] = d2;
> + d[H4(3)] = d3;
The H macros here I think are wrong -- d is a float16 so we
want H2(), and we need H4() macros for the n and m arrays.
(I think in fact if you work it through then all the H macros
cancel out and we could drop the lot, but since they're all
acting on constant indexes there's no runtime cost and having
them present is clearer for the reader.)
thanks
-- PMM
^ permalink raw reply [flat|nested] 105+ messages in thread* Re: [PATCH v6 60/64] target/arm: Implement FMMLA (FP8 to FP16) for AdvSIMD
2026-05-21 9:52 ` Peter Maydell
@ 2026-05-22 20:04 ` Richard Henderson
0 siblings, 0 replies; 105+ messages in thread
From: Richard Henderson @ 2026-05-22 20:04 UTC (permalink / raw)
To: Peter Maydell; +Cc: qemu-devel, qemu-arm
On 5/21/26 02:52, Peter Maydell wrote:
> On Wed, 20 May 2026 at 19:29, Richard Henderson
> <richard.henderson@linaro.org> wrote:
>>
>> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
>
>> +void HELPER(gvec_fmmla_hb)(void *vd, void *vn, void *vm,
>> + CPUARMState *env, uint32_t desc)
>
> This still has some lurking copy-and-paste issues from the _sb
> version:
>
>> +{
>> + FP8MulContext ctx = fp8_mul_start(env, 0xf);
>> + size_t oprsz = simd_oprsz(desc);
>> + size_t nseg = oprsz / 16;
>
> Each loop here handles 4 16-bit halfprec outputs == 8 bytes,
> so we want oprsz / 8.
>
>> + uint32_t *n = vn;
>> + uint32_t *m = vm;
>> + float16 *d = vd;
>> +
>> + for (size_t seg = 0; seg < nseg; seg++, d += 4, n += 2, m += 2) {
>> + float16 d0 = f8dotadd_h(n[0], m[0], 4, d[H4(0)], &ctx);
>> + float16 d1 = f8dotadd_h(n[0], m[1], 4, d[H4(1)], &ctx);
>> + float16 d2 = f8dotadd_h(n[1], m[0], 4, d[H4(2)], &ctx);
>> + float16 d3 = f8dotadd_h(n[1], m[1], 4, d[H4(3)], &ctx);
>> +
>> + d[H4(0)] = d0;
>> + d[H4(1)] = d1;
>> + d[H4(2)] = d2;
>> + d[H4(3)] = d3;
>
> The H macros here I think are wrong -- d is a float16 so we
> want H2(), and we need H4() macros for the n and m arrays.
> (I think in fact if you work it through then all the H macros
> cancel out and we could drop the lot, but since they're all
> acting on constant indexes there's no runtime cost and having
> them present is clearer for the reader.)
All correct, now fixed, thanks.
r~
^ permalink raw reply [flat|nested] 105+ messages in thread
* [PATCH v6 61/64] target/arm: Implement FMMLA (FP8 to FP16) for SVE
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
` (59 preceding siblings ...)
2026-05-20 18:22 ` [PATCH v6 60/64] target/arm: Implement FMMLA (FP8 to FP16) for AdvSIMD Richard Henderson
@ 2026-05-20 18:22 ` Richard Henderson
2026-05-20 18:22 ` [PATCH v6 62/64] target/arm: Enable FEAT_F8F16MM for -cpu max Richard Henderson
` (2 subsequent siblings)
63 siblings, 0 replies; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:22 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/cpu-features.h | 5 +++++
target/arm/tcg/translate-sve.c | 2 ++
target/arm/tcg/sve.decode | 1 +
3 files changed, 8 insertions(+)
diff --git a/target/arm/cpu-features.h b/target/arm/cpu-features.h
index fce38dfbb0..3eb08da6df 100644
--- a/target/arm/cpu-features.h
+++ b/target/arm/cpu-features.h
@@ -1703,6 +1703,11 @@ static inline bool isar_feature_aa64_sve2_f8mm8(const ARMISARegisters *id)
return isar_feature_aa64_sve2(id) && isar_feature_aa64_f8mm8(id);
}
+static inline bool isar_feature_aa64_sve2_f8mm4(const ARMISARegisters *id)
+{
+ return isar_feature_aa64_sve2(id) && isar_feature_aa64_f8mm4(id);
+}
+
static inline bool
isar_feature_aa64_sme2_or_sve2_faminmax(const ARMISARegisters *id)
{
diff --git a/target/arm/tcg/translate-sve.c b/target/arm/tcg/translate-sve.c
index 5bda5f6c01..2bce6a38a2 100644
--- a/target/arm/tcg/translate-sve.c
+++ b/target/arm/tcg/translate-sve.c
@@ -8458,3 +8458,5 @@ static bool do_fmmla_fp8(DisasContext *s, arg_rrrr_esz *a,
TRANS_FEAT_NONSTREAMING(FMMLA_sb, aa64_sve2_f8mm8, do_fmmla_fp8, a,
gen_helper_gvec_fmmla_sb)
+TRANS_FEAT_NONSTREAMING(FMMLA_hb, aa64_sve2_f8mm4, do_fmmla_fp8, a,
+ gen_helper_gvec_fmmla_hb)
diff --git a/target/arm/tcg/sve.decode b/target/arm/tcg/sve.decode
index 6610432528..b53fe6a58f 100644
--- a/target/arm/tcg/sve.decode
+++ b/target/arm/tcg/sve.decode
@@ -1809,6 +1809,7 @@ FMMLA_s 01100100 10 1 ..... 111 001 ..... ..... @rda_rn_rm_ex esz=2
FMMLA_d 01100100 11 1 ..... 111 001 ..... ..... @rda_rn_rm_ex esz=3
FMMLA_sb 01100100 00 1 ..... 111 000 ..... ..... @rda_rn_rm_ex esz=2
+FMMLA_hb 01100100 01 1 ..... 111 000 ..... ..... @rda_rn_rm_ex esz=1
### SVE2 Memory Gather Load Group
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread* [PATCH v6 62/64] target/arm: Enable FEAT_F8F16MM for -cpu max
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
` (60 preceding siblings ...)
2026-05-20 18:22 ` [PATCH v6 61/64] target/arm: Implement FMMLA (FP8 to FP16) for SVE Richard Henderson
@ 2026-05-20 18:22 ` Richard Henderson
2026-05-20 18:22 ` [PATCH v6 63/64] linux-user/aarch64: Implement hwcap bits for fp8 features Richard Henderson
2026-05-20 18:22 ` [PATCH v6 64/64] linux-user/aarch64: Implement FPMR signal frames Richard Henderson
63 siblings, 0 replies; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:22 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/tcg/cpu64.c | 1 +
docs/system/arm/emulation.rst | 1 +
2 files changed, 2 insertions(+)
diff --git a/target/arm/tcg/cpu64.c b/target/arm/tcg/cpu64.c
index 7a47af9f5a..492f70fc8d 100644
--- a/target/arm/tcg/cpu64.c
+++ b/target/arm/tcg/cpu64.c
@@ -1398,6 +1398,7 @@ void aarch64_max_tcg_initfn(Object *obj)
t = GET_IDREG(isar, ID_AA64FPFR0);
t = FIELD_DP64(t, ID_AA64FPFR0, F8E5M2, 1); /* FEAT_FP8 */
t = FIELD_DP64(t, ID_AA64FPFR0, F8E4M3, 1); /* FEAT_FP8 */
+ t = FIELD_DP64(t, ID_AA64FPFR0, F8MM4, 1); /* FEAT_F8F16MM */
t = FIELD_DP64(t, ID_AA64FPFR0, F8MM8, 1); /* FEAT_F8F32MM */
t = FIELD_DP64(t, ID_AA64FPFR0, F8DP2, 1); /* FEAT_FP8DOT2 */
t = FIELD_DP64(t, ID_AA64FPFR0, F8DP4, 1); /* FEAT_FP8DOT4 */
diff --git a/docs/system/arm/emulation.rst b/docs/system/arm/emulation.rst
index 83967da12d..2580246a1d 100644
--- a/docs/system/arm/emulation.rst
+++ b/docs/system/arm/emulation.rst
@@ -66,6 +66,7 @@ the following architecture extensions:
- FEAT_EPAC (Enhanced pointer authentication)
- FEAT_ETS2 (Enhanced Translation Synchronization)
- FEAT_EVT (Enhanced Virtualization Traps)
+- FEAT_F8F16MM (8-bit floating-point matrix multiply-accumulate to half-precision)
- FEAT_F8F32MM (8-bit floating-point matrix multiply-accumulate to single-precision)
- FEAT_F32MM (Single-precision Matrix Multiplication)
- FEAT_F64MM (Double-precision Matrix Multiplication)
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread* [PATCH v6 63/64] linux-user/aarch64: Implement hwcap bits for fp8 features
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
` (61 preceding siblings ...)
2026-05-20 18:22 ` [PATCH v6 62/64] target/arm: Enable FEAT_F8F16MM for -cpu max Richard Henderson
@ 2026-05-20 18:22 ` Richard Henderson
2026-05-21 16:42 ` Peter Maydell
2026-05-20 18:22 ` [PATCH v6 64/64] linux-user/aarch64: Implement FPMR signal frames Richard Henderson
63 siblings, 1 reply; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:22 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
linux-user/aarch64/elfload.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/linux-user/aarch64/elfload.c b/linux-user/aarch64/elfload.c
index 3af5a37776..0934524be2 100644
--- a/linux-user/aarch64/elfload.c
+++ b/linux-user/aarch64/elfload.c
@@ -218,6 +218,20 @@ abi_ulong get_elf_hwcap2(CPUState *cs)
GET_FEATURE_ID(aa64_sve_b16b16, ARM_HWCAP2_A64_SVE_B16B16);
GET_FEATURE_ID(aa64_cssc, ARM_HWCAP2_A64_CSSC);
GET_FEATURE_ID(aa64_lse128, ARM_HWCAP2_A64_LSE128);
+ GET_FEATURE_ID(aa64_fpmr, ARM_HWCAP2_A64_FPMR);
+ GET_FEATURE_ID(aa64_lut, ARM_HWCAP2_A64_LUT);
+ GET_FEATURE_ID(aa64_faminmax, ARM_HWCAP2_A64_FAMINMAX);
+ GET_FEATURE_ID(aa64_f8cvt, ARM_HWCAP2_A64_F8CVT |
+ ARM_HWCAP2_A64_F8E4M3 |
+ ARM_HWCAP2_A64_F8E5M2);
+ GET_FEATURE_ID(aa64_f8fma, ARM_HWCAP2_A64_F8FMA);
+ GET_FEATURE_ID(aa64_f8dp4, ARM_HWCAP2_A64_F8DP4);
+ GET_FEATURE_ID(aa64_f8dp2, ARM_HWCAP2_A64_F8DP2);
+ GET_FEATURE_ID(aa64_sme2p1_lutv2, ARM_HWCAP2_A64_SME_LUTV2);
+ GET_FEATURE_ID(aa64_sme2p1_lutv2, ARM_HWCAP2_A64_SME_LUTV2);
+ GET_FEATURE_ID(aa64_ssve_f8fma, ARM_HWCAP2_A64_SME_SF8FMA);
+ GET_FEATURE_ID(aa64_ssve_f8dp4, ARM_HWCAP2_A64_SME_SF8DP4);
+ GET_FEATURE_ID(aa64_ssve_f8dp2, ARM_HWCAP2_A64_SME_SF8DP2);
return hwcaps;
}
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread* Re: [PATCH v6 63/64] linux-user/aarch64: Implement hwcap bits for fp8 features
2026-05-20 18:22 ` [PATCH v6 63/64] linux-user/aarch64: Implement hwcap bits for fp8 features Richard Henderson
@ 2026-05-21 16:42 ` Peter Maydell
0 siblings, 0 replies; 105+ messages in thread
From: Peter Maydell @ 2026-05-21 16:42 UTC (permalink / raw)
To: Richard Henderson; +Cc: qemu-devel, qemu-arm
On Wed, 20 May 2026 at 19:29, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> linux-user/aarch64/elfload.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/linux-user/aarch64/elfload.c b/linux-user/aarch64/elfload.c
> index 3af5a37776..0934524be2 100644
> --- a/linux-user/aarch64/elfload.c
> +++ b/linux-user/aarch64/elfload.c
> @@ -218,6 +218,20 @@ abi_ulong get_elf_hwcap2(CPUState *cs)
> GET_FEATURE_ID(aa64_sve_b16b16, ARM_HWCAP2_A64_SVE_B16B16);
> GET_FEATURE_ID(aa64_cssc, ARM_HWCAP2_A64_CSSC);
> GET_FEATURE_ID(aa64_lse128, ARM_HWCAP2_A64_LSE128);
> + GET_FEATURE_ID(aa64_fpmr, ARM_HWCAP2_A64_FPMR);
> + GET_FEATURE_ID(aa64_lut, ARM_HWCAP2_A64_LUT);
> + GET_FEATURE_ID(aa64_faminmax, ARM_HWCAP2_A64_FAMINMAX);
> + GET_FEATURE_ID(aa64_f8cvt, ARM_HWCAP2_A64_F8CVT |
> + ARM_HWCAP2_A64_F8E4M3 |
> + ARM_HWCAP2_A64_F8E5M2);
> + GET_FEATURE_ID(aa64_f8fma, ARM_HWCAP2_A64_F8FMA);
> + GET_FEATURE_ID(aa64_f8dp4, ARM_HWCAP2_A64_F8DP4);
> + GET_FEATURE_ID(aa64_f8dp2, ARM_HWCAP2_A64_F8DP2);
> + GET_FEATURE_ID(aa64_sme2p1_lutv2, ARM_HWCAP2_A64_SME_LUTV2);
> + GET_FEATURE_ID(aa64_sme2p1_lutv2, ARM_HWCAP2_A64_SME_LUTV2);
Accidental duplicated line?
> + GET_FEATURE_ID(aa64_ssve_f8fma, ARM_HWCAP2_A64_SME_SF8FMA);
> + GET_FEATURE_ID(aa64_ssve_f8dp4, ARM_HWCAP2_A64_SME_SF8DP4);
> + GET_FEATURE_ID(aa64_ssve_f8dp2, ARM_HWCAP2_A64_SME_SF8DP2);
>
> return hwcaps;
Otherwise
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
^ permalink raw reply [flat|nested] 105+ messages in thread
* [PATCH v6 64/64] linux-user/aarch64: Implement FPMR signal frames
2026-05-20 18:21 [PATCH v6 00/64] target/arm: Implement FEAT_FP8 Richard Henderson
` (62 preceding siblings ...)
2026-05-20 18:22 ` [PATCH v6 63/64] linux-user/aarch64: Implement hwcap bits for fp8 features Richard Henderson
@ 2026-05-20 18:22 ` Richard Henderson
63 siblings, 0 replies; 105+ messages in thread
From: Richard Henderson @ 2026-05-20 18:22 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
linux-user/aarch64/signal.c | 44 ++++++++++++++++++++++++++++++++++++-
1 file changed, 43 insertions(+), 1 deletion(-)
diff --git a/linux-user/aarch64/signal.c b/linux-user/aarch64/signal.c
index f7edfa249e..899fce7643 100644
--- a/linux-user/aarch64/signal.c
+++ b/linux-user/aarch64/signal.c
@@ -73,6 +73,13 @@ struct target_esr_context {
uint64_t esr;
};
+#define TARGET_FPMR_MAGIC 0x46504d52
+
+struct target_fpmr_context {
+ struct target_aarch64_ctx head;
+ uint64_t fpmr;
+};
+
#define TARGET_EXTRA_MAGIC 0x45585401
struct target_extra_context {
@@ -362,6 +369,14 @@ static bool target_setup_gcs_record(struct target_gcs_context *ctx,
return true;
}
+static void target_setup_fpmr_record(struct target_fpmr_context *ctx,
+ CPUARMState *env)
+{
+ __put_user(TARGET_FPMR_MAGIC, &ctx->head.magic);
+ __put_user(sizeof(*ctx), &ctx->head.size);
+ __put_user(env->vfp.fpmr, &ctx->fpmr);
+}
+
static void target_restore_general_frame(CPUARMState *env,
struct target_rt_sigframe *sf)
{
@@ -518,6 +533,12 @@ static void target_restore_tpidr2_record(CPUARMState *env,
__get_user(env->cp15.tpidr2_el0, &tpidr2->tpidr2);
}
+static void target_restore_fpmr_record(CPUARMState *env,
+ struct target_fpmr_context *fpmr)
+{
+ __get_user(env->vfp.fpmr, &fpmr->fpmr);
+}
+
static bool target_restore_zt_record(CPUARMState *env,
struct target_zt_context *zt, int size,
int svcr)
@@ -610,6 +631,7 @@ static int target_restore_sigframe(CPUARMState *env,
struct target_tpidr2_context *tpidr2 = NULL;
struct target_zt_context *zt = NULL;
struct target_gcs_context *gcs = NULL;
+ struct target_fpmr_context *fpmr = NULL;
uint64_t extra_datap = 0;
bool used_extra = false;
bool rebuild_hflags = false;
@@ -691,6 +713,15 @@ static int target_restore_sigframe(CPUARMState *env,
gcs = (struct target_gcs_context *)ctx;
break;
+ case TARGET_FPMR_MAGIC:
+ if (fpmr
+ || size != sizeof(struct target_fpmr_context)
+ || !cpu_isar_feature(aa64_fpmr, env_archcpu(env))) {
+ goto err;
+ }
+ fpmr = (struct target_fpmr_context *)ctx;
+ break;
+
case TARGET_EXTRA_MAGIC:
if (extra || size != sizeof(struct target_extra_context)) {
goto err;
@@ -735,6 +766,9 @@ static int target_restore_sigframe(CPUARMState *env,
if (tpidr2) {
target_restore_tpidr2_record(env, tpidr2);
}
+ if (fpmr) {
+ target_restore_fpmr_record(env, fpmr);
+ }
/*
* NB that we must restore ZT after ZA so the check that there's
* no ZT record if SVCR.ZA is 0 gets the right value of SVCR.
@@ -817,7 +851,7 @@ static void target_setup_frame(int usig, struct target_sigaction *ka,
uc.tuc_mcontext.__reserved),
};
int fpsimd_ofs, fr_ofs, sve_ofs = 0, za_ofs = 0, tpidr2_ofs = 0;
- int zt_ofs = 0, esr_ofs = 0, gcs_ofs = 0;
+ int zt_ofs = 0, esr_ofs = 0, gcs_ofs = 0, fpmr_ofs = 0;
int sve_size = 0, za_size = 0, tpidr2_size = 0, zt_size = 0;
struct target_rt_sigframe *frame;
struct target_rt_frame_record *fr;
@@ -841,6 +875,11 @@ static void target_setup_frame(int usig, struct target_sigaction *ka,
&layout);
}
+ if (cpu_isar_feature(aa64_fpmr, env_archcpu(env))) {
+ fpmr_ofs = alloc_sigframe_space(sizeof(struct target_fpmr_context),
+ &layout);
+ }
+
/* SVE state needs saving only if it exists. */
if (cpu_isar_feature(aa64_sve, env_archcpu(env)) ||
cpu_isar_feature(aa64_sme, env_archcpu(env))) {
@@ -917,6 +956,9 @@ static void target_setup_frame(int usig, struct target_sigaction *ka,
!target_setup_gcs_record((void *)frame + gcs_ofs, env, return_addr)) {
goto give_sigsegv;
}
+ if (fpmr_ofs) {
+ target_setup_fpmr_record((void *)frame + fpmr_ofs, env);
+ }
target_setup_end_record((void *)frame + layout.std_end_ofs);
if (layout.extra_ofs) {
target_setup_extra_record((void *)frame + layout.extra_ofs,
--
2.43.0
^ permalink raw reply related [flat|nested] 105+ messages in thread