All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Florian Fuchs <fuchsfl@gmail.com>
Cc: Richard Weinberger <richard@nod.at>,
	 Vignesh Raghavendra <vigneshr@ti.com>,
	 linux-mtd@lists.infradead.org, linux-sh@vger.kernel.org,
	 linux-kernel@vger.kernel.org,  Rich Felker <dalias@libc.org>,
	 John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
	 Artur Rojek <contact@artur-rojek.eu>
Subject: Re: [PATCH v2 2/3] mtd: maps: vmu-flash: fix fault in unaligned fixup
Date: Mon, 27 Apr 2026 14:34:35 +0200	[thread overview]
Message-ID: <874ikwintw.fsf@bootlin.com> (raw)
In-Reply-To: <20260427114750.2480900-3-fuchsfl@gmail.com> (Florian Fuchs's message of "Mon, 27 Apr 2026 13:47:49 +0200")

On 27/04/2026 at 13:47:49 +02, Florian Fuchs <fuchsfl@gmail.com> wrote:

> Use kzalloc_obj() / kzalloc_objs() to allocate the memcard structs,
> instead of kmalloc_obj() / kmalloc_objs() to prevent access to
> uninitialized data.
>
> Fixes runtime error: Fault in unaligned fixup: 0000 [#1] at
> mtd_get_fact_prot_info.

Shall this patch receive a Fixes tag if it actually fixes runtime
behaviour?

Also, please add the 'Cc: stable' line in your fixes.

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Florian Fuchs <fuchsfl@gmail.com>
Cc: Richard Weinberger <richard@nod.at>,
	 Vignesh Raghavendra <vigneshr@ti.com>,
	 linux-mtd@lists.infradead.org, linux-sh@vger.kernel.org,
	 linux-kernel@vger.kernel.org,  Rich Felker <dalias@libc.org>,
	 John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
	 Artur Rojek <contact@artur-rojek.eu>
Subject: Re: [PATCH v2 2/3] mtd: maps: vmu-flash: fix fault in unaligned fixup
Date: Mon, 27 Apr 2026 14:34:35 +0200	[thread overview]
Message-ID: <874ikwintw.fsf@bootlin.com> (raw)
In-Reply-To: <20260427114750.2480900-3-fuchsfl@gmail.com> (Florian Fuchs's message of "Mon, 27 Apr 2026 13:47:49 +0200")

On 27/04/2026 at 13:47:49 +02, Florian Fuchs <fuchsfl@gmail.com> wrote:

> Use kzalloc_obj() / kzalloc_objs() to allocate the memcard structs,
> instead of kmalloc_obj() / kmalloc_objs() to prevent access to
> uninitialized data.
>
> Fixes runtime error: Fault in unaligned fixup: 0000 [#1] at
> mtd_get_fact_prot_info.

Shall this patch receive a Fixes tag if it actually fixes runtime
behaviour?

Also, please add the 'Cc: stable' line in your fixes.

Thanks,
Miquèl

  reply	other threads:[~2026-04-27 12:34 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-27 11:47 [PATCH v2 0/3] mtd: maps: vmu-flash: Fix build and runtime errors Florian Fuchs
2026-04-27 11:47 ` Florian Fuchs
2026-04-27 11:47 ` [PATCH v2 1/3] mtd: maps: vmu-flash: fix build error due to missing include of linux/device.h Florian Fuchs
2026-04-27 11:47   ` Florian Fuchs
2026-04-27 11:47 ` [PATCH v2 2/3] mtd: maps: vmu-flash: fix fault in unaligned fixup Florian Fuchs
2026-04-27 11:47   ` Florian Fuchs
2026-04-27 12:34   ` Miquel Raynal [this message]
2026-04-27 12:34     ` Miquel Raynal
2026-04-27 11:47 ` [PATCH v2 3/3] mtd: maps: vmu-flash: Fix NULL pointer dereference in initialization Florian Fuchs
2026-04-27 11:47   ` Florian Fuchs
2026-04-27 12:35   ` Miquel Raynal
2026-04-27 12:35     ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874ikwintw.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=contact@artur-rojek.eu \
    --cc=dalias@libc.org \
    --cc=fuchsfl@gmail.com \
    --cc=glaubitz@physik.fu-berlin.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.