All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Richard Weinberger <richard@nod.at>,
	 Vignesh Raghavendra <vigneshr@ti.com>,
	 linux-mtd@lists.infradead.org,  stable@vger.kernel.org
Subject: Re: [PATCH] mtd: rawnand: fsmc: Default to autodetect buswidth
Date: Thu, 18 Sep 2025 10:00:06 +0200	[thread overview]
Message-ID: <874it02nsp.fsf@bootlin.com> (raw)
In-Reply-To: <CACRpkdb-BxHb_xiyLf8Gx8PNTQ5nZEd8geJwb+PH+pd+SKpubQ@mail.gmail.com> (Linus Walleij's message of "Tue, 16 Sep 2025 20:49:25 +0200")

On 16/09/2025 at 20:49:25 +02, Linus Walleij <linus.walleij@linaro.org> wrote:

> On Tue, Sep 16, 2025 at 11:33 AM Miquel Raynal
> <miquel.raynal@bootlin.com> wrote:
>> On 14/09/2025 at 00:35:37 +02, Linus Walleij <linus.walleij@linaro.org> wrote:
>
>> > I don't know where or how this happened, I think some change
>> > in the nand core.
>>
>> I had a look and honnestly could not find where we broke this. Could it
>> be possible that it never worked with DT probing and only with platform
>> data? Any idea of what was the previously working base?
>
> I tested old kernels back to 4.20 and it didn't work.
> Probably it never worked?

Ah :-) Might make sense!

> I tried to recompile something further back but I don't
> have the required old toolchains around :P

Yeah, no pb. As you said, we probably never faced the issue even though
it was latent.

>> Anyhow, this is just curiosity, patch is relevant (just a little nit
>> below?).
>> > +             };
>>
>>                  ^
>> There is a spurious ';' here, no?
>
> Fixed in v2, also made a more elaborate handling if someone
> would explicitly set the width to 2.
>
> I think the SPEAr that is the primary user always sets the width
> to 2 so they never saw this bug.

Certainly.

Thanks!
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Richard Weinberger <richard@nod.at>,
	 Vignesh Raghavendra <vigneshr@ti.com>,
	 linux-mtd@lists.infradead.org,  stable@vger.kernel.org
Subject: Re: [PATCH] mtd: rawnand: fsmc: Default to autodetect buswidth
Date: Thu, 18 Sep 2025 10:00:06 +0200	[thread overview]
Message-ID: <874it02nsp.fsf@bootlin.com> (raw)
In-Reply-To: <CACRpkdb-BxHb_xiyLf8Gx8PNTQ5nZEd8geJwb+PH+pd+SKpubQ@mail.gmail.com> (Linus Walleij's message of "Tue, 16 Sep 2025 20:49:25 +0200")

On 16/09/2025 at 20:49:25 +02, Linus Walleij <linus.walleij@linaro.org> wrote:

> On Tue, Sep 16, 2025 at 11:33 AM Miquel Raynal
> <miquel.raynal@bootlin.com> wrote:
>> On 14/09/2025 at 00:35:37 +02, Linus Walleij <linus.walleij@linaro.org> wrote:
>
>> > I don't know where or how this happened, I think some change
>> > in the nand core.
>>
>> I had a look and honnestly could not find where we broke this. Could it
>> be possible that it never worked with DT probing and only with platform
>> data? Any idea of what was the previously working base?
>
> I tested old kernels back to 4.20 and it didn't work.
> Probably it never worked?

Ah :-) Might make sense!

> I tried to recompile something further back but I don't
> have the required old toolchains around :P

Yeah, no pb. As you said, we probably never faced the issue even though
it was latent.

>> Anyhow, this is just curiosity, patch is relevant (just a little nit
>> below?).
>> > +             };
>>
>>                  ^
>> There is a spurious ';' here, no?
>
> Fixed in v2, also made a more elaborate handling if someone
> would explicitly set the width to 2.
>
> I think the SPEAr that is the primary user always sets the width
> to 2 so they never saw this bug.

Certainly.

Thanks!
Miquèl

  reply	other threads:[~2025-09-18  8:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-13 22:35 [PATCH] mtd: rawnand: fsmc: Default to autodetect buswidth Linus Walleij
2025-09-13 22:35 ` Linus Walleij
2025-09-16  9:32 ` Miquel Raynal
2025-09-16  9:32   ` Miquel Raynal
2025-09-16 18:49   ` Linus Walleij
2025-09-16 18:49     ` Linus Walleij
2025-09-18  8:00     ` Miquel Raynal [this message]
2025-09-18  8:00       ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874it02nsp.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=richard@nod.at \
    --cc=stable@vger.kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.