Re: [SPAM] [PATCH v4 4/5] hw/misc/aspeed_otp: Add 'drive' property to support block backend

["Alex Bennée" <alex.bennee@linaro.org>]

Cédric Le Goater <clg@kaod.org> writes:

> On 7/8/25 07:57, Kane Chen wrote:
>> From: Kane-Chen-AS <kane_chen@aspeedtech.com>
>> This patch introduces a 'drive' property to the Aspeed OTP device,
>> allowing it to be backed by a block device. Users can now preload
>> OTP data via QEMU CLI using a block backend.
>> Example usage:
>>    ./qemu-system-arm \
>>      -blockdev driver=file,filename=otpmem.img,node-name=otp \
>>      -global aspeed-otp.drive=otp \
>>      ...
>> If the drive is provided, its content will be loaded as the initial
>> OTP state.
>> Otherwise, an internal memory buffer will be used.
>> Signed-off-by: Kane-Chen-AS <kane_chen@aspeedtech.com>
>
>
> Reviewed-by: Cédric Le Goater <clg@redhat.com>

Erm where is this email getting tagged as SPAM? The headers seem to
indicate its clear:

  X-Spam_score_int: -39
  X-Spam_score: -4.0
  X-Spam_bar: ----
  X-Spam_report: (-4.0 / 5.0 requ) BAYES_00=-1.9,
   HEADER_FROM_DIFFERENT_DOMAINS=0.157, RCVD_IN_DNSWL_MED=-2.3,
   SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
  X-Spam_action: no action
  X-BeenThere: qemu-arm@nongnu.org
  X-Mailman-Version: 2.1.29


>
> Thanks,
>
> C.
>
>
>> ---
>>   hw/nvram/aspeed_otp.c | 16 +++++++++++++++-
>>   1 file changed, 15 insertions(+), 1 deletion(-)
>> diff --git a/hw/nvram/aspeed_otp.c b/hw/nvram/aspeed_otp.c
>> index e41481d9bb..f018c58713 100644
>> --- a/hw/nvram/aspeed_otp.c
>> +++ b/hw/nvram/aspeed_otp.c
>> @@ -9,6 +9,7 @@
>>   #include "qemu/osdep.h"
>>   #include "qemu/log.h"
>>   #include "qapi/error.h"
>> +#include "system/block-backend-global-state.h"
>>   #include "system/block-backend-io.h"
>>   #include "hw/qdev-properties.h"
>>   #include "hw/nvram/aspeed_otp.h"
>> @@ -35,13 +36,25 @@ static bool aspeed_otp_init_storage(AspeedOTPState *s, Error **errp)
>>   {
>>       uint32_t *p;
>>       int i, num;
>> +    uint64_t perm;
>>   +    if (s->blk) {
>> +        perm = BLK_PERM_CONSISTENT_READ |
>> +               (blk_supports_write_perm(s->blk) ? BLK_PERM_WRITE : 0);
>> +        if (blk_set_perm(s->blk, perm, BLK_PERM_ALL, errp) < 0) {
>> +            return false;
>> +        }
>> +        if (blk_pread(s->blk, 0, s->size, s->storage, 0) < 0) {
>> +            error_setg(errp, "Failed to read the initial flash content");
>> +            return false;
>> +        }
>> +    } else {
>>           num = s->size / sizeof(uint32_t);
>>           p = (uint32_t *)s->storage;
>>           for (i = 0; i < num; i++) {
>>               p[i] = (i % 2 == 0) ? 0x00000000 : 0xFFFFFFFF;
>>           }
>> -
>> +    }
>>       return true;
>>   }
>>   @@ -75,6 +88,7 @@ static void aspeed_otp_realize(DeviceState *dev,
>> Error **errp)
>>     static const Property aspeed_otp_properties[] = {
>>       DEFINE_PROP_UINT64("size", AspeedOTPState, size, 0),
>> +    DEFINE_PROP_DRIVE("drive", AspeedOTPState, blk),
>>   };
>>     static void aspeed_otp_class_init(ObjectClass *klass, const void
>> *data)

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro