From: Thomas Gleixner <tglx@linutronix.de>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: Biju Das <biju.das.jz@bp.renesas.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Biju Das <biju.das.au@gmail.com>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 06/11] irqchip/renesas-rzv2h: Add max_tssel variable to struct rzv2h_hw_info
Date: Thu, 23 Jan 2025 11:54:00 +0100 [thread overview]
Message-ID: <874j1pajhz.ffs@tglx> (raw)
In-Reply-To: <20250120094715.25802-7-biju.das.jz@bp.renesas.com>
On Mon, Jan 20 2025 at 09:47, Biju Das wrote:
> /**
> * struct rzv2h_hw_info - Interrupt Control Unit controller hardware info structure.
> * @t_offs: TINT offset
> + * @max_tssel: TSSEL max value
> */
> struct rzv2h_hw_info {
> u16 t_offs;
> + u8 max_tssel;
Both the kernel doc and the actual struct members want to be done in
tabular fashion.
https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#struct-declarations-and-initializers
> };
>
> /**
> @@ -298,13 +299,12 @@ static int rzv2h_tint_set_type(struct irq_data *d, unsigned int type)
> return -EINVAL;
> }
>
> + priv = irq_data_to_priv(d);
> tint = (u32)(uintptr_t)irq_data_get_irq_chip_data(d);
> - if (tint > ICU_PB5_TINT)
> + if (tint > priv->info->max_tssel)
> return -EINVAL;
>
> - priv = irq_data_to_priv(d);
> hwirq = irqd_to_hwirq(d);
> -
> tint_nr = hwirq - ICU_TINT_START;
>
> tssr_k = ICU_TSSR_K(tint_nr);
> @@ -514,6 +514,7 @@ static int rzv2h_icu_init_common(struct device_node *node, struct device_node *p
>
> static const struct rzv2h_hw_info rzv2h_hw_params = {
> .t_offs = 0,
> + .max_tssel = 0x55,
See documentation.
Thanks,
tglx
next prev parent reply other threads:[~2025-01-23 10:54 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-20 9:46 [PATCH 00/11] Add Support for RZ/G3E ICU Biju Das
2025-01-20 9:46 ` [PATCH 01/11] dt-bindings: interrupt-controller: renesas,rzv2h-icu: Document RZ/G3E SoC Biju Das
2025-01-23 9:41 ` Fabrizio Castro
2025-01-23 22:53 ` Rob Herring (Arm)
2025-01-20 9:46 ` [PATCH 02/11] clk: renesas: r9a09g047: Add ICU clock/reset Biju Das
2025-01-23 9:48 ` Fabrizio Castro
2025-01-20 9:46 ` [PATCH 03/11] irqchip/renesas-rzv2h: Drop irqchip from struct rzv2h_icu_priv Biju Das
2025-01-22 10:24 ` Fabrizio Castro
2025-01-20 9:47 ` [PATCH 04/11] irqchip/renesas-rzv2h: Simplify rzv2h_icu_init() Biju Das
2025-01-20 10:04 ` Philipp Zabel
2025-01-20 10:18 ` Biju Das
2025-01-20 9:47 ` [PATCH 05/11] irqchip/renesas-rzv2h: Add struct rzv2h_hw_info with t_offs variable Biju Das
2025-01-22 10:17 ` Fabrizio Castro
2025-01-20 9:47 ` [PATCH 06/11] irqchip/renesas-rzv2h: Add max_tssel variable to struct rzv2h_hw_info Biju Das
2025-01-22 10:19 ` Fabrizio Castro
2025-01-23 10:54 ` Thomas Gleixner [this message]
2025-01-23 11:08 ` Biju Das
2025-01-20 9:47 ` [PATCH 07/11] irqchip/renesas-rzv2h: Add tssr_k " Biju Das
2025-01-22 10:20 ` Fabrizio Castro
2025-01-20 9:47 ` [PATCH 08/11] irqchip/renesas-rzv2h: Add tssel_mask and tssel_shift variables " Biju Das
2025-01-23 9:43 ` Fabrizio Castro
2025-01-20 9:47 ` [PATCH 09/11] irqchip/renesas-rzv2h: Add tien variable " Biju Das
2025-01-23 9:44 ` Fabrizio Castro
2025-01-20 9:47 ` [PATCH 10/11] irqchip/renesas-rzv2h: Add RZ/G3E support Biju Das
2025-01-23 9:45 ` Fabrizio Castro
2025-01-20 9:47 ` [PATCH 11/11] arm64: dts: renesas: r9a09g047: Add icu node Biju Das
2025-01-23 9:47 ` Fabrizio Castro
2025-01-21 17:32 ` [PATCH 00/11] Add Support for RZ/G3E ICU Tommaso Merciai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874j1pajhz.ffs@tglx \
--to=tglx@linutronix.de \
--cc=biju.das.au@gmail.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=geert+renesas@glider.be \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.