From: Thomas Gleixner <tglx@linutronix.de>
To: David Laight <David.Laight@ACULAB.COM>,
Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Easwar Hariharan <eahariha@linux.microsoft.com>,
"K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
Anna-Maria Behnsen <anna-maria@linutronix.de>,
Marcel Holtmann <marcel@holtmann.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
"linux-bluetooth@vger.kernel.org"
<linux-bluetooth@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Michael Kelley <mhklinux@outlook.com>
Subject: RE: [PATCH v2 1/2] jiffies: Define secs_to_jiffies()
Date: Thu, 07 Nov 2024 00:55:05 +0100 [thread overview]
Message-ID: <874j4jq5nq.ffs@tglx> (raw)
In-Reply-To: <6acb24504a454638848dd9adff7cb5dc@AcuMS.aculab.com>
On Wed, Nov 06 2024 at 22:19, David Laight wrote:
> From: Thomas Gleixner
>> Still the macro should be documented.
>
> I was wondering if it really had any purpose at all.
> It just obfuscates code, doesn't even make it smaller.
What is obfuscated here?
secs_to_jiffies() is clearly describing what this is about, while 5 * HZ
is not. Nothing in a driver has to care about the underlying conversion
of a time delta expressed in SI units to a jiffies based time delta.
Thanks,
tglx
next prev parent reply other threads:[~2024-11-06 23:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-28 19:11 [PATCH v2 0/2] Converge on secs_to_jiffies() Easwar Hariharan
2024-10-28 19:11 ` [PATCH v2 1/2] jiffies: Define secs_to_jiffies() Easwar Hariharan
2024-10-28 19:25 ` Luiz Augusto von Dentz
2024-10-29 16:08 ` Thomas Gleixner
2024-10-29 16:22 ` Geert Uytterhoeven
2024-10-29 17:25 ` Thomas Gleixner
2024-10-29 21:35 ` Easwar Hariharan
2024-11-06 22:19 ` David Laight
2024-11-06 23:55 ` Thomas Gleixner [this message]
2024-10-28 19:11 ` [PATCH v2 2/2] drivers: hv: Convert open-coded timeouts to secs_to_jiffies() Easwar Hariharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874j4jq5nq.ffs@tglx \
--to=tglx@linutronix.de \
--cc=David.Laight@ACULAB.COM \
--cc=anna-maria@linutronix.de \
--cc=decui@microsoft.com \
--cc=eahariha@linux.microsoft.com \
--cc=geert@linux-m68k.org \
--cc=haiyangz@microsoft.com \
--cc=johan.hedberg@gmail.com \
--cc=kys@microsoft.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=mhklinux@outlook.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.