All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Easwar Hariharan <eahariha@linux.microsoft.com>,
	"K. Y. Srinivasan" <kys@microsoft.com>,
	Haiyang Zhang <haiyangz@microsoft.com>,
	Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
	linux-hyperv@vger.kernel.org,
	Anna-Maria Behnsen <anna-maria@linutronix.de>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Marcel Holtmann <marcel@holtmann.org>,
	Johan Hedberg <johan.hedberg@gmail.com>,
	Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
	linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Michael Kelley <mhklinux@outlook.com>,
	Easwar Hariharan <eahariha@linux.microsoft.com>
Subject: Re: [PATCH v2 1/2] jiffies: Define secs_to_jiffies()
Date: Tue, 29 Oct 2024 17:08:57 +0100	[thread overview]
Message-ID: <87wmhq28o6.ffs@tglx> (raw)
In-Reply-To: <20241028-open-coded-timeouts-v2-1-c7294bb845a1@linux.microsoft.com>

On Mon, Oct 28 2024 at 19:11, Easwar Hariharan wrote:
> diff --git a/include/linux/jiffies.h b/include/linux/jiffies.h
> index 1220f0fbe5bf..e5256bb5f851 100644
> --- a/include/linux/jiffies.h
> +++ b/include/linux/jiffies.h
> @@ -526,6 +526,8 @@ static __always_inline unsigned long msecs_to_jiffies(const unsigned int m)
>  	}
>  }
>  
> +#define secs_to_jiffies(_secs) ((_secs) * HZ)

Can you please make that a static inline, as there is no need for macro
magic like in the other conversions, and add a kernel doc comment which
documents this?

Thanks,

        tglx

  parent reply	other threads:[~2024-10-29 16:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-28 19:11 [PATCH v2 0/2] Converge on secs_to_jiffies() Easwar Hariharan
2024-10-28 19:11 ` [PATCH v2 1/2] jiffies: Define secs_to_jiffies() Easwar Hariharan
2024-10-28 19:25   ` Luiz Augusto von Dentz
2024-10-29 16:08   ` Thomas Gleixner [this message]
2024-10-29 16:22     ` Geert Uytterhoeven
2024-10-29 17:25       ` Thomas Gleixner
2024-10-29 21:35         ` Easwar Hariharan
2024-11-06 22:19         ` David Laight
2024-11-06 23:55           ` Thomas Gleixner
2024-10-28 19:11 ` [PATCH v2 2/2] drivers: hv: Convert open-coded timeouts to secs_to_jiffies() Easwar Hariharan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wmhq28o6.ffs@tglx \
    --to=tglx@linutronix.de \
    --cc=anna-maria@linutronix.de \
    --cc=decui@microsoft.com \
    --cc=eahariha@linux.microsoft.com \
    --cc=geert@linux-m68k.org \
    --cc=haiyangz@microsoft.com \
    --cc=johan.hedberg@gmail.com \
    --cc=kys@microsoft.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    --cc=marcel@holtmann.org \
    --cc=mhklinux@outlook.com \
    --cc=wei.liu@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.