All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman.id.au>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
	Abaci Robot <abaci@linux.alibaba.com>,
	linux-kernel@vger.kernel.org, npiggin@gmail.com,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc: Use ARRAY_SIZE for array length
Date: Thu, 23 Nov 2023 11:26:31 +1100	[thread overview]
Message-ID: <874jhds4aw.fsf@mail.lhotse> (raw)
In-Reply-To: <20231122090312.114679-1-jiapeng.chong@linux.alibaba.com>

Jiapeng Chong <jiapeng.chong@linux.alibaba.com> writes:
> Use of macro ARRAY_SIZE to calculate array size minimizes
> the redundant code and improves code reusability.
>
> ./arch/powerpc/xmon/ppc-opc.c:957:67-68: WARNING: Use ARRAY_SIZE.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7612
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>  arch/powerpc/xmon/ppc-opc.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

This code is copied from binutils, we don't take cleanup patches to it.

See also the at least three times this has already been submitted :)

https://lore.kernel.org/all/4ed43222-17b0-8355-f836-adabb453e432@csgroup.eu/
https://lore.kernel.org/linuxppc-dev/20181004171036.GA1907@embeddedor.com/
https://lore.kernel.org/linuxppc-dev/874lfxjnzl.fsf@concordia.ellerman.id.au/

cheers

WARNING: multiple messages have this Message-ID (diff)
From: Michael Ellerman <mpe@ellerman.id.au>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: npiggin@gmail.com, christophe.leroy@csgroup.eu,
	linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
	Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] powerpc: Use ARRAY_SIZE for array length
Date: Thu, 23 Nov 2023 11:26:31 +1100	[thread overview]
Message-ID: <874jhds4aw.fsf@mail.lhotse> (raw)
In-Reply-To: <20231122090312.114679-1-jiapeng.chong@linux.alibaba.com>

Jiapeng Chong <jiapeng.chong@linux.alibaba.com> writes:
> Use of macro ARRAY_SIZE to calculate array size minimizes
> the redundant code and improves code reusability.
>
> ./arch/powerpc/xmon/ppc-opc.c:957:67-68: WARNING: Use ARRAY_SIZE.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7612
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>  arch/powerpc/xmon/ppc-opc.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

This code is copied from binutils, we don't take cleanup patches to it.

See also the at least three times this has already been submitted :)

https://lore.kernel.org/all/4ed43222-17b0-8355-f836-adabb453e432@csgroup.eu/
https://lore.kernel.org/linuxppc-dev/20181004171036.GA1907@embeddedor.com/
https://lore.kernel.org/linuxppc-dev/874lfxjnzl.fsf@concordia.ellerman.id.au/

cheers

  reply	other threads:[~2023-11-23  0:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-22  9:03 [PATCH] powerpc: Use ARRAY_SIZE for array length Jiapeng Chong
2023-11-22  9:03 ` Jiapeng Chong
2023-11-23  0:26 ` Michael Ellerman [this message]
2023-11-23  0:26   ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874jhds4aw.fsf@mail.lhotse \
    --to=mpe@ellerman.id.au \
    --cc=abaci@linux.alibaba.com \
    --cc=jiapeng.chong@linux.alibaba.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=npiggin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.