[PATCH] xenstored: print domain id in traces

[PATCH] xenstored: print domain id in traces

[Volodymyr Babchuk]

It is very helpful to see domain id why analyzing xenstored
traces. Especially when you are trying to understand which exactly
domain performs an action.

Signed-off-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>
---
 tools/xenstored/core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/xenstored/core.c b/tools/xenstored/core.c
index edd07711db..311764eb0c 100644
--- a/tools/xenstored/core.c
+++ b/tools/xenstored/core.c
@@ -135,8 +135,8 @@ static void trace_io(const struct connection *conn,
 	now = time(NULL);
 	tm = localtime(&now);
 
-	trace("io: %s %p %04d%02d%02d %02d:%02d:%02d %s (",
-	      out ? "OUT" : "IN", conn,
+	trace("io: %s %p (d%d) %04d%02d%02d %02d:%02d:%02d %s (",
+	      out ? "OUT" : "IN", conn, conn->id,
 	      tm->tm_year + 1900, tm->tm_mon + 1,
 	      tm->tm_mday, tm->tm_hour, tm->tm_min, tm->tm_sec,
 	      sockmsg_string(data->hdr.msg.type));
-- 
2.42.0

Re: [PATCH] xenstored: print domain id in traces

[Juergen Gross]

[-- Attachment #1.1.1: Type: text/plain, Size: 340 bytes --]

On 16.11.23 21:56, Volodymyr Babchuk wrote:
> It is very helpful to see domain id why analyzing xenstored
> traces. Especially when you are trying to understand which exactly
> domain performs an action.
> 
> Signed-off-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen


[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3743 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]

Re: [PATCH] xenstored: print domain id in traces

[Julien Grall]

Hi Volodymyr,

On 16/11/2023 20:56, Volodymyr Babchuk wrote:
> It is very helpful to see domain id why analyzing xenstored
> traces. Especially when you are trying to understand which exactly
> domain performs an action.
> 
> Signed-off-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>
> ---
>   tools/xenstored/core.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/xenstored/core.c b/tools/xenstored/core.c
> index edd07711db..311764eb0c 100644
> --- a/tools/xenstored/core.c
> +++ b/tools/xenstored/core.c
> @@ -135,8 +135,8 @@ static void trace_io(const struct connection *conn,
>   	now = time(NULL);
>   	tm = localtime(&now);
>   
> -	trace("io: %s %p %04d%02d%02d %02d:%02d:%02d %s (",
> -	      out ? "OUT" : "IN", conn,
> +	trace("io: %s %p (d%d) %04d%02d%02d %02d:%02d:%02d %s (",

AFAICT conn->id is an unsigned int. So it should be d%u. This can be 
dealt on commit.

Cheers,

-- 
Julien Grall

Re: [PATCH] xenstored: print domain id in traces

[Volodymyr Babchuk]

Hi Julien,

Julien Grall <julien@xen.org> writes:

> Hi Volodymyr,
>
> On 16/11/2023 20:56, Volodymyr Babchuk wrote:
>> It is very helpful to see domain id why analyzing xenstored
>> traces. Especially when you are trying to understand which exactly
>> domain performs an action.
>> Signed-off-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>
>> ---
>>   tools/xenstored/core.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>> diff --git a/tools/xenstored/core.c b/tools/xenstored/core.c
>> index edd07711db..311764eb0c 100644
>> --- a/tools/xenstored/core.c
>> +++ b/tools/xenstored/core.c
>> @@ -135,8 +135,8 @@ static void trace_io(const struct connection *conn,
>>   	now = time(NULL);
>>   	tm = localtime(&now);
>>   -	trace("io: %s %p %04d%02d%02d %02d:%02d:%02d %s (",
>> -	      out ? "OUT" : "IN", conn,
>> +	trace("io: %s %p (d%d) %04d%02d%02d %02d:%02d:%02d %s (",
>
> AFAICT conn->id is an unsigned int. So it should be d%u. This can be
> dealt on commit.
>

Yes, I missed this part. I have noticed that you already committed this
change and even mentioned %u in the commit message. But in the diff [1] I am
seeing %d. Should I sent another another patch that fixes this?

[1] https://xenbits.xen.org/gitweb/?p=xen.git;a=commitdiff;h=97f8555acbf3da013ed713ca0bbe739d41c48da9

-- 
WBR, Volodymyr

Re: [PATCH] xenstored: print domain id in traces

[Julien Grall]

Hi Volodymyr,

On 20/11/2023 12:28, Volodymyr Babchuk wrote:
> Julien Grall <julien@xen.org> writes:
> 
>> Hi Volodymyr,
>>
>> On 16/11/2023 20:56, Volodymyr Babchuk wrote:
>>> It is very helpful to see domain id why analyzing xenstored
>>> traces. Especially when you are trying to understand which exactly
>>> domain performs an action.
>>> Signed-off-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>
>>> ---
>>>    tools/xenstored/core.c | 4 ++--
>>>    1 file changed, 2 insertions(+), 2 deletions(-)
>>> diff --git a/tools/xenstored/core.c b/tools/xenstored/core.c
>>> index edd07711db..311764eb0c 100644
>>> --- a/tools/xenstored/core.c
>>> +++ b/tools/xenstored/core.c
>>> @@ -135,8 +135,8 @@ static void trace_io(const struct connection *conn,
>>>    	now = time(NULL);
>>>    	tm = localtime(&now);
>>>    -	trace("io: %s %p %04d%02d%02d %02d:%02d:%02d %s (",
>>> -	      out ? "OUT" : "IN", conn,
>>> +	trace("io: %s %p (d%d) %04d%02d%02d %02d:%02d:%02d %s (",
>>
>> AFAICT conn->id is an unsigned int. So it should be d%u. This can be
>> dealt on commit.
>>
> 
> Yes, I missed this part. I have noticed that you already committed this
> change and even mentioned %u in the commit message. But in the diff [1] I am
> seeing %d. Should I sent another another patch that fixes this?

:(. I keep forgetting that "git commit --amend" only ammend the commit 
message. If you don't mind, can you send a follow-up?

Sorry for the inconvenience.

Cheers,

-- 
Julien Grall