All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@kernel.org>
To: Atul Raut <rauji.raut@gmail.com>
Cc: linux-kernel-mentees@lists.linuxfoundation.org,
	aspriel@gmail.com, linux-wireless@vger.kernel.org,
	brcm80211-dev-list.pdl@broadcom.com, franky.lin@broadcom.com
Subject: Re: [PATCH v2] brcmfmac: replace one-element array with flexible-array member
Date: Thu, 03 Aug 2023 09:05:35 +0300	[thread overview]
Message-ID: <874jlgvexc.fsf@kernel.org> (raw)
In-Reply-To: <20230803052238.12147-2-rauji.raut@gmail.com> (Atul Raut's message of "Wed, 2 Aug 2023 22:22:38 -0700")

Atul Raut <rauji.raut@gmail.com> writes:

> One-element arrays are obsolete, and flexible
> array members have taken their place. So, in
> struct cca_stats_n_flags, replace the one-element
> array with a flexible-array member.
>
> This fixes warnings such as:
> ./drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:119:6-9:
> WARNING use flexible-array member instead
> (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)
>
> Signed-off-by: Atul Raut <rauji.raut@gmail.com>

I have now three patches from you in queue:

https://patchwork.kernel.org/project/linux-wireless/patch/20230731011635.20993-1-rauji.raut@gmail.com/

https://patchwork.kernel.org/project/linux-wireless/patch/20230803052238.12147-1-rauji.raut@gmail.com/

https://patchwork.kernel.org/project/linux-wireless/patch/20230803052238.12147-2-rauji.raut@gmail.com/

v1 submitted twice and v2 without any change log. Please read the
documentation from our wiki link below how to submit patches.

Also I would like to have a review from someone else before I consider
taking this.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@kernel.org>
To: Atul Raut <rauji.raut@gmail.com>
Cc: aspriel@gmail.com, franky.lin@broadcom.com,
	linux-wireless@vger.kernel.org,
	brcm80211-dev-list.pdl@broadcom.com,
	linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH v2] brcmfmac: replace one-element array with flexible-array member
Date: Thu, 03 Aug 2023 09:05:35 +0300	[thread overview]
Message-ID: <874jlgvexc.fsf@kernel.org> (raw)
In-Reply-To: <20230803052238.12147-2-rauji.raut@gmail.com> (Atul Raut's message of "Wed, 2 Aug 2023 22:22:38 -0700")

Atul Raut <rauji.raut@gmail.com> writes:

> One-element arrays are obsolete, and flexible
> array members have taken their place. So, in
> struct cca_stats_n_flags, replace the one-element
> array with a flexible-array member.
>
> This fixes warnings such as:
> ./drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:119:6-9:
> WARNING use flexible-array member instead
> (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)
>
> Signed-off-by: Atul Raut <rauji.raut@gmail.com>

I have now three patches from you in queue:

https://patchwork.kernel.org/project/linux-wireless/patch/20230731011635.20993-1-rauji.raut@gmail.com/

https://patchwork.kernel.org/project/linux-wireless/patch/20230803052238.12147-1-rauji.raut@gmail.com/

https://patchwork.kernel.org/project/linux-wireless/patch/20230803052238.12147-2-rauji.raut@gmail.com/

v1 submitted twice and v2 without any change log. Please read the
documentation from our wiki link below how to submit patches.

Also I would like to have a review from someone else before I consider
taking this.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

  reply	other threads:[~2023-08-03  6:05 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-03  5:22 [PATCH] brcmfmac: Replace zero-length arrays with DECLARE_FLEX_ARRAY() helper Atul Raut
2023-08-03  5:22 ` Atul Raut
2023-08-03  5:22 ` [PATCH v2] brcmfmac: replace one-element array with flexible-array member Atul Raut
2023-08-03  5:22   ` Atul Raut
2023-08-03  6:05   ` Kalle Valo [this message]
2023-08-03  6:05     ` Kalle Valo
2024-01-18 11:25   ` Kalle Valo
2024-01-18 13:53   ` Arend van Spriel
2024-01-18 20:19     ` Kees Cook
2024-01-19  6:35       ` Arend Van Spriel
2024-01-19 13:00       ` Lukas Bulwahn
2024-01-27  5:19         ` Atul Raut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874jlgvexc.fsf@kernel.org \
    --to=kvalo@kernel.org \
    --cc=aspriel@gmail.com \
    --cc=brcm80211-dev-list.pdl@broadcom.com \
    --cc=franky.lin@broadcom.com \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=rauji.raut@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.