From: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
To: linux-mm@kvack.org, akpm@linux-foundation.org,
mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org,
npiggin@gmail.com, christophe.leroy@csgroup.eu
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Muchun Song <muchun.song@linux.dev>,
Dan Williams <dan.j.williams@intel.com>,
Oscar Salvador <osalvador@suse.de>, Will Deacon <will@kernel.org>,
Joao Martins <joao.m.martins@oracle.com>,
Mike Kravetz <mike.kravetz@oracle.com>
Subject: [PATCH v6 12/13 -fix] powerpc/book3s64/radix: Remove mmu_vmemmap_psize
Date: Fri, 28 Jul 2023 15:53:31 +0530 [thread overview]
Message-ID: <874jlowd0c.fsf@linux.ibm.com> (raw)
In-Reply-To: <20230724190759.483013-13-aneesh.kumar@linux.ibm.com>
From 2d37f0570983bfa710e73a6485e178658e8f4b38 Mon Sep 17 00:00:00 2001
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
Date: Fri, 28 Jul 2023 14:47:46 +0530
Subject: [PATCH] powerpc/mm: Fix kernel build error
arch/powerpc/mm/init_64.c:201:15: error: no previous prototype for function '__vmemmap_populate' [-Werror,-Wmissing-prototypes]
int __meminit __vmemmap_populate(unsigned long start, unsigned long end, int node,
^
arch/powerpc/mm/init_64.c:201:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int __meminit __vmemmap_populate(unsigned long start, unsigned long end, int node,
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202307281617.OxcXz84j-lkp@intel.com/
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
---
arch/powerpc/mm/init_64.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/mm/init_64.c b/arch/powerpc/mm/init_64.c
index 8d184e89e943..e0208cb12058 100644
--- a/arch/powerpc/mm/init_64.c
+++ b/arch/powerpc/mm/init_64.c
@@ -198,8 +198,8 @@ bool altmap_cross_boundary(struct vmem_altmap *altmap, unsigned long start,
return false;
}
-int __meminit __vmemmap_populate(unsigned long start, unsigned long end, int node,
- struct vmem_altmap *altmap)
+static int __meminit __vmemmap_populate(unsigned long start, unsigned long end, int node,
+ struct vmem_altmap *altmap)
{
bool altmap_alloc;
unsigned long page_size = 1 << mmu_psize_defs[mmu_vmemmap_psize].shift;
--
2.41.0
WARNING: multiple messages have this Message-ID (diff)
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
To: linux-mm@kvack.org, akpm@linux-foundation.org,
mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org,
npiggin@gmail.com, christophe.leroy@csgroup.eu
Cc: Oscar Salvador <osalvador@suse.de>,
Mike Kravetz <mike.kravetz@oracle.com>,
Dan Williams <dan.j.williams@intel.com>,
Joao Martins <joao.m.martins@oracle.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Muchun Song <muchun.song@linux.dev>,
Will Deacon <will@kernel.org>
Subject: [PATCH v6 12/13 -fix] powerpc/book3s64/radix: Remove mmu_vmemmap_psize
Date: Fri, 28 Jul 2023 15:53:31 +0530 [thread overview]
Message-ID: <874jlowd0c.fsf@linux.ibm.com> (raw)
In-Reply-To: <20230724190759.483013-13-aneesh.kumar@linux.ibm.com>
From 2d37f0570983bfa710e73a6485e178658e8f4b38 Mon Sep 17 00:00:00 2001
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
Date: Fri, 28 Jul 2023 14:47:46 +0530
Subject: [PATCH] powerpc/mm: Fix kernel build error
arch/powerpc/mm/init_64.c:201:15: error: no previous prototype for function '__vmemmap_populate' [-Werror,-Wmissing-prototypes]
int __meminit __vmemmap_populate(unsigned long start, unsigned long end, int node,
^
arch/powerpc/mm/init_64.c:201:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int __meminit __vmemmap_populate(unsigned long start, unsigned long end, int node,
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202307281617.OxcXz84j-lkp@intel.com/
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
---
arch/powerpc/mm/init_64.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/mm/init_64.c b/arch/powerpc/mm/init_64.c
index 8d184e89e943..e0208cb12058 100644
--- a/arch/powerpc/mm/init_64.c
+++ b/arch/powerpc/mm/init_64.c
@@ -198,8 +198,8 @@ bool altmap_cross_boundary(struct vmem_altmap *altmap, unsigned long start,
return false;
}
-int __meminit __vmemmap_populate(unsigned long start, unsigned long end, int node,
- struct vmem_altmap *altmap)
+static int __meminit __vmemmap_populate(unsigned long start, unsigned long end, int node,
+ struct vmem_altmap *altmap)
{
bool altmap_alloc;
unsigned long page_size = 1 << mmu_psize_defs[mmu_vmemmap_psize].shift;
--
2.41.0
next prev parent reply other threads:[~2023-07-28 10:24 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-24 19:07 [PATCH v6 00/13] Add support for DAX vmemmap optimization for ppc64 Aneesh Kumar K.V
2023-07-24 19:07 ` Aneesh Kumar K.V
2023-07-24 19:07 ` [PATCH v6 01/13] mm/hugepage pud: Allow arch-specific helper function to check huge page pud support Aneesh Kumar K.V
2023-07-24 19:07 ` Aneesh Kumar K.V
2023-07-26 10:52 ` [PATCH v6 01/13 -fix] " Aneesh Kumar K.V
2023-07-26 10:52 ` Aneesh Kumar K.V
2023-07-24 19:07 ` [PATCH v6 02/13] mm: Change pudp_huge_get_and_clear_full take vm_area_struct as arg Aneesh Kumar K.V
2023-07-24 19:07 ` [PATCH v6 03/13] mm/vmemmap: Improve vmemmap_can_optimize and allow architectures to override Aneesh Kumar K.V
2023-07-24 19:07 ` Aneesh Kumar K.V
2023-07-24 19:07 ` [PATCH v6 04/13] mm/vmemmap: Allow architectures to override how vmemmap optimization works Aneesh Kumar K.V
2023-07-24 19:07 ` Aneesh Kumar K.V
2023-07-24 19:07 ` [PATCH v6 05/13] mm: Add pud_same similar to __HAVE_ARCH_P4D_SAME Aneesh Kumar K.V
2023-07-24 19:07 ` Aneesh Kumar K.V
2023-07-24 19:07 ` [PATCH v6 06/13] mm/huge pud: Use transparent huge pud helpers only with CONFIG_TRANSPARENT_HUGEPAGE Aneesh Kumar K.V
2023-07-24 19:07 ` [PATCH v6 07/13] mm/vmemmap optimization: Split hugetlb and devdax vmemmap optimization Aneesh Kumar K.V
2023-07-24 19:07 ` Aneesh Kumar K.V
2023-07-24 19:07 ` [PATCH v6 08/13] powerpc/mm/trace: Convert trace event to trace event class Aneesh Kumar K.V
2023-07-24 19:07 ` Aneesh Kumar K.V
2023-07-24 19:07 ` [PATCH v6 09/13] powerpc/book3s64/mm: Enable transparent pud hugepage Aneesh Kumar K.V
2023-07-24 19:07 ` Aneesh Kumar K.V
2023-07-24 19:07 ` [PATCH v6 10/13] powerpc/book3s64/vmemmap: Switch radix to use a different vmemmap handling function Aneesh Kumar K.V
2023-07-24 19:07 ` Aneesh Kumar K.V
2023-07-27 5:06 ` [PATCH v6 10/13 -fix] " Aneesh Kumar K.V
2023-07-27 5:06 ` Aneesh Kumar K.V
2023-07-28 10:22 ` [PATCH v6 10/13 -fix2] " Aneesh Kumar K.V
2023-07-28 10:22 ` Aneesh Kumar K.V
2023-07-24 19:07 ` [PATCH v6 11/13] powerpc/book3s64/radix: Add support for vmemmap optimization for radix Aneesh Kumar K.V
2023-07-24 19:07 ` Aneesh Kumar K.V
2023-07-26 14:05 ` [PATCH v6 11/13 -fix] " Aneesh Kumar K.V
2023-07-26 14:05 ` Aneesh Kumar K.V
2023-07-24 19:07 ` [PATCH v6 12/13] powerpc/book3s64/radix: Remove mmu_vmemmap_psize Aneesh Kumar K.V
2023-07-28 10:23 ` Aneesh Kumar K.V [this message]
2023-07-28 10:23 ` [PATCH v6 12/13 -fix] " Aneesh Kumar K.V
2023-07-24 19:07 ` [PATCH v6 13/13] powerpc/book3s64/radix: Add debug message to give more details of vmemmap allocation Aneesh Kumar K.V
2023-07-24 19:07 ` Aneesh Kumar K.V
2023-07-25 19:29 ` [PATCH v6 00/13] Add support for DAX vmemmap optimization for ppc64 Andrew Morton
2023-07-25 19:29 ` Andrew Morton
2023-07-26 5:29 ` Aneesh Kumar K V
2023-07-26 5:29 ` Aneesh Kumar K V
2023-07-26 18:52 ` Andrew Morton
2023-07-26 18:52 ` Andrew Morton
2023-07-27 5:37 ` Aneesh Kumar K.V
2023-07-27 5:37 ` Aneesh Kumar K.V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jlowd0c.fsf@linux.ibm.com \
--to=aneesh.kumar@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=christophe.leroy@csgroup.eu \
--cc=dan.j.williams@intel.com \
--cc=joao.m.martins@oracle.com \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mike.kravetz@oracle.com \
--cc=mpe@ellerman.id.au \
--cc=muchun.song@linux.dev \
--cc=npiggin@gmail.com \
--cc=osalvador@suse.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.