From: Markus Armbruster <armbru@redhat.com>
To: ~hyman <hyman@git.sr.ht>
Cc: qemu-devel@nongnu.org, ~hyman <yong.huang@smartx.com>,
Juan Quintela <quintela@redhat.com>,
Peter Xu <peterx@redhat.com>,
Leonardo Bras <leobras@redhat.com>,
Eric Blake <eblake@redhat.com>, Thomas Huth <thuth@redhat.com>,
Laurent Vivier <lvivier@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH QEMU v9 4/9] migration: Introduce dirty-limit capability
Date: Mon, 24 Jul 2023 11:24:58 +0200 [thread overview]
Message-ID: <874jltr79x.fsf@pond.sub.org> (raw)
In-Reply-To: <168987012554.14797.8679831725383645706-4@git.sr.ht> (hyman@git.sr.ht's message of "Wed, 07 Jun 2023 23:30:50 +0800")
~hyman <hyman@git.sr.ht> writes:
> From: Hyman Huang(黄勇) <yong.huang@smartx.com>
>
> Introduce migration dirty-limit capability, which can
> be turned on before live migration and limit dirty
> page rate durty live migration.
>
> Introduce migrate_dirty_limit function to help check
> if dirty-limit capability enabled during live migration.
>
> Meanwhile, refactor vcpu_dirty_rate_stat_collect
> so that period can be configured instead of hardcoded.
>
> dirty-limit capability is kind of like auto-converge
> but using dirty limit instead of traditional cpu-throttle
> to throttle guest down. To enable this feature, turn on
> the dirty-limit capability before live migration using
> migrate-set-capabilities, and set the parameters
> "x-vcpu-dirty-limit-period", "vcpu-dirty-limit" suitably
> to speed up convergence.
>
> Signed-off-by: Hyman Huang(黄勇) <yong.huang@smartx.com>
> Acked-by: Peter Xu <peterx@redhat.com>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
> Reviewed-by: Juan Quintela <quintela@redhat.com>
Looks good now, thanks!
next prev parent reply other threads:[~2023-07-24 9:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-20 16:22 [PATCH QEMU v9 0/9] migration: introduce dirtylimit capability ~hyman
2022-11-18 2:08 ` [PATCH QEMU v9 1/9] softmmu/dirtylimit: Add parameter check for hmp "set_vcpu_dirty_limit" ~hyman
2023-06-07 13:32 ` [PATCH QEMU v9 2/9] qapi/migration: Introduce x-vcpu-dirty-limit-period parameter ~hyman
2023-07-24 9:26 ` Markus Armbruster
2023-07-24 10:43 ` Markus Armbruster
2023-06-07 14:58 ` [PATCH QEMU v9 3/9] qapi/migration: Introduce vcpu-dirty-limit parameters ~hyman
2023-06-07 15:30 ` [PATCH QEMU v9 4/9] migration: Introduce dirty-limit capability ~hyman
2023-07-24 9:24 ` Markus Armbruster [this message]
2023-06-07 15:32 ` [PATCH QEMU v9 5/9] migration: Refactor auto-converge capability logic ~hyman
2023-06-07 16:12 ` [PATCH QEMU v9 7/9] migration: Implement dirty-limit convergence algorithm ~hyman
2023-06-07 16:21 ` [PATCH QEMU v9 8/9] migration: Extend query-migrate to provide dirty-limit info ~hyman
2023-06-07 16:46 ` [PATCH QEMU v9 9/9] tests: Add migration dirty-limit capability test ~hyman
2023-06-15 13:29 ` [PATCH QEMU v9 6/9] migration: Put the detection logic before auto-converge checking ~hyman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jltr79x.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=hyman@git.sr.ht \
--cc=leobras@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=thuth@redhat.com \
--cc=yong.huang@smartx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.