* [Intel-gfx] [PATCH] drm/i915: Fix memory leaks in i915 selftests
@ 2023-04-13 3:13 ` Cong Liu
0 siblings, 0 replies; 21+ messages in thread
From: Cong Liu @ 2023-04-13 3:13 UTC (permalink / raw)
To: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, Tvrtko Ursulin,
David Airlie, Daniel Vetter, Matthew Auld, Andi Shyti, Nirmoy Das,
Andrzej Hajda, Matthew Brost, Jonathan Cavitt, Chris Wilson,
Gwan-gyeong Mun, Mauro Carvalho Chehab, intel-gfx, dri-devel,
linux-kernel
Cc: Cong Liu
Fixes: c3bfba9a2225 ("drm/i915: Check for integer truncation on scatterlist creation")
Signed-off-by: Cong Liu <liucong2@kylinos.cn>
---
drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c
index 5361ce70d3f2..154801f1c468 100644
--- a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c
+++ b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c
@@ -69,8 +69,10 @@ static int fake_get_pages(struct drm_i915_gem_object *obj)
rem = round_up(obj->base.size, BIT(31)) >> 31;
/* restricted by sg_alloc_table */
- if (overflows_type(rem, unsigned int))
+ if (overflows_type(rem, unsigned int)) {
+ kfree(pages);
return -E2BIG;
+ }
if (sg_alloc_table(pages, rem, GFP)) {
kfree(pages);
--
2.34.1
No virus found
Checked by Hillstone Network AntiVirus
^ permalink raw reply related [flat|nested] 21+ messages in thread* [PATCH] drm/i915: Fix memory leaks in i915 selftests @ 2023-04-13 3:13 ` Cong Liu 0 siblings, 0 replies; 21+ messages in thread From: Cong Liu @ 2023-04-13 3:13 UTC (permalink / raw) To: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, Tvrtko Ursulin, David Airlie, Daniel Vetter, Matthew Auld, Andi Shyti, Nirmoy Das, Andrzej Hajda, Matthew Brost, Jonathan Cavitt, Chris Wilson, Gwan-gyeong Mun, Mauro Carvalho Chehab, intel-gfx, dri-devel, linux-kernel Cc: Cong Liu Fixes: c3bfba9a2225 ("drm/i915: Check for integer truncation on scatterlist creation") Signed-off-by: Cong Liu <liucong2@kylinos.cn> --- drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c index 5361ce70d3f2..154801f1c468 100644 --- a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c +++ b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c @@ -69,8 +69,10 @@ static int fake_get_pages(struct drm_i915_gem_object *obj) rem = round_up(obj->base.size, BIT(31)) >> 31; /* restricted by sg_alloc_table */ - if (overflows_type(rem, unsigned int)) + if (overflows_type(rem, unsigned int)) { + kfree(pages); return -E2BIG; + } if (sg_alloc_table(pages, rem, GFP)) { kfree(pages); -- 2.34.1 No virus found Checked by Hillstone Network AntiVirus ^ permalink raw reply related [flat|nested] 21+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Fix memory leaks in i915 selftests 2023-04-13 3:13 ` Cong Liu @ 2023-04-13 6:10 ` Andrzej Hajda -1 siblings, 0 replies; 21+ messages in thread From: Andrzej Hajda @ 2023-04-13 6:10 UTC (permalink / raw) To: Cong Liu, Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, Tvrtko Ursulin, David Airlie, Daniel Vetter, Matthew Auld, Andi Shyti, Nirmoy Das, Matthew Brost, Jonathan Cavitt, Chris Wilson, Gwan-gyeong Mun, Mauro Carvalho Chehab, intel-gfx, dri-devel, linux-kernel On 13.04.2023 05:13, Cong Liu wrote: > Fixes: c3bfba9a2225 ("drm/i915: Check for integer truncation on scatterlist creation") > > Signed-off-by: Cong Liu <liucong2@kylinos.cn> > --- Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com> Regards Andrzej > drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c > index 5361ce70d3f2..154801f1c468 100644 > --- a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c > +++ b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c > @@ -69,8 +69,10 @@ static int fake_get_pages(struct drm_i915_gem_object *obj) > > rem = round_up(obj->base.size, BIT(31)) >> 31; > /* restricted by sg_alloc_table */ > - if (overflows_type(rem, unsigned int)) > + if (overflows_type(rem, unsigned int)) { > + kfree(pages); > return -E2BIG; > + } > > if (sg_alloc_table(pages, rem, GFP)) { > kfree(pages); ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH] drm/i915: Fix memory leaks in i915 selftests @ 2023-04-13 6:10 ` Andrzej Hajda 0 siblings, 0 replies; 21+ messages in thread From: Andrzej Hajda @ 2023-04-13 6:10 UTC (permalink / raw) To: Cong Liu, Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, Tvrtko Ursulin, David Airlie, Daniel Vetter, Matthew Auld, Andi Shyti, Nirmoy Das, Matthew Brost, Jonathan Cavitt, Chris Wilson, Gwan-gyeong Mun, Mauro Carvalho Chehab, intel-gfx, dri-devel, linux-kernel On 13.04.2023 05:13, Cong Liu wrote: > Fixes: c3bfba9a2225 ("drm/i915: Check for integer truncation on scatterlist creation") > > Signed-off-by: Cong Liu <liucong2@kylinos.cn> > --- Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com> Regards Andrzej > drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c > index 5361ce70d3f2..154801f1c468 100644 > --- a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c > +++ b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c > @@ -69,8 +69,10 @@ static int fake_get_pages(struct drm_i915_gem_object *obj) > > rem = round_up(obj->base.size, BIT(31)) >> 31; > /* restricted by sg_alloc_table */ > - if (overflows_type(rem, unsigned int)) > + if (overflows_type(rem, unsigned int)) { > + kfree(pages); > return -E2BIG; > + } > > if (sg_alloc_table(pages, rem, GFP)) { > kfree(pages); ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Fix memory leaks in i915 selftests 2023-04-13 6:10 ` Andrzej Hajda @ 2023-04-13 7:15 ` Jani Nikula -1 siblings, 0 replies; 21+ messages in thread From: Jani Nikula @ 2023-04-13 7:15 UTC (permalink / raw) To: Andrzej Hajda, Cong Liu, Joonas Lahtinen, Rodrigo Vivi, Tvrtko Ursulin, David Airlie, Daniel Vetter, Matthew Auld, Andi Shyti, Nirmoy Das, Matthew Brost, Jonathan Cavitt, Chris Wilson, Gwan-gyeong Mun, Mauro Carvalho Chehab, intel-gfx, dri-devel, linux-kernel On Thu, 13 Apr 2023, Andrzej Hajda <andrzej.hajda@intel.com> wrote: > On 13.04.2023 05:13, Cong Liu wrote: A commit message is still needed. >> Fixes: c3bfba9a2225 ("drm/i915: Check for integer truncation on scatterlist creation") >> No blank line here. BR, Jani. >> Signed-off-by: Cong Liu <liucong2@kylinos.cn> >> --- > > Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com> > > Regards > Andrzej >> drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c >> index 5361ce70d3f2..154801f1c468 100644 >> --- a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c >> +++ b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c >> @@ -69,8 +69,10 @@ static int fake_get_pages(struct drm_i915_gem_object *obj) >> >> rem = round_up(obj->base.size, BIT(31)) >> 31; >> /* restricted by sg_alloc_table */ >> - if (overflows_type(rem, unsigned int)) >> + if (overflows_type(rem, unsigned int)) { >> + kfree(pages); >> return -E2BIG; >> + } >> >> if (sg_alloc_table(pages, rem, GFP)) { >> kfree(pages); > -- Jani Nikula, Intel Open Source Graphics Center ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH] drm/i915: Fix memory leaks in i915 selftests @ 2023-04-13 7:15 ` Jani Nikula 0 siblings, 0 replies; 21+ messages in thread From: Jani Nikula @ 2023-04-13 7:15 UTC (permalink / raw) To: Andrzej Hajda, Cong Liu, Joonas Lahtinen, Rodrigo Vivi, Tvrtko Ursulin, David Airlie, Daniel Vetter, Matthew Auld, Andi Shyti, Nirmoy Das, Matthew Brost, Jonathan Cavitt, Chris Wilson, Gwan-gyeong Mun, Mauro Carvalho Chehab, intel-gfx, dri-devel, linux-kernel On Thu, 13 Apr 2023, Andrzej Hajda <andrzej.hajda@intel.com> wrote: > On 13.04.2023 05:13, Cong Liu wrote: A commit message is still needed. >> Fixes: c3bfba9a2225 ("drm/i915: Check for integer truncation on scatterlist creation") >> No blank line here. BR, Jani. >> Signed-off-by: Cong Liu <liucong2@kylinos.cn> >> --- > > Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com> > > Regards > Andrzej >> drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c >> index 5361ce70d3f2..154801f1c468 100644 >> --- a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c >> +++ b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c >> @@ -69,8 +69,10 @@ static int fake_get_pages(struct drm_i915_gem_object *obj) >> >> rem = round_up(obj->base.size, BIT(31)) >> 31; >> /* restricted by sg_alloc_table */ >> - if (overflows_type(rem, unsigned int)) >> + if (overflows_type(rem, unsigned int)) { >> + kfree(pages); >> return -E2BIG; >> + } >> >> if (sg_alloc_table(pages, rem, GFP)) { >> kfree(pages); > -- Jani Nikula, Intel Open Source Graphics Center ^ permalink raw reply [flat|nested] 21+ messages in thread
* [Intel-gfx] [PATCH] drm/i915: Fix memory leaks in i915 selftests 2023-04-13 7:15 ` Jani Nikula (?) @ 2023-04-13 7:55 ` Cong Liu -1 siblings, 0 replies; 21+ messages in thread From: Cong Liu @ 2023-04-13 7:55 UTC (permalink / raw) To: jani.nikula Cc: mchehab, andrzej.hajda, intel-gfx, jonathan.cavitt, linux-kernel, dri-devel, chris, rodrigo.vivi, liucong2, matthew.auld, daniel, airlied, nirmoy.das This patch fixes memory leaks on error escapes in function fake_get_pages Fixes: c3bfba9a2225 ("drm/i915: Check for integer truncation on scatterlist creation") Signed-off-by: Cong Liu <liucong2@kylinos.cn> --- drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c index 5361ce70d3f2..154801f1c468 100644 --- a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c +++ b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c @@ -69,8 +69,10 @@ static int fake_get_pages(struct drm_i915_gem_object *obj) rem = round_up(obj->base.size, BIT(31)) >> 31; /* restricted by sg_alloc_table */ - if (overflows_type(rem, unsigned int)) + if (overflows_type(rem, unsigned int)) { + kfree(pages); return -E2BIG; + } if (sg_alloc_table(pages, rem, GFP)) { kfree(pages); -- 2.34.1 No virus found Checked by Hillstone Network AntiVirus ^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH] drm/i915: Fix memory leaks in i915 selftests @ 2023-04-13 7:55 ` Cong Liu 0 siblings, 0 replies; 21+ messages in thread From: Cong Liu @ 2023-04-13 7:55 UTC (permalink / raw) To: jani.nikula Cc: airlied, andi.shyti, andrzej.hajda, chris, daniel, dri-devel, gwan-gyeong.mun, intel-gfx, jonathan.cavitt, joonas.lahtinen, linux-kernel, liucong2, matthew.auld, matthew.brost, mchehab, nirmoy.das, rodrigo.vivi, tvrtko.ursulin This patch fixes memory leaks on error escapes in function fake_get_pages Fixes: c3bfba9a2225 ("drm/i915: Check for integer truncation on scatterlist creation") Signed-off-by: Cong Liu <liucong2@kylinos.cn> --- drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c index 5361ce70d3f2..154801f1c468 100644 --- a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c +++ b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c @@ -69,8 +69,10 @@ static int fake_get_pages(struct drm_i915_gem_object *obj) rem = round_up(obj->base.size, BIT(31)) >> 31; /* restricted by sg_alloc_table */ - if (overflows_type(rem, unsigned int)) + if (overflows_type(rem, unsigned int)) { + kfree(pages); return -E2BIG; + } if (sg_alloc_table(pages, rem, GFP)) { kfree(pages); -- 2.34.1 No virus found Checked by Hillstone Network AntiVirus ^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH] drm/i915: Fix memory leaks in i915 selftests @ 2023-04-13 7:55 ` Cong Liu 0 siblings, 0 replies; 21+ messages in thread From: Cong Liu @ 2023-04-13 7:55 UTC (permalink / raw) To: jani.nikula Cc: matthew.brost, tvrtko.ursulin, mchehab, andrzej.hajda, intel-gfx, jonathan.cavitt, linux-kernel, dri-devel, chris, rodrigo.vivi, liucong2, matthew.auld, andi.shyti, gwan-gyeong.mun, nirmoy.das This patch fixes memory leaks on error escapes in function fake_get_pages Fixes: c3bfba9a2225 ("drm/i915: Check for integer truncation on scatterlist creation") Signed-off-by: Cong Liu <liucong2@kylinos.cn> --- drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c index 5361ce70d3f2..154801f1c468 100644 --- a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c +++ b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c @@ -69,8 +69,10 @@ static int fake_get_pages(struct drm_i915_gem_object *obj) rem = round_up(obj->base.size, BIT(31)) >> 31; /* restricted by sg_alloc_table */ - if (overflows_type(rem, unsigned int)) + if (overflows_type(rem, unsigned int)) { + kfree(pages); return -E2BIG; + } if (sg_alloc_table(pages, rem, GFP)) { kfree(pages); -- 2.34.1 No virus found Checked by Hillstone Network AntiVirus ^ permalink raw reply related [flat|nested] 21+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Fix memory leaks in i915 selftests 2023-04-13 7:55 ` Cong Liu (?) @ 2023-04-13 8:44 ` Andi Shyti -1 siblings, 0 replies; 21+ messages in thread From: Andi Shyti @ 2023-04-13 8:44 UTC (permalink / raw) To: Cong Liu Cc: mchehab, andrzej.hajda, intel-gfx, jonathan.cavitt, linux-kernel, chris, rodrigo.vivi, nirmoy.das, dri-devel, daniel, airlied, matthew.auld On Thu, Apr 13, 2023 at 03:55:26PM +0800, Cong Liu wrote: > This patch fixes memory leaks on error escapes in function fake_get_pages > > Fixes: c3bfba9a2225 ("drm/i915: Check for integer truncation on scatterlist creation") > Signed-off-by: Cong Liu <liucong2@kylinos.cn> OK, while I was proposing the adjustments suggested by Jani you already replied to the e-mail. I will keep your version. Anyway, next time, please, do not forget to add the r-b's, in this case it was Andrzej's. Andi > --- > drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c > index 5361ce70d3f2..154801f1c468 100644 > --- a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c > +++ b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c > @@ -69,8 +69,10 @@ static int fake_get_pages(struct drm_i915_gem_object *obj) > > rem = round_up(obj->base.size, BIT(31)) >> 31; > /* restricted by sg_alloc_table */ > - if (overflows_type(rem, unsigned int)) > + if (overflows_type(rem, unsigned int)) { > + kfree(pages); > return -E2BIG; > + } > > if (sg_alloc_table(pages, rem, GFP)) { > kfree(pages); > -- > 2.34.1 > > > No virus found > Checked by Hillstone Network AntiVirus ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH] drm/i915: Fix memory leaks in i915 selftests @ 2023-04-13 8:44 ` Andi Shyti 0 siblings, 0 replies; 21+ messages in thread From: Andi Shyti @ 2023-04-13 8:44 UTC (permalink / raw) To: Cong Liu Cc: jani.nikula, airlied, andi.shyti, andrzej.hajda, chris, daniel, dri-devel, gwan-gyeong.mun, intel-gfx, jonathan.cavitt, joonas.lahtinen, linux-kernel, matthew.auld, matthew.brost, mchehab, nirmoy.das, rodrigo.vivi, tvrtko.ursulin On Thu, Apr 13, 2023 at 03:55:26PM +0800, Cong Liu wrote: > This patch fixes memory leaks on error escapes in function fake_get_pages > > Fixes: c3bfba9a2225 ("drm/i915: Check for integer truncation on scatterlist creation") > Signed-off-by: Cong Liu <liucong2@kylinos.cn> OK, while I was proposing the adjustments suggested by Jani you already replied to the e-mail. I will keep your version. Anyway, next time, please, do not forget to add the r-b's, in this case it was Andrzej's. Andi > --- > drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c > index 5361ce70d3f2..154801f1c468 100644 > --- a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c > +++ b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c > @@ -69,8 +69,10 @@ static int fake_get_pages(struct drm_i915_gem_object *obj) > > rem = round_up(obj->base.size, BIT(31)) >> 31; > /* restricted by sg_alloc_table */ > - if (overflows_type(rem, unsigned int)) > + if (overflows_type(rem, unsigned int)) { > + kfree(pages); > return -E2BIG; > + } > > if (sg_alloc_table(pages, rem, GFP)) { > kfree(pages); > -- > 2.34.1 > > > No virus found > Checked by Hillstone Network AntiVirus ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH] drm/i915: Fix memory leaks in i915 selftests @ 2023-04-13 8:44 ` Andi Shyti 0 siblings, 0 replies; 21+ messages in thread From: Andi Shyti @ 2023-04-13 8:44 UTC (permalink / raw) To: Cong Liu Cc: matthew.brost, tvrtko.ursulin, mchehab, andrzej.hajda, intel-gfx, jonathan.cavitt, linux-kernel, chris, rodrigo.vivi, nirmoy.das, dri-devel, andi.shyti, gwan-gyeong.mun, matthew.auld On Thu, Apr 13, 2023 at 03:55:26PM +0800, Cong Liu wrote: > This patch fixes memory leaks on error escapes in function fake_get_pages > > Fixes: c3bfba9a2225 ("drm/i915: Check for integer truncation on scatterlist creation") > Signed-off-by: Cong Liu <liucong2@kylinos.cn> OK, while I was proposing the adjustments suggested by Jani you already replied to the e-mail. I will keep your version. Anyway, next time, please, do not forget to add the r-b's, in this case it was Andrzej's. Andi > --- > drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c > index 5361ce70d3f2..154801f1c468 100644 > --- a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c > +++ b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c > @@ -69,8 +69,10 @@ static int fake_get_pages(struct drm_i915_gem_object *obj) > > rem = round_up(obj->base.size, BIT(31)) >> 31; > /* restricted by sg_alloc_table */ > - if (overflows_type(rem, unsigned int)) > + if (overflows_type(rem, unsigned int)) { > + kfree(pages); > return -E2BIG; > + } > > if (sg_alloc_table(pages, rem, GFP)) { > kfree(pages); > -- > 2.34.1 > > > No virus found > Checked by Hillstone Network AntiVirus ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Fix memory leaks in i915 selftests 2023-04-13 8:44 ` Andi Shyti (?) @ 2023-04-13 9:07 ` Cong Liu -1 siblings, 0 replies; 21+ messages in thread From: Cong Liu @ 2023-04-13 9:07 UTC (permalink / raw) To: Andi Shyti Cc: mchehab, andrzej.hajda, intel-gfx, jonathan.cavitt, linux-kernel, dri-devel, chris, nirmoy.das, daniel, rodrigo.vivi, airlied, matthew.auld Hi Andi, thank you for your reminder, next time I will pay attention to my format, and when someone has already reviewed, add the Reviewed-by field Regards. On 2023/4/13 16:44, Andi Shyti wrote: > On Thu, Apr 13, 2023 at 03:55:26PM +0800, Cong Liu wrote: >> This patch fixes memory leaks on error escapes in function fake_get_pages >> >> Fixes: c3bfba9a2225 ("drm/i915: Check for integer truncation on scatterlist creation") >> Signed-off-by: Cong Liu <liucong2@kylinos.cn> > OK, while I was proposing the adjustments suggested by Jani you > already replied to the e-mail. I will keep your version. > > Anyway, next time, please, do not forget to add the r-b's, in > this case it was Andrzej's. > > Andi > >> --- >> drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c >> index 5361ce70d3f2..154801f1c468 100644 >> --- a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c >> +++ b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c >> @@ -69,8 +69,10 @@ static int fake_get_pages(struct drm_i915_gem_object *obj) >> >> rem = round_up(obj->base.size, BIT(31)) >> 31; >> /* restricted by sg_alloc_table */ >> - if (overflows_type(rem, unsigned int)) >> + if (overflows_type(rem, unsigned int)) { >> + kfree(pages); >> return -E2BIG; >> + } >> >> if (sg_alloc_table(pages, rem, GFP)) { >> kfree(pages); >> -- >> 2.34.1 >> >> >> No virus found >> Checked by Hillstone Network AntiVirus ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH] drm/i915: Fix memory leaks in i915 selftests @ 2023-04-13 9:07 ` Cong Liu 0 siblings, 0 replies; 21+ messages in thread From: Cong Liu @ 2023-04-13 9:07 UTC (permalink / raw) To: Andi Shyti Cc: jani.nikula, airlied, andrzej.hajda, chris, daniel, dri-devel, gwan-gyeong.mun, intel-gfx, jonathan.cavitt, joonas.lahtinen, linux-kernel, matthew.auld, matthew.brost, mchehab, nirmoy.das, rodrigo.vivi, tvrtko.ursulin Hi Andi, thank you for your reminder, next time I will pay attention to my format, and when someone has already reviewed, add the Reviewed-by field Regards. On 2023/4/13 16:44, Andi Shyti wrote: > On Thu, Apr 13, 2023 at 03:55:26PM +0800, Cong Liu wrote: >> This patch fixes memory leaks on error escapes in function fake_get_pages >> >> Fixes: c3bfba9a2225 ("drm/i915: Check for integer truncation on scatterlist creation") >> Signed-off-by: Cong Liu <liucong2@kylinos.cn> > OK, while I was proposing the adjustments suggested by Jani you > already replied to the e-mail. I will keep your version. > > Anyway, next time, please, do not forget to add the r-b's, in > this case it was Andrzej's. > > Andi > >> --- >> drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c >> index 5361ce70d3f2..154801f1c468 100644 >> --- a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c >> +++ b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c >> @@ -69,8 +69,10 @@ static int fake_get_pages(struct drm_i915_gem_object *obj) >> >> rem = round_up(obj->base.size, BIT(31)) >> 31; >> /* restricted by sg_alloc_table */ >> - if (overflows_type(rem, unsigned int)) >> + if (overflows_type(rem, unsigned int)) { >> + kfree(pages); >> return -E2BIG; >> + } >> >> if (sg_alloc_table(pages, rem, GFP)) { >> kfree(pages); >> -- >> 2.34.1 >> >> >> No virus found >> Checked by Hillstone Network AntiVirus ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH] drm/i915: Fix memory leaks in i915 selftests @ 2023-04-13 9:07 ` Cong Liu 0 siblings, 0 replies; 21+ messages in thread From: Cong Liu @ 2023-04-13 9:07 UTC (permalink / raw) To: Andi Shyti Cc: matthew.brost, tvrtko.ursulin, mchehab, andrzej.hajda, intel-gfx, jonathan.cavitt, linux-kernel, dri-devel, chris, nirmoy.das, rodrigo.vivi, gwan-gyeong.mun, matthew.auld Hi Andi, thank you for your reminder, next time I will pay attention to my format, and when someone has already reviewed, add the Reviewed-by field Regards. On 2023/4/13 16:44, Andi Shyti wrote: > On Thu, Apr 13, 2023 at 03:55:26PM +0800, Cong Liu wrote: >> This patch fixes memory leaks on error escapes in function fake_get_pages >> >> Fixes: c3bfba9a2225 ("drm/i915: Check for integer truncation on scatterlist creation") >> Signed-off-by: Cong Liu <liucong2@kylinos.cn> > OK, while I was proposing the adjustments suggested by Jani you > already replied to the e-mail. I will keep your version. > > Anyway, next time, please, do not forget to add the r-b's, in > this case it was Andrzej's. > > Andi > >> --- >> drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c >> index 5361ce70d3f2..154801f1c468 100644 >> --- a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c >> +++ b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c >> @@ -69,8 +69,10 @@ static int fake_get_pages(struct drm_i915_gem_object *obj) >> >> rem = round_up(obj->base.size, BIT(31)) >> 31; >> /* restricted by sg_alloc_table */ >> - if (overflows_type(rem, unsigned int)) >> + if (overflows_type(rem, unsigned int)) { >> + kfree(pages); >> return -E2BIG; >> + } >> >> if (sg_alloc_table(pages, rem, GFP)) { >> kfree(pages); >> -- >> 2.34.1 >> >> >> No virus found >> Checked by Hillstone Network AntiVirus ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Fix memory leaks in i915 selftests 2023-04-13 3:13 ` Cong Liu (?) @ 2023-04-13 8:15 ` Andi Shyti -1 siblings, 0 replies; 21+ messages in thread From: Andi Shyti @ 2023-04-13 8:15 UTC (permalink / raw) To: Cong Liu Cc: Mauro Carvalho Chehab, dri-devel, intel-gfx, Jonathan Cavitt, linux-kernel, Chris Wilson, Andrzej Hajda, Matthew Auld, Daniel Vetter, Rodrigo Vivi, David Airlie, Nirmoy Das Hi Cong, > Fixes: c3bfba9a2225 ("drm/i915: Check for integer truncation on scatterlist creation") > > Signed-off-by: Cong Liu <liucong2@kylinos.cn> As Jani suggested we need a commit message here. Would something like this work for you? " We forget to free 'pages' after checking for overflow. Be sure to properly free the allocated memory before exiting the fake_free_pages() function. " If it's OK for you, then I can add this message and fix the blank space before pushing this patch. In any case: Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com> Andi > --- > drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c > index 5361ce70d3f2..154801f1c468 100644 > --- a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c > +++ b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c > @@ -69,8 +69,10 @@ static int fake_get_pages(struct drm_i915_gem_object *obj) > > rem = round_up(obj->base.size, BIT(31)) >> 31; > /* restricted by sg_alloc_table */ > - if (overflows_type(rem, unsigned int)) > + if (overflows_type(rem, unsigned int)) { > + kfree(pages); > return -E2BIG; > + } > > if (sg_alloc_table(pages, rem, GFP)) { > kfree(pages); > -- > 2.34.1 > > > No virus found > Checked by Hillstone Network AntiVirus ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH] drm/i915: Fix memory leaks in i915 selftests @ 2023-04-13 8:15 ` Andi Shyti 0 siblings, 0 replies; 21+ messages in thread From: Andi Shyti @ 2023-04-13 8:15 UTC (permalink / raw) To: Cong Liu Cc: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, Tvrtko Ursulin, David Airlie, Daniel Vetter, Matthew Auld, Andi Shyti, Nirmoy Das, Andrzej Hajda, Matthew Brost, Jonathan Cavitt, Chris Wilson, Gwan-gyeong Mun, Mauro Carvalho Chehab, intel-gfx, dri-devel, linux-kernel Hi Cong, > Fixes: c3bfba9a2225 ("drm/i915: Check for integer truncation on scatterlist creation") > > Signed-off-by: Cong Liu <liucong2@kylinos.cn> As Jani suggested we need a commit message here. Would something like this work for you? " We forget to free 'pages' after checking for overflow. Be sure to properly free the allocated memory before exiting the fake_free_pages() function. " If it's OK for you, then I can add this message and fix the blank space before pushing this patch. In any case: Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com> Andi > --- > drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c > index 5361ce70d3f2..154801f1c468 100644 > --- a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c > +++ b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c > @@ -69,8 +69,10 @@ static int fake_get_pages(struct drm_i915_gem_object *obj) > > rem = round_up(obj->base.size, BIT(31)) >> 31; > /* restricted by sg_alloc_table */ > - if (overflows_type(rem, unsigned int)) > + if (overflows_type(rem, unsigned int)) { > + kfree(pages); > return -E2BIG; > + } > > if (sg_alloc_table(pages, rem, GFP)) { > kfree(pages); > -- > 2.34.1 > > > No virus found > Checked by Hillstone Network AntiVirus ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH] drm/i915: Fix memory leaks in i915 selftests @ 2023-04-13 8:15 ` Andi Shyti 0 siblings, 0 replies; 21+ messages in thread From: Andi Shyti @ 2023-04-13 8:15 UTC (permalink / raw) To: Cong Liu Cc: Matthew Brost, Tvrtko Ursulin, Mauro Carvalho Chehab, Andi Shyti, dri-devel, intel-gfx, Jonathan Cavitt, linux-kernel, Chris Wilson, Andrzej Hajda, Matthew Auld, Rodrigo Vivi, Gwan-gyeong Mun, Nirmoy Das Hi Cong, > Fixes: c3bfba9a2225 ("drm/i915: Check for integer truncation on scatterlist creation") > > Signed-off-by: Cong Liu <liucong2@kylinos.cn> As Jani suggested we need a commit message here. Would something like this work for you? " We forget to free 'pages' after checking for overflow. Be sure to properly free the allocated memory before exiting the fake_free_pages() function. " If it's OK for you, then I can add this message and fix the blank space before pushing this patch. In any case: Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com> Andi > --- > drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c > index 5361ce70d3f2..154801f1c468 100644 > --- a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c > +++ b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c > @@ -69,8 +69,10 @@ static int fake_get_pages(struct drm_i915_gem_object *obj) > > rem = round_up(obj->base.size, BIT(31)) >> 31; > /* restricted by sg_alloc_table */ > - if (overflows_type(rem, unsigned int)) > + if (overflows_type(rem, unsigned int)) { > + kfree(pages); > return -E2BIG; > + } > > if (sg_alloc_table(pages, rem, GFP)) { > kfree(pages); > -- > 2.34.1 > > > No virus found > Checked by Hillstone Network AntiVirus ^ permalink raw reply [flat|nested] 21+ messages in thread
* [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Fix memory leaks in i915 selftests (rev4) 2023-04-13 3:13 ` Cong Liu ` (2 preceding siblings ...) (?) @ 2023-04-21 18:05 ` Patchwork -1 siblings, 0 replies; 21+ messages in thread From: Patchwork @ 2023-04-21 18:05 UTC (permalink / raw) To: Andi Shyti; +Cc: intel-gfx == Series Details == Series: drm/i915: Fix memory leaks in i915 selftests (rev4) URL : https://patchwork.freedesktop.org/series/116513/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 ^ permalink raw reply [flat|nested] 21+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix memory leaks in i915 selftests (rev4) 2023-04-13 3:13 ` Cong Liu ` (3 preceding siblings ...) (?) @ 2023-04-21 18:18 ` Patchwork -1 siblings, 0 replies; 21+ messages in thread From: Patchwork @ 2023-04-21 18:18 UTC (permalink / raw) To: Andi Shyti; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 2836 bytes --] == Series Details == Series: drm/i915: Fix memory leaks in i915 selftests (rev4) URL : https://patchwork.freedesktop.org/series/116513/ State : success == Summary == CI Bug Log - changes from CI_DRM_13043 -> Patchwork_116513v4 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116513v4/index.html Participating hosts (36 -> 36) ------------------------------ Additional (1): bat-mtlp-8 Missing (1): fi-snb-2520m Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_116513v4: ### IGT changes ### #### Suppressed #### The following results come from untrusted machines, tests, or statuses. They do not affect the overall result. * igt@i915_module_load@load: - {bat-mtlp-8}: NOTRUN -> [ABORT][1] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116513v4/bat-mtlp-8/igt@i915_module_load@load.html Known issues ------------ Here are the changes found in Patchwork_116513v4 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@i915_selftest@live@execlists: - fi-bsw-nick: [PASS][2] -> [ABORT][3] ([i915#7911] / [i915#7913]) [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13043/fi-bsw-nick/igt@i915_selftest@live@execlists.html [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116513v4/fi-bsw-nick/igt@i915_selftest@live@execlists.html * igt@i915_selftest@live@reset: - bat-rpls-1: [PASS][4] -> [ABORT][5] ([i915#4983] / [i915#8384]) [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13043/bat-rpls-1/igt@i915_selftest@live@reset.html [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116513v4/bat-rpls-1/igt@i915_selftest@live@reset.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983 [i915#7911]: https://gitlab.freedesktop.org/drm/intel/issues/7911 [i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913 [i915#8384]: https://gitlab.freedesktop.org/drm/intel/issues/8384 Build changes ------------- * Linux: CI_DRM_13043 -> Patchwork_116513v4 CI-20190529: 20190529 CI_DRM_13043: 2fa9c266135355c9993507d7c27cc6722956bfec @ git://anongit.freedesktop.org/gfx-ci/linux IGT_7264: 2f0a07378e58e5c7d7b589b39ace7e3a2317f6b2 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_116513v4: 2fa9c266135355c9993507d7c27cc6722956bfec @ git://anongit.freedesktop.org/gfx-ci/linux ### Linux commits == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116513v4/index.html [-- Attachment #2: Type: text/html, Size: 3503 bytes --] ^ permalink raw reply [flat|nested] 21+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Fix memory leaks in i915 selftests (rev4) 2023-04-13 3:13 ` Cong Liu ` (4 preceding siblings ...) (?) @ 2023-04-22 3:38 ` Patchwork -1 siblings, 0 replies; 21+ messages in thread From: Patchwork @ 2023-04-22 3:38 UTC (permalink / raw) To: Andi Shyti; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 14350 bytes --] == Series Details == Series: drm/i915: Fix memory leaks in i915 selftests (rev4) URL : https://patchwork.freedesktop.org/series/116513/ State : success == Summary == CI Bug Log - changes from CI_DRM_13043_full -> Patchwork_116513v4_full ==================================================== Summary ------- **SUCCESS** No regressions found. Participating hosts (7 -> 7) ------------------------------ No changes in participating hosts Known issues ------------ Here are the changes found in Patchwork_116513v4_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_exec_fair@basic-none-solo@rcs0: - shard-apl: [PASS][1] -> [FAIL][2] ([i915#2842]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13043/shard-apl2/igt@gem_exec_fair@basic-none-solo@rcs0.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116513v4/shard-apl7/igt@gem_exec_fair@basic-none-solo@rcs0.html * igt@gem_exec_fair@basic-pace-share@rcs0: - shard-glk: [PASS][3] -> [FAIL][4] ([i915#2842]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13043/shard-glk7/igt@gem_exec_fair@basic-pace-share@rcs0.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116513v4/shard-glk9/igt@gem_exec_fair@basic-pace-share@rcs0.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size: - shard-glk: [PASS][5] -> [FAIL][6] ([i915#2346]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13043/shard-glk8/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116513v4/shard-glk5/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html * igt@kms_flip@2x-flip-vs-blocking-wf-vblank@ab-hdmi-a1-hdmi-a2: - shard-glk: [PASS][7] -> [FAIL][8] ([i915#2122]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13043/shard-glk1/igt@kms_flip@2x-flip-vs-blocking-wf-vblank@ab-hdmi-a1-hdmi-a2.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116513v4/shard-glk2/igt@kms_flip@2x-flip-vs-blocking-wf-vblank@ab-hdmi-a1-hdmi-a2.html * igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-render: - shard-apl: NOTRUN -> [SKIP][9] ([fdo#109271]) +3 similar issues [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116513v4/shard-apl3/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-render.html * igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-a-vga-1: - shard-snb: NOTRUN -> [SKIP][10] ([fdo#109271]) +23 similar issues [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116513v4/shard-snb6/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-a-vga-1.html #### Possible fixes #### * igt@gem_exec_endless@dispatch@vecs0: - {shard-tglu}: [TIMEOUT][11] ([i915#3778]) -> [PASS][12] [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13043/shard-tglu-10/igt@gem_exec_endless@dispatch@vecs0.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116513v4/shard-tglu-5/igt@gem_exec_endless@dispatch@vecs0.html * igt@gem_exec_fair@basic-pace-solo@rcs0: - {shard-rkl}: [FAIL][13] ([i915#2842]) -> [PASS][14] [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13043/shard-rkl-4/igt@gem_exec_fair@basic-pace-solo@rcs0.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116513v4/shard-rkl-6/igt@gem_exec_fair@basic-pace-solo@rcs0.html * igt@gem_exec_schedule@smoketest@rcs0: - shard-glk: [DMESG-WARN][15] ([i915#118]) -> [PASS][16] [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13043/shard-glk4/igt@gem_exec_schedule@smoketest@rcs0.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116513v4/shard-glk2/igt@gem_exec_schedule@smoketest@rcs0.html * igt@gen9_exec_parse@allowed-all: - shard-apl: [ABORT][17] ([i915#5566]) -> [PASS][18] [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13043/shard-apl7/igt@gen9_exec_parse@allowed-all.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116513v4/shard-apl3/igt@gen9_exec_parse@allowed-all.html * igt@i915_pm_dc@dc6-dpms: - {shard-tglu}: [FAIL][19] ([i915#3989] / [i915#454]) -> [PASS][20] [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13043/shard-tglu-5/igt@i915_pm_dc@dc6-dpms.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116513v4/shard-tglu-4/igt@i915_pm_dc@dc6-dpms.html * igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a: - {shard-rkl}: [SKIP][21] ([i915#1937]) -> [PASS][22] [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13043/shard-rkl-6/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116513v4/shard-rkl-7/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a.html * igt@i915_pm_rc6_residency@rc6-idle@vcs0: - {shard-dg1}: [FAIL][23] ([i915#3591]) -> [PASS][24] +1 similar issue [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13043/shard-dg1-18/igt@i915_pm_rc6_residency@rc6-idle@vcs0.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116513v4/shard-dg1-15/igt@i915_pm_rc6_residency@rc6-idle@vcs0.html * igt@i915_pm_rpm@dpms-non-lpsp: - {shard-rkl}: [SKIP][25] ([i915#1397]) -> [PASS][26] +2 similar issues [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13043/shard-rkl-7/igt@i915_pm_rpm@dpms-non-lpsp.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116513v4/shard-rkl-2/igt@i915_pm_rpm@dpms-non-lpsp.html * igt@i915_pm_rpm@modeset-lpsp-stress: - {shard-dg1}: [SKIP][27] ([i915#1397]) -> [PASS][28] [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13043/shard-dg1-17/igt@i915_pm_rpm@modeset-lpsp-stress.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116513v4/shard-dg1-14/igt@i915_pm_rpm@modeset-lpsp-stress.html * igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic: - shard-glk: [FAIL][29] ([i915#72]) -> [PASS][30] [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13043/shard-glk4/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116513v4/shard-glk2/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html * igt@kms_cursor_legacy@single-move@pipe-b: - {shard-rkl}: [INCOMPLETE][31] ([i915#8011]) -> [PASS][32] +1 similar issue [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13043/shard-rkl-7/igt@kms_cursor_legacy@single-move@pipe-b.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116513v4/shard-rkl-2/igt@kms_cursor_legacy@single-move@pipe-b.html * igt@perf_pmu@idle@rcs0: - {shard-dg1}: [FAIL][33] ([i915#4349]) -> [PASS][34] [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13043/shard-dg1-14/igt@perf_pmu@idle@rcs0.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116513v4/shard-dg1-18/igt@perf_pmu@idle@rcs0.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274 [fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280 [fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283 [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289 [fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291 [fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295 [fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315 [fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506 [fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189 [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068 [fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614 [fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615 [fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283 [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072 [i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118 [i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397 [i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839 [i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937 [i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122 [i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346 [i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527 [i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575 [i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587 [i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658 [i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672 [i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280 [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842 [i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281 [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282 [i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297 [i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301 [i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359 [i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458 [i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469 [i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539 [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555 [i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591 [i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637 [i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638 [i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689 [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708 [i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742 [i915#3778]: https://gitlab.freedesktop.org/drm/intel/issues/3778 [i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840 [i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886 [i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955 [i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989 [i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070 [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077 [i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078 [i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079 [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083 [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103 [i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212 [i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213 [i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270 [i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281 [i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349 [i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538 [i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454 [i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565 [i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579 [i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812 [i915#4816]: https://gitlab.freedesktop.org/drm/intel/issues/4816 [i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833 [i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852 [i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860 [i915#4880]: https://gitlab.freedesktop.org/drm/intel/issues/4880 [i915#4958]: https://gitlab.freedesktop.org/drm/intel/issues/4958 [i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176 [i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235 [i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286 [i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325 [i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354 [i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563 [i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566 [i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095 [i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268 [i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524 [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658 [i915#6590]: https://gitlab.freedesktop.org/drm/intel/issues/6590 [i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946 [i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116 [i915#72]: https://gitlab.freedesktop.org/drm/intel/issues/72 [i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561 [i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697 [i915#7707]: https://gitlab.freedesktop.org/drm/intel/issues/7707 [i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711 [i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742 [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828 [i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011 [i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347 [i915#8381]: https://gitlab.freedesktop.org/drm/intel/issues/8381 Build changes ------------- * Linux: CI_DRM_13043 -> Patchwork_116513v4 CI-20190529: 20190529 CI_DRM_13043: 2fa9c266135355c9993507d7c27cc6722956bfec @ git://anongit.freedesktop.org/gfx-ci/linux IGT_7264: 2f0a07378e58e5c7d7b589b39ace7e3a2317f6b2 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_116513v4: 2fa9c266135355c9993507d7c27cc6722956bfec @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116513v4/index.html [-- Attachment #2: Type: text/html, Size: 10167 bytes --] ^ permalink raw reply [flat|nested] 21+ messages in thread
end of thread, other threads:[~2023-04-22 3:38 UTC | newest] Thread overview: 21+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-04-13 3:13 [Intel-gfx] [PATCH] drm/i915: Fix memory leaks in i915 selftests Cong Liu 2023-04-13 3:13 ` Cong Liu 2023-04-13 6:10 ` [Intel-gfx] " Andrzej Hajda 2023-04-13 6:10 ` Andrzej Hajda 2023-04-13 7:15 ` [Intel-gfx] " Jani Nikula 2023-04-13 7:15 ` Jani Nikula 2023-04-13 7:55 ` [Intel-gfx] " Cong Liu 2023-04-13 7:55 ` Cong Liu 2023-04-13 7:55 ` Cong Liu 2023-04-13 8:44 ` [Intel-gfx] " Andi Shyti 2023-04-13 8:44 ` Andi Shyti 2023-04-13 8:44 ` Andi Shyti 2023-04-13 9:07 ` [Intel-gfx] " Cong Liu 2023-04-13 9:07 ` Cong Liu 2023-04-13 9:07 ` Cong Liu 2023-04-13 8:15 ` [Intel-gfx] " Andi Shyti 2023-04-13 8:15 ` Andi Shyti 2023-04-13 8:15 ` Andi Shyti 2023-04-21 18:05 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Fix memory leaks in i915 selftests (rev4) Patchwork 2023-04-21 18:18 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2023-04-22 3:38 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.