All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Machata <petrm@nvidia.com>
To: Petr Machata <petrm@nvidia.com>
Cc: Daniel Machon <daniel.machon@microchip.com>,
	<netdev@vger.kernel.org>, <davem@davemloft.net>,
	<maxime.chevallier@bootlin.com>, <thomas.petazzoni@bootlin.com>,
	<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
	<lars.povlsen@microchip.com>, <Steen.Hegelund@microchip.com>,
	<UNGLinuxDriver@microchip.com>, <joe@perches.com>,
	<linux@armlinux.org.uk>, <horatiu.vultur@microchip.com>,
	<Julia.Lawall@inria.fr>, <vladimir.oltean@nxp.com>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH net-next v2 1/6] net: dcb: add new pcp selector to app object
Date: Fri, 30 Sep 2022 17:41:22 +0200	[thread overview]
Message-ID: <874jwovp6x.fsf@nvidia.com> (raw)
In-Reply-To: <87leq1uiyc.fsf@nvidia.com>


Petr Machata <petrm@nvidia.com> writes:

> We can pack the new stuff into a smaller payload. The inner attribute
> would not be DCB_ATTR_DCB_APP, but say DCB_ATTR_DCB_PCP, which would
> imply the selector. The payload can be struct { u8 prio; u16 proto; }.
> This would have been bounced by the old UAPI, so we know no userspace
> makes use of that.

Except this will end up having size of 4 anyway due to alignment. We'll
have to make it a struct { ... } __attribute__((__packed__));

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Petr Machata <petrm@nvidia.com>
To: Petr Machata <petrm@nvidia.com>
Cc: Daniel Machon <daniel.machon@microchip.com>,
	<netdev@vger.kernel.org>, <davem@davemloft.net>,
	<maxime.chevallier@bootlin.com>, <thomas.petazzoni@bootlin.com>,
	<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
	<lars.povlsen@microchip.com>, <Steen.Hegelund@microchip.com>,
	<UNGLinuxDriver@microchip.com>, <joe@perches.com>,
	<linux@armlinux.org.uk>, <horatiu.vultur@microchip.com>,
	<Julia.Lawall@inria.fr>, <vladimir.oltean@nxp.com>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH net-next v2 1/6] net: dcb: add new pcp selector to app object
Date: Fri, 30 Sep 2022 17:41:22 +0200	[thread overview]
Message-ID: <874jwovp6x.fsf@nvidia.com> (raw)
In-Reply-To: <87leq1uiyc.fsf@nvidia.com>


Petr Machata <petrm@nvidia.com> writes:

> We can pack the new stuff into a smaller payload. The inner attribute
> would not be DCB_ATTR_DCB_APP, but say DCB_ATTR_DCB_PCP, which would
> imply the selector. The payload can be struct { u8 prio; u16 proto; }.
> This would have been bounced by the old UAPI, so we know no userspace
> makes use of that.

Except this will end up having size of 4 anyway due to alignment. We'll
have to make it a struct { ... } __attribute__((__packed__));

  reply	other threads:[~2022-09-30 15:51 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-29 18:52 [PATCH net-next v2 0/6] Add new PCP and APPTRUST attributes to dcbnl Daniel Machon
2022-09-29 18:52 ` Daniel Machon
2022-09-29 18:52 ` [PATCH net-next v2 1/6] net: dcb: add new pcp selector to app object Daniel Machon
2022-09-29 18:52   ` Daniel Machon
2022-09-30 12:20   ` Petr Machata
2022-09-30 12:20     ` Petr Machata
2022-09-30 15:41     ` Petr Machata [this message]
2022-09-30 15:41       ` Petr Machata
2022-10-01  0:54     ` Jakub Kicinski
2022-10-01  0:54       ` Jakub Kicinski
2022-10-03  7:52       ` Petr Machata
2022-10-03  7:52         ` Petr Machata
2022-10-03 16:25         ` Jakub Kicinski
2022-10-03 16:25           ` Jakub Kicinski
2022-10-03 21:59           ` Daniel.Machon
2022-10-03 21:59             ` Daniel.Machon
2022-10-03 23:34             ` Jakub Kicinski
2022-10-03 23:34               ` Jakub Kicinski
2022-10-04 10:56               ` Petr Machata
2022-10-04 10:56                 ` Petr Machata
2022-10-04 10:20           ` Petr Machata
2022-10-04 10:20             ` Petr Machata
2022-10-04 10:52             ` Petr Machata
2022-10-04 10:52               ` Petr Machata
2022-10-04 19:51               ` Jakub Kicinski
2022-10-04 19:51                 ` Jakub Kicinski
2022-10-03  6:48     ` Daniel.Machon
2022-10-03  6:48       ` Daniel.Machon
2022-10-03  8:22       ` Petr Machata
2022-10-03  8:22         ` Petr Machata
2022-10-03  9:33         ` Daniel.Machon
2022-10-03  9:33           ` Daniel.Machon
2022-10-05 10:09           ` Petr Machata
2022-10-05 10:09             ` Petr Machata
2022-09-29 18:52 ` [PATCH net-next v2 2/6] net: dcb: add new apptrust attribute Daniel Machon
2022-09-29 18:52   ` Daniel Machon
2022-09-30 13:03   ` Petr Machata
2022-09-30 13:03     ` Petr Machata
2022-09-29 18:52 ` [PATCH net-next v2 3/6] net: microchip: sparx5: add support for offloading pcp table Daniel Machon
2022-09-29 18:52   ` Daniel Machon
2022-09-30 20:44   ` kernel test robot
2022-09-29 18:52 ` [PATCH net-next v2 4/6] net: microchip: sparx5: add support for apptrust Daniel Machon
2022-09-29 18:52   ` Daniel Machon
2022-09-30 15:49   ` Petr Machata
2022-09-30 15:49     ` Petr Machata
2022-10-03  6:52     ` Daniel.Machon
2022-10-03  6:52       ` Daniel.Machon
2022-10-03  8:01       ` Petr Machata
2022-10-03  8:01         ` Petr Machata
2022-10-03  8:17         ` Daniel.Machon
2022-10-03  8:17           ` Daniel.Machon
2022-10-03  9:34           ` Petr Machata
2022-10-03  9:34             ` Petr Machata
2022-09-29 18:52 ` [PATCH net-next v2 5/6] net: microchip: sparx5: add support for offloading dscp table Daniel Machon
2022-09-29 18:52   ` Daniel Machon
2022-09-30 23:23   ` kernel test robot
2022-09-29 18:52 ` [PATCH net-next v2 6/6] net: microchip: sparx5: add support for offloading default prio Daniel Machon
2022-09-29 18:52   ` Daniel Machon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874jwovp6x.fsf@nvidia.com \
    --to=petrm@nvidia.com \
    --cc=Julia.Lawall@inria.fr \
    --cc=Steen.Hegelund@microchip.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=daniel.machon@microchip.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horatiu.vultur@microchip.com \
    --cc=joe@perches.com \
    --cc=kuba@kernel.org \
    --cc=lars.povlsen@microchip.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=maxime.chevallier@bootlin.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=vladimir.oltean@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.