All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3 0/4] Patch series to set up a ppc64le CI
@ 2022-09-22 13:55 Lucas Mateus Castro(alqotel)
  2022-09-22 13:55 ` [PATCH v3 1/4] scripts/ci/setup: ninja missing from build-environment Lucas Mateus Castro(alqotel)
                   ` (4 more replies)
  0 siblings, 5 replies; 7+ messages in thread
From: Lucas Mateus Castro(alqotel) @ 2022-09-22 13:55 UTC (permalink / raw)
  To: qemu-devel, qemu-ppc
  Cc: Daniel P . Berrangé, Thomas Huth, Alex Bennée,
	Daniel Henrique Barboza, Lucas Mateus Castro(alqotel)

This patch series aim to make easier to set up a compilation and CI
environment on PPC64 and PPC64LE machines.

v3:
Changed patch 1 to respect alphabetical order

v2:
This patch series are only patches 2-4 of v1 and an alternative to patch 1
suggested by Daniel.

Lucas Mateus Castro (alqotel) (4):
  scripts/ci/setup: ninja missing from build-environment
  scripts/ci/setup: Fix libxen requirements
  scripts/ci/setup: spice-server only on x86 aarch64
  tests/docker: run script use realpath instead of readlink

 scripts/ci/setup/build-environment.yml | 15 +++++++++++++--
 tests/docker/run                       |  2 +-
 2 files changed, 14 insertions(+), 3 deletions(-)

-- 
2.25.1



^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH v3 1/4] scripts/ci/setup: ninja missing from build-environment
  2022-09-22 13:55 [PATCH v3 0/4] Patch series to set up a ppc64le CI Lucas Mateus Castro(alqotel)
@ 2022-09-22 13:55 ` Lucas Mateus Castro(alqotel)
  2022-09-22 13:55 ` [PATCH v3 2/4] scripts/ci/setup: Fix libxen requirements Lucas Mateus Castro(alqotel)
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 7+ messages in thread
From: Lucas Mateus Castro(alqotel) @ 2022-09-22 13:55 UTC (permalink / raw)
  To: qemu-devel, qemu-ppc
  Cc: Daniel P . Berrangé, Thomas Huth, Alex Bennée,
	Daniel Henrique Barboza, Lucas Mateus Castro (alqotel),
	Philippe Mathieu-Daudé, Wainer dos Santos Moschetta,
	Beraldo Leal

From: "Lucas Mateus Castro (alqotel)" <lucas.araujo@eldorado.org.br>

ninja-build is missing from the RHEL environment, so a system prepared
with that script would still fail to compile QEMU.
Tested on a Fedora 36

Signed-off-by: Lucas Mateus Castro (alqotel) <lucas.araujo@eldorado.org.br>
---
 scripts/ci/setup/build-environment.yml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/scripts/ci/setup/build-environment.yml b/scripts/ci/setup/build-environment.yml
index 232525b91d..b5acaf9118 100644
--- a/scripts/ci/setup/build-environment.yml
+++ b/scripts/ci/setup/build-environment.yml
@@ -153,6 +153,7 @@
           - make
           - mesa-libEGL-devel
           - nettle-devel
+          - ninja-build
           - nmap-ncat
           - perl-Test-Harness
           - pixman-devel
-- 
2.25.1



^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH v3 2/4] scripts/ci/setup: Fix libxen requirements
  2022-09-22 13:55 [PATCH v3 0/4] Patch series to set up a ppc64le CI Lucas Mateus Castro(alqotel)
  2022-09-22 13:55 ` [PATCH v3 1/4] scripts/ci/setup: ninja missing from build-environment Lucas Mateus Castro(alqotel)
@ 2022-09-22 13:55 ` Lucas Mateus Castro(alqotel)
  2022-09-22 13:55 ` [PATCH v3 3/4] scripts/ci/setup: spice-server only on x86 aarch64 Lucas Mateus Castro(alqotel)
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 7+ messages in thread
From: Lucas Mateus Castro(alqotel) @ 2022-09-22 13:55 UTC (permalink / raw)
  To: qemu-devel, qemu-ppc
  Cc: Daniel P . Berrangé, Thomas Huth, Alex Bennée,
	Daniel Henrique Barboza, Lucas Mateus Castro (alqotel),
	Philippe Mathieu-Daudé, Wainer dos Santos Moschetta,
	Beraldo Leal

From: "Lucas Mateus Castro (alqotel)" <lucas.araujo@eldorado.org.br>

XEN hypervisor is only available in ARM and x86, but the yaml only
checked if the architecture is different from s390x, changed it to
a more accurate test.
Tested this change on a Ubuntu 20.04 ppc64le.

Signed-off-by: Lucas Mateus Castro (alqotel) <lucas.araujo@eldorado.org.br>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 scripts/ci/setup/build-environment.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/ci/setup/build-environment.yml b/scripts/ci/setup/build-environment.yml
index b5acaf9118..49292715d3 100644
--- a/scripts/ci/setup/build-environment.yml
+++ b/scripts/ci/setup/build-environment.yml
@@ -97,7 +97,7 @@
         state: present
       when:
         - ansible_facts['distribution'] == 'Ubuntu'
-        - ansible_facts['architecture'] != 's390x'
+        - ansible_facts['architecture'] == 'aarch64' or ansible_facts['architecture'] == 'x86_64'
 
     - name: Install basic packages to build QEMU on Ubuntu 20.04
       package:
-- 
2.25.1



^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH v3 3/4] scripts/ci/setup: spice-server only on x86 aarch64
  2022-09-22 13:55 [PATCH v3 0/4] Patch series to set up a ppc64le CI Lucas Mateus Castro(alqotel)
  2022-09-22 13:55 ` [PATCH v3 1/4] scripts/ci/setup: ninja missing from build-environment Lucas Mateus Castro(alqotel)
  2022-09-22 13:55 ` [PATCH v3 2/4] scripts/ci/setup: Fix libxen requirements Lucas Mateus Castro(alqotel)
@ 2022-09-22 13:55 ` Lucas Mateus Castro(alqotel)
  2022-09-22 13:55 ` [PATCH v3 4/4] tests/docker: run script use realpath instead of readlink Lucas Mateus Castro(alqotel)
  2022-09-22 16:32 ` [PATCH v3 0/4] Patch series to set up a ppc64le CI Alex Bennée
  4 siblings, 0 replies; 7+ messages in thread
From: Lucas Mateus Castro(alqotel) @ 2022-09-22 13:55 UTC (permalink / raw)
  To: qemu-devel, qemu-ppc
  Cc: Daniel P . Berrangé, Thomas Huth, Alex Bennée,
	Daniel Henrique Barboza, Lucas Mateus Castro (alqotel),
	Philippe Mathieu-Daudé, Wainer dos Santos Moschetta,
	Beraldo Leal

From: "Lucas Mateus Castro (alqotel)" <lucas.araujo@eldorado.org.br>

Changed build-environment.yml to only install spice-server on x86_64 and
aarch64 as this package is only available on those architectures.

Signed-off-by: Lucas Mateus Castro (alqotel) <lucas.araujo@eldorado.org.br>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 scripts/ci/setup/build-environment.yml | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/scripts/ci/setup/build-environment.yml b/scripts/ci/setup/build-environment.yml
index 49292715d3..b04c2b7cee 100644
--- a/scripts/ci/setup/build-environment.yml
+++ b/scripts/ci/setup/build-environment.yml
@@ -160,7 +160,6 @@
           - python36
           - rdma-core-devel
           - spice-glib-devel
-          - spice-server
           - systemtap-sdt-devel
           - tar
           - zlib-devel
@@ -168,3 +167,14 @@
       when:
         - ansible_facts['distribution_file_variety'] == 'RedHat'
         - ansible_facts['distribution_version'] == '8'
+
+    - name: Install packages only available on x86 and aarch64
+      dnf:
+        # Spice server not available in ppc64le
+        name:
+          - spice-server
+        state: present
+      when:
+        - ansible_facts['distribution_file_variety'] == 'RedHat'
+        - ansible_facts['distribution_version'] == '8'
+        - ansible_facts['architecture'] == 'aarch64' or ansible_facts['architecture'] == 'x86_64'
-- 
2.25.1



^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH v3 4/4] tests/docker: run script use realpath instead of readlink
  2022-09-22 13:55 [PATCH v3 0/4] Patch series to set up a ppc64le CI Lucas Mateus Castro(alqotel)
                   ` (2 preceding siblings ...)
  2022-09-22 13:55 ` [PATCH v3 3/4] scripts/ci/setup: spice-server only on x86 aarch64 Lucas Mateus Castro(alqotel)
@ 2022-09-22 13:55 ` Lucas Mateus Castro(alqotel)
  2022-09-22 16:32 ` [PATCH v3 0/4] Patch series to set up a ppc64le CI Alex Bennée
  4 siblings, 0 replies; 7+ messages in thread
From: Lucas Mateus Castro(alqotel) @ 2022-09-22 13:55 UTC (permalink / raw)
  To: qemu-devel, qemu-ppc
  Cc: Daniel P . Berrangé, Thomas Huth, Alex Bennée,
	Daniel Henrique Barboza, Lucas Mateus Castro (alqotel),
	Philippe Mathieu-Daudé, Wainer dos Santos Moschetta,
	Beraldo Leal

From: "Lucas Mateus Castro (alqotel)" <lucas.araujo@eldorado.org.br>

The alpine docker image only comes with busybox, which doesn't have the
'-e' option on its readlink, so change it to 'realpath' to avoid that
problem.

Suggested-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Lucas Mateus Castro (alqotel) <lucas.araujo@eldorado.org.br>
---
 tests/docker/run | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/docker/run b/tests/docker/run
index 421393046b..9eb96129da 100755
--- a/tests/docker/run
+++ b/tests/docker/run
@@ -15,7 +15,7 @@ if test -n "$V"; then
     set -x
 fi
 
-BASE="$(dirname $(readlink -e $0))"
+BASE="$(dirname $(realpath $0))"
 
 # Prepare the environment
 export PATH=/usr/lib/ccache:/usr/lib64/ccache:$PATH
-- 
2.25.1



^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH v3 0/4] Patch series to set up a ppc64le CI
  2022-09-22 13:55 [PATCH v3 0/4] Patch series to set up a ppc64le CI Lucas Mateus Castro(alqotel)
                   ` (3 preceding siblings ...)
  2022-09-22 13:55 ` [PATCH v3 4/4] tests/docker: run script use realpath instead of readlink Lucas Mateus Castro(alqotel)
@ 2022-09-22 16:32 ` Alex Bennée
  2022-09-22 16:47   ` Lucas Mateus Martins Araujo e Castro
  4 siblings, 1 reply; 7+ messages in thread
From: Alex Bennée @ 2022-09-22 16:32 UTC (permalink / raw)
  To: Lucas Mateus Castro(alqotel)
  Cc: qemu-devel, qemu-ppc, Daniel P . Berrangé, Thomas Huth,
	Daniel Henrique Barboza


"Lucas Mateus Castro(alqotel)" <lucas.araujo@eldorado.org.br> writes:

> This patch series aim to make easier to set up a compilation and CI
> environment on PPC64 and PPC64LE machines.

Queued to testing/next, thanks.

Do we have a donated ppc64 machine to add to the custom runners?

> v3:
> Changed patch 1 to respect alphabetical order
>
> v2:
> This patch series are only patches 2-4 of v1 and an alternative to patch 1
> suggested by Daniel.
>
> Lucas Mateus Castro (alqotel) (4):
>   scripts/ci/setup: ninja missing from build-environment
>   scripts/ci/setup: Fix libxen requirements
>   scripts/ci/setup: spice-server only on x86 aarch64
>   tests/docker: run script use realpath instead of readlink
>
>  scripts/ci/setup/build-environment.yml | 15 +++++++++++++--
>  tests/docker/run                       |  2 +-
>  2 files changed, 14 insertions(+), 3 deletions(-)


-- 
Alex Bennée


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v3 0/4] Patch series to set up a ppc64le CI
  2022-09-22 16:32 ` [PATCH v3 0/4] Patch series to set up a ppc64le CI Alex Bennée
@ 2022-09-22 16:47   ` Lucas Mateus Martins Araujo e Castro
  0 siblings, 0 replies; 7+ messages in thread
From: Lucas Mateus Martins Araujo e Castro @ 2022-09-22 16:47 UTC (permalink / raw)
  To: Alex Bennée
  Cc: qemu-devel, qemu-ppc, Daniel P . Berrangé, Thomas Huth,
	Daniel Henrique Barboza



On 22/09/2022 13:32, Alex Bennée wrote:
> "Lucas Mateus Castro(alqotel)" <lucas.araujo@eldorado.org.br> writes:
> 
>> This patch series aim to make easier to set up a compilation and CI
>> environment on PPC64 and PPC64LE machines.
> 
> Queued to testing/next, thanks.
> 
> Do we have a donated ppc64 machine to add to the custom runners?
> 
I probably should have changed the message, this is just a restructuring 
of a patch series originally to set up a CI for PPC64 
(<20220727163632.59806-1-lucas.araujo@eldorado.org.br>), but Daniel 
pointed some uncertainty in the infrastructure originally planned to be 
used for this CI (<e8609bda-865f-42c8-9234-75b082ca9df0@gmail.com>) and 
asked for a resend of patch 1-4 as those were general fixes in scripts I 
found while using them to set up a PPC machine with ansible and run some 
docker tests.
So as of right now this patch series is not about set up a CI for 
PPC64/PPC64LE.
>> v3:
>> Changed patch 1 to respect alphabetical order
>>
>> v2:
>> This patch series are only patches 2-4 of v1 and an alternative to patch 1
>> suggested by Daniel.
>>
>> Lucas Mateus Castro (alqotel) (4):
>>    scripts/ci/setup: ninja missing from build-environment
>>    scripts/ci/setup: Fix libxen requirements
>>    scripts/ci/setup: spice-server only on x86 aarch64
>>    tests/docker: run script use realpath instead of readlink
>>
>>   scripts/ci/setup/build-environment.yml | 15 +++++++++++++--
>>   tests/docker/run                       |  2 +-
>>   2 files changed, 14 insertions(+), 3 deletions(-)
> 
> 
> --
> Alex Bennée

-- 
Lucas Mateus M. Araujo e Castro
Instituto de Pesquisas ELDORADO
<https://www.eldorado.org.br/?utm_campaign=assinatura_de_e-mail&utm_medium=email&utm_source=RD+Station>
Departamento Computação Embarcada
Analista de Software Junior
Aviso Legal - Disclaimer <https://www.eldorado.org.br/disclaimer.html>

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2022-09-22 17:31 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-22 13:55 [PATCH v3 0/4] Patch series to set up a ppc64le CI Lucas Mateus Castro(alqotel)
2022-09-22 13:55 ` [PATCH v3 1/4] scripts/ci/setup: ninja missing from build-environment Lucas Mateus Castro(alqotel)
2022-09-22 13:55 ` [PATCH v3 2/4] scripts/ci/setup: Fix libxen requirements Lucas Mateus Castro(alqotel)
2022-09-22 13:55 ` [PATCH v3 3/4] scripts/ci/setup: spice-server only on x86 aarch64 Lucas Mateus Castro(alqotel)
2022-09-22 13:55 ` [PATCH v3 4/4] tests/docker: run script use realpath instead of readlink Lucas Mateus Castro(alqotel)
2022-09-22 16:32 ` [PATCH v3 0/4] Patch series to set up a ppc64le CI Alex Bennée
2022-09-22 16:47   ` Lucas Mateus Martins Araujo e Castro

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.