From: "Alex Bennée" <alex.bennee@linaro.org>
To: Eric Auger <eric.auger@redhat.com>
Cc: eric.auger.pro@gmail.com, pbonzini@redhat.com,
qemu-arm@nongnu.org, qemu-devel@nongnu.org, mst@redhat.com,
david@gibson.dropbear.id.au, clg@kaod.org, eesposit@redhat.com,
Coiby.Xu@gmail.com, stefanha@redhat.com,
jean-philippe@linaro.org
Subject: Re: [PATCH v3 2/5] tests/qtest/libqos/pci: Introduce pio_limit
Date: Tue, 05 Apr 2022 14:54:20 +0100 [thread overview]
Message-ID: <874k37ljou.fsf@linaro.org> (raw)
In-Reply-To: <20220210145254.157790-3-eric.auger@redhat.com>
Eric Auger <eric.auger@redhat.com> writes:
> At the moment the IO space limit is hardcoded to
> QPCI_PIO_LIMIT = 0x10000. When accesses are performed to a bar,
> the base address of this latter is compared against the limit
> to decide whether we perform an IO or a memory access.
>
> On ARM, we cannot keep this PIO limit as the arm-virt machine
> uses [0x3eff0000, 0x3f000000 ] for the IO space map and we
> are mandated to allocate at 0x0.
>
> Add a new flag in QPCIBar indicating whether it is an IO bar
> or a memory bar. This flag is set on QPCIBar allocation and
> provisionned based on the BAR configuration. Then the new flag
> is used in access functions and in iomap() function.
>
> Signed-off-by: Eric Auger <eric.auger@redhat.com>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
WARNING: multiple messages have this Message-ID (diff)
From: "Alex Bennée" <alex.bennee@linaro.org>
To: Eric Auger <eric.auger@redhat.com>
Cc: eesposit@redhat.com, jean-philippe@linaro.org, mst@redhat.com,
qemu-devel@nongnu.org, Coiby.Xu@gmail.com, qemu-arm@nongnu.org,
clg@kaod.org, stefanha@redhat.com, pbonzini@redhat.com,
eric.auger.pro@gmail.com, david@gibson.dropbear.id.au
Subject: Re: [PATCH v3 2/5] tests/qtest/libqos/pci: Introduce pio_limit
Date: Tue, 05 Apr 2022 14:54:20 +0100 [thread overview]
Message-ID: <874k37ljou.fsf@linaro.org> (raw)
In-Reply-To: <20220210145254.157790-3-eric.auger@redhat.com>
Eric Auger <eric.auger@redhat.com> writes:
> At the moment the IO space limit is hardcoded to
> QPCI_PIO_LIMIT = 0x10000. When accesses are performed to a bar,
> the base address of this latter is compared against the limit
> to decide whether we perform an IO or a memory access.
>
> On ARM, we cannot keep this PIO limit as the arm-virt machine
> uses [0x3eff0000, 0x3f000000 ] for the IO space map and we
> are mandated to allocate at 0x0.
>
> Add a new flag in QPCIBar indicating whether it is an IO bar
> or a memory bar. This flag is set on QPCIBar allocation and
> provisionned based on the BAR configuration. Then the new flag
> is used in access functions and in iomap() function.
>
> Signed-off-by: Eric Auger <eric.auger@redhat.com>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
next prev parent reply other threads:[~2022-04-05 13:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-10 14:52 [PATCH v3 0/5] qtests/libqos: Allow PCI tests to be run with virt-machine Eric Auger
2022-02-10 14:52 ` [PATCH v3 1/5] tests/qtest/vhost-user-test.c: Use vhostforce=on Eric Auger
2022-02-10 14:52 ` [PATCH v3 2/5] tests/qtest/libqos/pci: Introduce pio_limit Eric Auger
2022-04-05 13:54 ` Alex Bennée [this message]
2022-04-05 13:54 ` Alex Bennée
2022-02-10 14:52 ` [PATCH v3 3/5] tests/qtest/libqos: Skip hotplug tests if pci root bus is not hotpluggable Eric Auger
2022-04-05 14:36 ` Alex Bennée
2022-04-05 14:36 ` Alex Bennée
2022-02-10 14:52 ` [PATCH v3 4/5] tests/qtest/vhost-user-blk-test: Temporary hack to get tests passing on aarch64 Eric Auger
2022-04-06 17:34 ` Alex Bennée
2022-04-06 17:34 ` Alex Bennée
2022-04-07 8:36 ` Eric Auger
2022-04-07 8:36 ` Eric Auger
2022-02-10 14:52 ` [PATCH v3 5/5] tests/qtest/libqos: Add generic pci host bridge in arm-virt machine Eric Auger
2022-03-06 10:53 ` Michael S. Tsirkin
2022-03-06 10:50 ` [PATCH v3 0/5] qtests/libqos: Allow PCI tests to be run with virt-machine Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874k37ljou.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=Coiby.Xu@gmail.com \
--cc=clg@kaod.org \
--cc=david@gibson.dropbear.id.au \
--cc=eesposit@redhat.com \
--cc=eric.auger.pro@gmail.com \
--cc=eric.auger@redhat.com \
--cc=jean-philippe@linaro.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.