From: "Alex Bennée" <alex.bennee@linaro.org>
To: Thomas Huth <thuth@redhat.com>
Cc: David Hildenbrand <david@redhat.com>,
Eduardo Habkost <eduardo@habkost.net>,
Richard Henderson <richard.henderson@linaro.org>,
qemu-devel@nongnu.org,
"open list:S390 TCG CPUs" <qemu-s390x@nongnu.org>,
"open list:ARM TCG CPUs" <qemu-arm@nongnu.org>,
Paolo Bonzini <pbonzini@redhat.com>,
peter.maydell@linaro.org
Subject: Re: [PULL 13/18] tests/tcg: add vectorised sha512 versions
Date: Wed, 09 Mar 2022 11:18:02 +0000 [thread overview]
Message-ID: <874k4774p6.fsf@linaro.org> (raw)
In-Reply-To: <162f6b45-8b3a-9672-2e5e-f28e867eff31@redhat.com>
Thomas Huth <thuth@redhat.com> writes:
> On 01/03/2022 10.47, Alex Bennée wrote:
>> This builds vectorised versions of sha512 to exercise the vector code:
>> - aarch64 (AdvSimd)
>> - i386 (SSE)
>> - s390x (MVX)
>> - ppc64/ppc64le (power10 vectors)
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>> Message-Id: <20220225172021.3493923-14-alex.bennee@linaro.org>
> [...]
>> diff --git a/tests/tcg/s390x/Makefile.target b/tests/tcg/s390x/Makefile.target
>> index 1a7238b4eb..e53b599b22 100644
>> --- a/tests/tcg/s390x/Makefile.target
>> +++ b/tests/tcg/s390x/Makefile.target
>> @@ -25,3 +25,12 @@ run-gdbstub-signals-s390x: signals-s390x
>> EXTRA_RUNS += run-gdbstub-signals-s390x
>> endif
>> +
>> +# MVX versions of sha512
>> +sha512-mvx: CFLAGS=-march=z13 -mvx -O3
>> +sha512-mvx: sha512.c
>> + $(CC) $(CFLAGS) $(EXTRA_CFLAGS) $< -o $@ $(LDFLAGS)
>> +
>> +run-sha512-mvx: QEMU_OPTS+=-cpu max
>> +
>> +TESTS+=sha512-mvx
>
> When running "make check-tcg" on my s390x host, I'm now getting this error:
>
> TEST sha512-mvx on s390x
> qemu-s390x: warning: 'msa5-base' requires 'kimd-sha-512'.
> qemu-s390x: warning: 'msa5-base' requires 'klmd-sha-512'.
> make[2]: *** [../Makefile.target:156: run-sha512-mvx] Error 10
Hmm I see the warning but it doesn't fail for me. Dropping -cpu max
makes the working go away. I thought we needed it to ensure the CPU
model had s390x's vector instructions enabled.
> Any ideas how to fix this?
>
> Thomas
--
Alex Bennée
WARNING: multiple messages have this Message-ID (diff)
From: "Alex Bennée" <alex.bennee@linaro.org>
To: Thomas Huth <thuth@redhat.com>
Cc: Eduardo Habkost <eduardo@habkost.net>,
peter.maydell@linaro.org, David Hildenbrand <david@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
qemu-devel@nongnu.org,
"open list:S390 TCG CPUs" <qemu-s390x@nongnu.org>,
"open list:ARM TCG CPUs" <qemu-arm@nongnu.org>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PULL 13/18] tests/tcg: add vectorised sha512 versions
Date: Wed, 09 Mar 2022 11:18:02 +0000 [thread overview]
Message-ID: <874k4774p6.fsf@linaro.org> (raw)
In-Reply-To: <162f6b45-8b3a-9672-2e5e-f28e867eff31@redhat.com>
Thomas Huth <thuth@redhat.com> writes:
> On 01/03/2022 10.47, Alex Bennée wrote:
>> This builds vectorised versions of sha512 to exercise the vector code:
>> - aarch64 (AdvSimd)
>> - i386 (SSE)
>> - s390x (MVX)
>> - ppc64/ppc64le (power10 vectors)
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>> Message-Id: <20220225172021.3493923-14-alex.bennee@linaro.org>
> [...]
>> diff --git a/tests/tcg/s390x/Makefile.target b/tests/tcg/s390x/Makefile.target
>> index 1a7238b4eb..e53b599b22 100644
>> --- a/tests/tcg/s390x/Makefile.target
>> +++ b/tests/tcg/s390x/Makefile.target
>> @@ -25,3 +25,12 @@ run-gdbstub-signals-s390x: signals-s390x
>> EXTRA_RUNS += run-gdbstub-signals-s390x
>> endif
>> +
>> +# MVX versions of sha512
>> +sha512-mvx: CFLAGS=-march=z13 -mvx -O3
>> +sha512-mvx: sha512.c
>> + $(CC) $(CFLAGS) $(EXTRA_CFLAGS) $< -o $@ $(LDFLAGS)
>> +
>> +run-sha512-mvx: QEMU_OPTS+=-cpu max
>> +
>> +TESTS+=sha512-mvx
>
> When running "make check-tcg" on my s390x host, I'm now getting this error:
>
> TEST sha512-mvx on s390x
> qemu-s390x: warning: 'msa5-base' requires 'kimd-sha-512'.
> qemu-s390x: warning: 'msa5-base' requires 'klmd-sha-512'.
> make[2]: *** [../Makefile.target:156: run-sha512-mvx] Error 10
Hmm I see the warning but it doesn't fail for me. Dropping -cpu max
makes the working go away. I thought we needed it to ensure the CPU
model had s390x's vector instructions enabled.
> Any ideas how to fix this?
>
> Thomas
--
Alex Bennée
next prev parent reply other threads:[~2022-03-09 11:20 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 9:46 [PULL 00/18] testing and semihosting updates Alex Bennée
2022-03-01 9:46 ` [PULL 01/18] tests/docker: restore TESTS/IMAGES filtering Alex Bennée
2022-03-01 9:46 ` [PULL 02/18] tests/docker: add NOUSER for alpine image Alex Bennée
2022-03-01 9:47 ` [PULL 03/18] tests/lcitool: update to latest version Alex Bennée
2022-03-01 9:47 ` [PULL 04/18] tests/docker: update debian-arm64-cross with lcitool Alex Bennée
2022-03-01 9:47 ` [PULL 05/18] tests/docker: update debian-s390x-cross " Alex Bennée
2022-03-01 9:47 ` [PULL 06/18] tests/docker: introduce debian-riscv64-test-cross Alex Bennée
2022-03-01 9:47 ` [PULL 07/18] scripts/ci: add build env rules for aarch32 on aarch64 Alex Bennée
2022-03-01 9:47 ` [PULL 08/18] scripts/ci: allow for a secondary runner Alex Bennée
2022-03-01 9:47 ` [PULL 09/18] gitlab: add a new aarch32 custom runner definition Alex Bennée
2022-03-01 9:47 ` [PULL 10/18] tests/tcg/ppc64: clean-up handling of byte-reverse Alex Bennée
2022-03-01 9:47 ` [PULL 11/18] tests/tcg: build sha1-vector with O3 and compare Alex Bennée
2022-03-01 9:47 ` Alex Bennée
2022-03-01 9:47 ` [PULL 12/18] tests/tcg: add sha512 test Alex Bennée
2022-03-01 9:47 ` [PULL 13/18] tests/tcg: add vectorised sha512 versions Alex Bennée
2022-03-01 9:47 ` Alex Bennée
2022-03-07 8:54 ` Thomas Huth
2022-03-07 8:54 ` Thomas Huth
2022-03-09 11:18 ` Alex Bennée [this message]
2022-03-09 11:18 ` Alex Bennée
2022-03-01 9:47 ` [PULL 14/18] travis.yml: Update the s390x jobs to Ubuntu Focal Alex Bennée
2022-03-01 9:47 ` [PULL 15/18] gitlab: upgrade the job definition for s390x to 20.04 Alex Bennée
2022-03-01 9:47 ` [PULL 16/18] tests/tcg: completely disable threadcount for sh4 Alex Bennée
2022-03-01 9:47 ` [PULL 17/18] semihosting/arm-compat: replace heuristic for softmmu SYS_HEAPINFO Alex Bennée
2022-03-01 9:47 ` [PULL 18/18] tests/tcg: port SYS_HEAPINFO to a system test Alex Bennée
2022-03-01 9:47 ` Alex Bennée
2022-03-02 12:38 ` [PULL 00/18] testing and semihosting updates Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874k4774p6.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=david@redhat.com \
--cc=eduardo@habkost.net \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.