From: Eric W. Biederman <ebiederm@xmission.com>
To: kbuild-all@lists.01.org
Subject: [PATCH] objtool: Add a missing comma to avoid string concatenation
Date: Wed, 15 Dec 2021 11:38:40 -0600 [thread overview]
Message-ID: <874k79sr8f.fsf_-_@email.froward.int.ebiederm.org> (raw)
In-Reply-To: <db094a6d-48d6-7641-b8c3-fc338bd779b0@intel.com>
[-- Attachment #1: Type: text/plain, Size: 1394 bytes --]
Recently the kbuild robot reported two new errors:
>> lib/kunit/kunit-example-test.o: warning: objtool: .text.unlikely: unexpected end of section
>> arch/x86/kernel/dumpstack.o: warning: objtool: oops_end() falls through to next function show_opcodes()
I don't know why they did not occur in my test setup but after digging
it I realized I had accidentally dropped a comma in
tools/objtool/check.c when I renamed rewind_stack_do_exit to
rewind_stack_and_make_dead.
Add that comma back to fix objtool errors.
Link: https://lkml.kernel.org/r/202112140949.Uq5sFKR1-lkp(a)intel.com
Fixes: 0e25498f8cd4 ("exit: Add and use make_task_dead.")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
---
For the record this is my trivial objtool fix.
tools/objtool/check.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/objtool/check.c b/tools/objtool/check.c
index 282273a1ffa5..3fc2c57f6124 100644
--- a/tools/objtool/check.c
+++ b/tools/objtool/check.c
@@ -177,7 +177,7 @@ static bool __dead_end_function(struct objtool_file *file, struct symbol *func,
"fortify_panic",
"usercopy_abort",
"machine_real_restart",
- "rewind_stack_and_make_dead"
+ "rewind_stack_and_make_dead",
"kunit_try_catch_throw",
"xen_start_kernel",
"cpu_bringup_and_idle",
--
2.29.2
WARNING: multiple messages have this Message-ID (diff)
From: ebiederm@xmission.com (Eric W. Biederman)
To: Rong Chen <rong.a.chen@intel.com>
Cc: kernel test robot <lkp@intel.com>,
kbuild-all@lists.01.org, linux-kernel@vger.kernel.org
Subject: [PATCH] objtool: Add a missing comma to avoid string concatenation
Date: Wed, 15 Dec 2021 11:38:40 -0600 [thread overview]
Message-ID: <874k79sr8f.fsf_-_@email.froward.int.ebiederm.org> (raw)
In-Reply-To: <db094a6d-48d6-7641-b8c3-fc338bd779b0@intel.com> (Rong Chen's message of "Wed, 15 Dec 2021 13:22:21 +0800")
Recently the kbuild robot reported two new errors:
>> lib/kunit/kunit-example-test.o: warning: objtool: .text.unlikely: unexpected end of section
>> arch/x86/kernel/dumpstack.o: warning: objtool: oops_end() falls through to next function show_opcodes()
I don't know why they did not occur in my test setup but after digging
it I realized I had accidentally dropped a comma in
tools/objtool/check.c when I renamed rewind_stack_do_exit to
rewind_stack_and_make_dead.
Add that comma back to fix objtool errors.
Link: https://lkml.kernel.org/r/202112140949.Uq5sFKR1-lkp@intel.com
Fixes: 0e25498f8cd4 ("exit: Add and use make_task_dead.")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
---
For the record this is my trivial objtool fix.
tools/objtool/check.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/objtool/check.c b/tools/objtool/check.c
index 282273a1ffa5..3fc2c57f6124 100644
--- a/tools/objtool/check.c
+++ b/tools/objtool/check.c
@@ -177,7 +177,7 @@ static bool __dead_end_function(struct objtool_file *file, struct symbol *func,
"fortify_panic",
"usercopy_abort",
"machine_real_restart",
- "rewind_stack_and_make_dead"
+ "rewind_stack_and_make_dead",
"kunit_try_catch_throw",
"xen_start_kernel",
"cpu_bringup_and_idle",
--
2.29.2
next prev parent reply other threads:[~2021-12-15 17:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-14 2:03 [ebiederm-user-namespace:signal-for-v5.17 4/12] arch/x86/kernel/dumpstack.o: warning: objtool: oops_end() falls through to next function show_opcodes() kernel test robot
2021-12-14 2:03 ` kernel test robot
2021-12-14 17:29 ` Eric W. Biederman
2021-12-14 17:29 ` Eric W. Biederman
2021-12-15 1:35 ` Rong Chen
2021-12-15 1:35 ` [kbuild-all] " Rong Chen
2021-12-15 4:48 ` Eric W. Biederman
2021-12-15 4:48 ` [kbuild-all] " Eric W. Biederman
2021-12-15 5:22 ` Rong Chen
2021-12-15 5:22 ` [kbuild-all] " Rong Chen
2021-12-15 17:36 ` Eric W. Biederman
2021-12-15 17:36 ` [kbuild-all] " Eric W. Biederman
2021-12-15 17:38 ` Eric W. Biederman [this message]
2021-12-15 17:38 ` [PATCH] objtool: Add a missing comma to avoid string concatenation Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874k79sr8f.fsf_-_@email.froward.int.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.