From: Kalle Valo <kvalo@codeaurora.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Felix Fietkau <nbd@nbd.name>,
Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>,
Arnd Bergmann <arnd@arndb.de>, Ryder Lee <ryder.lee@mediatek.com>,
Shayne Chen <shayne.chen@mediatek.com>,
Sean Wang <sean.wang@mediatek.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
YN Chen <YN.Chen@mediatek.com>, Deren Wu <deren.wu@mediatek.com>,
Leon Yen <Leon.Yen@mediatek.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mt76: mt7663s: fix link error with CONFIG_PM=n
Date: Wed, 27 Oct 2021 09:20:03 +0300 [thread overview]
Message-ID: <874k939egc.fsf@codeaurora.org> (raw)
In-Reply-To: <20211026083326.3421663-1-arnd@kernel.org> (Arnd Bergmann's message of "Tue, 26 Oct 2021 10:33:09 +0200")
Arnd Bergmann <arnd@kernel.org> writes:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The generic register access functions are compiled conditionally,
> causing a link failure in some randconfig builds:
>
> ERROR: modpost: "mt76_connac_mcu_reg_wr" [drivers/net/wireless/mediatek/mt76/mt7615/mt7663s.ko] undefined!
> ERROR: modpost: "mt76_connac_mcu_reg_rr" [drivers/net/wireless/mediatek/mt76/mt7615/mt7663s.ko] undefined!
>
> Move them out of the #ifdef block.
>
> Fixes: 02fbf8199f6e ("mt76: mt7663s: rely on mcu reg access utility")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Felix already submitted an identical patch:
https://patchwork.kernel.org/project/linux-wireless/patch/20211023112407.26448-1-nbd@nbd.name/
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Felix Fietkau <nbd@nbd.name>,
Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>,
Arnd Bergmann <arnd@arndb.de>, Ryder Lee <ryder.lee@mediatek.com>,
Shayne Chen <shayne.chen@mediatek.com>,
Sean Wang <sean.wang@mediatek.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
YN Chen <YN.Chen@mediatek.com>, Deren Wu <deren.wu@mediatek.com>,
Leon Yen <Leon.Yen@mediatek.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mt76: mt7663s: fix link error with CONFIG_PM=n
Date: Wed, 27 Oct 2021 09:20:03 +0300 [thread overview]
Message-ID: <874k939egc.fsf@codeaurora.org> (raw)
In-Reply-To: <20211026083326.3421663-1-arnd@kernel.org> (Arnd Bergmann's message of "Tue, 26 Oct 2021 10:33:09 +0200")
Arnd Bergmann <arnd@kernel.org> writes:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The generic register access functions are compiled conditionally,
> causing a link failure in some randconfig builds:
>
> ERROR: modpost: "mt76_connac_mcu_reg_wr" [drivers/net/wireless/mediatek/mt76/mt7615/mt7663s.ko] undefined!
> ERROR: modpost: "mt76_connac_mcu_reg_rr" [drivers/net/wireless/mediatek/mt76/mt7615/mt7663s.ko] undefined!
>
> Move them out of the #ifdef block.
>
> Fixes: 02fbf8199f6e ("mt76: mt7663s: rely on mcu reg access utility")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Felix already submitted an identical patch:
https://patchwork.kernel.org/project/linux-wireless/patch/20211023112407.26448-1-nbd@nbd.name/
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2021-10-27 6:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-26 8:33 [PATCH] mt76: mt7663s: fix link error with CONFIG_PM=n Arnd Bergmann
2021-10-26 8:33 ` Arnd Bergmann
2021-10-26 8:33 ` Arnd Bergmann
2021-10-27 6:20 ` Kalle Valo [this message]
2021-10-27 6:20 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874k939egc.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=Leon.Yen@mediatek.com \
--cc=YN.Chen@mediatek.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=davem@davemloft.net \
--cc=deren.wu@mediatek.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi83@gmail.com \
--cc=matthias.bgg@gmail.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=ryder.lee@mediatek.com \
--cc=sean.wang@mediatek.com \
--cc=shayne.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.