From: Kurt Kanzenbach <kurt@linutronix.de>
To: Jesper Dangaard Brouer <jbrouer@redhat.com>
Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
Sven Auhagen <sven.auhagen@voleatech.de>,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
bpf@vger.kernel.org,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Lorenzo Bianconi <lorenzo@kernel.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Richard Cochran <richardcochran@gmail.com>
Subject: Re: [PATCH net] igb: Fix XDP with PTP enabled
Date: Thu, 15 Apr 2021 14:16:36 +0200 [thread overview]
Message-ID: <874kg7hhej.fsf@kurt> (raw)
In-Reply-To: <20210415140438.60221f21@carbon>
[-- Attachment #1: Type: text/plain, Size: 947 bytes --]
On Thu Apr 15 2021, Jesper Dangaard Brouer wrote:
> On Thu, 15 Apr 2021 11:21:45 +0200
> Kurt Kanzenbach <kurt@linutronix.de> wrote:
>
>> When using native XDP with the igb driver, the XDP frame data doesn't point to
>> the beginning of the packet. It's off by 16 bytes. Everything works as expected
>> with XDP skb mode.
>>
>> Actually these 16 bytes are used to store the packet timestamps. Therefore, pull
>> the timestamp before executing any XDP operations and adjust all other code
>> accordingly. The igc driver does it like that as well.
>>
>> Tested with Intel i210 card and AF_XDP sockets.
>
> Doesn't the i210 card use the igc driver?
> This change is for igb driver.
Nope. igb is for i210 and igc is for the newer Intel i225 NICs.
|01:00.0 Ethernet controller: Intel Corporation I210 Gigabit Network Connection (rev 03)
|[...]
| Kernel driver in use: igb
| Kernel modules: igb
Thanks,
Kurt
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Kurt Kanzenbach <kurt@linutronix.de>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH net] igb: Fix XDP with PTP enabled
Date: Thu, 15 Apr 2021 14:16:36 +0200 [thread overview]
Message-ID: <874kg7hhej.fsf@kurt> (raw)
In-Reply-To: <20210415140438.60221f21@carbon>
On Thu Apr 15 2021, Jesper Dangaard Brouer wrote:
> On Thu, 15 Apr 2021 11:21:45 +0200
> Kurt Kanzenbach <kurt@linutronix.de> wrote:
>
>> When using native XDP with the igb driver, the XDP frame data doesn't point to
>> the beginning of the packet. It's off by 16 bytes. Everything works as expected
>> with XDP skb mode.
>>
>> Actually these 16 bytes are used to store the packet timestamps. Therefore, pull
>> the timestamp before executing any XDP operations and adjust all other code
>> accordingly. The igc driver does it like that as well.
>>
>> Tested with Intel i210 card and AF_XDP sockets.
>
> Doesn't the i210 card use the igc driver?
> This change is for igb driver.
Nope. igb is for i210 and igc is for the newer Intel i225 NICs.
|01:00.0 Ethernet controller: Intel Corporation I210 Gigabit Network Connection (rev 03)
|[...]
| Kernel driver in use: igb
| Kernel modules: igb
Thanks,
Kurt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20210415/19349a3d/attachment-0001.asc>
next prev parent reply other threads:[~2021-04-15 12:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 9:21 [PATCH net] igb: Fix XDP with PTP enabled Kurt Kanzenbach
2021-04-15 9:21 ` [Intel-wired-lan] " Kurt Kanzenbach
2021-04-15 11:24 ` Lorenzo Bianconi
2021-04-15 11:24 ` [Intel-wired-lan] " Lorenzo Bianconi
2021-04-15 12:19 ` Kurt Kanzenbach
2021-04-15 12:19 ` [Intel-wired-lan] " Kurt Kanzenbach
2021-04-15 12:04 ` Jesper Dangaard Brouer
2021-04-15 12:04 ` [Intel-wired-lan] " Jesper Dangaard Brouer
2021-04-15 12:16 ` Kurt Kanzenbach [this message]
2021-04-15 12:16 ` Kurt Kanzenbach
2021-04-15 12:51 ` Jesper Dangaard Brouer
2021-04-15 12:51 ` [Intel-wired-lan] " Jesper Dangaard Brouer
2021-04-15 13:20 ` Kurt Kanzenbach
2021-04-15 13:20 ` [Intel-wired-lan] " Kurt Kanzenbach
2021-04-15 12:17 ` Nick Lowe
2021-04-15 12:17 ` [Intel-wired-lan] " Nick Lowe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874kg7hhej.fsf@kurt \
--to=kurt@linutronix.de \
--cc=anthony.l.nguyen@intel.com \
--cc=ast@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=hawk@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jbrouer@redhat.com \
--cc=jesse.brandeburg@intel.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=lorenzo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=sven.auhagen@voleatech.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.