All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Lyude Paul <lyude@redhat.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Dave Airlie <airlied@gmail.com>,
	intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH v3 0/9] drm/i915: Add support for Intel's eDP backlight controls
Date: Wed, 23 Dec 2020 17:53:15 +0200	[thread overview]
Message-ID: <874kkco6xg.fsf@intel.com> (raw)
In-Reply-To: <20201204223603.249878-1-lyude@redhat.com>

On Fri, 04 Dec 2020, Lyude Paul <lyude@redhat.com> wrote:
> A while ago we ran into issues while trying to enable the eDP backlight
> control interface as defined by VESA, in order to make the DPCD
> backlight controls on newer laptop panels work. The issue ended up being
> much more complicated however, as we also apparently needed to add
> support for an Intel-specific DPCD backlight control interface as the
> VESA interface is broken on many laptop panels. For lack of a better
> name, we just call this the Intel HDR backlight interface.
>
> While this only adds support for the SDR backlight mode (I think), this
> will fix a lot of user's laptop panels that we weren't able to properly
> automatically detect DPCD backlight controls on previously.
>
> Series-wide changes in v3:
> * Pass down brightness values to enable/disable backlight callbacks in a
>   separate patch
> * Rebase
>
> Lyude Paul (9):
>   drm/i915/dp: Program source OUI on eDP panels
>   drm/i915: Rename pwm_* backlight callbacks to ext_pwm_*
>   drm/i915: Pass down brightness values to enable/disable backlight
>     callbacks
>   drm/i915/dp: Rename eDP VESA backlight interface functions
>   drm/i915/dp: Add register definitions for Intel HDR backlight
>     interface

Pushed the above patches to din to move things forward, thanks for the
patches.

Still looking at the below.

BR,
Jani.


>   drm/i915: Keep track of pwm-related backlight hooks separately
>   drm/i915/dp: Enable Intel's HDR backlight interface (only SDR for now)
>   drm/i915/dp: Allow forcing specific interfaces through
>     enable_dpcd_backlight
>   drm/dp: Revert "drm/dp: Introduce EDID-based quirks"
>
>  drivers/gpu/drm/drm_dp_helper.c               |  83 +---
>  drivers/gpu/drm/drm_dp_mst_topology.c         |   3 +-
>  .../drm/i915/display/intel_display_types.h    |  18 +-
>  drivers/gpu/drm/i915/display/intel_dp.c       |  42 +-
>  .../drm/i915/display/intel_dp_aux_backlight.c | 394 +++++++++++++---
>  drivers/gpu/drm/i915/display/intel_dp_mst.c   |   3 +-
>  .../i915/display/intel_dsi_dcs_backlight.c    |   7 +-
>  drivers/gpu/drm/i915/display/intel_panel.c    | 435 ++++++++++--------
>  drivers/gpu/drm/i915/display/intel_panel.h    |   4 +
>  drivers/gpu/drm/i915/display/intel_psr.c      |   2 +-
>  drivers/gpu/drm/i915/i915_params.c            |   2 +-
>  include/drm/drm_dp_helper.h                   |  21 +-
>  12 files changed, 655 insertions(+), 359 deletions(-)

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Lyude Paul <lyude@redhat.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Dave Airlie <airlied@gmail.com>,
	intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v3 0/9] drm/i915: Add support for Intel's eDP backlight controls
Date: Wed, 23 Dec 2020 17:53:15 +0200	[thread overview]
Message-ID: <874kkco6xg.fsf@intel.com> (raw)
In-Reply-To: <20201204223603.249878-1-lyude@redhat.com>

On Fri, 04 Dec 2020, Lyude Paul <lyude@redhat.com> wrote:
> A while ago we ran into issues while trying to enable the eDP backlight
> control interface as defined by VESA, in order to make the DPCD
> backlight controls on newer laptop panels work. The issue ended up being
> much more complicated however, as we also apparently needed to add
> support for an Intel-specific DPCD backlight control interface as the
> VESA interface is broken on many laptop panels. For lack of a better
> name, we just call this the Intel HDR backlight interface.
>
> While this only adds support for the SDR backlight mode (I think), this
> will fix a lot of user's laptop panels that we weren't able to properly
> automatically detect DPCD backlight controls on previously.
>
> Series-wide changes in v3:
> * Pass down brightness values to enable/disable backlight callbacks in a
>   separate patch
> * Rebase
>
> Lyude Paul (9):
>   drm/i915/dp: Program source OUI on eDP panels
>   drm/i915: Rename pwm_* backlight callbacks to ext_pwm_*
>   drm/i915: Pass down brightness values to enable/disable backlight
>     callbacks
>   drm/i915/dp: Rename eDP VESA backlight interface functions
>   drm/i915/dp: Add register definitions for Intel HDR backlight
>     interface

Pushed the above patches to din to move things forward, thanks for the
patches.

Still looking at the below.

BR,
Jani.


>   drm/i915: Keep track of pwm-related backlight hooks separately
>   drm/i915/dp: Enable Intel's HDR backlight interface (only SDR for now)
>   drm/i915/dp: Allow forcing specific interfaces through
>     enable_dpcd_backlight
>   drm/dp: Revert "drm/dp: Introduce EDID-based quirks"
>
>  drivers/gpu/drm/drm_dp_helper.c               |  83 +---
>  drivers/gpu/drm/drm_dp_mst_topology.c         |   3 +-
>  .../drm/i915/display/intel_display_types.h    |  18 +-
>  drivers/gpu/drm/i915/display/intel_dp.c       |  42 +-
>  .../drm/i915/display/intel_dp_aux_backlight.c | 394 +++++++++++++---
>  drivers/gpu/drm/i915/display/intel_dp_mst.c   |   3 +-
>  .../i915/display/intel_dsi_dcs_backlight.c    |   7 +-
>  drivers/gpu/drm/i915/display/intel_panel.c    | 435 ++++++++++--------
>  drivers/gpu/drm/i915/display/intel_panel.h    |   4 +
>  drivers/gpu/drm/i915/display/intel_psr.c      |   2 +-
>  drivers/gpu/drm/i915/i915_params.c            |   2 +-
>  include/drm/drm_dp_helper.h                   |  21 +-
>  12 files changed, 655 insertions(+), 359 deletions(-)

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2020-12-23 15:53 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-04 22:35 [Intel-gfx] [PATCH v3 0/9] drm/i915: Add support for Intel's eDP backlight controls Lyude Paul
2020-12-04 22:35 ` Lyude Paul
2020-12-04 22:35 ` [Intel-gfx] [PATCH v3 1/9] drm/i915/dp: Program source OUI on eDP panels Lyude Paul
2020-12-04 22:35   ` Lyude Paul
2020-12-04 22:35   ` Lyude Paul
2020-12-04 22:35 ` [Intel-gfx] [PATCH v3 2/9] drm/i915: Rename pwm_* backlight callbacks to ext_pwm_* Lyude Paul
2020-12-04 22:35   ` Lyude Paul
2020-12-04 22:35   ` Lyude Paul
2020-12-04 22:35 ` [Intel-gfx] [PATCH v3 3/9] drm/i915: Pass down brightness values to enable/disable backlight callbacks Lyude Paul
2020-12-04 22:35   ` Lyude Paul
2020-12-04 22:35   ` Lyude Paul
2020-12-04 22:35 ` [Intel-gfx] [PATCH v3 4/9] drm/i915: Keep track of pwm-related backlight hooks separately Lyude Paul
2020-12-04 22:35   ` Lyude Paul
2020-12-04 22:35   ` Lyude Paul
2020-12-23 16:37   ` [Intel-gfx] " Jani Nikula
2020-12-23 16:37     ` Jani Nikula
2020-12-23 16:37     ` Jani Nikula
2021-01-05 21:21     ` [Intel-gfx] " Lyude Paul
2021-01-05 21:21       ` Lyude Paul
2021-01-05 21:21       ` Lyude Paul
2020-12-04 22:35 ` [Intel-gfx] [PATCH v3 5/9] drm/i915/dp: Rename eDP VESA backlight interface functions Lyude Paul
2020-12-04 22:35   ` Lyude Paul
2020-12-04 22:35   ` Lyude Paul
2020-12-04 22:36 ` [Intel-gfx] [PATCH v3 6/9] drm/i915/dp: Add register definitions for Intel HDR backlight interface Lyude Paul
2020-12-04 22:36   ` Lyude Paul
2020-12-04 22:36   ` Lyude Paul
2020-12-04 22:36 ` [Intel-gfx] [PATCH v3 7/9] drm/i915/dp: Enable Intel's HDR backlight interface (only SDR for now) Lyude Paul
2020-12-04 22:36   ` Lyude Paul
2020-12-04 22:36   ` Lyude Paul
2020-12-23 17:05   ` [Intel-gfx] " Jani Nikula
2020-12-23 17:05     ` Jani Nikula
2020-12-23 17:05     ` Jani Nikula
2020-12-04 22:36 ` [Intel-gfx] [PATCH v3 8/9] drm/i915/dp: Allow forcing specific interfaces through enable_dpcd_backlight Lyude Paul
2020-12-04 22:36   ` Lyude Paul
2020-12-04 22:36   ` Lyude Paul
2020-12-23 17:12   ` [Intel-gfx] " Jani Nikula
2020-12-23 17:12     ` Jani Nikula
2020-12-23 17:12     ` Jani Nikula
2020-12-04 22:36 ` [Intel-gfx] [PATCH v3 9/9] drm/dp: Revert "drm/dp: Introduce EDID-based quirks" Lyude Paul
2020-12-04 22:36   ` Lyude Paul
2020-12-04 22:36   ` Lyude Paul
2020-12-05  8:12   ` [Intel-gfx] " kernel test robot
2020-12-05  8:12     ` kernel test robot
2020-12-05  8:12     ` kernel test robot
2020-12-05  8:12     ` kernel test robot
2020-12-04 22:46 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Add support for Intel's eDP backlight controls (rev3) Patchwork
2020-12-04 23:17 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-12-05  1:52 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2020-12-10 19:52 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Add support for Intel's eDP backlight controls (rev4) Patchwork
2020-12-10 19:57 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork
2020-12-10 20:20 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-12-10 22:31 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-12-17 21:26 ` [Intel-gfx] [PATCH v3 0/9] drm/i915: Add support for Intel's eDP backlight controls Lyude Paul
2020-12-17 21:26   ` Lyude Paul
2020-12-23 15:53 ` Jani Nikula [this message]
2020-12-23 15:53   ` Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874kkco6xg.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=airlied@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=lyude@redhat.com \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.