[PATCH] drm/dp: update kernel-doc line comments

[PATCH] drm/dp: update kernel-doc line comments

[Tian Tao]

Update kernel-doc line comments to fix warnings reported by make W=1.

drivers/gpu/drm/drm_dp_helper.c:1036: warning: Function parameter or member
'dpcd' not described in 'drm_dp_subconnector_type'
drivers/gpu/drm/drm_dp_helper.c:1036: warning: Function parameter or member
'port_cap' not described in 'drm_dp_subconnector_type'
drivers/gpu/drm/drm_dp_helper.c:1089: warning: Function parameter or member
'connector' not described in 'drm_dp_set_subconnector_property'
drivers/gpu/drm/drm_dp_helper.c:1089: warning: Function parameter or member
'status' not described in 'drm_dp_set_subconnector_property'
drivers/gpu/drm/drm_dp_helper.c:1089: warning: Function parameter or member
'dpcd' not described in 'drm_dp_set_subconnector_property'
drivers/gpu/drm/drm_dp_helper.c:1089: warning: Function parameter or member
'port_cap' not described in 'drm_dp_set_subconnector_property'

Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
---
 drivers/gpu/drm/drm_dp_helper.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
index 90807a6..a12485f 100644
--- a/drivers/gpu/drm/drm_dp_helper.c
+++ b/drivers/gpu/drm/drm_dp_helper.c
@@ -1026,7 +1026,7 @@ void drm_dp_downstream_debug(struct seq_file *m,
 }
 EXPORT_SYMBOL(drm_dp_downstream_debug);
 
-/**
+/*
  * drm_dp_subconnector_type() - get DP branch device type
  *
  */
@@ -1077,7 +1077,7 @@ drm_dp_subconnector_type(const u8 dpcd[DP_RECEIVER_CAP_SIZE],
 }
 EXPORT_SYMBOL(drm_dp_subconnector_type);
 
-/**
+/*
  * drm_mode_set_dp_subconnector_property - set subconnector for DP connector
  *
  * Called by a driver on every detect event.
-- 
2.7.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/dp: update kernel-doc line comments

[Jani Nikula]

On Sat, 19 Sep 2020, Tian Tao <tiantao6@hisilicon.com> wrote:
> Update kernel-doc line comments to fix warnings reported by make W=1.

It's really not a fix if it just turns the kernel-doc comments into
regular comments...

Please fix the warnings instead.

BR,
Jani.

>
> drivers/gpu/drm/drm_dp_helper.c:1036: warning: Function parameter or member
> 'dpcd' not described in 'drm_dp_subconnector_type'
> drivers/gpu/drm/drm_dp_helper.c:1036: warning: Function parameter or member
> 'port_cap' not described in 'drm_dp_subconnector_type'
> drivers/gpu/drm/drm_dp_helper.c:1089: warning: Function parameter or member
> 'connector' not described in 'drm_dp_set_subconnector_property'
> drivers/gpu/drm/drm_dp_helper.c:1089: warning: Function parameter or member
> 'status' not described in 'drm_dp_set_subconnector_property'
> drivers/gpu/drm/drm_dp_helper.c:1089: warning: Function parameter or member
> 'dpcd' not described in 'drm_dp_set_subconnector_property'
> drivers/gpu/drm/drm_dp_helper.c:1089: warning: Function parameter or member
> 'port_cap' not described in 'drm_dp_set_subconnector_property'
>
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
> ---
>  drivers/gpu/drm/drm_dp_helper.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
> index 90807a6..a12485f 100644
> --- a/drivers/gpu/drm/drm_dp_helper.c
> +++ b/drivers/gpu/drm/drm_dp_helper.c
> @@ -1026,7 +1026,7 @@ void drm_dp_downstream_debug(struct seq_file *m,
>  }
>  EXPORT_SYMBOL(drm_dp_downstream_debug);
>  
> -/**
> +/*
>   * drm_dp_subconnector_type() - get DP branch device type
>   *
>   */
> @@ -1077,7 +1077,7 @@ drm_dp_subconnector_type(const u8 dpcd[DP_RECEIVER_CAP_SIZE],
>  }
>  EXPORT_SYMBOL(drm_dp_subconnector_type);
>  
> -/**
> +/*
>   * drm_mode_set_dp_subconnector_property - set subconnector for DP connector
>   *
>   * Called by a driver on every detect event.

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel