From: Kalle Valo <kvalo@codeaurora.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Christophe Jaillet <christophe.jaillet@wanadoo.fr>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
wcn36xx@lists.infradead.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org, Andy Gross <andy.gross@linaro.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
"David S. Miller" <davem@davemloft.net>,
Marcel Holtmann <marcel@holtmann.org>
Subject: Re: [PATCH] wcn36xx: Fix error handling path in wcn36xx_probe()
Date: Thu, 07 May 2020 17:47:12 +0000 [thread overview]
Message-ID: <874ksr4oyn.fsf@codeaurora.org> (raw)
In-Reply-To: <5345c72b-8d18-74ba-a6fa-bdc0f7dfb4c3@web.de> (Markus Elfring's message of "Thu, 7 May 2020 19:39:17 +0200")
Markus Elfring <Markus.Elfring@web.de> writes:
> …
>> +++ b/drivers/net/wireless/ath/wcn36xx/main.c
> …
>> @@ -1359,6 +1359,8 @@ static int wcn36xx_probe(struct platform_device *pdev)
>> out_unmap:
>> iounmap(wcn->ccu_base);
>> iounmap(wcn->dxe_base);
>> +out_channel:
>> + rpmsg_destroy_ept(wcn->smd_channel);
>> out_wq:
>> ieee80211_free_hw(hw);
>> out_err:
>
> How do you think about to use the label “out_destroy_ept”?
Yeah, that's better. I'll change it in the pending branch before I
commit.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Christophe Jaillet <christophe.jaillet@wanadoo.fr>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
wcn36xx@lists.infradead.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org, Andy Gross <andy.gross@linaro.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
"David S. Miller" <davem@davemloft.net>,
Marcel Holtmann <marcel@holtmann.org>
Subject: Re: [PATCH] wcn36xx: Fix error handling path in wcn36xx_probe()
Date: Thu, 07 May 2020 20:47:12 +0300 [thread overview]
Message-ID: <874ksr4oyn.fsf@codeaurora.org> (raw)
In-Reply-To: <5345c72b-8d18-74ba-a6fa-bdc0f7dfb4c3@web.de> (Markus Elfring's message of "Thu, 7 May 2020 19:39:17 +0200")
Markus Elfring <Markus.Elfring@web.de> writes:
> …
>> +++ b/drivers/net/wireless/ath/wcn36xx/main.c
> …
>> @@ -1359,6 +1359,8 @@ static int wcn36xx_probe(struct platform_device *pdev)
>> out_unmap:
>> iounmap(wcn->ccu_base);
>> iounmap(wcn->dxe_base);
>> +out_channel:
>> + rpmsg_destroy_ept(wcn->smd_channel);
>> out_wq:
>> ieee80211_free_hw(hw);
>> out_err:
>
> How do you think about to use the label “out_destroy_ept”?
Yeah, that's better. I'll change it in the pending branch before I
commit.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-05-07 17:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 4:36 [PATCH] wcn36xx: Fix error handling path in 'wcn36xx_probe()' Christophe JAILLET
2020-05-07 4:36 ` Christophe JAILLET
2020-05-07 4:52 ` Bjorn Andersson
2020-05-07 4:52 ` Bjorn Andersson
2020-05-07 17:39 ` [PATCH] wcn36xx: Fix error handling path in wcn36xx_probe() Markus Elfring
2020-05-07 17:39 ` Markus Elfring
2020-05-07 17:47 ` Kalle Valo [this message]
2020-05-07 17:47 ` Kalle Valo
2020-05-11 12:37 ` [PATCH] wcn36xx: Fix error handling path in 'wcn36xx_probe()' Kalle Valo
2020-05-11 12:37 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874ksr4oyn.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=Markus.Elfring@web.de \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
--cc=wcn36xx@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.