* [jani:device-info-inheritance-v3 3/19] drivers/gpu/drm/i915/i915_pci.c:212:2: error: initializer element is not a compile-time constant
@ 2020-03-06 1:30 kbuild test robot
2020-03-06 17:30 ` Nick Desaulniers
0 siblings, 1 reply; 7+ messages in thread
From: kbuild test robot @ 2020-03-06 1:30 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 9945 bytes --]
tree: git://people.freedesktop.org/~jani/drm device-info-inheritance-v3
head: 6e8df0961b60ee4c69a95e9304bcb14e85ba4803
commit: c8b57de4e93bccfcabe9e32bb4fe8219d3633049 [3/19] drm/i915: store color info in const structs instead of macros
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (git://gitmirror/llvm_project f70e7dc17d78a83265a89158ee549f1147d7d500)
reproduce:
# FIXME the reproduce steps for clang is not ready yet
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> drivers/gpu/drm/i915/i915_pci.c:212:2: error: initializer element is not a compile-time constant
I830_FEATURES,
^~~~~~~~~~~~~
drivers/gpu/drm/i915/i915_pci.c:189:11: note: expanded from macro 'I830_FEATURES'
.color = i9xx_colors, \
^~~~~~~~~~~
drivers/gpu/drm/i915/i915_pci.c:217:2: error: initializer element is not a compile-time constant
I845_FEATURES,
^~~~~~~~~~~~~
drivers/gpu/drm/i915/i915_pci.c:207:11: note: expanded from macro 'I845_FEATURES'
.color = i9xx_colors, \
^~~~~~~~~~~
drivers/gpu/drm/i915/i915_pci.c:222:2: error: initializer element is not a compile-time constant
I830_FEATURES,
^~~~~~~~~~~~~
drivers/gpu/drm/i915/i915_pci.c:189:11: note: expanded from macro 'I830_FEATURES'
.color = i9xx_colors, \
^~~~~~~~~~~
drivers/gpu/drm/i915/i915_pci.c:228:2: error: initializer element is not a compile-time constant
I845_FEATURES,
^~~~~~~~~~~~~
drivers/gpu/drm/i915/i915_pci.c:207:11: note: expanded from macro 'I845_FEATURES'
.color = i9xx_colors, \
^~~~~~~~~~~
drivers/gpu/drm/i915/i915_pci.c:247:2: error: initializer element is not a compile-time constant
GEN3_FEATURES,
^~~~~~~~~~~~~
drivers/gpu/drm/i915/i915_pci.c:242:11: note: expanded from macro 'GEN3_FEATURES'
.color = i9xx_colors, \
^~~~~~~~~~~
drivers/gpu/drm/i915/i915_pci.c:258:2: error: initializer element is not a compile-time constant
GEN3_FEATURES,
^~~~~~~~~~~~~
drivers/gpu/drm/i915/i915_pci.c:242:11: note: expanded from macro 'GEN3_FEATURES'
.color = i9xx_colors, \
^~~~~~~~~~~
drivers/gpu/drm/i915/i915_pci.c:271:2: error: initializer element is not a compile-time constant
GEN3_FEATURES,
^~~~~~~~~~~~~
drivers/gpu/drm/i915/i915_pci.c:242:11: note: expanded from macro 'GEN3_FEATURES'
.color = i9xx_colors, \
^~~~~~~~~~~
drivers/gpu/drm/i915/i915_pci.c:282:2: error: initializer element is not a compile-time constant
GEN3_FEATURES,
^~~~~~~~~~~~~
drivers/gpu/drm/i915/i915_pci.c:242:11: note: expanded from macro 'GEN3_FEATURES'
.color = i9xx_colors, \
^~~~~~~~~~~
drivers/gpu/drm/i915/i915_pci.c:296:2: error: initializer element is not a compile-time constant
GEN3_FEATURES,
^~~~~~~~~~~~~
drivers/gpu/drm/i915/i915_pci.c:242:11: note: expanded from macro 'GEN3_FEATURES'
.color = i9xx_colors, \
^~~~~~~~~~~
drivers/gpu/drm/i915/i915_pci.c:303:2: error: initializer element is not a compile-time constant
GEN3_FEATURES,
^~~~~~~~~~~~~
drivers/gpu/drm/i915/i915_pci.c:242:11: note: expanded from macro 'GEN3_FEATURES'
.color = i9xx_colors, \
^~~~~~~~~~~
drivers/gpu/drm/i915/i915_pci.c:310:2: error: initializer element is not a compile-time constant
GEN3_FEATURES,
^~~~~~~~~~~~~
drivers/gpu/drm/i915/i915_pci.c:242:11: note: expanded from macro 'GEN3_FEATURES'
.color = i9xx_colors, \
^~~~~~~~~~~
drivers/gpu/drm/i915/i915_pci.c:333:2: error: initializer element is not a compile-time constant
GEN4_FEATURES,
^~~~~~~~~~~~~
drivers/gpu/drm/i915/i915_pci.c:328:11: note: expanded from macro 'GEN4_FEATURES'
.color = i965_colors, \
^~~~~~~~~~~
drivers/gpu/drm/i915/i915_pci.c:341:2: error: initializer element is not a compile-time constant
GEN4_FEATURES,
^~~~~~~~~~~~~
drivers/gpu/drm/i915/i915_pci.c:328:11: note: expanded from macro 'GEN4_FEATURES'
.color = i965_colors, \
^~~~~~~~~~~
drivers/gpu/drm/i915/i915_pci.c:352:2: error: initializer element is not a compile-time constant
GEN4_FEATURES,
^~~~~~~~~~~~~
drivers/gpu/drm/i915/i915_pci.c:328:11: note: expanded from macro 'GEN4_FEATURES'
.color = i965_colors, \
^~~~~~~~~~~
drivers/gpu/drm/i915/i915_pci.c:359:2: error: initializer element is not a compile-time constant
GEN4_FEATURES,
^~~~~~~~~~~~~
drivers/gpu/drm/i915/i915_pci.c:328:11: note: expanded from macro 'GEN4_FEATURES'
.color = i965_colors, \
^~~~~~~~~~~
drivers/gpu/drm/i915/i915_pci.c:384:2: error: initializer element is not a compile-time constant
GEN5_FEATURES,
^~~~~~~~~~~~~
drivers/gpu/drm/i915/i915_pci.c:379:11: note: expanded from macro 'GEN5_FEATURES'
.color = ilk_colors, \
^~~~~~~~~~
drivers/gpu/drm/i915/i915_pci.c:389:2: error: initializer element is not a compile-time constant
GEN5_FEATURES,
^~~~~~~~~~~~~
drivers/gpu/drm/i915/i915_pci.c:379:11: note: expanded from macro 'GEN5_FEATURES'
.color = ilk_colors, \
vim +212 drivers/gpu/drm/i915/i915_pci.c
da1184cd41d4c6b Matthew Auld 2019-10-18 172
37fbbd49054b624 Ville Syrjälä 2019-03-05 173 #define I830_FEATURES \
37fbbd49054b624 Ville Syrjälä 2019-03-05 174 GEN(2), \
37fbbd49054b624 Ville Syrjälä 2019-03-05 175 .is_mobile = 1, \
8d8b00318593e28 Jani Nikula 2019-09-11 176 .pipe_mask = BIT(PIPE_A) | BIT(PIPE_B), \
37fbbd49054b624 Ville Syrjälä 2019-03-05 177 .display.has_overlay = 1, \
37fbbd49054b624 Ville Syrjälä 2019-03-05 178 .display.cursor_needs_physical = 1, \
37fbbd49054b624 Ville Syrjälä 2019-03-05 179 .display.overlay_needs_physical = 1, \
37fbbd49054b624 Ville Syrjälä 2019-03-05 180 .display.has_gmch = 1, \
37fbbd49054b624 Ville Syrjälä 2019-03-05 181 .gpu_reset_clobbers_display = true, \
37fbbd49054b624 Ville Syrjälä 2019-03-05 182 .hws_needs_physical = 1, \
37fbbd49054b624 Ville Syrjälä 2019-03-05 183 .unfenced_needs_alignment = 1, \
37fbbd49054b624 Ville Syrjälä 2019-03-05 184 .engine_mask = BIT(RCS0), \
37fbbd49054b624 Ville Syrjälä 2019-03-05 185 .has_snoop = true, \
37fbbd49054b624 Ville Syrjälä 2019-03-05 186 .has_coherent_ggtt = false, \
37fbbd49054b624 Ville Syrjälä 2019-03-05 187 I9XX_PIPE_OFFSETS, \
37fbbd49054b624 Ville Syrjälä 2019-03-05 188 I9XX_CURSOR_OFFSETS, \
c8b57de4e93bccf Jani Nikula 2020-03-05 189 .color = i9xx_colors, \
2411ccdddd53007 Jani Nikula 2020-03-05 190 .page_sizes = GEN_DEFAULT_PAGE_SIZES, \
980a85a19e6db48 Jani Nikula 2020-03-05 191 .memory_regions = GEN_DEFAULT_REGIONS
37fbbd49054b624 Ville Syrjälä 2019-03-05 192
37fbbd49054b624 Ville Syrjälä 2019-03-05 193 #define I845_FEATURES \
bc76298e68e791f Chris Wilson 2018-02-15 194 GEN(2), \
8d8b00318593e28 Jani Nikula 2019-09-11 195 .pipe_mask = BIT(PIPE_A), \
d53db442db36fdb José Roberto de Souza 2018-11-30 196 .display.has_overlay = 1, \
d53db442db36fdb José Roberto de Souza 2018-11-30 197 .display.overlay_needs_physical = 1, \
b2ae318acdcaf1c Rodrigo Vivi 2019-02-04 198 .display.has_gmch = 1, \
55277e1f3107c0b Chris Wilson 2019-01-03 199 .gpu_reset_clobbers_display = true, \
3177659a41cc436 Carlos Santa 2016-08-17 200 .hws_needs_physical = 1, \
f4ce766f28cd0ef Chris Wilson 2017-03-25 201 .unfenced_needs_alignment = 1, \
8a68d464366efb5 Chris Wilson 2019-03-05 202 .engine_mask = BIT(RCS0), \
5d95c24867aea8a Chris Wilson 2017-09-06 203 .has_snoop = true, \
900ccf30f9e112b Chris Wilson 2018-07-20 204 .has_coherent_ggtt = false, \
37fbbd49054b624 Ville Syrjälä 2019-03-05 205 I845_PIPE_OFFSETS, \
37fbbd49054b624 Ville Syrjälä 2019-03-05 206 I845_CURSOR_OFFSETS, \
c8b57de4e93bccf Jani Nikula 2020-03-05 207 .color = i9xx_colors, \
2411ccdddd53007 Jani Nikula 2020-03-05 208 .page_sizes = GEN_DEFAULT_PAGE_SIZES, \
980a85a19e6db48 Jani Nikula 2020-03-05 209 .memory_regions = GEN_DEFAULT_REGIONS
0eec8dc7f628a8d Carlos Santa 2016-08-17 210
31409fff1a392fa Lucas De Marchi 2019-12-24 211 static const struct intel_device_info i830_info = {
37fbbd49054b624 Ville Syrjälä 2019-03-05 @212 I830_FEATURES,
c5cb21c17a169ee Chris Wilson 2018-02-15 213 PLATFORM(INTEL_I830),
42f5551d276921d Chris Wilson 2016-06-24 214 };
42f5551d276921d Chris Wilson 2016-06-24 215
:::::: The code at line 212 was first introduced by commit
:::::: 37fbbd49054b624400a65cf1a39f152a7f3f4749 drm/i915: Populate pipe_offsets[] & co. accurately
:::::: TO: Ville Syrjälä <ville.syrjala@linux.intel.com>
:::::: CC: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 72534 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [jani:device-info-inheritance-v3 3/19] drivers/gpu/drm/i915/i915_pci.c:212:2: error: initializer element is not a compile-time constant
2020-03-06 1:30 [jani:device-info-inheritance-v3 3/19] drivers/gpu/drm/i915/i915_pci.c:212:2: error: initializer element is not a compile-time constant kbuild test robot
@ 2020-03-06 17:30 ` Nick Desaulniers
2020-03-09 8:32 ` Jani Nikula
0 siblings, 1 reply; 7+ messages in thread
From: Nick Desaulniers @ 2020-03-06 17:30 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 10845 bytes --]
Based on the tree, I think this report was meant to go to Jani (cc'ed)?
On Thu, Mar 5, 2020 at 5:31 PM kbuild test robot <lkp@intel.com> wrote:
>
> tree: git://people.freedesktop.org/~jani/drm device-info-inheritance-v3
> head: 6e8df0961b60ee4c69a95e9304bcb14e85ba4803
> commit: c8b57de4e93bccfcabe9e32bb4fe8219d3633049 [3/19] drm/i915: store color info in const structs instead of macros
> config: x86_64-allyesconfig (attached as .config)
> compiler: clang version 11.0.0 (git://gitmirror/llvm_project f70e7dc17d78a83265a89158ee549f1147d7d500)
> reproduce:
> # FIXME the reproduce steps for clang is not ready yet
>
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
> >> drivers/gpu/drm/i915/i915_pci.c:212:2: error: initializer element is not a compile-time constant
> I830_FEATURES,
> ^~~~~~~~~~~~~
> drivers/gpu/drm/i915/i915_pci.c:189:11: note: expanded from macro 'I830_FEATURES'
> .color = i9xx_colors, \
> ^~~~~~~~~~~
> drivers/gpu/drm/i915/i915_pci.c:217:2: error: initializer element is not a compile-time constant
> I845_FEATURES,
> ^~~~~~~~~~~~~
> drivers/gpu/drm/i915/i915_pci.c:207:11: note: expanded from macro 'I845_FEATURES'
> .color = i9xx_colors, \
> ^~~~~~~~~~~
> drivers/gpu/drm/i915/i915_pci.c:222:2: error: initializer element is not a compile-time constant
> I830_FEATURES,
> ^~~~~~~~~~~~~
> drivers/gpu/drm/i915/i915_pci.c:189:11: note: expanded from macro 'I830_FEATURES'
> .color = i9xx_colors, \
> ^~~~~~~~~~~
> drivers/gpu/drm/i915/i915_pci.c:228:2: error: initializer element is not a compile-time constant
> I845_FEATURES,
> ^~~~~~~~~~~~~
> drivers/gpu/drm/i915/i915_pci.c:207:11: note: expanded from macro 'I845_FEATURES'
> .color = i9xx_colors, \
> ^~~~~~~~~~~
> drivers/gpu/drm/i915/i915_pci.c:247:2: error: initializer element is not a compile-time constant
> GEN3_FEATURES,
> ^~~~~~~~~~~~~
> drivers/gpu/drm/i915/i915_pci.c:242:11: note: expanded from macro 'GEN3_FEATURES'
> .color = i9xx_colors, \
> ^~~~~~~~~~~
> drivers/gpu/drm/i915/i915_pci.c:258:2: error: initializer element is not a compile-time constant
> GEN3_FEATURES,
> ^~~~~~~~~~~~~
> drivers/gpu/drm/i915/i915_pci.c:242:11: note: expanded from macro 'GEN3_FEATURES'
> .color = i9xx_colors, \
> ^~~~~~~~~~~
> drivers/gpu/drm/i915/i915_pci.c:271:2: error: initializer element is not a compile-time constant
> GEN3_FEATURES,
> ^~~~~~~~~~~~~
> drivers/gpu/drm/i915/i915_pci.c:242:11: note: expanded from macro 'GEN3_FEATURES'
> .color = i9xx_colors, \
> ^~~~~~~~~~~
> drivers/gpu/drm/i915/i915_pci.c:282:2: error: initializer element is not a compile-time constant
> GEN3_FEATURES,
> ^~~~~~~~~~~~~
> drivers/gpu/drm/i915/i915_pci.c:242:11: note: expanded from macro 'GEN3_FEATURES'
> .color = i9xx_colors, \
> ^~~~~~~~~~~
> drivers/gpu/drm/i915/i915_pci.c:296:2: error: initializer element is not a compile-time constant
> GEN3_FEATURES,
> ^~~~~~~~~~~~~
> drivers/gpu/drm/i915/i915_pci.c:242:11: note: expanded from macro 'GEN3_FEATURES'
> .color = i9xx_colors, \
> ^~~~~~~~~~~
> drivers/gpu/drm/i915/i915_pci.c:303:2: error: initializer element is not a compile-time constant
> GEN3_FEATURES,
> ^~~~~~~~~~~~~
> drivers/gpu/drm/i915/i915_pci.c:242:11: note: expanded from macro 'GEN3_FEATURES'
> .color = i9xx_colors, \
> ^~~~~~~~~~~
> drivers/gpu/drm/i915/i915_pci.c:310:2: error: initializer element is not a compile-time constant
> GEN3_FEATURES,
> ^~~~~~~~~~~~~
> drivers/gpu/drm/i915/i915_pci.c:242:11: note: expanded from macro 'GEN3_FEATURES'
> .color = i9xx_colors, \
> ^~~~~~~~~~~
> drivers/gpu/drm/i915/i915_pci.c:333:2: error: initializer element is not a compile-time constant
> GEN4_FEATURES,
> ^~~~~~~~~~~~~
> drivers/gpu/drm/i915/i915_pci.c:328:11: note: expanded from macro 'GEN4_FEATURES'
> .color = i965_colors, \
> ^~~~~~~~~~~
> drivers/gpu/drm/i915/i915_pci.c:341:2: error: initializer element is not a compile-time constant
> GEN4_FEATURES,
> ^~~~~~~~~~~~~
> drivers/gpu/drm/i915/i915_pci.c:328:11: note: expanded from macro 'GEN4_FEATURES'
> .color = i965_colors, \
> ^~~~~~~~~~~
> drivers/gpu/drm/i915/i915_pci.c:352:2: error: initializer element is not a compile-time constant
> GEN4_FEATURES,
> ^~~~~~~~~~~~~
> drivers/gpu/drm/i915/i915_pci.c:328:11: note: expanded from macro 'GEN4_FEATURES'
> .color = i965_colors, \
> ^~~~~~~~~~~
> drivers/gpu/drm/i915/i915_pci.c:359:2: error: initializer element is not a compile-time constant
> GEN4_FEATURES,
> ^~~~~~~~~~~~~
> drivers/gpu/drm/i915/i915_pci.c:328:11: note: expanded from macro 'GEN4_FEATURES'
> .color = i965_colors, \
> ^~~~~~~~~~~
> drivers/gpu/drm/i915/i915_pci.c:384:2: error: initializer element is not a compile-time constant
> GEN5_FEATURES,
> ^~~~~~~~~~~~~
> drivers/gpu/drm/i915/i915_pci.c:379:11: note: expanded from macro 'GEN5_FEATURES'
> .color = ilk_colors, \
> ^~~~~~~~~~
> drivers/gpu/drm/i915/i915_pci.c:389:2: error: initializer element is not a compile-time constant
> GEN5_FEATURES,
> ^~~~~~~~~~~~~
> drivers/gpu/drm/i915/i915_pci.c:379:11: note: expanded from macro 'GEN5_FEATURES'
> .color = ilk_colors, \
>
> vim +212 drivers/gpu/drm/i915/i915_pci.c
>
> da1184cd41d4c6b Matthew Auld 2019-10-18 172
> 37fbbd49054b624 Ville Syrjälä 2019-03-05 173 #define I830_FEATURES \
> 37fbbd49054b624 Ville Syrjälä 2019-03-05 174 GEN(2), \
> 37fbbd49054b624 Ville Syrjälä 2019-03-05 175 .is_mobile = 1, \
> 8d8b00318593e28 Jani Nikula 2019-09-11 176 .pipe_mask = BIT(PIPE_A) | BIT(PIPE_B), \
> 37fbbd49054b624 Ville Syrjälä 2019-03-05 177 .display.has_overlay = 1, \
> 37fbbd49054b624 Ville Syrjälä 2019-03-05 178 .display.cursor_needs_physical = 1, \
> 37fbbd49054b624 Ville Syrjälä 2019-03-05 179 .display.overlay_needs_physical = 1, \
> 37fbbd49054b624 Ville Syrjälä 2019-03-05 180 .display.has_gmch = 1, \
> 37fbbd49054b624 Ville Syrjälä 2019-03-05 181 .gpu_reset_clobbers_display = true, \
> 37fbbd49054b624 Ville Syrjälä 2019-03-05 182 .hws_needs_physical = 1, \
> 37fbbd49054b624 Ville Syrjälä 2019-03-05 183 .unfenced_needs_alignment = 1, \
> 37fbbd49054b624 Ville Syrjälä 2019-03-05 184 .engine_mask = BIT(RCS0), \
> 37fbbd49054b624 Ville Syrjälä 2019-03-05 185 .has_snoop = true, \
> 37fbbd49054b624 Ville Syrjälä 2019-03-05 186 .has_coherent_ggtt = false, \
> 37fbbd49054b624 Ville Syrjälä 2019-03-05 187 I9XX_PIPE_OFFSETS, \
> 37fbbd49054b624 Ville Syrjälä 2019-03-05 188 I9XX_CURSOR_OFFSETS, \
> c8b57de4e93bccf Jani Nikula 2020-03-05 189 .color = i9xx_colors, \
> 2411ccdddd53007 Jani Nikula 2020-03-05 190 .page_sizes = GEN_DEFAULT_PAGE_SIZES, \
> 980a85a19e6db48 Jani Nikula 2020-03-05 191 .memory_regions = GEN_DEFAULT_REGIONS
> 37fbbd49054b624 Ville Syrjälä 2019-03-05 192
> 37fbbd49054b624 Ville Syrjälä 2019-03-05 193 #define I845_FEATURES \
> bc76298e68e791f Chris Wilson 2018-02-15 194 GEN(2), \
> 8d8b00318593e28 Jani Nikula 2019-09-11 195 .pipe_mask = BIT(PIPE_A), \
> d53db442db36fdb José Roberto de Souza 2018-11-30 196 .display.has_overlay = 1, \
> d53db442db36fdb José Roberto de Souza 2018-11-30 197 .display.overlay_needs_physical = 1, \
> b2ae318acdcaf1c Rodrigo Vivi 2019-02-04 198 .display.has_gmch = 1, \
> 55277e1f3107c0b Chris Wilson 2019-01-03 199 .gpu_reset_clobbers_display = true, \
> 3177659a41cc436 Carlos Santa 2016-08-17 200 .hws_needs_physical = 1, \
> f4ce766f28cd0ef Chris Wilson 2017-03-25 201 .unfenced_needs_alignment = 1, \
> 8a68d464366efb5 Chris Wilson 2019-03-05 202 .engine_mask = BIT(RCS0), \
> 5d95c24867aea8a Chris Wilson 2017-09-06 203 .has_snoop = true, \
> 900ccf30f9e112b Chris Wilson 2018-07-20 204 .has_coherent_ggtt = false, \
> 37fbbd49054b624 Ville Syrjälä 2019-03-05 205 I845_PIPE_OFFSETS, \
> 37fbbd49054b624 Ville Syrjälä 2019-03-05 206 I845_CURSOR_OFFSETS, \
> c8b57de4e93bccf Jani Nikula 2020-03-05 207 .color = i9xx_colors, \
> 2411ccdddd53007 Jani Nikula 2020-03-05 208 .page_sizes = GEN_DEFAULT_PAGE_SIZES, \
> 980a85a19e6db48 Jani Nikula 2020-03-05 209 .memory_regions = GEN_DEFAULT_REGIONS
> 0eec8dc7f628a8d Carlos Santa 2016-08-17 210
> 31409fff1a392fa Lucas De Marchi 2019-12-24 211 static const struct intel_device_info i830_info = {
> 37fbbd49054b624 Ville Syrjälä 2019-03-05 @212 I830_FEATURES,
> c5cb21c17a169ee Chris Wilson 2018-02-15 213 PLATFORM(INTEL_I830),
> 42f5551d276921d Chris Wilson 2016-06-24 214 };
> 42f5551d276921d Chris Wilson 2016-06-24 215
>
> :::::: The code at line 212 was first introduced by commit
> :::::: 37fbbd49054b624400a65cf1a39f152a7f3f4749 drm/i915: Populate pipe_offsets[] & co. accurately
>
> :::::: TO: Ville Syrjälä <ville.syrjala@linux.intel.com>
> :::::: CC: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
>
> --
> You received this message because you are subscribed to the Google Groups "Clang Built Linux" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to clang-built-linux+unsubscribe(a)googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/202003060916.RI5pROBS%25lkp%40intel.com.
--
Thanks,
~Nick Desaulniers
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [jani:device-info-inheritance-v3 3/19] drivers/gpu/drm/i915/i915_pci.c:212:2: error: initializer element is not a compile-time constant
2020-03-06 17:30 ` Nick Desaulniers
@ 2020-03-09 8:32 ` Jani Nikula
2020-03-09 18:03 ` Nick Desaulniers
0 siblings, 1 reply; 7+ messages in thread
From: Jani Nikula @ 2020-03-09 8:32 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 11429 bytes --]
On Fri, 06 Mar 2020, Nick Desaulniers <ndesaulniers@google.com> wrote:
> Based on the tree, I think this report was meant to go to Jani (cc'ed)?
It baffles me that the build bot burns resources on building random
branches in my personal repositories.
That said, this builds on GCC 8 just fine. Is clang not able to do this?
Sad trombone. Pretty much blocks what I thought was a nice cleanup from
illegible macros to plain C code.
BR,
Jani.
>
> On Thu, Mar 5, 2020 at 5:31 PM kbuild test robot <lkp@intel.com> wrote:
>>
>> tree: git://people.freedesktop.org/~jani/drm device-info-inheritance-v3
>> head: 6e8df0961b60ee4c69a95e9304bcb14e85ba4803
>> commit: c8b57de4e93bccfcabe9e32bb4fe8219d3633049 [3/19] drm/i915: store color info in const structs instead of macros
>> config: x86_64-allyesconfig (attached as .config)
>> compiler: clang version 11.0.0 (git://gitmirror/llvm_project f70e7dc17d78a83265a89158ee549f1147d7d500)
>> reproduce:
>> # FIXME the reproduce steps for clang is not ready yet
>>
>> If you fix the issue, kindly add following tag
>> Reported-by: kbuild test robot <lkp@intel.com>
>>
>> All errors (new ones prefixed by >>):
>>
>> >> drivers/gpu/drm/i915/i915_pci.c:212:2: error: initializer element is not a compile-time constant
>> I830_FEATURES,
>> ^~~~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:189:11: note: expanded from macro 'I830_FEATURES'
>> .color = i9xx_colors, \
>> ^~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:217:2: error: initializer element is not a compile-time constant
>> I845_FEATURES,
>> ^~~~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:207:11: note: expanded from macro 'I845_FEATURES'
>> .color = i9xx_colors, \
>> ^~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:222:2: error: initializer element is not a compile-time constant
>> I830_FEATURES,
>> ^~~~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:189:11: note: expanded from macro 'I830_FEATURES'
>> .color = i9xx_colors, \
>> ^~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:228:2: error: initializer element is not a compile-time constant
>> I845_FEATURES,
>> ^~~~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:207:11: note: expanded from macro 'I845_FEATURES'
>> .color = i9xx_colors, \
>> ^~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:247:2: error: initializer element is not a compile-time constant
>> GEN3_FEATURES,
>> ^~~~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:242:11: note: expanded from macro 'GEN3_FEATURES'
>> .color = i9xx_colors, \
>> ^~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:258:2: error: initializer element is not a compile-time constant
>> GEN3_FEATURES,
>> ^~~~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:242:11: note: expanded from macro 'GEN3_FEATURES'
>> .color = i9xx_colors, \
>> ^~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:271:2: error: initializer element is not a compile-time constant
>> GEN3_FEATURES,
>> ^~~~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:242:11: note: expanded from macro 'GEN3_FEATURES'
>> .color = i9xx_colors, \
>> ^~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:282:2: error: initializer element is not a compile-time constant
>> GEN3_FEATURES,
>> ^~~~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:242:11: note: expanded from macro 'GEN3_FEATURES'
>> .color = i9xx_colors, \
>> ^~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:296:2: error: initializer element is not a compile-time constant
>> GEN3_FEATURES,
>> ^~~~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:242:11: note: expanded from macro 'GEN3_FEATURES'
>> .color = i9xx_colors, \
>> ^~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:303:2: error: initializer element is not a compile-time constant
>> GEN3_FEATURES,
>> ^~~~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:242:11: note: expanded from macro 'GEN3_FEATURES'
>> .color = i9xx_colors, \
>> ^~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:310:2: error: initializer element is not a compile-time constant
>> GEN3_FEATURES,
>> ^~~~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:242:11: note: expanded from macro 'GEN3_FEATURES'
>> .color = i9xx_colors, \
>> ^~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:333:2: error: initializer element is not a compile-time constant
>> GEN4_FEATURES,
>> ^~~~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:328:11: note: expanded from macro 'GEN4_FEATURES'
>> .color = i965_colors, \
>> ^~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:341:2: error: initializer element is not a compile-time constant
>> GEN4_FEATURES,
>> ^~~~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:328:11: note: expanded from macro 'GEN4_FEATURES'
>> .color = i965_colors, \
>> ^~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:352:2: error: initializer element is not a compile-time constant
>> GEN4_FEATURES,
>> ^~~~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:328:11: note: expanded from macro 'GEN4_FEATURES'
>> .color = i965_colors, \
>> ^~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:359:2: error: initializer element is not a compile-time constant
>> GEN4_FEATURES,
>> ^~~~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:328:11: note: expanded from macro 'GEN4_FEATURES'
>> .color = i965_colors, \
>> ^~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:384:2: error: initializer element is not a compile-time constant
>> GEN5_FEATURES,
>> ^~~~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:379:11: note: expanded from macro 'GEN5_FEATURES'
>> .color = ilk_colors, \
>> ^~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:389:2: error: initializer element is not a compile-time constant
>> GEN5_FEATURES,
>> ^~~~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:379:11: note: expanded from macro 'GEN5_FEATURES'
>> .color = ilk_colors, \
>>
>> vim +212 drivers/gpu/drm/i915/i915_pci.c
>>
>> da1184cd41d4c6b Matthew Auld 2019-10-18 172
>> 37fbbd49054b624 Ville Syrjälä 2019-03-05 173 #define I830_FEATURES \
>> 37fbbd49054b624 Ville Syrjälä 2019-03-05 174 GEN(2), \
>> 37fbbd49054b624 Ville Syrjälä 2019-03-05 175 .is_mobile = 1, \
>> 8d8b00318593e28 Jani Nikula 2019-09-11 176 .pipe_mask = BIT(PIPE_A) | BIT(PIPE_B), \
>> 37fbbd49054b624 Ville Syrjälä 2019-03-05 177 .display.has_overlay = 1, \
>> 37fbbd49054b624 Ville Syrjälä 2019-03-05 178 .display.cursor_needs_physical = 1, \
>> 37fbbd49054b624 Ville Syrjälä 2019-03-05 179 .display.overlay_needs_physical = 1, \
>> 37fbbd49054b624 Ville Syrjälä 2019-03-05 180 .display.has_gmch = 1, \
>> 37fbbd49054b624 Ville Syrjälä 2019-03-05 181 .gpu_reset_clobbers_display = true, \
>> 37fbbd49054b624 Ville Syrjälä 2019-03-05 182 .hws_needs_physical = 1, \
>> 37fbbd49054b624 Ville Syrjälä 2019-03-05 183 .unfenced_needs_alignment = 1, \
>> 37fbbd49054b624 Ville Syrjälä 2019-03-05 184 .engine_mask = BIT(RCS0), \
>> 37fbbd49054b624 Ville Syrjälä 2019-03-05 185 .has_snoop = true, \
>> 37fbbd49054b624 Ville Syrjälä 2019-03-05 186 .has_coherent_ggtt = false, \
>> 37fbbd49054b624 Ville Syrjälä 2019-03-05 187 I9XX_PIPE_OFFSETS, \
>> 37fbbd49054b624 Ville Syrjälä 2019-03-05 188 I9XX_CURSOR_OFFSETS, \
>> c8b57de4e93bccf Jani Nikula 2020-03-05 189 .color = i9xx_colors, \
>> 2411ccdddd53007 Jani Nikula 2020-03-05 190 .page_sizes = GEN_DEFAULT_PAGE_SIZES, \
>> 980a85a19e6db48 Jani Nikula 2020-03-05 191 .memory_regions = GEN_DEFAULT_REGIONS
>> 37fbbd49054b624 Ville Syrjälä 2019-03-05 192
>> 37fbbd49054b624 Ville Syrjälä 2019-03-05 193 #define I845_FEATURES \
>> bc76298e68e791f Chris Wilson 2018-02-15 194 GEN(2), \
>> 8d8b00318593e28 Jani Nikula 2019-09-11 195 .pipe_mask = BIT(PIPE_A), \
>> d53db442db36fdb José Roberto de Souza 2018-11-30 196 .display.has_overlay = 1, \
>> d53db442db36fdb José Roberto de Souza 2018-11-30 197 .display.overlay_needs_physical = 1, \
>> b2ae318acdcaf1c Rodrigo Vivi 2019-02-04 198 .display.has_gmch = 1, \
>> 55277e1f3107c0b Chris Wilson 2019-01-03 199 .gpu_reset_clobbers_display = true, \
>> 3177659a41cc436 Carlos Santa 2016-08-17 200 .hws_needs_physical = 1, \
>> f4ce766f28cd0ef Chris Wilson 2017-03-25 201 .unfenced_needs_alignment = 1, \
>> 8a68d464366efb5 Chris Wilson 2019-03-05 202 .engine_mask = BIT(RCS0), \
>> 5d95c24867aea8a Chris Wilson 2017-09-06 203 .has_snoop = true, \
>> 900ccf30f9e112b Chris Wilson 2018-07-20 204 .has_coherent_ggtt = false, \
>> 37fbbd49054b624 Ville Syrjälä 2019-03-05 205 I845_PIPE_OFFSETS, \
>> 37fbbd49054b624 Ville Syrjälä 2019-03-05 206 I845_CURSOR_OFFSETS, \
>> c8b57de4e93bccf Jani Nikula 2020-03-05 207 .color = i9xx_colors, \
>> 2411ccdddd53007 Jani Nikula 2020-03-05 208 .page_sizes = GEN_DEFAULT_PAGE_SIZES, \
>> 980a85a19e6db48 Jani Nikula 2020-03-05 209 .memory_regions = GEN_DEFAULT_REGIONS
>> 0eec8dc7f628a8d Carlos Santa 2016-08-17 210
>> 31409fff1a392fa Lucas De Marchi 2019-12-24 211 static const struct intel_device_info i830_info = {
>> 37fbbd49054b624 Ville Syrjälä 2019-03-05 @212 I830_FEATURES,
>> c5cb21c17a169ee Chris Wilson 2018-02-15 213 PLATFORM(INTEL_I830),
>> 42f5551d276921d Chris Wilson 2016-06-24 214 };
>> 42f5551d276921d Chris Wilson 2016-06-24 215
>>
>> :::::: The code at line 212 was first introduced by commit
>> :::::: 37fbbd49054b624400a65cf1a39f152a7f3f4749 drm/i915: Populate pipe_offsets[] & co. accurately
>>
>> :::::: TO: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> :::::: CC: Ville Syrjälä <ville.syrjala@linux.intel.com>
>>
>> ---
>> 0-DAY CI Kernel Test Service, Intel Corporation
>> https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
>>
>> --
>> You received this message because you are subscribed to the Google Groups "Clang Built Linux" group.
>> To unsubscribe from this group and stop receiving emails from it, send an email to clang-built-linux+unsubscribe(a)googlegroups.com.
>> To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/202003060916.RI5pROBS%25lkp%40intel.com.
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [jani:device-info-inheritance-v3 3/19] drivers/gpu/drm/i915/i915_pci.c:212:2: error: initializer element is not a compile-time constant
2020-03-09 8:32 ` Jani Nikula
@ 2020-03-09 18:03 ` Nick Desaulniers
2020-03-10 8:51 ` Jani Nikula
0 siblings, 1 reply; 7+ messages in thread
From: Nick Desaulniers @ 2020-03-09 18:03 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 12607 bytes --]
On Mon, Mar 9, 2020 at 1:32 AM Jani Nikula <jani.nikula@linux.intel.com> wrote:
>
> On Fri, 06 Mar 2020, Nick Desaulniers <ndesaulniers@google.com> wrote:
> > Based on the tree, I think this report was meant to go to Jani (cc'ed)?
>
> It baffles me that the build bot burns resources on building random
> branches in my personal repositories.
It uses a branch naming convention to avoid testing branches:
https://github.com/intel/lkp-tests/wiki/LKP-FAQ#is-there-a-way-not-to-trigger-kbuild-tests-on-a-specific-branch
But in this case, it seems it caught a build breakage even further
upstream, which is valuable, right?
>
> That said, this builds on GCC 8 just fine. Is clang not able to do this?
Places that require integer constant expressions can be very subtle.
See this recent example in i915 for example:
https://github.com/ClangBuiltLinux/linux/issues/918
Sometimes reproducing also depends on some configs. In this case,
it's not as I've fetched your branch and can repro on defconfig.
This is definitely our bug: https://bugs.llvm.org/show_bug.cgi?id=45157
> Sad trombone. Pretty much blocks what I thought was a nice cleanup from
> illegible macros to plain C code.
>
>
> BR,
> Jani.
>
>
> >
> > On Thu, Mar 5, 2020 at 5:31 PM kbuild test robot <lkp@intel.com> wrote:
> >>
> >> tree: git://people.freedesktop.org/~jani/drm device-info-inheritance-v3
> >> head: 6e8df0961b60ee4c69a95e9304bcb14e85ba4803
> >> commit: c8b57de4e93bccfcabe9e32bb4fe8219d3633049 [3/19] drm/i915: store color info in const structs instead of macros
> >> config: x86_64-allyesconfig (attached as .config)
> >> compiler: clang version 11.0.0 (git://gitmirror/llvm_project f70e7dc17d78a83265a89158ee549f1147d7d500)
> >> reproduce:
> >> # FIXME the reproduce steps for clang is not ready yet
> >>
> >> If you fix the issue, kindly add following tag
> >> Reported-by: kbuild test robot <lkp@intel.com>
> >>
> >> All errors (new ones prefixed by >>):
> >>
> >> >> drivers/gpu/drm/i915/i915_pci.c:212:2: error: initializer element is not a compile-time constant
> >> I830_FEATURES,
> >> ^~~~~~~~~~~~~
> >> drivers/gpu/drm/i915/i915_pci.c:189:11: note: expanded from macro 'I830_FEATURES'
> >> .color = i9xx_colors, \
> >> ^~~~~~~~~~~
> >> drivers/gpu/drm/i915/i915_pci.c:217:2: error: initializer element is not a compile-time constant
> >> I845_FEATURES,
> >> ^~~~~~~~~~~~~
> >> drivers/gpu/drm/i915/i915_pci.c:207:11: note: expanded from macro 'I845_FEATURES'
> >> .color = i9xx_colors, \
> >> ^~~~~~~~~~~
> >> drivers/gpu/drm/i915/i915_pci.c:222:2: error: initializer element is not a compile-time constant
> >> I830_FEATURES,
> >> ^~~~~~~~~~~~~
> >> drivers/gpu/drm/i915/i915_pci.c:189:11: note: expanded from macro 'I830_FEATURES'
> >> .color = i9xx_colors, \
> >> ^~~~~~~~~~~
> >> drivers/gpu/drm/i915/i915_pci.c:228:2: error: initializer element is not a compile-time constant
> >> I845_FEATURES,
> >> ^~~~~~~~~~~~~
> >> drivers/gpu/drm/i915/i915_pci.c:207:11: note: expanded from macro 'I845_FEATURES'
> >> .color = i9xx_colors, \
> >> ^~~~~~~~~~~
> >> drivers/gpu/drm/i915/i915_pci.c:247:2: error: initializer element is not a compile-time constant
> >> GEN3_FEATURES,
> >> ^~~~~~~~~~~~~
> >> drivers/gpu/drm/i915/i915_pci.c:242:11: note: expanded from macro 'GEN3_FEATURES'
> >> .color = i9xx_colors, \
> >> ^~~~~~~~~~~
> >> drivers/gpu/drm/i915/i915_pci.c:258:2: error: initializer element is not a compile-time constant
> >> GEN3_FEATURES,
> >> ^~~~~~~~~~~~~
> >> drivers/gpu/drm/i915/i915_pci.c:242:11: note: expanded from macro 'GEN3_FEATURES'
> >> .color = i9xx_colors, \
> >> ^~~~~~~~~~~
> >> drivers/gpu/drm/i915/i915_pci.c:271:2: error: initializer element is not a compile-time constant
> >> GEN3_FEATURES,
> >> ^~~~~~~~~~~~~
> >> drivers/gpu/drm/i915/i915_pci.c:242:11: note: expanded from macro 'GEN3_FEATURES'
> >> .color = i9xx_colors, \
> >> ^~~~~~~~~~~
> >> drivers/gpu/drm/i915/i915_pci.c:282:2: error: initializer element is not a compile-time constant
> >> GEN3_FEATURES,
> >> ^~~~~~~~~~~~~
> >> drivers/gpu/drm/i915/i915_pci.c:242:11: note: expanded from macro 'GEN3_FEATURES'
> >> .color = i9xx_colors, \
> >> ^~~~~~~~~~~
> >> drivers/gpu/drm/i915/i915_pci.c:296:2: error: initializer element is not a compile-time constant
> >> GEN3_FEATURES,
> >> ^~~~~~~~~~~~~
> >> drivers/gpu/drm/i915/i915_pci.c:242:11: note: expanded from macro 'GEN3_FEATURES'
> >> .color = i9xx_colors, \
> >> ^~~~~~~~~~~
> >> drivers/gpu/drm/i915/i915_pci.c:303:2: error: initializer element is not a compile-time constant
> >> GEN3_FEATURES,
> >> ^~~~~~~~~~~~~
> >> drivers/gpu/drm/i915/i915_pci.c:242:11: note: expanded from macro 'GEN3_FEATURES'
> >> .color = i9xx_colors, \
> >> ^~~~~~~~~~~
> >> drivers/gpu/drm/i915/i915_pci.c:310:2: error: initializer element is not a compile-time constant
> >> GEN3_FEATURES,
> >> ^~~~~~~~~~~~~
> >> drivers/gpu/drm/i915/i915_pci.c:242:11: note: expanded from macro 'GEN3_FEATURES'
> >> .color = i9xx_colors, \
> >> ^~~~~~~~~~~
> >> drivers/gpu/drm/i915/i915_pci.c:333:2: error: initializer element is not a compile-time constant
> >> GEN4_FEATURES,
> >> ^~~~~~~~~~~~~
> >> drivers/gpu/drm/i915/i915_pci.c:328:11: note: expanded from macro 'GEN4_FEATURES'
> >> .color = i965_colors, \
> >> ^~~~~~~~~~~
> >> drivers/gpu/drm/i915/i915_pci.c:341:2: error: initializer element is not a compile-time constant
> >> GEN4_FEATURES,
> >> ^~~~~~~~~~~~~
> >> drivers/gpu/drm/i915/i915_pci.c:328:11: note: expanded from macro 'GEN4_FEATURES'
> >> .color = i965_colors, \
> >> ^~~~~~~~~~~
> >> drivers/gpu/drm/i915/i915_pci.c:352:2: error: initializer element is not a compile-time constant
> >> GEN4_FEATURES,
> >> ^~~~~~~~~~~~~
> >> drivers/gpu/drm/i915/i915_pci.c:328:11: note: expanded from macro 'GEN4_FEATURES'
> >> .color = i965_colors, \
> >> ^~~~~~~~~~~
> >> drivers/gpu/drm/i915/i915_pci.c:359:2: error: initializer element is not a compile-time constant
> >> GEN4_FEATURES,
> >> ^~~~~~~~~~~~~
> >> drivers/gpu/drm/i915/i915_pci.c:328:11: note: expanded from macro 'GEN4_FEATURES'
> >> .color = i965_colors, \
> >> ^~~~~~~~~~~
> >> drivers/gpu/drm/i915/i915_pci.c:384:2: error: initializer element is not a compile-time constant
> >> GEN5_FEATURES,
> >> ^~~~~~~~~~~~~
> >> drivers/gpu/drm/i915/i915_pci.c:379:11: note: expanded from macro 'GEN5_FEATURES'
> >> .color = ilk_colors, \
> >> ^~~~~~~~~~
> >> drivers/gpu/drm/i915/i915_pci.c:389:2: error: initializer element is not a compile-time constant
> >> GEN5_FEATURES,
> >> ^~~~~~~~~~~~~
> >> drivers/gpu/drm/i915/i915_pci.c:379:11: note: expanded from macro 'GEN5_FEATURES'
> >> .color = ilk_colors, \
> >>
> >> vim +212 drivers/gpu/drm/i915/i915_pci.c
> >>
> >> da1184cd41d4c6b Matthew Auld 2019-10-18 172
> >> 37fbbd49054b624 Ville Syrjälä 2019-03-05 173 #define I830_FEATURES \
> >> 37fbbd49054b624 Ville Syrjälä 2019-03-05 174 GEN(2), \
> >> 37fbbd49054b624 Ville Syrjälä 2019-03-05 175 .is_mobile = 1, \
> >> 8d8b00318593e28 Jani Nikula 2019-09-11 176 .pipe_mask = BIT(PIPE_A) | BIT(PIPE_B), \
> >> 37fbbd49054b624 Ville Syrjälä 2019-03-05 177 .display.has_overlay = 1, \
> >> 37fbbd49054b624 Ville Syrjälä 2019-03-05 178 .display.cursor_needs_physical = 1, \
> >> 37fbbd49054b624 Ville Syrjälä 2019-03-05 179 .display.overlay_needs_physical = 1, \
> >> 37fbbd49054b624 Ville Syrjälä 2019-03-05 180 .display.has_gmch = 1, \
> >> 37fbbd49054b624 Ville Syrjälä 2019-03-05 181 .gpu_reset_clobbers_display = true, \
> >> 37fbbd49054b624 Ville Syrjälä 2019-03-05 182 .hws_needs_physical = 1, \
> >> 37fbbd49054b624 Ville Syrjälä 2019-03-05 183 .unfenced_needs_alignment = 1, \
> >> 37fbbd49054b624 Ville Syrjälä 2019-03-05 184 .engine_mask = BIT(RCS0), \
> >> 37fbbd49054b624 Ville Syrjälä 2019-03-05 185 .has_snoop = true, \
> >> 37fbbd49054b624 Ville Syrjälä 2019-03-05 186 .has_coherent_ggtt = false, \
> >> 37fbbd49054b624 Ville Syrjälä 2019-03-05 187 I9XX_PIPE_OFFSETS, \
> >> 37fbbd49054b624 Ville Syrjälä 2019-03-05 188 I9XX_CURSOR_OFFSETS, \
> >> c8b57de4e93bccf Jani Nikula 2020-03-05 189 .color = i9xx_colors, \
> >> 2411ccdddd53007 Jani Nikula 2020-03-05 190 .page_sizes = GEN_DEFAULT_PAGE_SIZES, \
> >> 980a85a19e6db48 Jani Nikula 2020-03-05 191 .memory_regions = GEN_DEFAULT_REGIONS
> >> 37fbbd49054b624 Ville Syrjälä 2019-03-05 192
> >> 37fbbd49054b624 Ville Syrjälä 2019-03-05 193 #define I845_FEATURES \
> >> bc76298e68e791f Chris Wilson 2018-02-15 194 GEN(2), \
> >> 8d8b00318593e28 Jani Nikula 2019-09-11 195 .pipe_mask = BIT(PIPE_A), \
> >> d53db442db36fdb José Roberto de Souza 2018-11-30 196 .display.has_overlay = 1, \
> >> d53db442db36fdb José Roberto de Souza 2018-11-30 197 .display.overlay_needs_physical = 1, \
> >> b2ae318acdcaf1c Rodrigo Vivi 2019-02-04 198 .display.has_gmch = 1, \
> >> 55277e1f3107c0b Chris Wilson 2019-01-03 199 .gpu_reset_clobbers_display = true, \
> >> 3177659a41cc436 Carlos Santa 2016-08-17 200 .hws_needs_physical = 1, \
> >> f4ce766f28cd0ef Chris Wilson 2017-03-25 201 .unfenced_needs_alignment = 1, \
> >> 8a68d464366efb5 Chris Wilson 2019-03-05 202 .engine_mask = BIT(RCS0), \
> >> 5d95c24867aea8a Chris Wilson 2017-09-06 203 .has_snoop = true, \
> >> 900ccf30f9e112b Chris Wilson 2018-07-20 204 .has_coherent_ggtt = false, \
> >> 37fbbd49054b624 Ville Syrjälä 2019-03-05 205 I845_PIPE_OFFSETS, \
> >> 37fbbd49054b624 Ville Syrjälä 2019-03-05 206 I845_CURSOR_OFFSETS, \
> >> c8b57de4e93bccf Jani Nikula 2020-03-05 207 .color = i9xx_colors, \
> >> 2411ccdddd53007 Jani Nikula 2020-03-05 208 .page_sizes = GEN_DEFAULT_PAGE_SIZES, \
> >> 980a85a19e6db48 Jani Nikula 2020-03-05 209 .memory_regions = GEN_DEFAULT_REGIONS
> >> 0eec8dc7f628a8d Carlos Santa 2016-08-17 210
> >> 31409fff1a392fa Lucas De Marchi 2019-12-24 211 static const struct intel_device_info i830_info = {
> >> 37fbbd49054b624 Ville Syrjälä 2019-03-05 @212 I830_FEATURES,
> >> c5cb21c17a169ee Chris Wilson 2018-02-15 213 PLATFORM(INTEL_I830),
> >> 42f5551d276921d Chris Wilson 2016-06-24 214 };
> >> 42f5551d276921d Chris Wilson 2016-06-24 215
> >>
> >> :::::: The code at line 212 was first introduced by commit
> >> :::::: 37fbbd49054b624400a65cf1a39f152a7f3f4749 drm/i915: Populate pipe_offsets[] & co. accurately
> >>
> >> :::::: TO: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >> :::::: CC: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >>
> >> ---
> >> 0-DAY CI Kernel Test Service, Intel Corporation
> >> https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
> >>
> >> --
> >> You received this message because you are subscribed to the Google Groups "Clang Built Linux" group.
> >> To unsubscribe from this group and stop receiving emails from it, send an email to clang-built-linux+unsubscribe(a)googlegroups.com.
> >> To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/202003060916.RI5pROBS%25lkp%40intel.com.
>
> --
> Jani Nikula, Intel Open Source Graphics Center
--
Thanks,
~Nick Desaulniers
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [jani:device-info-inheritance-v3 3/19] drivers/gpu/drm/i915/i915_pci.c:212:2: error: initializer element is not a compile-time constant
2020-03-09 18:03 ` Nick Desaulniers
@ 2020-03-10 8:51 ` Jani Nikula
2020-03-10 15:58 ` Philip Li
2020-03-16 23:29 ` Nick Desaulniers
0 siblings, 2 replies; 7+ messages in thread
From: Jani Nikula @ 2020-03-10 8:51 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 1710 bytes --]
On Mon, 09 Mar 2020, Nick Desaulniers <ndesaulniers@google.com> wrote:
> On Mon, Mar 9, 2020 at 1:32 AM Jani Nikula <jani.nikula@linux.intel.com> wrote:
>>
>> On Fri, 06 Mar 2020, Nick Desaulniers <ndesaulniers@google.com> wrote:
>> > Based on the tree, I think this report was meant to go to Jani (cc'ed)?
>>
>> It baffles me that the build bot burns resources on building random
>> branches in my personal repositories.
>
> It uses a branch naming convention to avoid testing branches:
> https://github.com/intel/lkp-tests/wiki/LKP-FAQ#is-there-a-way-not-to-trigger-kbuild-tests-on-a-specific-branch
>
> But in this case, it seems it caught a build breakage even further
> upstream, which is valuable, right?
I guess, though I usually only use it to share some half-baked
stuff. Perhaps I'll also start using it for build testing some of the
more obscure ideas. ;)
>> That said, this builds on GCC 8 just fine. Is clang not able to do this?
>
> Places that require integer constant expressions can be very subtle.
> See this recent example in i915 for example:
> https://github.com/ClangBuiltLinux/linux/issues/918
> Sometimes reproducing also depends on some configs. In this case,
> it's not as I've fetched your branch and can repro on defconfig.
Yeah, reminds me of earlier issues with GCC and Clang having different
order in certain checks and optimizations, leading to Clang warnings in
code that GCC just optimized away.
> This is definitely our bug: https://bugs.llvm.org/show_bug.cgi?id=45157
Any idea if older GCC is also limited in this regard? What versions does
the kbuild bot test?
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [jani:device-info-inheritance-v3 3/19] drivers/gpu/drm/i915/i915_pci.c:212:2: error: initializer element is not a compile-time constant
2020-03-10 8:51 ` Jani Nikula
@ 2020-03-10 15:58 ` Philip Li
2020-03-16 23:29 ` Nick Desaulniers
1 sibling, 0 replies; 7+ messages in thread
From: Philip Li @ 2020-03-10 15:58 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 2236 bytes --]
On Tue, Mar 10, 2020 at 10:51:29AM +0200, Jani Nikula wrote:
> On Mon, 09 Mar 2020, Nick Desaulniers <ndesaulniers@google.com> wrote:
> > On Mon, Mar 9, 2020 at 1:32 AM Jani Nikula <jani.nikula@linux.intel.com> wrote:
> >>
> >> On Fri, 06 Mar 2020, Nick Desaulniers <ndesaulniers@google.com> wrote:
> >> > Based on the tree, I think this report was meant to go to Jani (cc'ed)?
> >>
> >> It baffles me that the build bot burns resources on building random
> >> branches in my personal repositories.
> >
> > It uses a branch naming convention to avoid testing branches:
> > https://github.com/intel/lkp-tests/wiki/LKP-FAQ#is-there-a-way-not-to-trigger-kbuild-tests-on-a-specific-branch
> >
> > But in this case, it seems it caught a build breakage even further
> > upstream, which is valuable, right?
>
> I guess, though I usually only use it to share some half-baked
> stuff. Perhaps I'll also start using it for build testing some of the
> more obscure ideas. ;)
>
> >> That said, this builds on GCC 8 just fine. Is clang not able to do this?
> >
> > Places that require integer constant expressions can be very subtle.
> > See this recent example in i915 for example:
> > https://github.com/ClangBuiltLinux/linux/issues/918
> > Sometimes reproducing also depends on some configs. In this case,
> > it's not as I've fetched your branch and can repro on defconfig.
>
> Yeah, reminds me of earlier issues with GCC and Clang having different
> order in certain checks and optimizations, leading to Clang warnings in
> code that GCC just optimized away.
>
> > This is definitely our bug: https://bugs.llvm.org/show_bug.cgi?id=45157
>
> Any idea if older GCC is also limited in this regard? What versions does
> the kbuild bot test?
Hi Jani, we have gcc-4.9/gcc-5/gcc-6/gcc-7 now, gcc-7 is default, and others
will be picked up randomly, thus it may not have chance to test this commit
yet, we can give a try to let you know later.
>
> BR,
> Jani.
>
>
>
> --
> Jani Nikula, Intel Open Source Graphics Center
> _______________________________________________
> kbuild-all mailing list -- kbuild-all(a)lists.01.org
> To unsubscribe send an email to kbuild-all-leave(a)lists.01.org
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [jani:device-info-inheritance-v3 3/19] drivers/gpu/drm/i915/i915_pci.c:212:2: error: initializer element is not a compile-time constant
2020-03-10 8:51 ` Jani Nikula
2020-03-10 15:58 ` Philip Li
@ 2020-03-16 23:29 ` Nick Desaulniers
1 sibling, 0 replies; 7+ messages in thread
From: Nick Desaulniers @ 2020-03-16 23:29 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 3097 bytes --]
On Tue, Mar 10, 2020 at 1:51 AM Jani Nikula <jani.nikula@linux.intel.com> wrote:
>
> On Mon, 09 Mar 2020, Nick Desaulniers <ndesaulniers@google.com> wrote:
> > On Mon, Mar 9, 2020 at 1:32 AM Jani Nikula <jani.nikula@linux.intel.com> wrote:
> >>
> >> On Fri, 06 Mar 2020, Nick Desaulniers <ndesaulniers@google.com> wrote:
> >> > Based on the tree, I think this report was meant to go to Jani (cc'ed)?
> >>
> >> It baffles me that the build bot burns resources on building random
> >> branches in my personal repositories.
> >
> > It uses a branch naming convention to avoid testing branches:
> > https://github.com/intel/lkp-tests/wiki/LKP-FAQ#is-there-a-way-not-to-trigger-kbuild-tests-on-a-specific-branch
> >
> > But in this case, it seems it caught a build breakage even further
> > upstream, which is valuable, right?
>
> I guess, though I usually only use it to share some half-baked
> stuff. Perhaps I'll also start using it for build testing some of the
> more obscure ideas. ;)
>
> >> That said, this builds on GCC 8 just fine. Is clang not able to do this?
> >
> > Places that require integer constant expressions can be very subtle.
> > See this recent example in i915 for example:
> > https://github.com/ClangBuiltLinux/linux/issues/918
> > Sometimes reproducing also depends on some configs. In this case,
> > it's not as I've fetched your branch and can repro on defconfig.
So I've been taking a crack at implementing this in Clang.
https://reviews.llvm.org/D76096 Turns out the problem is very closely
related to `constexpr` handling in C++. It seems there's already
machinery for this, but it's explicitly disabled
(https://reviews.llvm.org/D76169) because if you have a huge array or
struct or deeply nested struct, it can take a while to verify that
every single element/member is itself a constant expression.
Further, the C standard has language about initializer lists and
constant expressions, but provides no guidance on structs being
treated as constant expressions, though it has a vague loophole about
what may be considered constant expressions. ("An implementation may
accept other forms of constant expressions."). From what I can tell,
this seems like a GNU C extension, but one that's not documented,
AFAICT. Certainly would be something the ISO WG14 could provide more
clarification on. See discussion in
https://bugs.llvm.org/show_bug.cgi?id=45157.
I'll try to push further on this, but the comments in Clang came from
the owner of the codebase, who also happens to be the ISO WG21 spec
editor, so we'll see...
>
> Yeah, reminds me of earlier issues with GCC and Clang having different
> order in certain checks and optimizations, leading to Clang warnings in
> code that GCC just optimized away.
>
> > This is definitely our bug: https://bugs.llvm.org/show_bug.cgi?id=45157
>
> Any idea if older GCC is also limited in this regard? What versions does
> the kbuild bot test?
>
> BR,
> Jani.
>
>
>
> --
> Jani Nikula, Intel Open Source Graphics Center
--
Thanks,
~Nick Desaulniers
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-03-16 23:29 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-06 1:30 [jani:device-info-inheritance-v3 3/19] drivers/gpu/drm/i915/i915_pci.c:212:2: error: initializer element is not a compile-time constant kbuild test robot
2020-03-06 17:30 ` Nick Desaulniers
2020-03-09 8:32 ` Jani Nikula
2020-03-09 18:03 ` Nick Desaulniers
2020-03-10 8:51 ` Jani Nikula
2020-03-10 15:58 ` Philip Li
2020-03-16 23:29 ` Nick Desaulniers
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.