* Remaining sparse warnings
@ 2019-05-29 16:41 Kalle Valo
2019-05-31 3:51 ` Vasanthakumar Thiagarajan
0 siblings, 1 reply; 3+ messages in thread
From: Kalle Valo @ 2019-05-29 16:41 UTC (permalink / raw)
To: ath11k
Hi,
there are still few sparse warnings, anyone willing to fix the last
ones? Though I'm not sure how to fix "dubious: x & !y" warnings, any
ideas?
drivers/net/wireless/ath/ath11k/hal_rx.c:118:17: warning: dubious: x & !y
drivers/net/wireless/ath/ath11k/hal_rx.c:120:17: warning: dubious: x & !y
drivers/net/wireless/ath/ath11k/hal_rx.c:122:17: warning: dubious: x & !y
drivers/net/wireless/ath/ath11k/hal_rx.c:124:17: warning: dubious: x & !y
drivers/net/wireless/ath/ath11k/hal_rx.c:126:17: warning: dubious: x & !y
drivers/net/wireless/ath/ath11k/hal_rx.c:128:17: warning: dubious: x & !y
drivers/net/wireless/ath/ath11k/hal_rx.c:130:17: warning: dubious: x & !y
drivers/net/wireless/ath/ath11k/hal_rx.c:132:17: warning: dubious: x & !y
drivers/net/wireless/ath/ath11k/hal_rx.c:134:17: warning: dubious: x & !y
drivers/net/wireless/ath/ath11k/hal_rx.c:136:17: warning: dubious: x & !y
drivers/net/wireless/ath/ath11k/hal_rx.c:138:17: warning: dubious: x & !y
drivers/net/wireless/ath/ath11k/hal_rx.c:140:17: warning: dubious: x & !y
drivers/net/wireless/ath/ath11k/hal_rx.c:142:17: warning: dubious: x & !y
drivers/net/wireless/ath/ath11k/hal_rx.c:144:17: warning: dubious: x & !y
drivers/net/wireless/ath/ath11k/hal_rx.c:146:17: warning: dubious: x & !y
drivers/net/wireless/ath/ath11k/hal_rx.c:148:17: warning: dubious: x & !y
drivers/net/wireless/ath/ath11k/hal_rx.c:150:17: warning: dubious: x & !y
drivers/net/wireless/ath/ath11k/hal_rx.c:152:17: warning: dubious: x & !y
drivers/net/wireless/ath/ath11k/hal_rx.c:154:17: warning: dubious: x & !y
drivers/net/wireless/ath/ath11k/hal_rx.c:156:17: warning: dubious: x & !y
drivers/net/wireless/ath/ath11k/hal_rx.c:158:17: warning: dubious: x & !y
drivers/net/wireless/ath/ath11k/hal_rx.c:160:17: warning: dubious: x & !y
drivers/net/wireless/ath/ath11k/hal_rx.c:166:17: warning: dubious: x & !y
drivers/net/wireless/ath/ath11k/hal_rx.c:170:17: warning: dubious: x & !y
drivers/net/wireless/ath/ath11k/hal_rx.c:172:17: warning: dubious: x & !y
drivers/net/wireless/ath/ath11k/hal_rx.c:176:17: warning: dubious: x & !y
drivers/net/wireless/ath/ath11k/hal_rx.c:178:17: warning: dubious: x & !y
drivers/net/wireless/ath/ath11k/hal_rx.c:180:17: warning: dubious: x & !y
drivers/net/wireless/ath/ath11k/hal_rx.c:182:17: warning: dubious: x & !y
drivers/net/wireless/ath/ath11k/hal_rx.c:184:17: warning: dubious: x & !y
drivers/net/wireless/ath/ath11k/hal_rx.c:186:17: warning: dubious: x & !y
drivers/net/wireless/ath/ath11k/hal_rx.c:188:17: warning: dubious: x & !y
drivers/net/wireless/ath/ath11k/hal_rx.c:190:17: warning: dubious: x & !y
drivers/net/wireless/ath/ath11k/hal_rx.c:192:17: warning: dubious: x & !y
drivers/net/wireless/ath/ath11k/hal_rx.c:212:17: warning: dubious: x & !y
drivers/net/wireless/ath/ath11k/hal_rx.c:216:17: warning: dubious: x & !y
drivers/net/wireless/ath/ath11k/hal_rx.c:218:17: warning: dubious: x & !y
drivers/net/wireless/ath/ath11k/dp_tx.c:665:23: warning: dubious: x & !y
drivers/net/wireless/ath/ath11k/dp_tx.c:667:23: warning: dubious: x & !y
drivers/net/wireless/ath/ath11k/dp_tx.c:670:23: warning: dubious: x & !y
drivers/net/wireless/ath/ath11k/dp_tx.c:830:23: warning: dubious: x & !y
drivers/net/wireless/ath/ath11k/dp_tx.c:832:23: warning: dubious: x & !y
drivers/net/wireless/ath/ath11k/dp_tx.c:837:33: warning: incorrect type in assignment (different base types)
drivers/net/wireless/ath/ath11k/dp_tx.c:837:33: expected unsigned int [usertype] pkt_type_en_flags0
drivers/net/wireless/ath/ath11k/dp_tx.c:837:33: got restricted __le32 [usertype]
drivers/net/wireless/ath/ath11k/dp_tx.c:838:33: warning: incorrect type in assignment (different base types)
drivers/net/wireless/ath/ath11k/dp_tx.c:838:33: expected unsigned int [usertype] pkt_type_en_flags1
drivers/net/wireless/ath/ath11k/dp_tx.c:838:33: got restricted __le32 [usertype]
drivers/net/wireless/ath/ath11k/dp_tx.c:839:33: warning: incorrect type in assignment (different base types)
drivers/net/wireless/ath/ath11k/dp_tx.c:839:33: expected unsigned int [usertype] pkt_type_en_flags2
drivers/net/wireless/ath/ath11k/dp_tx.c:839:33: got restricted __le32 [usertype]
drivers/net/wireless/ath/ath11k/dp_tx.c:840:33: warning: incorrect type in assignment (different base types)
drivers/net/wireless/ath/ath11k/dp_tx.c:840:33: expected unsigned int [usertype] pkt_type_en_flags3
drivers/net/wireless/ath/ath11k/dp_tx.c:840:33: got restricted __le32 [usertype]
drivers/net/wireless/ath/ath11k/dp_tx.c:841:28: warning: incorrect type in assignment (different base types)
drivers/net/wireless/ath/ath11k/dp_tx.c:841:28: expected unsigned int [usertype] rx_filter_tlv
drivers/net/wireless/ath/ath11k/dp_tx.c:841:28: got restricted __le32 [usertype]
--
Kalle Valo
_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Remaining sparse warnings
2019-05-29 16:41 Remaining sparse warnings Kalle Valo
@ 2019-05-31 3:51 ` Vasanthakumar Thiagarajan
2019-05-31 14:33 ` Kalle Valo
0 siblings, 1 reply; 3+ messages in thread
From: Vasanthakumar Thiagarajan @ 2019-05-31 3:51 UTC (permalink / raw)
To: ath11k@lists.infradead.org
On Wednesday 29 May 2019 10:11 PM, Kalle Valo wrote:
> Hi,
>
> there are still few sparse warnings, anyone willing to fix the last
> ones? Though I'm not sure how to fix "dubious: x & !y" warnings, any
> ideas?
>
> drivers/net/wireless/ath/ath11k/hal_rx.c:118:17: warning: dubious: x & !y
> drivers/net/wireless/ath/ath11k/hal_rx.c:120:17: warning: dubious: x & !y
> drivers/net/wireless/ath/ath11k/hal_rx.c:122:17: warning: dubious: x & !y
> drivers/net/wireless/ath/ath11k/hal_rx.c:124:17: warning: dubious: x & !y
> drivers/net/wireless/ath/ath11k/hal_rx.c:126:17: warning: dubious: x & !y
> drivers/net/wireless/ath/ath11k/hal_rx.c:128:17: warning: dubious: x & !y
> drivers/net/wireless/ath/ath11k/hal_rx.c:130:17: warning: dubious: x & !y
> drivers/net/wireless/ath/ath11k/hal_rx.c:132:17: warning: dubious: x & !y
> drivers/net/wireless/ath/ath11k/hal_rx.c:134:17: warning: dubious: x & !y
> drivers/net/wireless/ath/ath11k/hal_rx.c:136:17: warning: dubious: x & !y
> drivers/net/wireless/ath/ath11k/hal_rx.c:138:17: warning: dubious: x & !y
> drivers/net/wireless/ath/ath11k/hal_rx.c:140:17: warning: dubious: x & !y
> drivers/net/wireless/ath/ath11k/hal_rx.c:142:17: warning: dubious: x & !y
> drivers/net/wireless/ath/ath11k/hal_rx.c:144:17: warning: dubious: x & !y
> drivers/net/wireless/ath/ath11k/hal_rx.c:146:17: warning: dubious: x & !y
> drivers/net/wireless/ath/ath11k/hal_rx.c:148:17: warning: dubious: x & !y
> drivers/net/wireless/ath/ath11k/hal_rx.c:150:17: warning: dubious: x & !y
> drivers/net/wireless/ath/ath11k/hal_rx.c:152:17: warning: dubious: x & !y
> drivers/net/wireless/ath/ath11k/hal_rx.c:154:17: warning: dubious: x & !y
> drivers/net/wireless/ath/ath11k/hal_rx.c:156:17: warning: dubious: x & !y
> drivers/net/wireless/ath/ath11k/hal_rx.c:158:17: warning: dubious: x & !y
> drivers/net/wireless/ath/ath11k/hal_rx.c:160:17: warning: dubious: x & !y
> drivers/net/wireless/ath/ath11k/hal_rx.c:166:17: warning: dubious: x & !y
> drivers/net/wireless/ath/ath11k/hal_rx.c:170:17: warning: dubious: x & !y
> drivers/net/wireless/ath/ath11k/hal_rx.c:172:17: warning: dubious: x & !y
> drivers/net/wireless/ath/ath11k/hal_rx.c:176:17: warning: dubious: x & !y
> drivers/net/wireless/ath/ath11k/hal_rx.c:178:17: warning: dubious: x & !y
> drivers/net/wireless/ath/ath11k/hal_rx.c:180:17: warning: dubious: x & !y
> drivers/net/wireless/ath/ath11k/hal_rx.c:182:17: warning: dubious: x & !y
> drivers/net/wireless/ath/ath11k/hal_rx.c:184:17: warning: dubious: x & !y
> drivers/net/wireless/ath/ath11k/hal_rx.c:186:17: warning: dubious: x & !y
> drivers/net/wireless/ath/ath11k/hal_rx.c:188:17: warning: dubious: x & !y
> drivers/net/wireless/ath/ath11k/hal_rx.c:190:17: warning: dubious: x & !y
> drivers/net/wireless/ath/ath11k/hal_rx.c:192:17: warning: dubious: x & !y
> drivers/net/wireless/ath/ath11k/hal_rx.c:212:17: warning: dubious: x & !y
> drivers/net/wireless/ath/ath11k/hal_rx.c:216:17: warning: dubious: x & !y
> drivers/net/wireless/ath/ath11k/hal_rx.c:218:17: warning: dubious: x & !y
> drivers/net/wireless/ath/ath11k/dp_tx.c:665:23: warning: dubious: x & !y
> drivers/net/wireless/ath/ath11k/dp_tx.c:667:23: warning: dubious: x & !y
> drivers/net/wireless/ath/ath11k/dp_tx.c:670:23: warning: dubious: x & !y
> drivers/net/wireless/ath/ath11k/dp_tx.c:830:23: warning: dubious: x & !y
> drivers/net/wireless/ath/ath11k/dp_tx.c:832:23: warning: dubious: x & !y
To me, this seems like a false warning, I do not see any issue with the way values are passed
to FIELD_PREP() macro.
> drivers/net/wireless/ath/ath11k/dp_tx.c:837:33: warning: incorrect type in assignment (different base types)
> drivers/net/wireless/ath/ath11k/dp_tx.c:837:33: expected unsigned int [usertype] pkt_type_en_flags0
> drivers/net/wireless/ath/ath11k/dp_tx.c:837:33: got restricted __le32 [usertype]
> drivers/net/wireless/ath/ath11k/dp_tx.c:838:33: warning: incorrect type in assignment (different base types)
> drivers/net/wireless/ath/ath11k/dp_tx.c:838:33: expected unsigned int [usertype] pkt_type_en_flags1
> drivers/net/wireless/ath/ath11k/dp_tx.c:838:33: got restricted __le32 [usertype]
> drivers/net/wireless/ath/ath11k/dp_tx.c:839:33: warning: incorrect type in assignment (different base types)
> drivers/net/wireless/ath/ath11k/dp_tx.c:839:33: expected unsigned int [usertype] pkt_type_en_flags2
> drivers/net/wireless/ath/ath11k/dp_tx.c:839:33: got restricted __le32 [usertype]
> drivers/net/wireless/ath/ath11k/dp_tx.c:840:33: warning: incorrect type in assignment (different base types)
> drivers/net/wireless/ath/ath11k/dp_tx.c:840:33: expected unsigned int [usertype] pkt_type_en_flags3
> drivers/net/wireless/ath/ath11k/dp_tx.c:840:33: got restricted __le32 [usertype]
> drivers/net/wireless/ath/ath11k/dp_tx.c:841:28: warning: incorrect type in assignment (different base types)
> drivers/net/wireless/ath/ath11k/dp_tx.c:841:28: expected unsigned int [usertype] rx_filter_tlv
> drivers/net/wireless/ath/ath11k/dp_tx.c:841:28: got restricted __le32 [usertype]
>
Ill take a loot at these warnings.
Vasanth
_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Remaining sparse warnings
2019-05-31 3:51 ` Vasanthakumar Thiagarajan
@ 2019-05-31 14:33 ` Kalle Valo
0 siblings, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2019-05-31 14:33 UTC (permalink / raw)
To: Vasanthakumar Thiagarajan; +Cc: ath11k@lists.infradead.org
Vasanthakumar Thiagarajan <vthiagar@qti.qualcomm.com> writes:
> On Wednesday 29 May 2019 10:11 PM, Kalle Valo wrote:
>>
>> there are still few sparse warnings, anyone willing to fix the last
>> ones? Though I'm not sure how to fix "dubious: x & !y" warnings, any
>> ideas?
>>
>> drivers/net/wireless/ath/ath11k/hal_rx.c:118:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:120:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:122:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:124:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:126:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:128:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:130:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:132:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:134:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:136:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:138:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:140:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:142:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:144:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:146:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:148:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:150:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:152:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:154:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:156:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:158:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:160:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:166:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:170:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:172:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:176:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:178:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:180:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:182:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:184:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:186:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:188:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:190:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:192:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:212:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:216:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/hal_rx.c:218:17: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/dp_tx.c:665:23: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/dp_tx.c:667:23: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/dp_tx.c:670:23: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/dp_tx.c:830:23: warning: dubious: x & !y
>> drivers/net/wireless/ath/ath11k/dp_tx.c:832:23: warning: dubious: x & !y
>
> To me, this seems like a false warning, I do not see any issue with
> the way values are passed
> to FIELD_PREP() macro.
Me neither. I think I'll filter out all "dubious:" warnings in my
ath11k-check script for now. Let's just hope we don't miss any real
warnings because of this.
>> drivers/net/wireless/ath/ath11k/dp_tx.c:837:33: warning: incorrect
>> type in assignment (different base types)
>> drivers/net/wireless/ath/ath11k/dp_tx.c:837:33: expected unsigned
>> int [usertype] pkt_type_en_flags0
>> drivers/net/wireless/ath/ath11k/dp_tx.c:837:33: got restricted __le32 [usertype]
>> drivers/net/wireless/ath/ath11k/dp_tx.c:838:33: warning: incorrect
>> type in assignment (different base types)
>> drivers/net/wireless/ath/ath11k/dp_tx.c:838:33: expected unsigned
>> int [usertype] pkt_type_en_flags1
>> drivers/net/wireless/ath/ath11k/dp_tx.c:838:33: got restricted __le32 [usertype]
>> drivers/net/wireless/ath/ath11k/dp_tx.c:839:33: warning: incorrect
>> type in assignment (different base types)
>> drivers/net/wireless/ath/ath11k/dp_tx.c:839:33: expected unsigned
>> int [usertype] pkt_type_en_flags2
>> drivers/net/wireless/ath/ath11k/dp_tx.c:839:33: got restricted __le32 [usertype]
>> drivers/net/wireless/ath/ath11k/dp_tx.c:840:33: warning: incorrect
>> type in assignment (different base types)
>> drivers/net/wireless/ath/ath11k/dp_tx.c:840:33: expected unsigned
>> int [usertype] pkt_type_en_flags3
>> drivers/net/wireless/ath/ath11k/dp_tx.c:840:33: got restricted __le32 [usertype]
>> drivers/net/wireless/ath/ath11k/dp_tx.c:841:28: warning: incorrect
>> type in assignment (different base types)
>> drivers/net/wireless/ath/ath11k/dp_tx.c:841:28: expected unsigned
>> int [usertype] rx_filter_tlv
>> drivers/net/wireless/ath/ath11k/dp_tx.c:841:28: got restricted __le32 [usertype]
>>
>
> Ill take a loot at these warnings.
Thanks!
--
Kalle Valo
_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-05-31 14:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-29 16:41 Remaining sparse warnings Kalle Valo
2019-05-31 3:51 ` Vasanthakumar Thiagarajan
2019-05-31 14:33 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.