Re: [RFC PATCH] drm/panfrost: Add initial panfrost driver

[Eric Anholt <eric@anholt.net>]

[-- Attachment #1.1: Type: text/plain, Size: 1335 bytes --]

Rob Herring <robh@kernel.org> writes:

> On Fri, Mar 8, 2019 at 10:29 AM Eric Anholt <eric@anholt.net> wrote:
>>
>> Rob Herring <robh@kernel.org> writes:
>>
>> > From: "Marty E. Plummer" <hanetzer@startmail.com>
>> >
>> > This adds the initial driver for panfrost which supports Arm Mali
>> > Midgard and Bifrost family of GPUs. Currently, only the T860 Midgard GPU
>> > has been tested.
>
> [...]
>
>> It looks like you've got v3d's silliness with the fences -- we reserve a
>> shared slot, then use excl only anyway.  For v3d I'm planning on moving
>> to just excl -- only one of my entrypoints has info on write vs
>> read-only, and I don't know of a usecase where having multiple read-only
>> consumers of a shared buffer simultaneously matters.
>>
>> More importantly, I think you also have my bug of not doing implicit
>> synchronization on buffers, which will break X11 rendering
>> sometimes. X11's GL requirements are that previously-submitted rendering
>> by the client fd will execute before X11's rendering on its fd to the
>> same buffers.  If you're running a single client, X11's copies are cheap
>> enough that it'll probably work out most of the time.
>
> Is there a fix for this? I didn't find anything that looked like one.

Missed this part.

I'm thinking something like what the lima driver has for implicit sync.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel