* [Qemu-devel] [RFC for 3.0] tests/tpm-emu: double the timeout
@ 2018-07-06 8:06 Alex Bennée
2018-07-06 9:26 ` Marc-André Lureau
0 siblings, 1 reply; 5+ messages in thread
From: Alex Bennée @ 2018-07-06 8:06 UTC (permalink / raw)
To: peter.maydell; +Cc: qemu-devel, Alex Bennée, Stefan Berger
We see various failures on Travis so lets just double the timeout and
see if that makes them go away.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
tests/tpm-emu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/tpm-emu.c b/tests/tpm-emu.c
index 8c2bd53cad..308f1884f6 100644
--- a/tests/tpm-emu.c
+++ b/tests/tpm-emu.c
@@ -20,7 +20,7 @@
void tpm_emu_test_wait_cond(TestState *s)
{
- gint64 end_time = g_get_monotonic_time() + 5 * G_TIME_SPAN_SECOND;
+ gint64 end_time = g_get_monotonic_time() + 10 * G_TIME_SPAN_SECOND;
g_mutex_lock(&s->data_mutex);
if (!g_cond_wait_until(&s->data_cond, &s->data_mutex, end_time)) {
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [RFC for 3.0] tests/tpm-emu: double the timeout
2018-07-06 8:06 [Qemu-devel] [RFC for 3.0] tests/tpm-emu: double the timeout Alex Bennée
@ 2018-07-06 9:26 ` Marc-André Lureau
2018-07-06 10:19 ` Alex Bennée
0 siblings, 1 reply; 5+ messages in thread
From: Marc-André Lureau @ 2018-07-06 9:26 UTC (permalink / raw)
To: Alex Bennée; +Cc: Peter Maydell, QEMU, Stefan Berger
Hi
On Fri, Jul 6, 2018 at 10:06 AM, Alex Bennée <alex.bennee@linaro.org> wrote:
> We see various failures on Travis so lets just double the timeout and
> see if that makes them go away.
This is just waiting for the thread to start and open a socket. It
shouldn't be a problem to wait longer, but do you have a Travis error
log?
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> tests/tpm-emu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/tpm-emu.c b/tests/tpm-emu.c
> index 8c2bd53cad..308f1884f6 100644
> --- a/tests/tpm-emu.c
> +++ b/tests/tpm-emu.c
> @@ -20,7 +20,7 @@
>
> void tpm_emu_test_wait_cond(TestState *s)
> {
> - gint64 end_time = g_get_monotonic_time() + 5 * G_TIME_SPAN_SECOND;
> + gint64 end_time = g_get_monotonic_time() + 10 * G_TIME_SPAN_SECOND;
>
> g_mutex_lock(&s->data_mutex);
> if (!g_cond_wait_until(&s->data_cond, &s->data_mutex, end_time)) {
> --
> 2.17.1
>
>
--
Marc-André Lureau
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [RFC for 3.0] tests/tpm-emu: double the timeout
2018-07-06 9:26 ` Marc-André Lureau
@ 2018-07-06 10:19 ` Alex Bennée
2018-07-06 10:24 ` Marc-André Lureau
0 siblings, 1 reply; 5+ messages in thread
From: Alex Bennée @ 2018-07-06 10:19 UTC (permalink / raw)
To: Marc-André Lureau; +Cc: Peter Maydell, QEMU, Stefan Berger
Marc-André Lureau <marcandre.lureau@gmail.com> writes:
> Hi
>
> On Fri, Jul 6, 2018 at 10:06 AM, Alex Bennée <alex.bennee@linaro.org> wrote:
>> We see various failures on Travis so lets just double the timeout and
>> see if that makes them go away.
>
> This is just waiting for the thread to start and open a socket. It
> shouldn't be a problem to wait longer, but do you have a Travis error
> log?
For example:
https://travis-ci.org/qemu/qemu/jobs/400436724#L8971
GTESTER check-qtest-i386
**
ERROR:tests/tpm-emu.c:27:tpm_emu_test_wait_cond: code should not be reached
>
>>
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> ---
>> tests/tpm-emu.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/tpm-emu.c b/tests/tpm-emu.c
>> index 8c2bd53cad..308f1884f6 100644
>> --- a/tests/tpm-emu.c
>> +++ b/tests/tpm-emu.c
>> @@ -20,7 +20,7 @@
>>
>> void tpm_emu_test_wait_cond(TestState *s)
>> {
>> - gint64 end_time = g_get_monotonic_time() + 5 * G_TIME_SPAN_SECOND;
>> + gint64 end_time = g_get_monotonic_time() + 10 * G_TIME_SPAN_SECOND;
>>
>> g_mutex_lock(&s->data_mutex);
>> if (!g_cond_wait_until(&s->data_cond, &s->data_mutex, end_time)) {
>> --
>> 2.17.1
>>
>>
--
Alex Bennée
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [RFC for 3.0] tests/tpm-emu: double the timeout
2018-07-06 10:19 ` Alex Bennée
@ 2018-07-06 10:24 ` Marc-André Lureau
2018-07-06 11:07 ` Alex Bennée
0 siblings, 1 reply; 5+ messages in thread
From: Marc-André Lureau @ 2018-07-06 10:24 UTC (permalink / raw)
To: Alex Bennée; +Cc: Peter Maydell, QEMU, Stefan Berger
On Fri, Jul 6, 2018 at 12:19 PM, Alex Bennée <alex.bennee@linaro.org> wrote:
>
> Marc-André Lureau <marcandre.lureau@gmail.com> writes:
>
>> Hi
>>
>> On Fri, Jul 6, 2018 at 10:06 AM, Alex Bennée <alex.bennee@linaro.org> wrote:
>>> We see various failures on Travis so lets just double the timeout and
>>> see if that makes them go away.
>>
>> This is just waiting for the thread to start and open a socket. It
>> shouldn't be a problem to wait longer, but do you have a Travis error
>> log?
>
> For example:
>
> https://travis-ci.org/qemu/qemu/jobs/400436724#L8971
>
> GTESTER check-qtest-i386
> **
> ERROR:tests/tpm-emu.c:27:tpm_emu_test_wait_cond: code should not be reached
>
thanks, what about increasing the timeout to 30s ? I am afraid x2
might not be enough for such overloaded systems.
>>>
>>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>>> ---
>>> tests/tpm-emu.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/tests/tpm-emu.c b/tests/tpm-emu.c
>>> index 8c2bd53cad..308f1884f6 100644
>>> --- a/tests/tpm-emu.c
>>> +++ b/tests/tpm-emu.c
>>> @@ -20,7 +20,7 @@
>>>
>>> void tpm_emu_test_wait_cond(TestState *s)
>>> {
>>> - gint64 end_time = g_get_monotonic_time() + 5 * G_TIME_SPAN_SECOND;
>>> + gint64 end_time = g_get_monotonic_time() + 10 * G_TIME_SPAN_SECOND;
>>>
>>> g_mutex_lock(&s->data_mutex);
>>> if (!g_cond_wait_until(&s->data_cond, &s->data_mutex, end_time)) {
>>> --
>>> 2.17.1
>>>
>>>
>
>
> --
> Alex Bennée
--
Marc-André Lureau
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [RFC for 3.0] tests/tpm-emu: double the timeout
2018-07-06 10:24 ` Marc-André Lureau
@ 2018-07-06 11:07 ` Alex Bennée
0 siblings, 0 replies; 5+ messages in thread
From: Alex Bennée @ 2018-07-06 11:07 UTC (permalink / raw)
To: Marc-André Lureau; +Cc: Peter Maydell, QEMU, Stefan Berger
Marc-André Lureau <marcandre.lureau@gmail.com> writes:
> On Fri, Jul 6, 2018 at 12:19 PM, Alex Bennée <alex.bennee@linaro.org> wrote:
>>
>> Marc-André Lureau <marcandre.lureau@gmail.com> writes:
>>
>>> Hi
>>>
>>> On Fri, Jul 6, 2018 at 10:06 AM, Alex Bennée <alex.bennee@linaro.org> wrote:
>>>> We see various failures on Travis so lets just double the timeout and
>>>> see if that makes them go away.
>>>
>>> This is just waiting for the thread to start and open a socket. It
>>> shouldn't be a problem to wait longer, but do you have a Travis error
>>> log?
>>
>> For example:
>>
>> https://travis-ci.org/qemu/qemu/jobs/400436724#L8971
>>
>> GTESTER check-qtest-i386
>> **
>> ERROR:tests/tpm-emu.c:27:tpm_emu_test_wait_cond: code should not be reached
>>
>
> thanks, what about increasing the timeout to 30s ? I am afraid x2
> might not be enough for such overloaded systems.
Sure - the Travis servers are certainly hammered most of the time.
>
>>>>
>>>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>>>> ---
>>>> tests/tpm-emu.c | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/tests/tpm-emu.c b/tests/tpm-emu.c
>>>> index 8c2bd53cad..308f1884f6 100644
>>>> --- a/tests/tpm-emu.c
>>>> +++ b/tests/tpm-emu.c
>>>> @@ -20,7 +20,7 @@
>>>>
>>>> void tpm_emu_test_wait_cond(TestState *s)
>>>> {
>>>> - gint64 end_time = g_get_monotonic_time() + 5 * G_TIME_SPAN_SECOND;
>>>> + gint64 end_time = g_get_monotonic_time() + 10 * G_TIME_SPAN_SECOND;
>>>>
>>>> g_mutex_lock(&s->data_mutex);
>>>> if (!g_cond_wait_until(&s->data_cond, &s->data_mutex, end_time)) {
>>>> --
>>>> 2.17.1
>>>>
>>>>
>>
>>
>> --
>> Alex Bennée
--
Alex Bennée
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-07-06 12:49 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-06 8:06 [Qemu-devel] [RFC for 3.0] tests/tpm-emu: double the timeout Alex Bennée
2018-07-06 9:26 ` Marc-André Lureau
2018-07-06 10:19 ` Alex Bennée
2018-07-06 10:24 ` Marc-André Lureau
2018-07-06 11:07 ` Alex Bennée
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.