From: ebiederm@xmission.com (Eric W. Biederman)
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Tobin C. Harding" <me@tobin.cc>,
"Jason A. Donenfeld" <Jason@zx2c4.com>,
"Theodore Ts'o" <tytso@mit.edu>,
"Kees Cook" <keescook@chromium.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Tycho Andersen" <tycho@tycho.ws>,
"Roberts, William C" <william.c.roberts@intel.com>,
"Tejun Heo" <tj@kernel.org>,
"Jordan Glover" <Golden_Miller83@protonmail.ch>,
"Greg KH" <gregkh@linuxfoundation.org>,
"Petr Mladek" <pmladek@suse.com>, "Joe Perches" <joe@perches.com>,
"Ian Campbell" <ijc@hellion.org.uk>,
"Sergey Senozhatsky" <sergey.senozhatsky@gmail.com>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Will Deacon" <wilal.deacon@arm.com>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Chris Fries" <cfries@google.com>,
"Dave Weinstein" <olorin@google.com>,
"Daniel Micay" <danielmicay@gmail.com>,
"Djalal Harouni" <tixxdz@gmail.com>,
"Radim Krčmář" <rkrcmar@redhat.com>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"KVM list" <kvm@vger.kernel.org>,
"kernel-hardening@lists.openwall.com"
<kernel-hardening@lists.openwall.com>
Subject: [kernel-hardening] Re: [PATCH 0/5] add printk specifier %px, unique identifier
Date: Tue, 28 Nov 2017 00:26:58 -0600 [thread overview]
Message-ID: <874lpelxzh.fsf@xmission.com> (raw)
In-Reply-To: <CA+55aFzDh7GpkKniTgQp29-6TObR8NpOKczbAW-85qux=ek0Tw@mail.gmail.com> (Linus Torvalds's message of "Mon, 27 Nov 2017 17:09:10 -0800")
Linus Torvalds <torvalds@linux-foundation.org> writes:
> On Mon, Nov 27, 2017 at 4:03 PM, Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
>>
>> So the big remaining ones for me are the /proc/<pid>/stack (stack
>> pointers) and the /proc/net/* ones.
>>
>> I'm a bit disappointed that those haven't been fixed already and
>> aren't even in this series..
>
> Oh well, I just did /proc/<pid>/stack by making it just print 0
> unconditionally rather than the hex number.
Patch?
I know I have used /proc/<pid>/stack manually many times when looking
at a system where something is hung/weird and I needed to see what is
going on. The backtrace inside the kernel can be invaluable.
At the same time I don't know if we actually need the hex address.
But please don't break that interface it is very useful.
Eric
WARNING: multiple messages have this Message-ID (diff)
From: ebiederm@xmission.com (Eric W. Biederman)
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Tobin C. Harding" <me@tobin.cc>,
"Jason A. Donenfeld" <Jason@zx2c4.com>,
"Theodore Ts'o" <tytso@mit.edu>,
Kees Cook <keescook@chromium.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Tycho Andersen <tycho@tycho.ws>, "Roberts\,
William C" <william.c.roberts@intel.com>,
Tejun Heo <tj@kernel.org>,
Jordan Glover <Golden_Miller83@protonmail.ch>,
Greg KH <gregkh@linuxfoundation.org>,
Petr Mladek <pmladek@suse.com>, Joe Perches <joe@perches.com>,
Ian Campbell <ijc@hellion.org.uk>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <wilal.deacon@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Chris Fries <cfries@google.com>,
Dave Weinstein <olorin@google.com>,
Daniel Micay <danielmicay@gmail.com>,
Dj
Subject: Re: [PATCH 0/5] add printk specifier %px, unique identifier
Date: Tue, 28 Nov 2017 00:26:58 -0600 [thread overview]
Message-ID: <874lpelxzh.fsf@xmission.com> (raw)
In-Reply-To: <CA+55aFzDh7GpkKniTgQp29-6TObR8NpOKczbAW-85qux=ek0Tw@mail.gmail.com> (Linus Torvalds's message of "Mon, 27 Nov 2017 17:09:10 -0800")
Linus Torvalds <torvalds@linux-foundation.org> writes:
> On Mon, Nov 27, 2017 at 4:03 PM, Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
>>
>> So the big remaining ones for me are the /proc/<pid>/stack (stack
>> pointers) and the /proc/net/* ones.
>>
>> I'm a bit disappointed that those haven't been fixed already and
>> aren't even in this series..
>
> Oh well, I just did /proc/<pid>/stack by making it just print 0
> unconditionally rather than the hex number.
Patch?
I know I have used /proc/<pid>/stack manually many times when looking
at a system where something is hung/weird and I needed to see what is
going on. The backtrace inside the kernel can be invaluable.
At the same time I don't know if we actually need the hex address.
But please don't break that interface it is very useful.
Eric
WARNING: multiple messages have this Message-ID (diff)
From: ebiederm@xmission.com (Eric W. Biederman)
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Tobin C. Harding" <me@tobin.cc>,
"Jason A. Donenfeld" <Jason@zx2c4.com>,
"Theodore Ts'o" <tytso@mit.edu>,
"Kees Cook" <keescook@chromium.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Tycho Andersen" <tycho@tycho.ws>,
"Roberts, William C" <william.c.roberts@intel.com>,
"Tejun Heo" <tj@kernel.org>,
"Jordan Glover" <Golden_Miller83@protonmail.ch>,
"Greg KH" <gregkh@linuxfoundation.org>,
"Petr Mladek" <pmladek@suse.com>, "Joe Perches" <joe@perches.com>,
"Ian Campbell" <ijc@hellion.org.uk>,
"Sergey Senozhatsky" <sergey.senozhatsky@gmail.com>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Will Deacon" <wilal.deacon@arm.com>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Chris Fries" <cfries@google.com>,
"Dave Weinstein" <olorin@google.com>,
"Daniel Micay" <danielmicay@gmail.com>,
"Djalal Harouni" <tixxdz@gmail.com>,
"Radim Krčmář" <rkrcmar@redhat.com>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"KVM list" <kvm@vger.kernel.org>,
"kernel-hardening@lists.openwall.com"
<kernel-hardening@lists.openwall.com>
Subject: Re: [PATCH 0/5] add printk specifier %px, unique identifier
Date: Tue, 28 Nov 2017 00:26:58 -0600 [thread overview]
Message-ID: <874lpelxzh.fsf@xmission.com> (raw)
In-Reply-To: <CA+55aFzDh7GpkKniTgQp29-6TObR8NpOKczbAW-85qux=ek0Tw@mail.gmail.com> (Linus Torvalds's message of "Mon, 27 Nov 2017 17:09:10 -0800")
Linus Torvalds <torvalds@linux-foundation.org> writes:
> On Mon, Nov 27, 2017 at 4:03 PM, Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
>>
>> So the big remaining ones for me are the /proc/<pid>/stack (stack
>> pointers) and the /proc/net/* ones.
>>
>> I'm a bit disappointed that those haven't been fixed already and
>> aren't even in this series..
>
> Oh well, I just did /proc/<pid>/stack by making it just print 0
> unconditionally rather than the hex number.
Patch?
I know I have used /proc/<pid>/stack manually many times when looking
at a system where something is hung/weird and I needed to see what is
going on. The backtrace inside the kernel can be invaluable.
At the same time I don't know if we actually need the hex address.
But please don't break that interface it is very useful.
Eric
next prev parent reply other threads:[~2017-11-28 6:26 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-27 23:40 [kernel-hardening] [PATCH 0/5] add printk specifier %px, unique identifier Tobin C. Harding
2017-11-27 23:40 ` Tobin C. Harding
2017-11-27 23:40 ` Tobin C. Harding
2017-11-27 23:40 ` [kernel-hardening] [PATCH 1/5] docs: correct documentation for %pK Tobin C. Harding
2017-11-27 23:40 ` Tobin C. Harding
2017-11-27 23:40 ` Tobin C. Harding
2017-11-28 0:46 ` [kernel-hardening] " Kees Cook
2017-11-28 0:46 ` Kees Cook
2017-11-28 0:46 ` Kees Cook
2017-11-27 23:40 ` [kernel-hardening] [PATCH 2/5] vsprintf: refactor pK code out of pointer() Tobin C. Harding
2017-11-27 23:40 ` Tobin C. Harding
2017-11-27 23:40 ` Tobin C. Harding
2017-11-27 23:40 ` [kernel-hardening] [PATCH 3/5] vsprintf: add specifier %px, unique identifier Tobin C. Harding
2017-11-27 23:40 ` Tobin C. Harding
2017-11-27 23:40 ` Tobin C. Harding
2017-11-27 23:40 ` [kernel-hardening] [PATCH 4/5] KVM: use %px to print token identifier Tobin C. Harding
2017-11-27 23:40 ` Tobin C. Harding
2017-11-27 23:40 ` Tobin C. Harding
2017-11-27 23:40 ` [kernel-hardening] [PATCH 5/5] vfio_pci: " Tobin C. Harding
2017-11-27 23:40 ` Tobin C. Harding
2017-11-27 23:40 ` Tobin C. Harding
2017-11-28 0:03 ` [kernel-hardening] Re: [PATCH 0/5] add printk specifier %px, unique identifier Linus Torvalds
2017-11-28 0:03 ` Linus Torvalds
2017-11-28 0:03 ` Linus Torvalds
2017-11-28 1:09 ` [kernel-hardening] " Linus Torvalds
2017-11-28 1:09 ` Linus Torvalds
2017-11-28 1:09 ` Linus Torvalds
2017-11-28 6:26 ` Eric W. Biederman [this message]
2017-11-28 6:26 ` Eric W. Biederman
2017-11-28 6:26 ` Eric W. Biederman
2017-11-28 10:12 ` [kernel-hardening] " David Laight
2017-11-28 10:12 ` David Laight
2017-11-28 10:12 ` David Laight
2017-11-28 17:33 ` [kernel-hardening] " Linus Torvalds
2017-11-28 17:33 ` Linus Torvalds
2017-11-28 17:33 ` Linus Torvalds
2017-11-28 17:41 ` [kernel-hardening] " Joe Perches
2017-11-28 17:41 ` Joe Perches
2017-11-28 17:41 ` Joe Perches
2017-11-28 18:04 ` [kernel-hardening] " Linus Torvalds
2017-11-28 18:04 ` Linus Torvalds
2017-11-28 18:04 ` Linus Torvalds
2017-11-28 18:11 ` [kernel-hardening] " Linus Torvalds
2017-11-28 18:11 ` Linus Torvalds
2017-11-28 18:11 ` Linus Torvalds
2017-11-28 17:44 ` [kernel-hardening] " David Laight
2017-11-28 17:44 ` David Laight
2017-11-28 17:44 ` David Laight
2017-11-28 0:57 ` [kernel-hardening] " Kees Cook
2017-11-28 0:57 ` Kees Cook
2017-11-28 0:57 ` Kees Cook
2017-11-28 1:43 ` [kernel-hardening] " Tobin C. Harding
2017-11-28 1:43 ` Tobin C. Harding
2017-11-28 1:43 ` Tobin C. Harding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874lpelxzh.fsf@xmission.com \
--to=ebiederm@xmission.com \
--cc=Golden_Miller83@protonmail.ch \
--cc=Jason@zx2c4.com \
--cc=catalin.marinas@arm.com \
--cc=cfries@google.com \
--cc=danielmicay@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=ijc@hellion.org.uk \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@tobin.cc \
--cc=olorin@google.com \
--cc=pbonzini@redhat.com \
--cc=pmladek@suse.com \
--cc=rkrcmar@redhat.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=tixxdz@gmail.com \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=tycho@tycho.ws \
--cc=tytso@mit.edu \
--cc=wilal.deacon@arm.com \
--cc=william.c.roberts@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.