From: "Huang\, Ying" <ying.huang@intel.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Andrea Arcangeli <aarcange@redhat.com>,
Rik van Riel <riel@redhat.com>,
linux-nvdimm@lists.01.org, "Huang, Ying" <ying.huang@intel.com>,
Hugh Dickins <hughd@google.com>,
linux-kernel@vger.kernel.org, Michal Hocko <mhocko@kernel.org>,
Jens Axboe <axboe@fb.com>,
linux-mm@kvack.org, Johannes Weiner <hannes@cmpxchg.org>,
Minchan Kim <minchan@kernel.org>, Ming Lei <ming.lei@redhat.com>,
Shaohua Li <shli@kernel.org>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>
Subject: Re: [PATCH -mm -v2 00/12] mm, THP, swap: Delay splitting THP after swapped out
Date: Mon, 24 Jul 2017 08:57:48 +0800 [thread overview]
Message-ID: <874lu2ircj.fsf@yhuang-dev.intel.com> (raw)
In-Reply-To: <20170721162129.077f7d9b4c77c8593e47aed9@linux-foundation.org> (Andrew Morton's message of "Fri, 21 Jul 2017 16:21:29 -0700")
Andrew Morton <akpm@linux-foundation.org> writes:
> On Fri, 23 Jun 2017 15:12:51 +0800 "Huang, Ying" <ying.huang@intel.com> wrote:
>
>> From: Huang Ying <ying.huang@intel.com>
>>
>> Hi, Andrew, could you help me to check whether the overall design is
>> reasonable?
>>
>> Hi, Johannes and Minchan, Thanks a lot for your review to the first
>> step of the THP swap optimization! Could you help me to review the
>> second step in this patchset?
>>
>> Hi, Hugh, Shaohua, Minchan and Rik, could you help me to review the
>> swap part of the patchset? Especially [01/12], [02/12], [03/12],
>> [04/12], [11/12], and [12/12].
>>
>> Hi, Andrea and Kirill, could you help me to review the THP part of the
>> patchset? Especially [01/12], [03/12], [07/12], [08/12], [09/12],
>> [11/12].
>>
>> Hi, Johannes, Michal, could you help me to review the cgroup part of
>> the patchset? Especially [08/12], [09/12], and [10/12].
>>
>> And for all, Any comment is welcome!
>
> I guess it's time for a resend. Folks, could we please get some more
> review&test going here?
Sure. Will resend it ASAP. And Thanks for reminding!
>> Because the THP swap writing support patch [06/12] needs to be rebased
>> on multipage bvec patchset which hasn't been merged yet. The [06/12]
>> in this patchset is just a test patch and will be rewritten later.
>> The patchset depends on multipage bvec patchset too.
>
> Are these dependency issues any simpler now?
Ming Lei has sent the v2 of multipage bvec patchset on June 26th. Jens
Axboe thinks the patchset will target v4.14.
https://lkml.org/lkml/2017/6/26/538
Best Regards,
Huang, Ying
>> This is the second step of THP (Transparent Huge Page) swap
>> optimization. In the first step, the splitting huge page is delayed
>> from almost the first step of swapping out to after allocating the
>> swap space for the THP and adding the THP into the swap cache. In the
>> second step, the splitting is delayed further to after the swapping
>> out finished. The plan is to delay splitting THP step by step,
>> finally avoid splitting THP for the THP swapping out and swap out/in
>> the THP as a whole.
>>
>> In the patchset, more operations for the anonymous THP reclaiming,
>> such as TLB flushing, writing the THP to the swap device, removing the
>> THP from the swap cache are batched. So that the performance of
>> anonymous THP swapping out are improved.
>>
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: "Huang\, Ying" <ying.huang@intel.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Huang, Ying" <ying.huang@intel.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Ross Zwisler <ross.zwisler@linux.intel.com>,
linux-nvdimm@lists.01.org, Johannes Weiner <hannes@cmpxchg.org>,
Minchan Kim <minchan@kernel.org>, Hugh Dickins <hughd@google.com>,
Shaohua Li <shli@kernel.org>, Rik van Riel <riel@redhat.com>,
Andrea Arcangeli <aarcange@redhat.com>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Jens Axboe <axboe@fb.com>, Michal Hocko <mhocko@kernel.org>,
Ming Lei <ming.lei@redhat.com>
Subject: Re: [PATCH -mm -v2 00/12] mm, THP, swap: Delay splitting THP after swapped out
Date: Mon, 24 Jul 2017 08:57:48 +0800 [thread overview]
Message-ID: <874lu2ircj.fsf@yhuang-dev.intel.com> (raw)
In-Reply-To: <20170721162129.077f7d9b4c77c8593e47aed9@linux-foundation.org> (Andrew Morton's message of "Fri, 21 Jul 2017 16:21:29 -0700")
Andrew Morton <akpm@linux-foundation.org> writes:
> On Fri, 23 Jun 2017 15:12:51 +0800 "Huang, Ying" <ying.huang@intel.com> wrote:
>
>> From: Huang Ying <ying.huang@intel.com>
>>
>> Hi, Andrew, could you help me to check whether the overall design is
>> reasonable?
>>
>> Hi, Johannes and Minchan, Thanks a lot for your review to the first
>> step of the THP swap optimization! Could you help me to review the
>> second step in this patchset?
>>
>> Hi, Hugh, Shaohua, Minchan and Rik, could you help me to review the
>> swap part of the patchset? Especially [01/12], [02/12], [03/12],
>> [04/12], [11/12], and [12/12].
>>
>> Hi, Andrea and Kirill, could you help me to review the THP part of the
>> patchset? Especially [01/12], [03/12], [07/12], [08/12], [09/12],
>> [11/12].
>>
>> Hi, Johannes, Michal, could you help me to review the cgroup part of
>> the patchset? Especially [08/12], [09/12], and [10/12].
>>
>> And for all, Any comment is welcome!
>
> I guess it's time for a resend. Folks, could we please get some more
> review&test going here?
Sure. Will resend it ASAP. And Thanks for reminding!
>> Because the THP swap writing support patch [06/12] needs to be rebased
>> on multipage bvec patchset which hasn't been merged yet. The [06/12]
>> in this patchset is just a test patch and will be rewritten later.
>> The patchset depends on multipage bvec patchset too.
>
> Are these dependency issues any simpler now?
Ming Lei has sent the v2 of multipage bvec patchset on June 26th. Jens
Axboe thinks the patchset will target v4.14.
https://lkml.org/lkml/2017/6/26/538
Best Regards,
Huang, Ying
>> This is the second step of THP (Transparent Huge Page) swap
>> optimization. In the first step, the splitting huge page is delayed
>> from almost the first step of swapping out to after allocating the
>> swap space for the THP and adding the THP into the swap cache. In the
>> second step, the splitting is delayed further to after the swapping
>> out finished. The plan is to delay splitting THP step by step,
>> finally avoid splitting THP for the THP swapping out and swap out/in
>> the THP as a whole.
>>
>> In the patchset, more operations for the anonymous THP reclaiming,
>> such as TLB flushing, writing the THP to the swap device, removing the
>> THP from the swap cache are batched. So that the performance of
>> anonymous THP swapping out are improved.
>>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: "Huang\, Ying" <ying.huang@intel.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Huang\, Ying" <ying.huang@intel.com>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>,
Ross Zwisler <ross.zwisler@linux.intel.com>,
<linux-nvdimm@lists.01.org>, Johannes Weiner <hannes@cmpxchg.org>,
Minchan Kim <minchan@kernel.org>, Hugh Dickins <hughd@google.com>,
Shaohua Li <shli@kernel.org>, Rik van Riel <riel@redhat.com>,
Andrea Arcangeli <aarcange@redhat.com>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Jens Axboe <axboe@fb.com>, Michal Hocko <mhocko@kernel.org>,
Ming Lei <ming.lei@redhat.com>
Subject: Re: [PATCH -mm -v2 00/12] mm, THP, swap: Delay splitting THP after swapped out
Date: Mon, 24 Jul 2017 08:57:48 +0800 [thread overview]
Message-ID: <874lu2ircj.fsf@yhuang-dev.intel.com> (raw)
In-Reply-To: <20170721162129.077f7d9b4c77c8593e47aed9@linux-foundation.org> (Andrew Morton's message of "Fri, 21 Jul 2017 16:21:29 -0700")
Andrew Morton <akpm@linux-foundation.org> writes:
> On Fri, 23 Jun 2017 15:12:51 +0800 "Huang, Ying" <ying.huang@intel.com> wrote:
>
>> From: Huang Ying <ying.huang@intel.com>
>>
>> Hi, Andrew, could you help me to check whether the overall design is
>> reasonable?
>>
>> Hi, Johannes and Minchan, Thanks a lot for your review to the first
>> step of the THP swap optimization! Could you help me to review the
>> second step in this patchset?
>>
>> Hi, Hugh, Shaohua, Minchan and Rik, could you help me to review the
>> swap part of the patchset? Especially [01/12], [02/12], [03/12],
>> [04/12], [11/12], and [12/12].
>>
>> Hi, Andrea and Kirill, could you help me to review the THP part of the
>> patchset? Especially [01/12], [03/12], [07/12], [08/12], [09/12],
>> [11/12].
>>
>> Hi, Johannes, Michal, could you help me to review the cgroup part of
>> the patchset? Especially [08/12], [09/12], and [10/12].
>>
>> And for all, Any comment is welcome!
>
> I guess it's time for a resend. Folks, could we please get some more
> review&test going here?
Sure. Will resend it ASAP. And Thanks for reminding!
>> Because the THP swap writing support patch [06/12] needs to be rebased
>> on multipage bvec patchset which hasn't been merged yet. The [06/12]
>> in this patchset is just a test patch and will be rewritten later.
>> The patchset depends on multipage bvec patchset too.
>
> Are these dependency issues any simpler now?
Ming Lei has sent the v2 of multipage bvec patchset on June 26th. Jens
Axboe thinks the patchset will target v4.14.
https://lkml.org/lkml/2017/6/26/538
Best Regards,
Huang, Ying
>> This is the second step of THP (Transparent Huge Page) swap
>> optimization. In the first step, the splitting huge page is delayed
>> from almost the first step of swapping out to after allocating the
>> swap space for the THP and adding the THP into the swap cache. In the
>> second step, the splitting is delayed further to after the swapping
>> out finished. The plan is to delay splitting THP step by step,
>> finally avoid splitting THP for the THP swapping out and swap out/in
>> the THP as a whole.
>>
>> In the patchset, more operations for the anonymous THP reclaiming,
>> such as TLB flushing, writing the THP to the swap device, removing the
>> THP from the swap cache are batched. So that the performance of
>> anonymous THP swapping out are improved.
>>
next prev parent reply other threads:[~2017-07-24 0:55 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-23 7:12 [PATCH -mm -v2 00/12] mm, THP, swap: Delay splitting THP after swapped out Huang, Ying
2017-06-23 7:12 ` Huang, Ying
2017-06-23 7:12 ` [PATCH -mm -v2 01/12] mm, THP, swap: Support to clear swap cache flag for THP " Huang, Ying
2017-06-23 7:12 ` Huang, Ying
2017-06-23 7:12 ` Huang, Ying
2017-06-23 7:12 ` [PATCH -mm -v2 02/12] mm, THP, swap: Support to reclaim swap space " Huang, Ying
2017-06-23 7:12 ` Huang, Ying
2017-06-23 7:12 ` Huang, Ying
2017-06-23 7:12 ` [PATCH -mm -v2 03/12] mm, THP, swap: Make reuse_swap_page() works " Huang, Ying
2017-06-23 7:12 ` Huang, Ying
2017-06-23 7:12 ` Huang, Ying
2017-06-23 7:12 ` [PATCH -mm -v2 04/12] mm, THP, swap: Don't allocate huge cluster for file backed swap device Huang, Ying
2017-06-23 7:12 ` Huang, Ying
2017-06-23 7:12 ` Huang, Ying
2017-06-23 7:12 ` [PATCH -mm -v2 05/12] block, THP: Make block_device_operations.rw_page support THP Huang, Ying
2017-06-23 7:12 ` Huang, Ying
2017-06-23 7:12 ` Huang, Ying
2017-06-23 7:12 ` [PATCH -mm -v2 06/12] Test code to write THP to swap device as a whole Huang, Ying
2017-06-23 7:12 ` Huang, Ying
2017-06-23 7:12 ` Huang, Ying
2017-06-23 7:12 ` [PATCH -mm -v2 07/12] mm, THP, swap: Support to split THP for THP swapped out Huang, Ying
2017-06-23 7:12 ` Huang, Ying
2017-06-23 7:12 ` Huang, Ying
2017-06-23 7:12 ` [PATCH -mm -v2 08/12] memcg, THP, swap: Support move mem cgroup charge " Huang, Ying
2017-06-23 7:12 ` Huang, Ying
2017-06-23 7:12 ` Huang, Ying
2017-06-23 7:13 ` [PATCH -mm -v2 09/12] memcg, THP, swap: Avoid to duplicated charge THP in swap cache Huang, Ying
2017-06-23 7:13 ` Huang, Ying
2017-06-23 7:13 ` Huang, Ying
2017-06-23 7:13 ` [PATCH -mm -v2 10/12] memcg, THP, swap: Make mem_cgroup_swapout() support THP Huang, Ying
2017-06-23 7:13 ` Huang, Ying
2017-06-23 7:13 ` Huang, Ying
2017-06-23 7:13 ` [PATCH -mm -v2 11/12] mm, THP, swap: Delay splitting THP after swapped out Huang, Ying
2017-06-23 7:13 ` Huang, Ying
2017-06-23 7:13 ` Huang, Ying
2017-06-23 7:13 ` [PATCH -mm -v2 12/12] mm, THP, swap: Add THP swapping out fallback counting Huang, Ying
2017-06-23 7:13 ` Huang, Ying
2017-06-23 7:13 ` Huang, Ying
2017-07-21 23:21 ` [PATCH -mm -v2 00/12] mm, THP, swap: Delay splitting THP after swapped out Andrew Morton
2017-07-21 23:21 ` Andrew Morton
2017-07-21 23:21 ` Andrew Morton
2017-07-24 0:57 ` Huang, Ying [this message]
2017-07-24 0:57 ` Huang, Ying
2017-07-24 0:57 ` Huang, Ying
2017-07-24 2:46 ` Ming Lei
2017-07-24 2:46 ` Ming Lei
2017-07-24 2:46 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874lu2ircj.fsf@yhuang-dev.intel.com \
--to=ying.huang@intel.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@fb.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=mhocko@kernel.org \
--cc=minchan@kernel.org \
--cc=ming.lei@redhat.com \
--cc=riel@redhat.com \
--cc=shli@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.