From: balbi@ti.com (Felipe Balbi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] USB: USB_OTG does not depend on PM
Date: Tue, 17 Nov 2015 15:38:33 -0600 [thread overview]
Message-ID: <874mgkjoh2.fsf@saruman.tx.rr.com> (raw)
In-Reply-To: <7521777.8ZmnT3AlIC@wuerfel>
Hi,
Arnd Bergmann <arnd@arndb.de> writes:
> USB_OTG initially depended on USB_SUSPEND, which was later turned into
> PM_RUNTIME and finally into PM. I don't know at what point the dependency
> became unnecessary but it appears to work fine without CONFIG_PM now.
>
> However, we get lots of warnings in randconfig kernels like:
>
> warning: (USB_OTG_FSM && FSL_USB2_OTG && USB_MV_OTG) selects USB_OTG which has unmet direct dependencies (USB_SUPPORT && USB && PM)
>
> whenever CONFIG_PM is disabled and something else selects USB_OTG.
> Let's just drop the dependency to avoid the warnings.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> I keep seeing this one in my ARM randconfig test
and how did you test this ? Did you make sure you're not breaking HNP ?
For HNP to happen we depend on a bus_suspend and bus_suspend is only
available on CONFIG_PM, unless that has changed.
Seems like you've only compile tested this patch, is that correct ?
--
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20151117/f383883d/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Felipe Balbi <balbi@ti.com>
To: Arnd Bergmann <arnd@arndb.de>,
Peter Chen <Peter.Chen@freescale.com>,
<gregkh@linuxfoundation.org>
Cc: <linux-usb@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] USB: USB_OTG does not depend on PM
Date: Tue, 17 Nov 2015 15:38:33 -0600 [thread overview]
Message-ID: <874mgkjoh2.fsf@saruman.tx.rr.com> (raw)
In-Reply-To: <7521777.8ZmnT3AlIC@wuerfel>
[-- Attachment #1: Type: text/plain, Size: 997 bytes --]
Hi,
Arnd Bergmann <arnd@arndb.de> writes:
> USB_OTG initially depended on USB_SUSPEND, which was later turned into
> PM_RUNTIME and finally into PM. I don't know at what point the dependency
> became unnecessary but it appears to work fine without CONFIG_PM now.
>
> However, we get lots of warnings in randconfig kernels like:
>
> warning: (USB_OTG_FSM && FSL_USB2_OTG && USB_MV_OTG) selects USB_OTG which has unmet direct dependencies (USB_SUPPORT && USB && PM)
>
> whenever CONFIG_PM is disabled and something else selects USB_OTG.
> Let's just drop the dependency to avoid the warnings.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> I keep seeing this one in my ARM randconfig test
and how did you test this ? Did you make sure you're not breaking HNP ?
For HNP to happen we depend on a bus_suspend and bus_suspend is only
available on CONFIG_PM, unless that has changed.
Seems like you've only compile tested this patch, is that correct ?
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
next prev parent reply other threads:[~2015-11-17 21:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-17 21:01 [PATCH] USB: USB_OTG does not depend on PM Arnd Bergmann
2015-11-17 21:01 ` Arnd Bergmann
2015-11-17 21:38 ` Felipe Balbi [this message]
2015-11-17 21:38 ` Felipe Balbi
2015-11-17 22:00 ` Arnd Bergmann
2015-11-17 22:00 ` Arnd Bergmann
2015-11-17 22:21 ` Felipe Balbi
2015-11-17 22:21 ` Felipe Balbi
2015-11-18 3:17 ` Peter Chen
2015-11-18 3:17 ` Peter Chen
2015-11-18 9:38 ` Arnd Bergmann
2015-11-18 9:38 ` Arnd Bergmann
2015-11-18 9:41 ` Peter Chen
2015-11-18 9:41 ` Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874mgkjoh2.fsf@saruman.tx.rr.com \
--to=balbi@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.