All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH 2/4] ath10k: fix HTC endpoint worker starvation
Date: Mon, 12 Aug 2013 17:56:58 +0300	[thread overview]
Message-ID: <874navt0sl.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CA+BoTQk4n=kiWhwvzieuvXp5Wou_QpkY=8iU474XPwG7P4KSiQ@mail.gmail.com> (Michal Kazior's message of "Thu, 8 Aug 2013 12:12:03 +0200")

Michal Kazior <michal.kazior@tieto.com> writes:

>> @@ -602,7 +602,8 @@ static void ath10k_htc_reset_endpoint_states(struct ath10k_htc *htc)
>>                 skb_queue_head_init(&ep->tx_queue);
>>                 ep->htc = htc;
>>                 ep->tx_credit_flow_enabled = true;
>> -               INIT_WORK(&ep->send_work, ath10k_htc_send_work);
>> +               tasklet_init(&ep->send_task, ath10k_htc_send_task,
>> +                             (unsigned long)ep);
>>         }
>>  }
>>
>
> Indentation is off by one here. Is it okay if I just resend this
> single patch or is it easier for applying if I resend the whole
> patchset?

It's errorprone if I start to pick patches from different sets. So
please resend the whole series. But take a look at my other comment
first.

-- 
Kalle Valo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 2/4] ath10k: fix HTC endpoint worker starvation
Date: Mon, 12 Aug 2013 17:56:58 +0300	[thread overview]
Message-ID: <874navt0sl.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CA+BoTQk4n=kiWhwvzieuvXp5Wou_QpkY=8iU474XPwG7P4KSiQ@mail.gmail.com> (Michal Kazior's message of "Thu, 8 Aug 2013 12:12:03 +0200")

Michal Kazior <michal.kazior@tieto.com> writes:

>> @@ -602,7 +602,8 @@ static void ath10k_htc_reset_endpoint_states(struct ath10k_htc *htc)
>>                 skb_queue_head_init(&ep->tx_queue);
>>                 ep->htc = htc;
>>                 ep->tx_credit_flow_enabled = true;
>> -               INIT_WORK(&ep->send_work, ath10k_htc_send_work);
>> +               tasklet_init(&ep->send_task, ath10k_htc_send_task,
>> +                             (unsigned long)ep);
>>         }
>>  }
>>
>
> Indentation is off by one here. Is it okay if I just resend this
> single patch or is it easier for applying if I resend the whole
> patchset?

It's errorprone if I start to pick patches from different sets. So
please resend the whole series. But take a look at my other comment
first.

-- 
Kalle Valo

  reply	other threads:[~2013-08-12 14:57 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-08  8:16 [PATCH 0/4] ath10k: fixes Michal Kazior
2013-08-08  8:16 ` Michal Kazior
2013-08-08  8:16 ` [PATCH 1/4] ath10k: fix HTT service setup Michal Kazior
2013-08-08  8:16   ` Michal Kazior
2013-08-08  8:16 ` [PATCH 2/4] ath10k: fix HTC endpoint worker starvation Michal Kazior
2013-08-08  8:16   ` Michal Kazior
2013-08-08 10:12   ` Michal Kazior
2013-08-08 10:12     ` Michal Kazior
2013-08-12 14:56     ` Kalle Valo [this message]
2013-08-12 14:56       ` Kalle Valo
2013-08-08  8:16 ` [PATCH 3/4] ath10k: implement 802.3 SNAP rx decap type A-MSDU handling Michal Kazior
2013-08-08  8:16   ` Michal Kazior
2013-08-12 14:55   ` Kalle Valo
2013-08-12 14:55     ` Kalle Valo
2013-08-13  5:18     ` Michal Kazior
2013-08-13  5:18       ` Michal Kazior
2013-08-08  8:16 ` [PATCH 4/4] ath10k: plug possible memory leak in WMI Michal Kazior
2013-08-08  8:16   ` Michal Kazior
2013-08-13  5:59 ` [PATCH v2 0/4] ath10k: fixes Michal Kazior
2013-08-13  5:59   ` Michal Kazior
2013-08-13  5:59   ` [PATCH v2 1/4] ath10k: fix HTT service setup Michal Kazior
2013-08-13  5:59     ` Michal Kazior
2013-08-13  5:59   ` [PATCH v2 2/4] ath10k: fix HTC endpoint worker starvation Michal Kazior
2013-08-13  5:59     ` Michal Kazior
2013-08-13 10:22     ` Michal Kazior
2013-08-13 10:22       ` Michal Kazior
2013-08-13  5:59   ` [PATCH v2 3/4] ath10k: implement 802.3 SNAP rx decap type A-MSDU handling Michal Kazior
2013-08-13  5:59     ` Michal Kazior
2013-08-13  5:59   ` [PATCH v2 4/4] ath10k: plug possible memory leak in WMI Michal Kazior
2013-08-13  5:59     ` Michal Kazior
2013-08-14 15:02   ` [PATCH v2 0/4] ath10k: fixes Kalle Valo
2013-08-14 15:02     ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874navt0sl.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@qca.qualcomm.com \
    --cc=ath10k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=michal.kazior@tieto.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.