From: rusty@rustcorp.com.au (Rusty Russell)
To: linux-arm-kernel@lists.infradead.org
Subject: [patch 2/7] tick: Convert broadcast cpu bitmaps to cpumask_var_t
Date: Thu, 07 Mar 2013 16:51:23 +1100 [thread overview]
Message-ID: <874ngnycys.fsf@rustcorp.com.au> (raw)
In-Reply-To: <20130306111537.366394000@linutronix.de>
Thomas Gleixner <tglx@linutronix.de> writes:
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Cc: Rusty Russell <rusty@rustcorp.com.au>
> ---
> kernel/time/tick-broadcast.c | 86 +++++++++++++++++++++----------------------
> kernel/time/tick-common.c | 1
> kernel/time/tick-internal.h | 3 +
> 3 files changed, 46 insertions(+), 44 deletions(-)
>
> Index: tip/kernel/time/tick-broadcast.c
> ===================================================================
> --- tip.orig/kernel/time/tick-broadcast.c
> +++ tip/kernel/time/tick-broadcast.c
> @@ -28,9 +28,8 @@
> */
>
> static struct tick_device tick_broadcast_device;
> -/* FIXME: Use cpumask_var_t. */
> -static DECLARE_BITMAP(tick_broadcast_mask, NR_CPUS);
> -static DECLARE_BITMAP(tmpmask, NR_CPUS);
> +static cpumask_var_t tick_broadcast_mask;
> +static cpumask_var_t tmpmask;
> static DEFINE_RAW_SPINLOCK(tick_broadcast_lock);
> static int tick_broadcast_force;
Thanks, this is a nice cleanup.
Cheers,
Rusty.
WARNING: multiple messages have this Message-ID (diff)
From: Rusty Russell <rusty@rustcorp.com.au>
To: Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>
Cc: LAK <linux-arm-kernel@lists.infradead.org>,
John Stultz <john.stultz@linaro.org>,
Arjan van de Veen <arjan@infradead.org>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Jason Liu <liu.h.jason@gmail.com>
Subject: Re: [patch 2/7] tick: Convert broadcast cpu bitmaps to cpumask_var_t
Date: Thu, 07 Mar 2013 16:51:23 +1100 [thread overview]
Message-ID: <874ngnycys.fsf@rustcorp.com.au> (raw)
In-Reply-To: <20130306111537.366394000@linutronix.de>
Thomas Gleixner <tglx@linutronix.de> writes:
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Cc: Rusty Russell <rusty@rustcorp.com.au>
> ---
> kernel/time/tick-broadcast.c | 86 +++++++++++++++++++++----------------------
> kernel/time/tick-common.c | 1
> kernel/time/tick-internal.h | 3 +
> 3 files changed, 46 insertions(+), 44 deletions(-)
>
> Index: tip/kernel/time/tick-broadcast.c
> ===================================================================
> --- tip.orig/kernel/time/tick-broadcast.c
> +++ tip/kernel/time/tick-broadcast.c
> @@ -28,9 +28,8 @@
> */
>
> static struct tick_device tick_broadcast_device;
> -/* FIXME: Use cpumask_var_t. */
> -static DECLARE_BITMAP(tick_broadcast_mask, NR_CPUS);
> -static DECLARE_BITMAP(tmpmask, NR_CPUS);
> +static cpumask_var_t tick_broadcast_mask;
> +static cpumask_var_t tmpmask;
> static DEFINE_RAW_SPINLOCK(tick_broadcast_lock);
> static int tick_broadcast_force;
Thanks, this is a nice cleanup.
Cheers,
Rusty.
next prev parent reply other threads:[~2013-03-07 5:51 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-06 11:18 [patch 0/7] tick: Optimize broadcast handling and prevent expiry ping pong Thomas Gleixner
2013-03-06 11:18 ` Thomas Gleixner
2013-03-06 11:18 ` [patch 1/7] tick: Call tick_init late Thomas Gleixner
2013-03-06 11:18 ` Thomas Gleixner
2013-03-07 16:29 ` [tip:timers/core] " tip-bot for Thomas Gleixner
2013-03-06 11:18 ` [patch 2/7] tick: Convert broadcast cpu bitmaps to cpumask_var_t Thomas Gleixner
2013-03-06 11:18 ` Thomas Gleixner
2013-03-07 5:51 ` Rusty Russell [this message]
2013-03-07 5:51 ` Rusty Russell
2013-03-07 16:30 ` [tip:timers/core] " tip-bot for Thomas Gleixner
2013-03-06 11:18 ` [patch 4/7] tick: Handle broadcast wakeup of multiple cpus Thomas Gleixner
2013-03-06 11:18 ` Thomas Gleixner
2013-03-13 11:36 ` Lorenzo Pieralisi
2013-03-13 11:36 ` Lorenzo Pieralisi
2013-03-13 21:42 ` Thomas Gleixner
2013-03-13 21:42 ` Thomas Gleixner
2013-03-19 11:37 ` [tip:timers/core] " tip-bot for Thomas Gleixner
2013-03-06 11:18 ` [patch 3/7] tick: Avoid programming the local cpu timer if broadcast pending Thomas Gleixner
2013-03-06 11:18 ` Thomas Gleixner
2013-03-19 11:35 ` [tip:timers/core] " tip-bot for Thomas Gleixner
2013-03-06 11:18 ` [patch 5/7] tick: Provide a check for a forced " Thomas Gleixner
2013-03-06 11:18 ` Thomas Gleixner
2013-03-19 11:38 ` [tip:timers/core] " tip-bot for Thomas Gleixner
2013-03-06 11:18 ` [patch 6/7] arm: Use tick broadcast expired check Thomas Gleixner
2013-03-06 11:18 ` Thomas Gleixner
2013-03-19 11:39 ` [tip:timers/core] " tip-bot for Thomas Gleixner
2013-03-06 11:18 ` [patch 7/7] x86: " Thomas Gleixner
2013-03-06 11:18 ` Thomas Gleixner
2013-03-19 11:40 ` [tip:timers/core] " tip-bot for Thomas Gleixner
2013-03-13 9:35 ` [patch 0/7] tick: Optimize broadcast handling and prevent expiry ping pong Santosh Shilimkar
2013-03-13 9:35 ` Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874ngnycys.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.