From: Kevin Hilman <khilman@deeprootsystems.com>
To: balbi@ti.com
Cc: Tero Kristo <t-kristo@ti.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Kishon Vijay Abraham I <kishon@ti.com>,
Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCHv2] ARM: OMAP4: USB: power down MUSB PHY during boot
Date: Tue, 13 Nov 2012 16:03:14 -0800 [thread overview]
Message-ID: <874nktgif1.fsf@deeprootsystems.com> (raw)
In-Reply-To: <20121109143033.GB10718@arwen.pp.htv.fi> (Felipe Balbi's message of "Fri, 9 Nov 2012 16:30:34 +0200")
Felipe Balbi <balbi@ti.com> writes:
> HI,
>
> On Fri, Nov 09, 2012 at 04:30:35PM +0200, Tero Kristo wrote:
>> Commit c9e4412ab8eb8ef82d645d8749c4ce96ad490007 removed all of the USB
>> PHY functions for OMAP4, but this causes a problem with core retention
>> as the MUSB module remains enabled if omap-usb2 phy driver is not used.
>> This keeps the USB DPLL enabled and prevents l3_init pwrdm from idling.
>>
>> Fixed by adding a minimal function back that disables the USB PHY during
>> boot.
>>
>> Signed-off-by: Tero Kristo <t-kristo@ti.com>
>> Cc: Kishon Vijay Abraham I <kishon@ti.com>
>> Cc: Felipe Balbi <balbi@ti.com>
>> Cc: Tony Lindgren <tony@atomide.com>
>> Cc: Kevin Hilman <khilman@ti.com>
>
> looks good to me. I would still suggest adding a REVISIT or FIXME note
> stating that this should be moved to SCM driver eventually ;-)
>
> Other than that:
>
> Acked-by: Felipe Balbi <balbi@ti.com>
Thanks will try to get this in for v3.8 along with the original patch
4/9 which gets full-chip retention working on OMAP4.
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: khilman@deeprootsystems.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2] ARM: OMAP4: USB: power down MUSB PHY during boot
Date: Tue, 13 Nov 2012 16:03:14 -0800 [thread overview]
Message-ID: <874nktgif1.fsf@deeprootsystems.com> (raw)
In-Reply-To: <20121109143033.GB10718@arwen.pp.htv.fi> (Felipe Balbi's message of "Fri, 9 Nov 2012 16:30:34 +0200")
Felipe Balbi <balbi@ti.com> writes:
> HI,
>
> On Fri, Nov 09, 2012 at 04:30:35PM +0200, Tero Kristo wrote:
>> Commit c9e4412ab8eb8ef82d645d8749c4ce96ad490007 removed all of the USB
>> PHY functions for OMAP4, but this causes a problem with core retention
>> as the MUSB module remains enabled if omap-usb2 phy driver is not used.
>> This keeps the USB DPLL enabled and prevents l3_init pwrdm from idling.
>>
>> Fixed by adding a minimal function back that disables the USB PHY during
>> boot.
>>
>> Signed-off-by: Tero Kristo <t-kristo@ti.com>
>> Cc: Kishon Vijay Abraham I <kishon@ti.com>
>> Cc: Felipe Balbi <balbi@ti.com>
>> Cc: Tony Lindgren <tony@atomide.com>
>> Cc: Kevin Hilman <khilman@ti.com>
>
> looks good to me. I would still suggest adding a REVISIT or FIXME note
> stating that this should be moved to SCM driver eventually ;-)
>
> Other than that:
>
> Acked-by: Felipe Balbi <balbi@ti.com>
Thanks will try to get this in for v3.8 along with the original patch
4/9 which gets full-chip retention working on OMAP4.
Kevin
next prev parent reply other threads:[~2012-11-14 0:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-09 14:30 [PATCHv2] ARM: OMAP4: USB: power down MUSB PHY during boot Tero Kristo
2012-11-09 14:30 ` Tero Kristo
2012-11-09 14:30 ` Felipe Balbi
2012-11-09 14:30 ` Felipe Balbi
2012-11-14 0:03 ` Kevin Hilman [this message]
2012-11-14 0:03 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874nktgif1.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=balbi@ti.com \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.