From: Rusty Russell <rusty@rustcorp.com.au>
To: Julia Lawall <Julia.Lawall@lip6.fr>, Julia Lawall <julia@diku.dk>
Cc: kernel-janitors@vger.kernel.org,
Gilles Muller <Gilles.Muller@lip6.fr>,
Nicolas Palix <npalix.work@gmail.com>,
cocci@diku.dk, linux-kernel@vger.kernel.org,
Michal Marek <mmarek@suse.cz>,
bruce.w.allan@intel.com, joe@perches.com
Subject: Re: [PATCH v2] scripts/coccinelle/misc/boolinit.cocci: semantic patch for bool issues
Date: Fri, 10 Feb 2012 20:58:16 +0000 [thread overview]
Message-ID: <874nuye7aa.fsf@rustcorp.com.au> (raw)
In-Reply-To: <1328905355-30874-1-git-send-email-Julia.Lawall@lip6.fr>
On Fri, 10 Feb 2012 21:22:35 +0100, Julia Lawall <Julia.Lawall@lip6.fr> wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
FWIW:
Reviewed-by: Rusty Russell <rusty@rustcorp.com.au>
> +coccilib.report.print_report(p2[0],"WARNING: Assignment of bool to non-0/1 constant")
IMHO, this one should be an error!
Thanks,
Rusty.
WARNING: multiple messages have this Message-ID (diff)
From: Rusty Russell <rusty@rustcorp.com.au>
To: Julia Lawall <Julia.Lawall@lip6.fr>, Julia Lawall <julia@diku.dk>
Cc: kernel-janitors@vger.kernel.org,
Gilles Muller <Gilles.Muller@lip6.fr>,
Nicolas Palix <npalix.work@gmail.com>,
cocci@diku.dk, linux-kernel@vger.kernel.org,
Michal Marek <mmarek@suse.cz>,
bruce.w.allan@intel.com, joe@perches.com
Subject: Re: [PATCH v2] scripts/coccinelle/misc/boolinit.cocci: semantic patch for bool issues
Date: Sat, 11 Feb 2012 07:27:01 +1030 [thread overview]
Message-ID: <874nuye7aa.fsf@rustcorp.com.au> (raw)
In-Reply-To: <1328905355-30874-1-git-send-email-Julia.Lawall@lip6.fr>
On Fri, 10 Feb 2012 21:22:35 +0100, Julia Lawall <Julia.Lawall@lip6.fr> wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
FWIW:
Reviewed-by: Rusty Russell <rusty@rustcorp.com.au>
> +coccilib.report.print_report(p2[0],"WARNING: Assignment of bool to non-0/1 constant")
IMHO, this one should be an error!
Thanks,
Rusty.
next prev parent reply other threads:[~2012-02-10 20:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-10 20:22 [PATCH v2] scripts/coccinelle/misc/boolinit.cocci: semantic patch for bool issues Julia Lawall
2012-02-10 20:22 ` Julia Lawall
2012-02-10 20:57 ` Rusty Russell [this message]
2012-02-10 20:58 ` Rusty Russell
2012-02-10 21:05 ` Julia Lawall
2012-02-10 21:05 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874nuye7aa.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=Gilles.Muller@lip6.fr \
--cc=Julia.Lawall@lip6.fr \
--cc=bruce.w.allan@intel.com \
--cc=cocci@diku.dk \
--cc=joe@perches.com \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=npalix.work@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.