Re: [PATCH 04/13] OMAP: Introduce API to return a device list associated with a voltage domain

[Kevin Hilman <khilman@deeprootsystems.com>]

"Gopinath, Thara" <thara@ti.com> writes:

[...]

>>>> +struct device **opp_init_voltage_params(struct voltagedomain *voltdm,
>>>> +					int *dev_count)
>>>> +{
>>>> +	struct device_opp *dev_opp;
>>>> +	struct device **dev_list;
>>>> +	int count = 0, i = 0;
>>>> +
>>>> +	list_for_each_entry(dev_opp, &dev_opp_list, node) {
>>>> +		if (!dev_opp->oh->vdd_name)
>>>> +			continue;
>>>> +
>>>> +		if (!strcmp(dev_opp->oh->vdd_name, voltdm->name)) {
>>>> +			dev_opp->oh->voltdm = voltdm;
>>>
>>>Couldn't we assign the voltdm at opp_add() time since you added it as
>>>part of the hwmod?
>
> We cannot as the voltage layer is not initialized at the point of opp_add.
> Having said this, today voltage layer is dependent on opp layer only to figure out 
> the current nominal voltage from the opp table. If that can be some how decoupled we
> can initialize voltage layer early on and implement this.

We could decouple the voltage init into and early init and late init to
handle this.

Kevin